markt-asf commented on PR #608:
URL: https://github.com/apache/tomcat/pull/608#issuecomment-1503257308
Thanks for the PR.
Note for reviewers: There is a default method in Java 17 (but not Java 11)
so this change is safe in Tomcat 11 but can't be back-ported to earlier
versions.
--
markt-asf merged PR #608:
URL: https://github.com/apache/tomcat/pull/608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
VirtualTim commented on PR #600:
URL: https://github.com/apache/tomcat/pull/600#issuecomment-1504514693
Oh cool. I was planning on getting around to it, but didn't get time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
VirtualTim opened a new pull request, #609:
URL: https://github.com/apache/tomcat/pull/609
This looks like a bigger change than it is, simply because I sorted the list.
**Changes**:
* Sorted the Windows/Linux include/exclude lists, to make it easy to compare
the two
* **Windows*
markt-asf commented on PR #600:
URL: https://github.com/apache/tomcat/pull/600#issuecomment-1504867534
np - thanks for the prompt to improve things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
markt-asf commented on PR #609:
URL: https://github.com/apache/tomcat/pull/609#issuecomment-1504905883
The build script would benefit from some comments here. The core .zip and
.tar.gz distros are not intended to be Windows/Linux distros. They should both
be platform neutral (i.e. work on b
VirtualTim commented on PR #609:
URL: https://github.com/apache/tomcat/pull/609#issuecomment-1505066640
>The core .zip and .tar.gz distros are not intended to be Windows/Linux
distros
Ah, I guess I misunderstood things. You're right, some comments would be
helpful.
>Historical
markt-asf commented on PR #609:
URL: https://github.com/apache/tomcat/pull/609#issuecomment-1505077215
tomcat10.exe is a renamed Commons Daemon ProcRun executable. It is not a
wrapper around the JAR (at least there is no Java code embedded in that exe).
service.bat is useless without tomcat
rmaucher commented on code in PR #607:
URL: https://github.com/apache/tomcat/pull/607#discussion_r1165225586
##
java/org/apache/catalina/util/TimeBucketCounter.java:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor l
VirtualTim commented on PR #609:
URL: https://github.com/apache/tomcat/pull/609#issuecomment-1508011831
OK, so what do you think the end goal should look like?
org.apache.tomcat/tomcat is currently described as "Binary distribution of
Apache Tomcat".
Currently that contains a tar.gz th
markt-asf commented on PR #609:
URL: https://github.com/apache/tomcat/pull/609#issuecomment-1508578170
What end goal are you looking for? Going back to users@ thread from a month
ago, it looks like you want to be able to obtain a version of Tomcat from Maven
Central that can be installed a
ChristopherSchultz commented on PR #609:
URL: https://github.com/apache/tomcat/pull/609#issuecomment-1508680413
Why not have a separate Maven package for *just* the binaries / scripts
required for the platform, and a dependency on the core package?
I am -1 on labeling the distribution
markt-asf commented on PR #609:
URL: https://github.com/apache/tomcat/pull/609#issuecomment-1509148516
My initial reasoning for not having Maven packages (one for each
architecture) with just the binaries in it is that we don't have that anywhere
else at the moment whereas we do have the fu
hungvietnguyen opened a new issue, #46:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/46
### Context
I'm investigating https://youtrack.jetbrains.com/issue/KT-57767 where the
build fails when reading
[tomcat-embed-core-10.1.7-jakartaee.jar](https://github.com/a
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1511753986
Tomcat 10.1.x already uses the Jakarta EE APIs so there is no need to run a
conversion tool on this JAR.
--
This is an automated message from the Apache Git Servi
markt-asf closed issue #46: "java.util.zip.ZipException: invalid CEN header
(bad signature)" when opening migrated jar with `java.util.zip.ZipFile`
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/46
--
This is an automated message from the Apache Git Service.
To respond to th
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1511773166
I have been able to reproduce the issue. Even if Tomcat 10.1 doesn't need to
be migrated the use of a zip64 entry is questionable. The same issue could
affect another
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1511775702
I tried disabling the zip64 mode and the migration fails with:
```
Exception in thread "main"
org.apache.tomcat.jakartaee.commons.compress.archivers.zip.Zip64
markt-asf merged PR #42:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
markt-asf closed issue #39: Fix (remove) "javax.servlet.*" package version when
processing the MANIFEST.MF
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
markt-asf commented on PR #42:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/42#issuecomment-1511962978
Thanks for the PR. I think there is probably more to do here (EL, WebSocket,
etc) and possible some debate to be had regarding exactly which version numbers
to use in th
markt-asf merged PR #38:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
ebourg commented on PR #42:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/42#issuecomment-1511994026
Changing the range to an arbitrary value is a bit odd. What about dropping
the range completely?
--
This is an automated message from the Apache Git Service.
To respond t
markt-asf commented on PR #42:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/42#issuecomment-1512004122
Please open a new issue to discuss options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1512675348
Use -zipInMemory to avoid this error. I need to remind myself what it was
about some zips that meant we needed to introduce this option.
--
This is an automated m
rmannibucau opened a new pull request, #610:
URL: https://github.com/apache/tomcat/pull/610
The file abstraction is sometimes bothering (tomcat embedded to mention it)
so enable to use PEMFile logic without having to dump a temp file.
--
This is an automated message from the Apache Git Se
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1512841690
I think that was for performance. Maybe we should make it the default when
processing jar files.
--
This is an automated message from the Apache Git Service.
To resp
markt-asf closed issue #46: "java.util.zip.ZipException: invalid CEN header
(bad signature)" when opening migrated jar with `java.util.zip.ZipFile`
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/46
--
This is an automated message from the Apache Git Service.
To respond to th
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1512882338
The root cause is a Java bug. If I open the converted file with Java 8, I
get the `invalid CEN header (bad signature)`. If I switch to Java 11, it opens
as expected
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513023104
The file is unreadable using a ZipInputStream with OpenJDK 11.0.18 and
17.0.6 (tested with ZuluJDK on Windows). Are you sure it works with Java 11?
I agree this
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513051774
I was testing `ZipFile` which fails with Java 8 but works with Java 11.
I do see issues with `ZipInputStream`. It is failing on the very first entry
and in Ja
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513182991
If that helps, this is the difference between the two jar files for the
first entry (as seen by diffoscope):
```
¦ End-of-central-directory record:
¦ ---
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513198356
Something weird I noticed, commons-compress thinks the entries of the
original jar have the zip64 field (`ZipArchiveOutputStream.hasZip64Extra()`
returns true), and th
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513245658
In `Migration.migrateArchiveStreaming()`, if the zip64 field is removed with
`destZipEntry.removeExtraField(new ZipShort(0x0001));` the file generated
becomes parseabl
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513306019
My test was flawed, removing the zip64 field has no effect actually :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513451186
Progress. The field shadowing was a red herring. The Eclipse IDE was
providing misleading information.
I think I am seeing a similar root cause to you. The ne
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513471359
It is the JRE that is in the wrong:
https://bugs.openjdk.org/browse/JDK-8303866
--
This is an automated message from the Apache Git Service.
To respond to the mes
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513487060
> It is the JRE that is in the wrong:
https://bugs.openjdk.org/browse/JDK-8303866
Hi. I contributted JDK-8303866 and the associated PR which is currently
under
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513489596
Another exotic feature of this ZIP is that it has CEN ZIP64 extended
information fields with no content (0 bytes). I don't think I've ever seen that
before.
--
This
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513560520
There is something funny going on with the source file being migrated here,
[tomcat-embed-core-10.1.7.jar](https://repo1.maven.org/maven2/org/apache/tomcat/embed/tomcat
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513568182
zipdetails 2.104 gives me a different output:
```
00 LOCAL HEADER #1 04034B50
04 Extract Zip Spec 0A '1.0'
05 Extract OS
ChristopherSchultz commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513581200
I'm happy to have this investigated if it improves our migration tool, but
I'm curious as to why the tomcat-embed-10.1.7.jar file is even being migrated.
T
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513584043
From the OpenJDK side it would be interesting to learn which tool or API
produced the `tomcat-embed-10.1.7.jar` file.
--
This is an automated message from the Apache
ChristopherSchultz commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513596335
The code is on GH, here:
https://github.com/apache/tomcat-jakartaee-migration/blob/main/src/main/java/org/apache/tomcat/jakartaee/Migration.java
Look
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513597387
> From the OpenJDK side it would be interesting to learn which tool or API
produced the tomcat-embed-10.1.7.jar file.
It was produced by Ant, which has its own z
ChristopherSchultz commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513599230
Sorry @eirbjo I wasn't sure if you meant the JAR file before or after
migration. Apache ant produces the original, and commons-compress produces the
migrat
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513626451
It is also post-processed by BND.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513655682
> It is also post-processed by BND.
Commenting out the `add-graal` call makes the ZIP64 extra fields disappear.
I have debugged the `zip` call, and `zip` in this
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513668571
Could this be summarized to Java inhability to read zip files using ZIP64
fields and streaming data headers? If so, this means tomcat-jakartaee-migration
could simply
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513675091
> Could this be summarized to Java inability to read zip files using ZIP64
fields and streaming data headers?
That sounds right. `java.util.ZipInputStream` curre
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513716893
> If Tomcat does not want to produce such files, you could always overide
the `zip64Mode` option to `never`, instead of the default `as-needed`.
Note that the `j
ChristopherSchultz commented on PR #610:
URL: https://github.com/apache/tomcat/pull/610#issuecomment-1513785961
I've merged this separately, including a changelog entry.
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ChristopherSchultz closed pull request #610: Enhance PEMFile to load from an
inputstream too
URL: https://github.com/apache/tomcat/pull/610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513807408
Digging further... my initial intuition of removing the ZIP64 extra field
does really work, I just didn't implement it correctly (I added it only to the
STORED branch
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513823210
Excellent. We can always check if the size > 4GB and log a warning in that
case.
--
This is an automated message from the Apache Git Service.
To respond to the me
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513834050
Suggested fix, test case to follow
https://github.com/ebourg/tomcat-jakartaee-migration/commit/4d8457d3658bff94510e6b215707e172493f0b71
--
This is an automated me
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1514233727
I was also working on a fix. I've combined your fix and mine and committed
it. My local test and the unit tests pass.
--
This is an automated message from the Apa
markt-asf closed issue #46: "java.util.zip.ZipException: invalid entry size
(expected 0 but got 913 bytes)" when opening migrated jar with
`java.util.zip.ZipInputStream`
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/46
--
This is an automated message from the Apache Git Se
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1514246160
@eirbjo Many thanks for your input, that was really helpful. Good luck with
your JDK PR
--
This is an automated message from the Apache Git Service.
To respond to th
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1514256218
> @eirbjo Many thanks for your input, that was really helpful. Good luck
with your JDK PR
Thanks, I hope this Tomcat issue helps showcase that this really is a
dependabot[bot] opened a new pull request, #14:
URL: https://github.com/apache/tomcat-training/pull/14
Bumps [json-schema](https://github.com/kriszyp/json-schema) from 0.2.3 to
0.4.0.
Commits
https://github.com/kriszyp/json-schema/commit/f6f6a3b02d667aa4ba2d5d50cc19208c4462abfa
dependabot[bot] opened a new pull request, #15:
URL: https://github.com/apache/tomcat-training/pull/15
Bumps [ms](https://github.com/vercel/ms) from 0.7.1 to 2.0.0.
Release notes
Sourced from https://github.com/vercel/ms/releases";>ms's
releases.
2.0.0
Major Changes
dependabot[bot] opened a new pull request, #16:
URL: https://github.com/apache/tomcat-training/pull/16
Bumps [debug](https://github.com/debug-js/debug) from 2.2.0 to 2.6.9.
Release notes
Sourced from https://github.com/debug-js/debug/releases";>debug's releases.
2.6.9
Patc
dependabot[bot] opened a new pull request, #17:
URL: https://github.com/apache/tomcat-training/pull/17
Bumps [lodash](https://github.com/lodash/lodash) from 3.7.0 to 4.17.21.
Release notes
Sourced from https://github.com/lodash/lodash/releases";>lodash's releases.
4.0.0
ht
reftel opened a new pull request, #611:
URL: https://github.com/apache/tomcat/pull/611
Fixes minor annoyance when analyzing log files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
aooohan merged PR #611:
URL: https://github.com/apache/tomcat/pull/611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
aooohan commented on PR #611:
URL: https://github.com/apache/tomcat/pull/611#issuecomment-1521052913
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
fage88 commented on PR #28:
URL:
https://github.com/apache/tomcat-maven-plugin/pull/28#issuecomment-1522064083
Closing this PR, we abandoned Tomcat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
fage88 closed pull request #28: PFCORE-7274 upgrade tomcat 7 version to 7.0.92
URL: https://github.com/apache/tomcat-maven-plugin/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dsoumis opened a new pull request, #17:
URL: https://github.com/apache/tomcat-native/pull/17
Replace steps from non-existent files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dsoumis opened a new pull request, #18:
URL: https://github.com/apache/tomcat-native/pull/18
It would be best if the downloaded versions are aligned with the recommended
ones (https://github.com/apache/tomcat-native/blob/main/native/srclib/VERSIONS).
--
This is an automated message from t
markt-asf merged PR #17:
URL: https://github.com/apache/tomcat-native/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa
markt-asf commented on PR #17:
URL: https://github.com/apache/tomcat-native/pull/17#issuecomment-1523672553
Thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
markt-asf merged PR #18:
URL: https://github.com/apache/tomcat-native/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa
markt-asf commented on PR #18:
URL: https://github.com/apache/tomcat-native/pull/18#issuecomment-1523676472
Tx.
I don't use this script myself. Is it useful? Should it be in the `native`
directory?
--
This is an automated message from the Apache Git Service.
To respond to the messa
dsoumis commented on PR #18:
URL: https://github.com/apache/tomcat-native/pull/18#issuecomment-1523725451
Just a quick way to fetch the prerequisites for building in native, not that
useful, but nice to have. And yes, I think it would be wiser if it's placed in
the native directory.
--
T
rainerjung commented on PR #539:
URL: https://github.com/apache/tomcat/pull/539#issuecomment-1525194171
@thomasmey I added support for all subkeyed patterns like request headers
(%i), response headers (%o) etc. You might want to have a look and test it. It
is now contained in the heads for
thomasmey commented on PR #539:
URL: https://github.com/apache/tomcat/pull/539#issuecomment-1525602662
@rainerjung very nice, many thanks!
I just did test the version which landed in 9.0.74 ...
I will allocate some time next week and do some tests.
As you are also an http
rmaucher commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525822068
This seems like a good idea (although no idea about the best default idle
value). It was like this since the code was initially added.
--
This is an automated message from the Apache Git
markt-asf commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525904959
My reading of the code is that the AsynchronousChannelProvider submits tasks
that never end to the executor so this patch has no effect. The purpose of the
Executor is to replace any threa
mjgp2 commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525913263
I'll have a further look at this tomorrow. The situation I have is hundreds
of idle threads. Potentially a configurable solution using virtual threads
would mitigate the issue.
--
This is a
markt-asf commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525916279
A thread dump would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rmaucher commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525937787
Hum, this is the websocket client and it is using NIO2, so that executor
would be used internally for all things that are run asynchronously for IO like
calling completion handlers and so o
mjgp2 commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1527404654
I can find this documentation on the
`AsynchronousChannelGroup.withCachedThreadPool` call made within this websocket
code:
```
• An asynchronous channel group associated with a cach
jackshirazi opened a new pull request, #613:
URL: https://github.com/apache/tomcat/pull/613
We (Elastic APM) have a customer (using tomcat 9.0.72) that is hitting this
bug. The file copy is getting interrupted (likely from CPU time slicing
signals, which is happening because of additional p
ChristopherSchultz commented on PR #613:
URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528119740
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
ChristopherSchultz commented on PR #613:
URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528121310
@rmaucher applied this PR earlier today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ChristopherSchultz closed pull request #613: transferTo can transfer only part
of the file, so need to loop
URL: https://github.com/apache/tomcat/pull/613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
markt-asf commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1531137327
The thread dump confirms the earlier analysis. The
`sun.nio.ch.KQueuePort$EventHandlerTask` never exits so the proposed change
will not have the impact desired.
It would be worth explor
markt-asf commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1531277972
The default `AsynchronousChannelGroup` has adopted a keep-alive of 60s at
some point but since the task never exits, it makes no difference in this case.
We could make the similar change
markt-asf merged PR #612:
URL: https://github.com/apache/tomcat/pull/612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
isapir commented on code in PR #607:
URL: https://github.com/apache/tomcat/pull/607#discussion_r1184526447
##
java/org/apache/catalina/util/TimeBucketCounter.java:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
isapir commented on code in PR #607:
URL: https://github.com/apache/tomcat/pull/607#discussion_r1184526447
##
java/org/apache/catalina/util/TimeBucketCounter.java:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
rmannibucau commented on code in PR #607:
URL: https://github.com/apache/tomcat/pull/607#discussion_r1184594119
##
java/org/apache/catalina/util/TimeBucketCounter.java:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributo
isapir merged PR #607:
URL: https://github.com/apache/tomcat/pull/607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
kang-hl opened a new pull request, #614:
URL: https://github.com/apache/tomcat/pull/614
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1542634643
The method is necessary. It releases the reference to the SocketWrapper,
allowing it ti be GC'd.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
markt-asf closed pull request #614: Remove unnecessary reset
URL: https://github.com/apache/tomcat/pull/614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
kang-hl commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1543272195
NioSocketWrapper is referenced by NioChannel, and it may need to release the
reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
kang-hl commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1543285158
> The method is necessary. It releases the reference to the SocketWrapper,
allowing it ti be GC'd.
NioSocketWrapper is referenced by NioChannel, and it may need to release the
referen
201 - 300 of 2003 matches
Mail list logo
