eirbjo commented on issue #46:
URL: 
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513675091

   > Could this be summarized to Java inability to read zip files using ZIP64 
fields and streaming data headers?
   
   That sounds right. `java.util.ZipInputStream` currently can read 8-byte size 
fields from the data descriptor record, but only does so when the actual number 
of compressed or uncompressed files is larger than Integer.MAX_VALUE. My 
OpenJDK PR changes this to also add a for the precense of a ZIP64 extended 
information field in the LOC header. If this is present, the Data Descriptor 
will be read with 8-byte fields. 
   
   > If so, this means tomcat-jakartaee-migration could simply detect the ZIP64 
extra field and either stop with an error, or enable the in memory processing 
automatically.
   
   You are probably reading from files on disk anyway, so perhaps using 
`java.util.zip.ZipFile` would work better. That API does not need to parse the 
Data Descriptor record, since it has that all info in the `CEN` headers.
   `java.util.zip.ZipInputStream` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to