markt-asf commented on PR #609:
URL: https://github.com/apache/tomcat/pull/609#issuecomment-1504905883
The build script would benefit from some comments here. The core .zip and
.tar.gz distros are not intended to be Windows/Linux distros. They should both
be platform neutral (i.e. work on both). The only difference should be the line
endings. Both should have .bat and .sh files.
The Windows service files (service.bat,.exe and .dll files) are only meant
to be in the Windows specific distributions.
Historically, service.bat wasn't included in the Windows installer (built
via a separate script) but it is now included. There isn't much point including
service.bat if the associated binaries are not present.
The conf/** files are not excluded from the tar.gz distribution, they are
added separately using a different permission set.
There are essentially three sets of files being added:
- the standard directories (bin, conf, lib etc)
- the top-level files (LICENSE, README, etc)
- and the Windows binaries
I think it may be clearer if, rather than sorting all these files as one
group, they are kept as three groups (perhaps another opportunity for some
brief comments) but sorted within the groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
