[GitHub] [tomcat] iamjooon2 commented on pull request #652: Upgrade Readability by removing brackets and depth

2023-09-06 Thread via GitHub
iamjooon2 commented on PR #652: URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708120119 Hello from Korea @markt-asf I unified all of conventions in package apache/coyote 1. unify conditional convention e.g ```java // from if (type == Constants.JK_AJP13_CPI

[GitHub] [tomcat] iamjooon2 commented on pull request #652: Upgrade Readability by removing brackets and depth

2023-09-06 Thread via GitHub
iamjooon2 commented on PR #652: URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708163596 My mistake! I rollbacked some codes. I really appreciate for your comment! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tomcat] Jaeyoung22 commented on pull request #661: Unify conditional statement format for some constants in http1 package

2023-09-06 Thread via GitHub
Jaeyoung22 commented on PR #661: URL: https://github.com/apache/tomcat/pull/661#issuecomment-1708220046 I've taken note of what you've said. ## 1. remove unnecessary parentheses throughout the package Personally, I find conditional statements with three or more conditions to be mor

[GitHub] [tomcat] markt-asf merged pull request #659: Unify constant delimiters and Refactoring for better readability

2023-09-06 Thread via GitHub
markt-asf merged PR #659: URL: https://github.com/apache/tomcat/pull/659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] markt-asf commented on pull request #659: Unify constant delimiters and Refactoring for better readability

2023-09-06 Thread via GitHub
markt-asf commented on PR #659: URL: https://github.com/apache/tomcat/pull/659#issuecomment-1708271503 Tx for the PR. I added a commit to remove an unnecessary line of code I spotted while reviewing the PR. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [tomcat] markt-asf commented on a diff in pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #660: URL: https://github.com/apache/tomcat/pull/660#discussion_r1317221552 ## java/org/apache/catalina/util/SessionConfig.java: ## @@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) { * @return the parameter na

[GitHub] [tomcat] markt-asf merged pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
markt-asf merged PR #660: URL: https://github.com/apache/tomcat/pull/660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] markt-asf commented on pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
markt-asf commented on PR #660: URL: https://github.com/apache/tomcat/pull/660#issuecomment-1708278473 Tx for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [tomcat] markt-asf commented on a diff in pull request #662: Simplify and enhance charset extraction from content type

2023-09-06 Thread via GitHub
markt-asf commented on code in PR #662: URL: https://github.com/apache/tomcat/pull/662#discussion_r1317240076 ## java/org/apache/coyote/Request.java: ## @@ -852,25 +854,17 @@ public boolean isProcessing() { * * @param contentType a content type header */ -p

[GitHub] [tomcat] iamjooon2 commented on pull request #652: Upgrade Readability by removing brackets

2023-09-06 Thread via GitHub
iamjooon2 commented on PR #652: URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708308925 I rollbacked some codes. I really appreciate for your comments. Have a good Day -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [tomcat] markt-asf commented on pull request #661: Unify conditional statement format

2023-09-06 Thread via GitHub
markt-asf commented on PR #661: URL: https://github.com/apache/tomcat/pull/661#issuecomment-1708336648 Thanks for the PR. It is so much more efficient to review this sort of change at this sort of scale. Thanks for the De Morgan's law changes. I think those conditions are a lot easie

[GitHub] [tomcat] markt-asf merged pull request #661: Unify conditional statement format

2023-09-06 Thread via GitHub
markt-asf merged PR #661: URL: https://github.com/apache/tomcat/pull/661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] ChrissW-R1 opened a new pull request, #665: Update tool-wrapper.bat

2023-09-06 Thread via GitHub
ChrissW-R1 opened a new pull request, #665: URL: https://github.com/apache/tomcat/pull/665 Solved issue with spaces in path. If you install tomcat on windows in a path with spaces, the tool-wrapper.bat could be executed. This PR adds two missing qoutes to solve this issue. -- This

[GitHub] [tomcat] markt-asf commented on pull request #664: Improved code readability

2023-09-06 Thread via GitHub
markt-asf commented on PR #664: URL: https://github.com/apache/tomcat/pull/664#issuecomment-1708352372 Included in #661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] markt-asf closed pull request #664: Improved code readability

2023-09-06 Thread via GitHub
markt-asf closed pull request #664: Improved code readability URL: https://github.com/apache/tomcat/pull/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [tomcat] markt-asf merged pull request #652: Upgrade Readability by removing brackets

2023-09-06 Thread via GitHub
markt-asf merged PR #652: URL: https://github.com/apache/tomcat/pull/652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] markt-asf merged pull request #662: Simplify and enhance charset extraction from content type

2023-09-06 Thread via GitHub
markt-asf merged PR #662: URL: https://github.com/apache/tomcat/pull/662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] greeng00se commented on pull request #660: Optimize when call getSessionCookieName & getSessionUriParamName

2023-09-06 Thread via GitHub
greeng00se commented on PR #660: URL: https://github.com/apache/tomcat/pull/660#issuecomment-1709145552 @markt-asf thx for good comment XD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [tomcat] anuragdy opened a new pull request, #666: Performance improvements for ImplicitObjectELResolver

2023-09-07 Thread via GitHub
anuragdy opened a new pull request, #666: URL: https://github.com/apache/tomcat/pull/666 Fixes [67080](https://bz.apache.org/bugzilla/show_bug.cgi?id=67080). Tested the speed using following Test Code - ``` package com.amazon.weblab; import java.util.Arrays; im

[GitHub] [tomcat] michael-o commented on a diff in pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-07 Thread via GitHub
michael-o commented on code in PR #666: URL: https://github.com/apache/tomcat/pull/666#discussion_r1318844150 ## java/javax/servlet/jsp/el/ImplicitObjectELResolver.java: ## @@ -44,31 +44,32 @@ * @since JSP 2.1 */ public class ImplicitObjectELResolver extends ELResolver { +

[GitHub] [tomcat] anuragdy commented on a diff in pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-07 Thread via GitHub
anuragdy commented on code in PR #666: URL: https://github.com/apache/tomcat/pull/666#discussion_r1319322612 ## java/javax/servlet/jsp/el/ImplicitObjectELResolver.java: ## @@ -44,31 +44,32 @@ * @since JSP 2.1 */ public class ImplicitObjectELResolver extends ELResolver { +

[GitHub] [tomcat] michael-o commented on a diff in pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-08 Thread via GitHub
michael-o commented on code in PR #666: URL: https://github.com/apache/tomcat/pull/666#discussion_r1319594183 ## java/javax/servlet/jsp/el/ImplicitObjectELResolver.java: ## @@ -44,31 +44,32 @@ * @since JSP 2.1 */ public class ImplicitObjectELResolver extends ELResolver { +

[GitHub] [tomcat] y987425112 opened a new pull request, #667: Before closing the database connection, roll back the transaction

2023-09-08 Thread via GitHub
y987425112 opened a new pull request, #667: URL: https://github.com/apache/tomcat/pull/667 fix bug https://bz.apache.org/bugzilla/show_bug.cgi?id=64570 Before closing the database connection, roll back the transaction -- This is an automated message from the Apache Git Service. To r

[GitHub] [tomcat] anuragdy commented on a diff in pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-08 Thread via GitHub
anuragdy commented on code in PR #666: URL: https://github.com/apache/tomcat/pull/666#discussion_r1319841883 ## java/javax/servlet/jsp/el/ImplicitObjectELResolver.java: ## @@ -44,31 +44,32 @@ * @since JSP 2.1 */ public class ImplicitObjectELResolver extends ELResolver { +

[GitHub] [tomcat] marcorobiati opened a new pull request, #668: Doc correction

2023-09-09 Thread via GitHub
marcorobiati opened a new pull request, #668: URL: https://github.com/apache/tomcat/pull/668 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [tomcat] shin-mallang opened a new pull request, #669: Relocate the useCompression check and apply parts back to back

2023-09-09 Thread via GitHub
shin-mallang opened a new pull request, #669: URL: https://github.com/apache/tomcat/pull/669 I think it can be confusing to read the code because there is a part that checks for HTTP compression, and a part that applies the filter. I've placed them back-to-back to improve readability. -

[GitHub] [tomcat] rmaucher commented on pull request #669: Relocate the useCompression check and apply parts back to back

2023-09-10 Thread via GitHub
rmaucher commented on PR #669: URL: https://github.com/apache/tomcat/pull/669#issuecomment-1712763013 The ordering of these is often important. Please don't try to change this for cosmetic reason since it needs time and expertise to review. -- This is an automated message from the Apache

[GitHub] [tomcat] rmaucher closed pull request #669: Relocate the useCompression check and apply parts back to back

2023-09-10 Thread via GitHub
rmaucher closed pull request #669: Relocate the useCompression check and apply parts back to back URL: https://github.com/apache/tomcat/pull/669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [tomcat] aooohan merged pull request #668: Doc correction

2023-09-10 Thread via GitHub
aooohan merged PR #668: URL: https://github.com/apache/tomcat/pull/668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[GitHub] [tomcat] aooohan commented on pull request #668: Doc correction

2023-09-10 Thread via GitHub
aooohan commented on PR #668: URL: https://github.com/apache/tomcat/pull/668#issuecomment-1713076196 Thanks for the PR. ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [tomcat] marcorobiati commented on pull request #668: Doc correction

2023-09-10 Thread via GitHub
marcorobiati commented on PR #668: URL: https://github.com/apache/tomcat/pull/668#issuecomment-1713209620 What LGTM means? And is this doc the same that goes on the website or just a copy integrated in the release? In case where to contribute to the online doc? -- This is an automated mes

[GitHub] [tomcat] aooohan commented on pull request #668: Doc correction

2023-09-10 Thread via GitHub
aooohan commented on PR #668: URL: https://github.com/apache/tomcat/pull/668#issuecomment-1713222910 > What LGTM means? That means 'Looks Good To Me'. > And is this doc the same that goes on the website or just a copy integrated in the release? In case where to contribute to t

[GitHub] [tomcat] aooohan merged pull request #665: Update tool-wrapper.bat

2023-09-11 Thread via GitHub
aooohan merged PR #665: URL: https://github.com/apache/tomcat/pull/665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[GitHub] [tomcat] aooohan commented on pull request #665: Update tool-wrapper.bat

2023-09-11 Thread via GitHub
aooohan commented on PR #665: URL: https://github.com/apache/tomcat/pull/665#issuecomment-1713426562 Thanks for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] anuragdy commented on pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-12 Thread via GitHub
anuragdy commented on PR #666: URL: https://github.com/apache/tomcat/pull/666#issuecomment-1715600463 Benchmarks with JMH JDK11 ``` Benchmark Mode Cnt ScoreError Units MyBenchmark.runNewTestthrpt5 20981286.747 ± 52439.9

[GitHub] [tomcat] anuragdy commented on pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-14 Thread via GitHub
anuragdy commented on PR #666: URL: https://github.com/apache/tomcat/pull/666#issuecomment-1719698843 Hi @michael-o I wonder if you have any further thoughts/comments on this change and if we could finish the Code Review process soon. -- This is an automated message from the Apache Git Se

[GitHub] [tomcat] michael-o commented on pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-14 Thread via GitHub
michael-o commented on PR #666: URL: https://github.com/apache/tomcat/pull/666#issuecomment-1719703370 I cannot make any judgement on any performance improvement. I'd prefer to leave this to other committers. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [tomcat] markt-asf commented on pull request #669: Relocate the useCompression check and apply parts back to back

2023-09-14 Thread via GitHub
markt-asf commented on PR #669: URL: https://github.com/apache/tomcat/pull/669#issuecomment-1719734655 Re-opening. Discussion on the dev list confirmed that this change was safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat] markt-asf merged pull request #669: Relocate the useCompression check and apply parts back to back

2023-09-14 Thread via GitHub
markt-asf merged PR #669: URL: https://github.com/apache/tomcat/pull/669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

[GitHub] [tomcat] shin-mallang commented on pull request #669: Relocate the useCompression check and apply parts back to back

2023-09-14 Thread via GitHub
shin-mallang commented on PR #669: URL: https://github.com/apache/tomcat/pull/669#issuecomment-1719742560 @markt-asf I apologize for not sending a PR with an explanation after carefully checking that the change in the code was safe. I apologize for the inconvenience. Thank you. -

[GitHub] [tomcat] coheigea opened a new pull request, #670: Adding ASL Bundle-License to the manifests

2023-09-18 Thread via GitHub
coheigea opened a new pull request, #670: URL: https://github.com/apache/tomcat/pull/670 Other ASF projects like CXF that are built using the maven-bundle-plugin have the pom license automatically inserted into the manifest as "Bundle-License: https://www.apache.org/licenses/LICENSE-2.0.txt

[GitHub] [tomcat] anuragdy commented on pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-20 Thread via GitHub
anuragdy commented on PR #666: URL: https://github.com/apache/tomcat/pull/666#issuecomment-1727332333 Okk, Thanks for letting me know. I will check with the Bug Reviewer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [tomcat] markt-asf closed pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-20 Thread via GitHub
markt-asf closed pull request #666: Performance improvements for ImplicitObjectELResolver URL: https://github.com/apache/tomcat/pull/666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] markt-asf commented on pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-20 Thread via GitHub
markt-asf commented on PR #666: URL: https://github.com/apache/tomcat/pull/666#issuecomment-1727979952 The test is not a fair test since the Enum approach doesn't include the cost of the switch. If that is included, the original optimisation is better. I will be applying a version of the or

[GitHub] [tomcat] wonyongChoi05 commented on a diff in pull request #662: Simplify and enhance charset extraction from content type

2023-09-20 Thread via GitHub
wonyongChoi05 commented on code in PR #662: URL: https://github.com/apache/tomcat/pull/662#discussion_r1317009172 ## java/org/apache/coyote/Request.java: ## @@ -853,24 +846,22 @@ public boolean isProcessing() { * @param contentType a content type header */ priva

[GitHub] [tomcat] markt-asf closed pull request #663: Refactoring the main method of a Tomcat class to improve readability

2023-09-22 Thread via GitHub
markt-asf closed pull request #663: Refactoring the main method of a Tomcat class to improve readability URL: https://github.com/apache/tomcat/pull/663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [tomcat] ChristopherSchultz commented on a diff in pull request #670: Adding ASL Bundle-License to the manifests

2023-09-22 Thread via GitHub
ChristopherSchultz commented on code in PR #670: URL: https://github.com/apache/tomcat/pull/670#discussion_r1334621098 ## res/bnd/annotations-api.jar.tmp.bnd: ## @@ -15,6 +15,7 @@ -include: build-defaults.bnd, spec-defaults.bnd +Bundle-License: https://www.apache.org/licens

[GitHub] [tomcat] markt-asf commented on pull request #670: Adding ASL Bundle-License to the manifests

2023-09-22 Thread via GitHub
markt-asf commented on PR #670: URL: https://github.com/apache/tomcat/pull/670#issuecomment-1731755393 Fixed by adding that header to the defaults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf closed pull request #670: Adding ASL Bundle-License to the manifests

2023-09-22 Thread via GitHub
markt-asf closed pull request #670: Adding ASL Bundle-License to the manifests URL: https://github.com/apache/tomcat/pull/670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat-native] michael-o commented on pull request #9: Simplify Address#getInfo() native implementation

2023-09-26 Thread via GitHub
michael-o commented on PR #9: URL: https://github.com/apache/tomcat-native/pull/9#issuecomment-1735722146 @mturk still waiting for years... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

2024-07-03 Thread via GitHub
pb00067 commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2205400307 > please notice that both methods registerCleaner() and unregisterCleaner() having the synchronized keyword does not prevent that one thread executes registerCleaner() while another thread s

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

2024-07-03 Thread via GitHub
markt-asf commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2205441036 That the threads have different context class loaders doesn't explain the behaviour you are seeing. As per section 8.4.3.6 of the JLS, there is a single monitor for both methods. Cl

Re: [PR] javax2jakarta has been included in Fedora [tomcat-jakartaee-migration]

2024-07-03 Thread via GitHub
markt-asf merged PR #58: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

Re: [PR] Changed simple synchronization to ReentrantReadWriteLock [tomcat]

2024-07-03 Thread via GitHub
wapkch commented on PR #712: URL: https://github.com/apache/tomcat/pull/712#issuecomment-2207881666 @ChristopherSchultz Could this fix be ported to 8.5.x? Cause the latest 8.5.100 has the same problem. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Changed simple synchronization to ReentrantReadWriteLock [tomcat]

2024-07-03 Thread via GitHub
n828cl commented on PR #712: URL: https://github.com/apache/tomcat/pull/712#issuecomment-2208075153 Tomcat 8.5 reached end-of-life in March, so there won't be any more updates. You should update to a supported level at your earliest convenience. -- This is an automated message from the Ap

[PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21 in /modules/openssl-foreign [tomcat]

2024-07-05 Thread via GitHub
dependabot[bot] opened a new pull request, #738: URL: https://github.com/apache/tomcat/pull/738 Bumps org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-nam

[PR] Merged two loops into one to simplify the logic [tomcat]

2024-07-05 Thread via GitHub
lee-jeong-geun opened a new pull request, #739: URL: https://github.com/apache/tomcat/pull/739 Hello. Reduced the filter addition logic in createFilterChain to a single loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Merged two loops into one to simplify the logic [tomcat]

2024-07-05 Thread via GitHub
n828cl commented on PR #739: URL: https://github.com/apache/tomcat/pull/739#issuecomment-2211492415 The proposed change would violate the servlet spec, which requires that filters matching URL patterns must precede those matching servlet names, even when using the same filter for both. See

Re: [PR] Merged two loops into one to simplify the logic [tomcat]

2024-07-05 Thread via GitHub
markt-asf closed pull request #739: Merged two loops into one to simplify the logic URL: https://github.com/apache/tomcat/pull/739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Merged two loops into one to simplify the logic [tomcat]

2024-07-05 Thread via GitHub
markt-asf commented on PR #739: URL: https://github.com/apache/tomcat/pull/739#issuecomment-2211679939 This won't be merged for the reason Chuck explained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

2024-07-07 Thread via GitHub
Hakky54 closed pull request #706: Simplify usage of custom ssl configuration URL: https://github.com/apache/tomcat/pull/706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

2024-07-07 Thread via GitHub
Hakky54 commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2212556516 After couple of review rounds it is not clear whether it would get approved/merged, so I decided to close this PR. Please ping me if you guys still consider and and I will create a new PR.

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21 in /modules/openssl-foreign [tomcat]

2024-07-08 Thread via GitHub
dependabot[bot] closed pull request #738: Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21 in /modules/openssl-foreign URL: https://github.com/apache/tomcat/pull/738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21 in /modules/openssl-foreign [tomcat]

2024-07-08 Thread via GitHub
dependabot[bot] commented on PR #738: URL: https://github.com/apache/tomcat/pull/738#issuecomment-2214028341 Looks like org.apache.tomcat:tomcat-coyote is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Update, refactor and polish instructions of the documentation. [tomcat-native]

2024-07-09 Thread via GitHub
dsoumis merged PR #25: URL: https://github.com/apache/tomcat-native/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apach

[PR] Add OpenSSL FFM code [tomcat]

2024-07-10 Thread via GitHub
rmaucher opened a new pull request, #740: URL: https://github.com/apache/tomcat/pull/740 Also port the TLS testsuite improvements from 10.1. APR TLS testing uses only the OpenSSL parameter (and skips JSSE and OpenSSL FFM) to avoid looking weird while running only once. -- This is an au

Re: [PR] Add OpenSSL FFM code [tomcat]

2024-07-11 Thread via GitHub
rmaucher commented on PR #740: URL: https://github.com/apache/tomcat/pull/740#issuecomment-259840 The rationale behind this is long term support of Tomcat 9.0. - FFM support is likely desirable starting with the Java 25 LTS release - Java 25 cannot be used to compile Tomcat 9.0 -

Re: [PR] Add OpenSSL FFM code [tomcat]

2024-07-11 Thread via GitHub
rmaucher merged PR #740: URL: https://github.com/apache/tomcat/pull/740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.or

[PR] fix typos [tomcat]

2024-07-11 Thread via GitHub
rafaeldeoliveira opened a new pull request, #741: URL: https://github.com/apache/tomcat/pull/741 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] fix typos [tomcat]

2024-07-11 Thread via GitHub
ChristopherSchultz commented on PR #741: URL: https://github.com/apache/tomcat/pull/741#issuecomment-2223306831 Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] fix typos [tomcat]

2024-07-11 Thread via GitHub
ChristopherSchultz merged PR #741: URL: https://github.com/apache/tomcat/pull/741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat

Re: [I] test [tomcat-jakartaee-migration]

2024-07-16 Thread via GitHub
aooohan closed issue #59: test URL: https://github.com/apache/tomcat-jakartaee-migration/issues/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

2024-07-18 Thread via GitHub
pizzi80 commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2236111941 It would be nice to replace all these synchronized methods/blocks with a real Lock to be more VirtualThread friendly. https://stackoverflow.com/questions/76618264/synchronize-block

Re: [PR] Handle osgi headers correctly [tomcat-jakartaee-migration]

2024-07-18 Thread via GitHub
markt-asf commented on PR #54: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/54#issuecomment-2236760666 The size of the `org.eclipse.osgi` JAR is a concern. At 1.5MB it would more than double the size of the migration JAR and increase Tomcat's footprint by 10-15%. I think

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

2024-07-18 Thread via GitHub
ChristopherSchultz commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2237137467 There isn't much here that isn't Virtual Thread friendly. VTs will indeed be pinned while running a synchronized block (at least in today's JVMs), but these blocks are short

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

2024-07-18 Thread via GitHub
ChristopherSchultz closed pull request #737: Fix problem with concurrent access to different ConnectionPool instances URL: https://github.com/apache/tomcat/pull/737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-07-23 Thread via GitHub
markt-asf merged PR #742: URL: https://github.com/apache/tomcat/pull/742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-07-23 Thread via GitHub
markt-asf commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2244574724 Thanks for the PR. All looks reasonable to me. There are a few bits of potential clean-up I noticed both in the patch and the surrounding code. I'll do that after I've merged this PR. --

[PR] Update RUNNING.txt [tomcat]

2024-07-25 Thread via GitHub
anujdevopslearn opened a new pull request, #743: URL: https://github.com/apache/tomcat/pull/743 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Update RUNNING.txt [tomcat]

2024-07-25 Thread via GitHub
anujdevopslearn closed pull request #743: Update RUNNING.txt URL: https://github.com/apache/tomcat/pull/743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] refactor: standardize the HTML, CSS and JSP in the webapps folder. [tomcat]

2024-08-02 Thread via GitHub
ChristopherSchultz commented on PR #316: URL: https://github.com/apache/tomcat/pull/316#issuecomment-2265991701 I'm a -1 on this change mostly because it's so large with so many changes at the same time. If this PR had been the accumulation of several commits e.g. (1) re-format whitespace e

Re: [PR] Introduce Tomcat Source-to-Image (S2I) [tomcat]

2024-08-02 Thread via GitHub
ChristopherSchultz commented on PR #188: URL: https://github.com/apache/tomcat/pull/188#issuecomment-2266023942 I'm not sure this is something appropriate for the Tomcat team to adopt. Sounds like a great community-led project to exist outside of Tomcat, though. -- This is an automated me

[PR] correct typos [tomcat-connectors]

2024-08-05 Thread via GitHub
carehart opened a new pull request, #9: URL: https://github.com/apache/tomcat-connectors/pull/9 Folks, are you ok with accepting PRs for doc improvements this way? The [page discussing doc contributions](https://tomcat.apache.org/connectors-doc/miscellaneous/doccontrib.html) proposes many

Re: [PR] correct typos [tomcat-connectors]

2024-08-06 Thread via GitHub
markt-asf commented on PR #9: URL: https://github.com/apache/tomcat-connectors/pull/9#issuecomment-2270572433 > Folks, are you ok with accepting PRs for doc improvements this way? Yes. > The [page discussing doc contributions](https://tomcat.apache.org/connectors-doc/miscellane

Re: [PR] correct typos [tomcat-connectors]

2024-08-06 Thread via GitHub
markt-asf merged PR #9: URL: https://github.com/apache/tomcat-connectors/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.a

Re: [PR] correct typos [tomcat-connectors]

2024-08-06 Thread via GitHub
carehart commented on PR #9: URL: https://github.com/apache/tomcat-connectors/pull/9#issuecomment-2272452476 So great to hear. Thanks for that, Mark. I look forward to helping more on the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] native/common/jk_global.h: fix compilation on musl [tomcat-connectors]

2024-08-07 Thread via GitHub
rainerjung merged PR #8: URL: https://github.com/apache/tomcat-connectors/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.

Re: [PR] native/common/jk_global.h: fix compilation on musl [tomcat-connectors]

2024-08-07 Thread via GitHub
rainerjung commented on PR #8: URL: https://github.com/apache/tomcat-connectors/pull/8#issuecomment-2273555656 Thanks for providing the fix. Will be part of 1.2.50. Maybe you can inform downstreams, that they will no longer to apply custom a patch. -- This is an automated message from

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-08-07 Thread via GitHub
chrisw-s commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2274770607 Unfortunately this caused some issues. Where we previously relied on catching `SQLException` a `java.lang.reflect.UndeclaredThrowableException` is now being thrown. -- This is an automat

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-08-08 Thread via GitHub
mc1arke commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2275124454 @chrisw-s Do you have a stacktrace that shows the exception you're getting or steps to reproduce the issue? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-08-08 Thread via GitHub
chrisw-s commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2275611258 Just this: ``` try (Statement statement = connection.createStatement(); ResultSet resultSet = statement.executeQuery("sp_help_fulltext_catalogs")) { fullTextSearchable

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-08-08 Thread via GitHub
VRBogdanov commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2275626750 Hello, Same is observed on my side with the following strack trace below. With latest tomcat 9.091 is ok while after updating to tomcat 9.092/93 it fails. The problem is that DB in

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-08-08 Thread via GitHub
mc1arke commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2275689404 Ah, ok. It's an exception being thrown whilst executing the underlying statement, which is happening outside the existing try/catch block that unwraps the exception. I'll raise a Bugzilla re

[PR] Unwrap InvocationTargetException from underlying statement execution [tomcat]

2024-08-08 Thread via GitHub
mc1arke opened a new pull request, #744: URL: https://github.com/apache/tomcat/pull/744 When executing a wrapped statement, any resulting SQLException is wrapped in an InvocationTargetException by the reflective invocation, which is rethrown by the InvocationHandler as an UndeclaredThrow

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-08-08 Thread via GitHub
mc1arke commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2276512539 Proposed fix in #744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Unwrap InvocationTargetException from underlying statement execution [tomcat]

2024-08-09 Thread via GitHub
markt-asf merged PR #744: URL: https://github.com/apache/tomcat/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] Unwrap InvocationTargetException from underlying statement execution [tomcat]

2024-08-09 Thread via GitHub
VRBogdanov commented on PR #744: URL: https://github.com/apache/tomcat/pull/744#issuecomment-2277924088 Hello @markt-asf, is there any possible chance of having pre-release snapshot with this change to validate it or we should wait for official build ? -- This is an automated message from

Re: [PR] Unwrap InvocationTargetException from underlying statement execution [tomcat]

2024-08-09 Thread via GitHub
markt-asf commented on PR #744: URL: https://github.com/apache/tomcat/pull/744#issuecomment-2277929769 There will be one in the [snapshot repo](https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/tomcat/11.0.0-M25-SNAPSHOT/) in about 40 mins once the CI system fin

Re: [PR] Unwrap InvocationTargetException from underlying statement execution [tomcat]

2024-08-09 Thread via GitHub
markt-asf commented on PR #744: URL: https://github.com/apache/tomcat/pull/744#issuecomment-2277931556 It isn't an official release. It is for testing purposes only. Use it at your own risk. If your server catches fire don't blame us ;) -- This is an automated message from the Apache Git

Re: [PR] Unwrap InvocationTargetException from underlying statement execution [tomcat]

2024-08-09 Thread via GitHub
VRBogdanov commented on PR #744: URL: https://github.com/apache/tomcat/pull/744#issuecomment-2277932891 Of course, thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

<    7   8   9   10   11   12   13   14   15   16   >