ChristopherSchultz commented on PR #316: URL: https://github.com/apache/tomcat/pull/316#issuecomment-2265991701
I'm a -1 on this change mostly because it's so large with so many changes at the same time. If this PR had been the accumulation of several commits e.g. (1) re-format whitespace everywhere with no other changes then (2) remove unnecessary auto-close elements then (3) standardize quoting, etc. then it would have been easier to review, spot things we didn't like, etc. But this is one giant change I'm unwilling to read through to decide if I like every single one of them so, no. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
