Re: dbcp pool evictor deadlock?

2009-06-23 Thread Mark Thomas
Eric B. wrote: > "Mark Thomas" wrote in message > news:4a40e12c.2070...@apache.org... >> Narendra Sarkar wrote: >>> Hi, >>> We have a multi threaded environment. We have noticed that thread blocks >>> for >>> 10 to 20 minutes due

Re: svn commit: r787648 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-23 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/6/23 >> Author: markt >> Date: Tue Jun 23 12:00:14 2009 >> New Revision: 787648 >> >> URL: http://svn.apache.org/viewvc?rev=787648&view=rev >> Log: >> Improved, single patch >> >> +* Make diagnosing broken requests a little easier. >> + http://people.apache.org/~m

Re: svn commit: r787955 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-24 Thread Mark Thomas
kkoli...@apache.org wrote: > Author: kkolinko > Date: Wed Jun 24 09:23:37 2009 > New Revision: 787955 > > URL: http://svn.apache.org/viewvc?rev=787955&view=rev > Log: > Updated patch. See bugzilla for details. I think that Mark won't mind. I don't mind although I am a little confused. The only ch

Re: svn commit: r787955 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-24 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/6/24 Mark Thomas : >> kkoli...@apache.org wrote: >>> Author: kkolinko >>> Date: Wed Jun 24 09:23:37 2009 >>> New Revision: 787955 >>> >>> URL: http://svn.apache.org/viewvc?rev=787955&view=rev >>>

Re: 5.5 release time frame

2009-06-24 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > what do you guys wanna do? Get through STATUS as it is today, then issue > a release? I need to add a port of the AccessLogValve threading. I'll do that tonight. Mark - To unsubscribe, e-mail:

Re: support for JSP2.1 MR2

2009-06-24 Thread Mark Thomas
Robert E Goff wrote: > The wiki says that Tomcat 7.0.x will support Servlet 3.0, and JSP 2.1 > (there is no JSP 2.2). Will it support JSP2.1 MR2? > > http://jcp.org/aboutJava/communityprocess/maintenance/jsr245/245ChangeLog2.html Yes. I would expect Tomcat 6 to support it as well. Mark

Re: svn commit: r787833 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-24 Thread Mark Thomas
mt...@apache.org wrote: > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38352 >JSPs should have read/write access to the context's temp dir >http://svn.apache.org/viewvc?rev=786490&view=rev >+1: markt, fhanik > + +1: mturk - however I agree with Bill Barker this needs furt

[RESULT] [VOTE] Release build 4.1.40 - Take 2

2009-06-25 Thread Mark Thomas
t; [X] Stable > > > Filip > Mark Thomas wrote: >> The (updated) candidates source tarball and derived binaries are >> available here: >> http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ >> >> According to the release process, the release based on th

Re: svn commit: r788376 [2/2] - in /tomcat/trunk/modules/tomcat-lite/java/org/apache/tomcat: addons/ integration/ integration/jmx/ integration/simple/ lite/ lite/cli/ lite/coyote/ lite/webxml/ servlet

2009-06-25 Thread Mark Thomas
cos...@apache.org wrote: > Modified: > tomcat/trunk/modules/tomcat-lite/java/org/apache/tomcat/lite/ServletResponseImpl.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/modules/tomcat-lite/java/org/apache/tomcat/lite/ServletResponseImpl.java?rev=788376&r1=788375&r2=788376&view=diff > =

[PROPOSAL] Use CTR for anything in the tomcat/archive in svn

2009-06-25 Thread Mark Thomas
It is unclear to me whether the archive is CTR or RTC since it does contain some old release branches. I would like to propose making the whole archive CTR. On the rare occassions where someone wishes to make a change to code in the archive, this will make it easier. Unsurprisingly, here is my +1

[ANN] Apache Tomcat 4.1.40 stable is now available

2009-06-25 Thread Mark Thomas
The Apache Tomcat team is proud to announce the immediate availability of Tomcat 4.1.40 stable. This build contains a small number of bug fixes and two important and three low severity security fixes. Please refer to the release notes for a complete list of changes. Apache Tomcat 4 is an implemen

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-26 Thread Mark Thomas
Konstantin Kolinko wrote: > 1. There is a bug, that sneaked in rev.781753 > http://svn.apache.org/viewvc?rev=781753&view=rev > That is: > the timeZoneNoDST field is never assigned and remains null > It was ok in 5.5.27. That is an error in my backport. That line should never have been deleted. I'l

[RESULT] [PROPOSAL] Use CTR for anything in the tomcat/archive in svn

2009-06-30 Thread Mark Thomas
Mark Thomas wrote: > It is unclear to me whether the archive is CTR or RTC since it does > contain some old release branches. I would like to propose making the > whole archive CTR. On the rare occasions where someone wishes to make a > change to code in the archive, this will make it

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-30 Thread Mark Thomas
Konstantin Kolinko wrote: > Regarding FastCommonAccessLogValve and ExtendedAccessLogValve: > > FastCommonAccessLogValve: > >>> There is a bug, that sneaked in rev.781753 >>> http://svn.apache.org/viewvc?rev=781753&view=rev >>> That is: >>> the timeZoneNoDST field is never assigned and remains nul

Re: svn commit: r789792 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-30 Thread Mark Thomas
rj...@apache.org wrote: > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37084 > @@ -78,11 +78,19 @@ >http://svn.apache.org/viewvc?rev=786487&view=rev >+1: markt >-1: > + rjung: +1 in principle, but a few questions/suggestions: > + - Do we need to dechunk the read requ

Re: svn commit: r790245 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-01 Thread Mark Thomas
funk...@apache.org wrote: > Author: funkman > Date: Wed Jul 1 16:10:56 2009 > New Revision: 790245 > > URL: http://svn.apache.org/viewvc?rev=790245&view=rev > Log: > vote > > Modified: > tomcat/current/tc5.5.x/STATUS.txt > > Modified: tomcat/current/tc5.5.x/STATUS.txt > URL: > http://svn.a

Re: svn commit: r790296 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-01 Thread Mark Thomas
Rainer Jung wrote: > On 01.07.2009 20:14, ma...@apache.org wrote: >> * Fix small memory leak found by find bugs. >>Backport of http://svn.apache.org/viewvc?view=rev&revision=717906 from tc6 >>resp. http://svn.apache.org/viewvc?view=rev&revision=735645 from OACC. >>+1: rjung, kkolinko >

Re: svn commit: r790398 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-01 Thread Mark Thomas
ma...@apache.org wrote: > Author: markt > Date: Wed Jul 1 21:59:09 2009 > New Revision: 790398 > > URL: http://svn.apache.org/viewvc?rev=790398&view=rev > Log: > Propose fix for 37869 Just so folks know, in terms of 5.5.28 I'm not expecting any of these patches to make it. It they get the votes

Re: [PROPOSAL] Remove build-webapps-precompile target from dist.xml of TC 6, TC 7. Or enable and fix it?

2009-07-03 Thread Mark Thomas
Konstantin Kolinko wrote: > Otherwise I'll propose removal of that "build-webapps-precompile" > target from dist.xml of 6.0 and trunk. +1 to removing it from both Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java

2009-07-05 Thread Mark Thomas
Konstantin Kolinko wrote: > Fixed it myself, in rev.791186. Don't worry. Thanks, but I am going to have to revert. Those are spec classes. I should not have made my original change. Mark - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java

2009-07-05 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/7/5 : >> Author: markt >> Date: Sun Jul 5 11:30:22 2009 >> New Revision: 791224 >> >> URL: http://svn.apache.org/viewvc?rev=791224&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797 >> Revert previous fix for >> https://issues.apache

Re: I find a bug in tomcat 4.1.x or later version(5.x,6.x)

2009-07-05 Thread Mark Thomas
jun ma wrote: > Dear Tomcat organization: > >I think I find a bug in tomcat, I explain it in the document.The document > is in the attachment. Or I paste it directly following: I haven't looked at this at all but... It is best if you create a Bugzilla entry for this so it doesn't get lost.

Re: I find a bug in tomcat 4.1.x or later version(5.x,6.x)

2009-07-05 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/7/5 jun ma : >> >> >> <% >> >> Integer myElement = (Integer)element; >> >> List myList = (List)myMap.get(myElement); >> >> *if* (myList == *null* || myList.size() <= 1) >> >> { >> >> System.out.println("test!!!"

Re: Session replication without Apache

2009-07-06 Thread Mark Thomas
Manu_SF wrote: > Hi, > > I have a working "prototype" tomcat cluster with 2 worker nodes connected to > Apache webserver as the Loadbalancer with mod_jk connectors. The session > replication works like a charm with these 2 nodes. > > However, my ultimate goal is to deploy it over a system that do

Re: [PROPOSAL] Remove SVN keywords from JavaDoc

2009-07-07 Thread Mark Thomas
Konstantin Kolinko wrote: > As was written early in this my thread: > http://www.nabble.com/Coding-Guidelines%2C-encodings%2C-keywords-td23662661.html > (http://markmail.org/thread/d6dsgrsfvnuzclt7) > > there are problems with Subversion $Date$ keyword: > 1. It uses localized names for the month a

Re: 5.5.28 tag on Monday July 13th

2009-07-08 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > Unless anyone objects, we can clear out the status for 5.5 and do a tag > on Monday. +1. Note there is a POOL 1.5.2 release with a couple more fixes in it happening now and it would be good to get that into 5.5.28 if possible. Mark

Re: svn commit: r792872 - in /tomcat/container/tc5.5.x: modules/cluster/src/share/org/apache/catalina/cluster/tcp/mbeans-descriptors.xml webapps/docs/changelog.xml

2009-07-10 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/7/10 : >> Author: markt >> Date: Fri Jul 10 10:32:14 2009 >> New Revision: 792872 >> >> URL: http://svn.apache.org/viewvc?rev=792872&view=rev >> Log: >> NEEDINFO - bug 39997: JSVC and APR do not work together for HTTPS connector >> https://issues.apache.org/bugzill

Re: svn commit: r793672 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-07-13 Thread Mark Thomas
rj...@apache.org wrote: > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47478 > @@ -159,5 +159,7 @@ >AJP connectors do not handle certificate chains >Patch by Patrik Schnellmann >https://issues.apache.org/bugzilla/attachment.cgi?id=23951 > - +1: markt > + +1: markt, rjung

Re: Why was the behaviour of ResourceBundleELResolver

2009-07-16 Thread Mark Thomas
Maarten_D wrote: > Hi, > > In response to https://issues.apache.org/bugzilla/show_bug.cgi?id=46915, the > Tomcat code was patched and 6.0.20 has now reverted back to the old > behaviour of throwing an exception for every element in a resource bundle > that can't be found. > So, my question is,

Re: Jaspic (jsr 196) support in tomcat

2009-07-16 Thread Mark Thomas
David Jencks wrote: > I think it would be great if the tomcat community integrated some > version of this code in perhaps tomcat 7 but I do not expect to be > providing any patches to tomcat for this. I'm happy to talk about the > code, but I'm more likely to see discussion on the geronimo dev lis

[PROPOSAL] Remove Realm from GenericPrincipal

2009-07-16 Thread Mark Thomas
As a result of looking into https://issues.apache.org/bugzilla/show_bug.cgi?id=40881, I discovered that the only use made of the Realm attribute of GenericPrincipal is to control whether or not a debug message is logged in RealmBase.hasRole() Given that the Realm is the reason that GenericPrincipa

Re: [PROPOSAL] Remove Realm from GenericPrincipal

2009-07-17 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/7/17 Mark Thomas : >> As a result of looking into >> https://issues.apache.org/bugzilla/show_bug.cgi?id=40881, I discovered >> that the only use made of the Realm attribute of GenericPrincipal is to >> control whether or not a

Tomcat 7 created for Bugzilla

2009-07-17 Thread Mark Thomas
Since we had a bug reported against trunk recently, I have just created a Tomcat 7 product in Bugzilla. It is heavily based on Tomcat 6 with a few minor tweaks to the components. Let me know if anything needs changing. I'll move that one TC7 bug to the new product in a sec. Mark --

Re: Tomcat 7 created for Bugzilla

2009-07-17 Thread Mark Thomas
Mark Thomas wrote: > Since we had a bug reported against trunk recently, I have just created > a Tomcat 7 product in Bugzilla. It is heavily based on Tomcat 6 with a > few minor tweaks to the components. > > Let me know if anything needs changing. > > I'll move t

Re: svn commit: r796162 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-22 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > huh? I thought in Java 6 this should work everywhere > it sure does for me Java 6 on my Mac was complaining. I'll double check my Eclipse settings - check that another JVM isn't creeping in somewhere. I'd need to double check when I get home but I think this was o

Application Period for Travel Assistance to ApacheCon US 2009 Opens Soon

2009-07-22 Thread Mark Thomas
The Travel Assistance Committee is taking in applications for those wanting to attend ApacheCon US 2009 (Oakland) which takes place between the 2nd and 6th November 2009. The Travel Assistance Committee is looking for people who would like to be able to attend ApacheCon US 2009 who may need some f

Re: Tomcat segments

2009-07-23 Thread Mark Thomas
Richard Frovarp wrote: > The Revision3 show Hak5 is doing a couple of segments on Tomcat. They > just released one episode this week with some Tomcat stuff in it, and > will be doing at least one more next week. I don't know if any of the > devs want to respond to their security or other concerns o

Re: svn commit: r796739 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-23 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > Correct, servlet 3.0 requires minimum 1.6 > so we don't have to build down to 1.5 anymore > > Filip I think sebb needs to do an svn up. build.properties.default has specified 1.6 for over 6 months. Mark > > On 07/22/2009 10:48 AM, sebb wrote: >> On 22/07/2009,

Re: Adding thumbs.db to svn:ignore?

2009-07-25 Thread Mark Thomas
Rainer Jung wrote: > I intend to add > > thumbs.db > Thumbs.db > > to svn:ignore in any images folder we have in the webapps to prevent > having it appearing again unintentionally. > > I would set the property for trunk and all release branches we maintain. > > Any objections? None at all. +1

Re: Bug 47413 - difference in composite ${a}${b} EL expressions between 6.0.18 and 6.0.20

2009-07-27 Thread Mark Thomas
Konstantin Kolinko wrote: > but to fix the second one there, I need to generate JSP code that > coerces the string value to the expected type according to EL coercion > rules. > > I do not see how to easily implement that. Maybe somebody has an idea? Some thoughts in-line. > 1) EL coercion rule

Re: [VOTE] Release build 5.5.28

2009-08-02 Thread Mark Thomas
sebb wrote: > Just noticed another problem - the source archive does not contain the > overall build script. I don't know where you are looking, but the script is there. > There are probably other source files missing. Making assumptions about what is and isn't present is not helpful. There are

Re: [VOTE] Release build 5.5.28

2009-08-02 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > The candidates binaries are available here: > http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/ > > According to the release process, the 5.5.28 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable A few minor niggles but nothing to stop the release.

Re: [PROPOSAL] Remove Realm from GenericPrincipal

2009-08-03 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/7/17 Mark Thomas : >> As a result of looking into >> https://issues.apache.org/bugzilla/show_bug.cgi?id=40881, I discovered >> that the only use made of the Realm attribute of GenericPrincipal is to >> control whether or not a

Re: 3.0 annotations ?

2009-08-04 Thread Mark Thomas
Costin Manolache wrote: > Hi, anyone working on the @Filter, @Servlet annotation scanner for > tomcat-trunk ? > If I'm understanding it correctly, tomcat will have to read all files in > classes and lib and look for the > annotation - and I would guess the only reasonable option is looking at > byt

Re: DO NOT REPLY [Bug 46990] Synchronize target can be changed midway fixed the best syntax running

2009-08-05 Thread Mark Thomas
bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=46990 > > > Mbiama Assogo Roger changed: > >What|Removed |Added > > CC|

Re: [VOTE] jdbc-pool Release build 1.0.7

2009-08-05 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > The candidates source and binaries are available here: > http://people.apache.org/~fhanik/jdbc-pool/v1.0.7/ > > According to the release process, the 1.0.7 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable Tested on Windows using zip distro MD5 OK PGP OK -

svn re-org imminent

2009-08-07 Thread Mark Thomas
Just a reminder that once 5.5.28 is released, I am planning to re-org svn. If you have checkouts of 5.5.x, jk, native, isapi, nsapi this will affect you. My plan to handle this is to: - check-in what I can beforehand - re-checkout each of the components to a new location - copy any locally modifie

Re: Regarding JmxRemoteLifecycleListener

2009-08-07 Thread Mark Thomas
Rainer Frey wrote: > Hi, > > I have some questions about the JmxRemoteLifecycleListerner that was added to > trunk. > > 1. Revision 751496 was commented with "Tomcat uses Platform MBean server. > Adjust listener accordingly." and removed the separate configuration > for "Catalina" mbean server

Re: Regarding JmxRemoteLifecycleListener

2009-08-07 Thread Mark Thomas
Rainer Frey (Inxmail GmbH) wrote: > On Friday 07 August 2009 15:49:38 Mark Thomas wrote: >> Rainer Frey wrote: >>> 1. Revision 751496 was commented with "Tomcat uses Platform MBean server. >>> Adjust listener accordingly." and removed the separate configuratio

Re: svn re-org imminent

2009-08-07 Thread Mark Thomas
Mladen Turk wrote: > On 07/08/09 13:41, Mark Thomas wrote: >> Just a reminder that once 5.5.28 is released, I am planning to re-org >> svn. If you have checkouts of 5.5.x, jk, native, isapi, nsapi this will >> affect you. >> >> >> I am currently planning t

svn re-org complete

2009-08-07 Thread Mark Thomas
The svn re-organisation is complete. I have tested the 5.5.x build and got pretty close to the 5.5.28 release. The differences appear to be attributable to post 5.5.28 fixes and that I am building using a different JDK version. One big difference is that the jk and native sources or no longer incl

Re: ... IllegalStateException: Cannot map handler [] to URL path

2009-08-10 Thread Mark Thomas
or...@l wrote: > Hello, > > I have a Java web application built using Spring + Freemarker + Hibernate + > XFire > Everything worked fine until today whenafter creating a new page > Controller, I built the project -> BUILD SUCCESFULL, but when I start Tomcat > i get ... IllegalStateException: C

Re: BIO connector - upload timeout

2009-08-10 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > Http11Processor.java > > inputBuffer.parseRequestLine(); > request.setStartTime(System.currentTimeMillis()); > keptAlive = true; > if (disableUploadTimeout) { > socket.setSoTimeout(soTimeout); >

Re: svn re-org complete

2009-08-12 Thread Mark Thomas
sebb wrote: > On 07/08/2009, Mark Thomas wrote: >> The svn re-organisation is complete. > > Is the file build/BUILDING.txt still accurate? Yes. It is the top-level build.xml that needs tweaking. > Presumably I would need to change "current.loc" but it's not cl

Re: NullPointerException - org.apache.tomcat.util.http.MimeHeaders.clear(MimeHeaders.java:130)

2009-08-13 Thread Mark Thomas
Rastogi Nikhil wrote: > Hi, > > I've implemented Axis2 Web Services in Tomcat 5.5.26 and at times of high > load (when there are several web service client requests coming in to > Tomcat), Tomcat starts throwing following NPE: > > java.lang.NullPointerException > at > org.apache.tomcat.ut

Re: Taglibs SVN migration to Tomcat

2009-08-13 Thread Mark Thomas
Henri Yandell wrote: > Post discussion between Tomcat PMC and Jakarta PMC (with myself as the > go between), the Jakarta Taglibs subproject is going to move over to > Tomcat land. Chiefly this means: > site/ [subsite -> tomcat.apache.org/taglibs/] > Anyway - all open to discussion + d

Re: [proposal] remove worker based connector thread pools in trunk

2009-08-14 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > Here is why I think its good > > 1. Current pools can't shrink, so when peak has been hit, that's where > were at > 2. Current pools are unfair, synchronized (workers) { workers.wait() }, > executors are a bit more fair since they only hold a lock for a short > per

Re: problems with urlrewrite filter 3.2.0

2009-08-14 Thread Mark Thomas
danielecal...@gmail.com wrote: > Hi, > I have istalled urlrewrite filter on my tomcat 5.5. The rewrite with the > file urlrewrite.xml work, but I can’t configure the rewrite with the > htaccess file 1. This is the dev list, not the user list. 2. This is the Tomcat project, not the UrlRewriteFilte

Re: /dev/urandom usage

2009-08-14 Thread Mark Thomas
George Sexton wrote: > I've got a question and it's kind of deep developer question. > > I was poking around today looking at my tomcat instance running under Linux. > > I was looking in the /proc//fd directory, which is the list of file > descriptors open by my servlet application. > > There ar

Re: svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread Mark Thomas
kkoli...@apache.org wrote: > + -1: kkolinko: ( > + FileDirContext#file() contains a check that file.canRead() is true. > + A side-effect of this patch will be that files that are not readable > + will be excluded from the enumeration provided by FileDirContext#list() > + or Fil

Re: Regarding JAAS logout patch (for bug 39231)

2009-08-16 Thread Mark Thomas
Konstantin Kolinko wrote: > The following patch is currently in voting for 5.5 and 6.0 > > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231 > http://svn.apache.org/viewvc?rev=791900&view=rev > http://svn.apache.org/viewvc?rev=792446&view=rev (Filip's suggestion) > JAAS LoginCon

Re: svn commit: r804963 - /tomcat/trunk/bin/catalina.sh

2009-08-17 Thread Mark Thomas
sebb wrote: > On 17/08/2009, ma...@apache.org wrote: >> + else >> +if [ $? -eq 0 ]; then > > Might be better to check $FORCE before sleeping? On reflection, I don't think there is any need for a sleep here at all. There is no PID so force won't be able to do anything anyway. > Surely tha

Re: GSoC2009 Project Wiki page updated

2009-08-18 Thread Mark Thomas
Xie Xiaodong wrote: > Hello, Dear All, > I have updated the GSoC2009 Project Wiki page. I've got some design > decisions to make, could you please spare me some time take a look at those? > Any comments are welcome. Thank you for your time. The wiki pages are beginning to look quite crowded. Rat

Re: svn commit: r805375 - in /tomcat/trunk: conf/ java/org/apache/catalina/filters/ java/org/apache/catalina/mbeans/ java/org/apache/catalina/valves/ webapps/docs/config/ webapps/examples/WEB-INF/

2009-08-18 Thread Mark Thomas
sebb wrote: > On 18/08/2009, ma...@apache.org wrote: - Trimming your responses would be really helpful >> + * @author Craig R. McClanahan > > Was the author really Craig? Enough of the code is his work that I'm not comfortable removing it. Mark -

Re: Why 404 instead of dir list ?

2009-08-18 Thread Mark Thomas
bobgosling wrote: > Why would the links be a problem ? I can see it could be a security issue > perhaps but why is it happening and is there a way to supress the problem ? This is a question for the users list, not the dev list. Mark --

Re: GSoC2009 Project Wiki page updated

2009-08-19 Thread Mark Thomas
Xie Xiaodong wrote: > Hello, Mark, > > > I've made a separate wiki page for discussing the configuration location of > those converted filters. And I updated the original wiki page based on your > comments. Thanks. > By the way, I wish that I could propose a patch for web fragment > implementat

Re: DO NOT REPLY [Bug 47767] [PatchAvailable] mod_actions and Server-Status

2009-08-31 Thread Mark Thomas
This looks like spam to me. I am going to purge it from Bugzilla and disable the account of the use that created it. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@to

Testing new website sync process

2009-09-03 Thread Mark Thomas
Folks, As part of the response to the recent compromise of ASF servers [1] the infrastructure team are introducing a new way to sync web sites from svn and are looking for PMS to volunteer to test the new process. I'd like to volunteer the Tomcat website. Any objections? I'm happy to take on fixi

Re: Testing new website sync process

2009-09-03 Thread Mark Thomas
Tim Funk wrote: > Does that mean the entire site would be in svn? If so - would that also > mean that all documentation (like javadocs etc) would move into svn? Not sure. That is one of the things to be ironed out. That doesn't strike me as a particularly good idea but it might be necessary. It is

Re: svn commit: r810161 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-09-07 Thread Mark Thomas
rj...@apache.org wrote: > URL: http://svn.apache.org/viewvc?rev=810161&view=rev > + rjung: The docs page contains a typo: rmiRegsitryPortPlatform -> > rmiRegistryPortPlatform Fixed. > + There are also some hidden defaults (password and access file) > which might make > + sense t

Re: [ANN] Apache Tomcat 5.5.28 released

2009-09-07 Thread Mark Thomas
Phil Steitz wrote: > Filip Hanik - Dev Lists wrote: >> The Apache Tomcat team announces (a bit late) the immediate availability >> of Apache >> Tomcat 5.5.28 stable. >> >> Apache Tomcat 5.5.28 incorporates numerous security updates and bug fixes. >> Please refer to the change log for the list of ch

Re: svn commit: r815411 - /tomcat/native/trunk/native/src/sslnetwork.c

2009-09-15 Thread Mark Thomas
ma...@apache.org wrote: > Author: markt > Date: Tue Sep 15 17:41:28 2009 > New Revision: 815411 C isn't my strong point so this is worth folks who know C better than I do taking a close look. Mark > > URL: http://svn.apache.org/viewvc?rev=815411&view=rev > Log: > Part of fix for https://issues.

Re: what does j_security_check do in clustering?

2009-09-16 Thread Mark Thomas
Rex Wang wrote: > Dear Tomcat devs, > > I meet a problem when config a web project which using the form based > security in clustering. > > When I set session affinity = true in my front http server, the security > check was done in single node, there is no problem with that. > But if I set affin

Re: tcnative 1.1.x CTR or RTC

2009-09-16 Thread Mark Thomas
Rainer Jung wrote: > Is tcnative 1.1.x CTR or RTC? I thought CTR - if that was wrong then I apologise. > We once had a status file, which was lost during the svn reorg. I > recovered it. Thanks. Sorry for that. > There are a couple of simple fixes sitting in there and waiting for a > vote, but

Re: svn commit: r815768 - in /tomcat/native/branches/1.1.x: ./ java/org/apache/tomcat/jni/

2009-09-16 Thread Mark Thomas
rj...@apache.org wrote: > Author: rjung > Date: Wed Sep 16 13:24:54 2009 > New Revision: 815768 > > URL: http://svn.apache.org/viewvc?rev=815768&view=rev > Log: > Sync java parts of tcnative with C part. Do we need the java part here any more? 5.5.x, 6.0.x and trunk all have their own copies. Ma

Re: Bug workflow

2009-09-17 Thread Mark Thomas
Uwe Günther wrote: > So I could set this one to resolved! Thanks Tim. Thank you. Help closing bugs is always much appreciated. > Some other questions are popping up in my head right now: > > - How do you guys to choose which bugs to fix first? As we say at the ASF - you scratch you own itch. We

Re: Bug workflow

2009-09-17 Thread Mark Thomas
Uwe Günther wrote: > So I wasn't so wrong with the first one. Unfortunately there was nothing > to code at all. > > So I am gonna go for some odd ones and go on with the good things to do. > > How does this work for non commiters; if they have a patch? Ok, 1st > attach the patch to the bug, 2nd..

Re: Testing new website sync process

2009-09-18 Thread Mark Thomas
omcat/site/trunk/ I don't know how well that would fit in with how the tag libs site is generated currently. If that won't work, do whatever you think is reasonable. We can always refine/adjust later. Mark > > Hen > > On Thu, Sep 3, 2009 at 3:59 AM, Mark Thomas wrote: >

Re: Implementing and adding an arbitrary component to Apache Tomcat 6.0

2009-09-19 Thread Mark Thomas
Stefan Zoerner wrote: > Hi all, > > I try to figure out what the best way for an arbitrary extension to > tomcat would be. If I implement my own realm, valve etc., there are > specific interfaces with corresponding life cycles. But how about > extension which are not standard components? > > If I

Re: Move Tomcat, MySQL and jre1.6.0 from Windows XP to Linux/W2008

2009-09-21 Thread Mark Thomas
homerun wrote: > Also, if this is not the best place > for me to post this question, where would it be more appropriate? This is a question for the users list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn commit: r818040 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-09-23 Thread Mark Thomas
rj...@apache.org wrote: > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47267 >http://svn.apache.org/viewvc?rev=817822&view=rev >+1: markt >-1: > + rjung: Our dreaded multi platform build system is a bit fragile > + w.r.t. fixcrlf. If you change the file to crlf in the ins

Re: svn commit: r818040 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-09-23 Thread Mark Thomas
Rainer Jung wrote: > On 23.09.2009 13:12, Mark Thomas wrote: >> rj...@apache.org wrote: >>> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47267 >>>http://svn.apache.org/viewvc?rev=817822&view=rev >>>+1: markt >>>-1: >>&

Re: Bypassing tomcat basic authentication

2009-09-23 Thread Mark Thomas
cuccigucci wrote: > Is there a way to by pass tomcat authentication. > We have an application that has BASIC authentication. > But if the incoming URL has parameter say 'apikey' then we do not want > tomcat to authenticate and instead perform our own authenticatin. That would be a question for the

Re: svn commit: r814550 - /tomcat/tc5.5.x/trunk/STATUS.txt

2009-10-03 Thread Mark Thomas
rj...@apache.org wrote: > * Add additional permission required by JULI >http://svn.apache.org/viewvc?rev=813001&view=rev > - +1: markt > + +1: markt, rjung >-1: > + rjung: Should we also add ${catalina.base}/bin/tomcat-juli.jar as a > codeBase? I'm leaning towards not. Konstantin has

Re: svn commit: r821411 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-10-03 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/10/4 : >> Author: markt >> Date: Sat Oct 3 20:58:06 2009 >> New Revision: 821411 >> >> URL: http://svn.apache.org/viewvc?rev=821411&view=rev >> Log: >> Votes >> >> Modified: >>tomcat/tc6.0.x/trunk/STATUS.txt >> >> * Fix display of sessionList and sessionDetai

Re: svn commit: r821438 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2009-10-04 Thread Mark Thomas
kkoli...@apache.org wrote: > @@ -316,10 +317,19 @@ >Make maxThreads return consistent. Will still return -1 in many cases but > that >is better than previously. >https://issues.apache.org/bugzilla/attachment.cgi?id=24341&action=edit > - +1: markt > - -1: > + +1: markt, kkolinko > +

Re: Taglibs website migration

2009-10-05 Thread Mark Thomas
Henri Yandell wrote: > This is now live. > > The Jakarta side of things has been retired and some redirects exist. > It's ready to be linked to from tomcat.apache.org. > > What do people think is best? > > a) A "Taglibs" entry under the Home link. +1 Mark > b) Individual entries per Taglib und

Re: tomcat is live but client can't request web

2009-10-20 Thread Mark Thomas
chetz wrote: > Hi, guys. I'm newbie. Btw, I want ask to you. I have installed tomcat in > linux ( opensuse). I also install postgresql there. PC which has been > installed, is connected to Internet. So client can access. > When I checked process of tomcat, it was live. But client could'nt request >

Re: svn commit: r828212 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2009-10-22 Thread Mark Thomas
Remy Maucherat wrote: > On Wed, 2009-10-21 at 20:57 +, ma...@apache.org wrote: >> Author: markt >> Date: Wed Oct 21 20:57:14 2009 >> New Revision: 828212 >> >> URL: http://svn.apache.org/viewvc?rev=828212&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47987 >> Limit

Re: monitor tomcat status through nagios

2009-10-22 Thread Mark Thomas
samengr wrote: > Hi, > > I am using tomcat version 5.5.9 and nagios for monitoring services and > harware resources in my office environment. Can someone help me to monitor > tomcat status remotely from nagios server? Is tomcat up or down and throw > email if tomcat is down? I know there isnt any

Re: How to upload the site

2009-10-23 Thread Mark Thomas
Mladen Turk wrote: > Hi, > > I've committed the 10th anniversary logo > to the site. How to put that to tomcat.apache.org > svn export --force ? umask 002 svn up Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: How to upload the site

2009-10-23 Thread Mark Thomas
Mladen Turk wrote: > On 23/10/09 17:04, Mark Thomas wrote: >> Mladen Turk wrote: >>> Hi, >>> >>> I've committed the 10th anniversary logo >>> to the site. How to put that to tomcat.apache.org >>> svn export --force ? >> >>

Re: svn commit: r830589 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2009-10-28 Thread Mark Thomas
ma...@apache.org wrote: > Author: markt > Date: Wed Oct 28 15:30:49 2009 > New Revision: 830589 > > URL: http://svn.apache.org/viewvc?rev=830589&view=rev > Log: > Ensure thread ratio calc is valid This will need to go into 6.0.x to address Konstantin's review comments on the thread count patch bu

Re: svn commit: r830736 - in /tomcat/trunk/java/org/apache/catalina/core: JreMemoryLeakPreventionListener.java LocalStrings.properties

2009-10-29 Thread Mark Thomas
Konstantin Kolinko wrote: > 2009/10/28 : >> Author: markt >> Date: Wed Oct 28 19:25:31 2009 >> New Revision: 830736 >> >> URL: http://svn.apache.org/viewvc?rev=830736&view=rev >> Log: >> Add a workaround for a common cause of locked files. >> >> Modified: >> >> tomcat/trunk/java/org/apache/cat

Re: svn commit: r831069 - in /tomcat/trunk: java/javax/servlet/http/Cookie.java webapps/docs/config/systemprops.xml

2009-10-29 Thread Mark Thomas
Konstantin Kolinko wrote: Thanks for the review. Way too much cut and paste on my part there. > Also, > "javax.servlet.http.Cookie. STRICT_NAMING" > > It would be better to name that "org.apache.tomcat.util.http. > ServerCookie.STRICT_NAMING" > as I think java(x)* property names are reserved by

Re: svn commit: r831536 - in /tomcat/trunk: java/org/apache/tomcat/util/http/ test/org/apache/tomcat/util/http/ webapps/docs/config/

2009-10-31 Thread Mark Thomas
Remy Maucherat wrote: > On Sat, 2009-10-31 at 12:59 +, ma...@apache.org wrote: >> Author: markt >> Date: Sat Oct 31 12:59:51 2009 >> New Revision: 831536 >> >> URL: http://svn.apache.org/viewvc?rev=831536&view=rev >> Log: >> Add an explicit configuration option for cookie version switching and

Re: How do I setup Tomcat to refresh a directory faster than the default 5 seconds

2009-11-01 Thread Mark Thomas
ed2003 wrote: > I tried adding variations of the following to server.xml but it still takes 5 > seconds for a newly modified file to appear. Anybody know what I am doing > wrong? That would be a question for the users list. Mark > > cacheTTL="1" > >status/picture.png > > ---

Re: svn commit: r832039 - in /tomcat/trunk/java/org/apache/naming: HandlerRef.java ResourceRef.java ServiceRef.java StringManager.java resources/DirContextURLStreamHandler.java

2009-11-02 Thread Mark Thomas
Remy Maucherat wrote: > On Mon, 2009-11-02 at 18:46 +, ma...@apache.org wrote: >> Author: markt >> Date: Mon Nov 2 18:46:21 2009 >> New Revision: 832039 >> >> URL: http://svn.apache.org/viewvc?rev=832039&view=rev >> Log: >> StringBuffer -> StringBuilder for o.a.naming > > So I did not test or

Re: svn commit: r832039 - in /tomcat/trunk/java/org/apache/naming: HandlerRef.java ResourceRef.java ServiceRef.java StringManager.java resources/DirContextURLStreamHandler.java

2009-11-03 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: > On 11/02/2009 02:30 PM, Remy Maucherat wrote: >> On Mon, 2009-11-02 at 18:46 +, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Mon Nov 2 18:46:21 2009 >>> New Revision: 832039 >>> >>> URL: http://svn.apache.org/viewvc?rev=832039&view=rev >>> Log: >>>

Re: svn commit: r833242 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-11-05 Thread Mark Thomas
jfcl...@apache.org wrote: > Author: jfclere > Date: Thu Nov 5 23:48:35 2009 > New Revision: 833242 > > URL: http://svn.apache.org/viewvc?rev=833242&view=rev > Log: > my votes. > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: > http://svn.

<    7   8   9   10   11   12   13   14   15   16   >