do not see such feature there.
http://java.net/projects/servlet-spec/lists/jsr340-experts/archive/2012-06/message/9
Does it differ much from resource JARs (the ones containing
META-INF/resources directory) of Servlet 3.0?
Be
ve
the ordering of url-patterns when someone dumps merged web.xml.
> +public void addUrlPattern(String urlPattern) {
> +this.urlPattern.add(urlPattern);
> }
> -public String getUrlPattern() { return this.urlPattern; }
> +public Set getUrlPatterns() { retu
ntext instance could be extracted into a factory
method in Tomcat's JAASRealm.
That way you (in a subclass) could use whatever you want to configure
a new LoginContext instance.
Best regards,
Konstantin Kolinko
-
To unsubscri
scriptor() always returns null.
2) Can we stop publishing merged web.xml as context attribute (make
this publishing off by default)?
org.apache.tomcat.util.scan.Constants.MERGED_WEB_XML
Best regards,
Konstantin Kolinko
-
To
ture is retained, that is a much better implementation.
>
Re: 1:
Maybe somebody wants their full GC once an hour, or once a day?
There are documentation glitches yet to be fixed:
a. systemprops.xml change in trunk was not reverted by this commit.
It was reverted in 7.0.
> -assertTrue(responseLine.startsWith("HTTP/1.1 101"));
> +Assert.assertNotNull(responseLine);
> +Assert.assertTrue(responseLine.startsWith("HTTP/1.1 101"));
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
u?
I took care of that an hour ago.
http://svn.apache.org/viewvc?rev=1377831&view=rev
>
>> b. The new property is yet to be documented in listeners.xml.
> [Filip Hanik]
> Done
>
Best regards,
Konstantin Kolinko
-
t;> Subject: Re: svn commit: r1377689 -
>>> /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListe
>>> ner.java
>>>
>>> On 27/08/2012 22:37, Filip Hanik (mailing lists) wrote:
>>>>> -Original Message-
>>>
appens/expected, nothing new here),
TestWebappClassLoaderExecutorMemoryLeak#testTimerThreadLeak
Tested BIOxNIOxAPR (native 1.1.24) with JDK 6u34 32-bit on WinXP
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-
2012/8/13 :
> Author: markt
> Date: Mon Aug 13 12:29:51 2012
> New Revision: 1372394
>
> URL: http://svn.apache.org/viewvc?rev=1372394&view=rev
> Log:
> Additional fix for http://issues.apache.org/bugzilla/show_bug.cgi?id=53584
> Store decoded and original request URI. Restore both. Use decoded fo
2012/8/28 Mark Thomas :
> On 28/08/2012 03:10, Konstantin Kolinko wrote:
>> 2012/8/13 :
>>> Author: markt
>>> Date: Mon Aug 13 12:29:51 2012
>>> New Revision: 1372394
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1372394&view=rev
>>
2012/8/28 Mark Thomas :
> On 28/08/2012 19:36, Mark Thomas wrote:
>> On 28/08/2012 14:24, Konstantin Kolinko wrote:
>>> 2012/8/28 Mark Thomas :
>>>> On 28/08/2012 03:10, Konstantin Kolinko wrote:
>>>>> 2012/8/13 :
>>>>>> Author:
in some other manner.
>
Can you please open an issue in Bugzilla?
So it would be better to keep track of things.
The patch looks good.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-7-trunk/
There is quite a number of "pending requests" in that list.
If it really would try to build all those one-by-one (x 30 minutes
each), that would be a bit silly.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
ublic HeadersTooLargeException(Throwable cause) {
> +super(cause);
> +}
I wonder whether UCDetector will remove some of the above.
Just joking.
If it is supposed to be used by 3rd parties, it is better to keep all
4 constructors.
> +}
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
(results == null || results.size() == 0) {
> return null;
> }
> SecurityConstraint [] array = new SecurityConstraint[results.size()];
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/8/30 :
> Author: markt
> Date: Thu Aug 30 19:44:46 2012
> New Revision: 1379091
>
> URL: http://svn.apache.org/viewvc?rev=1379091&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53792
> Support method expressions that include a method call that is not at the end
> of
2012/8/31 Konstantin Kolinko :
> 2012/8/31 :
>> Author: markt
>> Date: Thu Aug 30 21:57:15 2012
>> New Revision: 1379178
>>
>> URL: http://svn.apache.org/viewvc?rev=1379178&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.
2012/9/1 Mark Thomas :
> On 31/08/2012 12:37, Konstantin Kolinko wrote:
>> 2012/8/30 :
>>> Author: markt
>>> Date: Thu Aug 30 19:44:46 2012
>>> New Revision: 1379091
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1379091&view=rev
>>&
2012/9/1 Mark Thomas :
> On 01/09/2012 01:55, Konstantin Kolinko wrote:
>> 2012/9/1 Mark Thomas :
>>> On 31/08/2012 12:37, Konstantin Kolinko wrote:
>>>> 2012/8/30 :
>>>>> Author: markt
>>>>> Date: Thu Aug 30 19:44:46 2012
>>>&
sertionFailedError: Uri: /, Status: 200, Time: 30486
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:83)
at
org.apache.catalina.core.TestAsyncContextImpl.testBug50753(TestAsyncContextImpl.java:
mcat-Native 1.1.24
x bio, nio, apr: all pass successfully, except one memory leak protection test,
org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak#testTimerThreadLeak,
that fails randomly for different connectors. It is a known issue -
nothing new wit
to read.
On this page;
http://tomcat.apache.org/lists.html#tomcat-users
there is a link to "How To Ask Questions The Smart Way" guide.
You may find it useful.
http://www.catb.org/~esr/faqs/smart-questions.html#writewell
Best regards,
Konstantin Kolinko
--
AndSet&invoke=BEANNAME&op=METHODNAME&ps=COMMASEPARATEDPARAMETERS&set=BEANNAME&att=MYATTRIBUTE&val=NEWVALUE
becomes
http://webserver/manager/jmxproxy/?operations=invoke,set&0.invoke=BEANNAME&0.op=METHODNAME&0.ps=COMMASEPARATEDPARAMET
submitted as patches via Bugzilla (for Tomcat) or JIRA (for
Apache Commons). They are covered by clause 5 of the Apache License,
http://www.apache.org/licenses/LICENSE-2.0
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mai
> pDestinationPath + "/" + aIncludeDir);
> +copyDirectoryContentIntoArchive(new File(pSourceFolder + "/"
> + aIncludeDir), pDestinationPath + "/" + aIncludeDir, pArchiveOutputSteam);
> +}
> +}
> +
uld be a check for isServiced().
4. Some synchronization is needed.
E.g. checkResources() is a synchronized method. I think chekUndeploy
should be synchronized as well.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-uns
; @@ -0,0 +1,22 @@
> +package org.apache.catalina.webresources;
> +
> +public final class Constants {
> +
> +public static final String Package = "org.apache.catalina.webresoucres";
There is a typo in the above constant value.
> +}
Best regards,
Konstantin Koli
> +thread.interrupt();
> +thread = null;
> +}
> super.stop(svc);
> }
The above changes the meaning of the "running" flag.
IMHO, the flag is supposed to say whether TcpPingInterceptor itself is
running or not. It does not matter
ready some
caching to prevent re-opening the jar file on each access.
There is a related issue in WebappClassLoader that I filed here:
https://issues.apache.org/bugzilla/show_bug.cgi?id=52448
I think I'll have time for more detailed review on this weekend.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
nd(Long.toString(remains / 100));
> -remains = remains % 100;
> -buf.append(Long.toString(remains / 10));
> -buf.append(Long.toString(remains % 10));
> +buf.append(Long.toString(time % 1000));
The above change is plainly wrong. It loses leading
its synchronized methods be a bottleneck? (That is what
ConcurrentLinkedQueue is designed to avoid).
The pop() method should assign null value to the slot that it freed.
(It is not important if the object is going to be re-added to the
cache. It would be noticeable if the object would be discard
go.
It moves reference queue handling into separate method that is
callable as a periodic task.
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/collections/ManagedConcurrentWeakHashMap.java?view=markup
(for https://issue
t;
I am sure that DirContext is not the right API to define resources.
At best is could be a [deprecated] view/proxy to the actual implementation.
The only benefit I see in using this API by someone is that the API
itself is defined in javax.* and so one can avoid compile-time
dependencies on Tomcat code.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
compressionFilters.CompressionFilter).
There exists a gzip filter in the Ehcache project.
It is likely that there are others as well.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
and a ServletFilter is not that bad, grmbl :-)
>
> I've already implemented an initial version. It's not ideal, but it's enough
> for me to play around:
>
>
> Your feedback is highly appreciated!
>
> Best regards,
>
> Florian
>
> Am 30.09.2012 um
r to see (a), (a+b) and (a+b+c).
Seeing (a+b+c) is usually also good enough if you can explain the
changes such that a committer would be able to separate them.
2. Why do you need sophisticated header parsing in SimpleHttpClient?
The server s
2012/10/1 Olivier Lamy :
> Hi Folks,
> I wonder what is the plan for CMS or svnpubsub for the web site ?
The plan is to use svnpubsub.
The whole site is already in svn, except for subprojects that rely on Maven:
1. Taglibs
2. Maven Plugin
Best regards,
Konstantin K
h exceeds the limit of 50 ones, so it was shortened to the summary.]
>
The page
http://tomcat.apache.org/maven-plugin.html
says that the beta-1 site is http://tomcat.apache.org/maven-plugin-2/
Should you correct the link and remove "maven-plugin-2" dir
2012/10/1 Olivier Lamy :
> 2012/10/1 Mark Thomas :
>> On 01/10/2012 10:36, Olivier Lamy wrote:
>>> 2012/10/1 Mark Thomas :
>>>> On 01/10/2012 07:48, Olivier Lamy wrote:
>>>>> 2012/10/1 Konstantin Kolinko :
>>>>>> 2012/10/1 Olivier Lam
first?
The documentation formatting for the manager webapp is still broken.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:722)
Best regards,
Konstantin Kolinko
-
To
2012/10/2 Christopher Schultz :
> Konstantin,
>
> On 10/2/12 2:32 PM, Konstantin Kolinko wrote:
>> Running current trunk + Nio connector + JDK 7u7, I see a lot of the
>> following exceptions.
>>
>> It looks like there is some bug in AccessLogValve optimization w
; I assume no-one will object to these but it will take me a little while
> to figure out what I need to do to generate a release so shout if there
> are any objections to these updates.
>
> Mark
>
Looks OK, but you need to update the changelog as well.
(The RM name on will
> +Update to Apache Tomcat native 1.2.24. (markt)
_N_ative, 1._1_.24
> +
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
yMethodsSet.contains(method))
That is unless the method name is converted to uppercase somewhere.
I have not yet checked what HTTP spec says on method names.
>
> String contentType = getContentType();
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
requirements/expectations of hasOp()
must be documented somewhere. The old Javadoc correctly documented
that the only flag that it supported was that legacy renegotiation
one.
If we consider the java classes in tomcat/trunk as the main source of
java classes for tcnative, then I think this javadoc up
2012/10/5 Christopher Schultz :
> Konstantin,
>
> On 10/5/12 8:45 AM, Konstantin Kolinko wrote:
>> 2012/10/4 :
>>> Author: markt
>>> Date: Thu Oct 4 14:55:59 2012
>>> New Revision: 1394104
>>>
>>> URL: http://svn.apache.org/viewvc?rev
2012/10/6 Mark Thomas :
>
> Konstantin Kolinko wrote:
>
>>2012/10/5 Christopher Schultz :
>
>>> RFCs 2616, 2068, and 1945 all agree that method name is
>>case-sensitive:
>>> http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1
>>>
>
ttps://issues.apache.org/jira/browse/DAEMON-252
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
e is being waited for a long time.
It is better to release one sooner, as is,
and then have the next release of 6.0.x in ~3 months.
That said, I do not stop you from implementing your patch. I just do
not want it to be a factor in postponing the relea
2012/10/12 :
> Author: markt
> Date: Thu Oct 11 20:29:01 2012
> New Revision: 1397291
>
> URL: http://svn.apache.org/viewvc?rev=1397291&view=rev
> Log:
> Fill in some of the HTTP upgrade Javadoc
>
> Modified:
> tomcat/trunk/java/javax/servlet/http/HttpServletRequest.java
> tomcat/trunk/jav
at java.io.BufferedReader.readLine(BufferedReader.java:317)
at java.io.BufferedReader.readLine(BufferedReader.java:382)
at
org.apache.tomcat.util.net.TestSsl.testRenegotiateWorks(TestSsl.java:197)
]]]
Best regards,
Konstantin Kolinko
-
2012/10/12 Mark Thomas :
> On 12/10/2012 09:01, Konstantin Kolinko wrote:
>> 2012/10/12 Mark Thomas :
>>> On 12/10/2012 01:21, ma...@apache.org wrote:
>>>> Author: markt
>>>> Date: Fri Oct 12 00:21:23 2012
>>>> New Revision: 1397390
>>&g
2012/10/12 Mark Thomas :
> On 12/10/2012 08:54, Konstantin Kolinko wrote:
>> 2012/10/12 :
>>> Author: markt
>>> Date: Thu Oct 11 20:29:01 2012
>>> New Revision: 1397291
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1397291&view
or array of size [{2}]
> +msg = MessageFormat.format(msg, msgArgs);
> +throw new IndexOutOfBoundsException(msg);
> }
> +
> +contentLength += len;
> }
> }
>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
)
[junit] at
org.apache.tomcat.util.bcel.classfile.Constant$1.hashCode(Constant.java:51)
[junit] at
org.apache.tomcat.util.bcel.classfile.Constant.hashCode(Constant.java:150)
]]]
Best regards,
Konstantin Kolinko
-
To uns
2012/10/14 Mark Thomas :
> On 14/10/2012 00:05, Konstantin Kolinko wrote:
>> 2012/10/14 Mark Thomas :
>>> On 13/10/2012 22:43, ma...@apache.org wrote:
>>>> Author: markt
>>>> Date: Sat Oct 13 21:43:36 2012
>>>> New Revision: 1397953
>>&g
changes the content of those char arrays, the access
log may become a mess.
I propose to just write the digits. I think the following will work,
appending a digit value to the code of '0' character:
int status = response.getStatus();
if (100 <= status && status < 100
etween trunk and trunk-resources branch state after that
commit.
The command is
svn diff --old=https://svn.apache.org/repos/asf/tomcat/trunk@1397302
--new=https://svn.apache.org/repos/asf/tomcat/sandbox/trunk-resources@1397302
I uploaded the diff file here (its size is ~400KB):
http://people.apache.
2012/10/20 :
> Author: olamy
> Date: Fri Oct 19 20:22:22 2012
> New Revision: 1400269
>
> URL: http://svn.apache.org/viewvc?rev=1400269&view=rev
> Log:
> add doc on how to test tomcat6 maven artifacts
>
-Dtomcat6Version=7.0.26
is a wrong version to use in a Tomcat 6 example ;)
BTW, the current s
2012/10/17 Mark Thomas :
> On 17/10/2012 15:07, Konstantin Kolinko wrote:
>
>> 1. Are and able to inject individual files?
>
> Not yet, but that should be relatively simple to implement.
>
>> 2. I am -1 on removal of VirtualWebappLoader.
>>
>> The fe
lve.java
>
It needs svn:eol-style.
BTW, I reopened the issue
https://issues.apache.org/bugzilla/show_bug.cgi?id=54044#c6
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
F
e the following comment:
<%--
Resource file that is present both fragments and the ordering need a desision!
--%>
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
nticator.TestSSOnonLoginAndDigestAuthenticator.NIO.txt
Testsuite:
org.apache.catalina.authenticator.TestSSOnonLoginAndDigestAuthenticator
Tests run: 6, Failures: 4, Errors: 0, Time elapsed: 3.05 sec
All 4 failures are printing
expected:<200> but was:<401>
Best regards,
Konstantin Kolinko
--
irst look at
it, the change looks OK.
BTW, there are "XXX" comments on this
PageContextImpl#proprietaryEvaluate() method and in
o.a.jasper.compiler.JspUtil#interpreterCall(..) where it generates JSP
java code that calls this method.
The comments say that the intention was to remove this
&q
just mention that the file is described elsewhere, or follows
some procedure described elsewhere.
It may be worth adding the AL header (though some say that trivial
files do not need it).
Best regards,
Konstantin Kolinko
2012/11/6 :
> Author: olamy
> Date: Mon Nov 5 21:59
k on Apache Tomcat, those are listed here:
http://tomcat.apache.org/resources.html
and on the "Books" page in the wiki.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For
8-255).
2) Quickly looking what the spec says. The JSP one says to use the EL
rules (JSP.2.3.2, JSP.2.3.4). The EL one (1.18.4) says to just call
charAt(0) here.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
che.org
6. It is not clear what is lifecycle of a comment.
I see that when I log in then there is a link above each comment that
allows to mark it as "Resolved". When (and who) is removing resolved
comments?
E.g. someone is supposed to do a manual sweep once the next minor
Tomcat version is
2012/11/8 Olivier Lamy :
> apologize for delayed response (I'm on vacations :-) )
> So I have added a "how to contribute" page see
> http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/how-to-contribute.html
>
OK. I have seen your commits.
Best regards,
Konstant
vironment_Entries
Best regards,
Konstantin Kolinko
> Modified:
> tomcat/tc7.0.x/trunk/ (props changed)
>
> tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/NamingContextListener.java
>
> tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestNamingContextList
Dispatch(TestAsyncContextImpl.java:387)
The code is
alvGlobal.validateAccessLog(1, 200, TimeoutServlet.ASYNC_TIMEOUT,
TimeoutServlet.ASYNC_TIMEOUT + TIMEOUT_MARGIN +
REQUEST_TIME);
TimeoutServlet.ASYNC_TIMEOUT is 3000, so it executed faster (2
)
> +&& artifact.getFile().isFile() ) )
> {
> String fileName = artifact.getFile().getName();
> if ( !fileInClassLoaderEntries.contains( fileName ) )
Сalling both artifact.getFile().
2012/11/12 :
> Author: markt
> Date: Sun Nov 11 23:35:41 2012
> New Revision: 1408152
>
> URL: http://svn.apache.org/viewvc?rev=1408152&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54123
> There are two things going on here:
> 1. The reported bug. If there is a async ti
concern, or
maybe you will notice it while running TCK).
There is already ready-to-use class AsyncContextImpl$PrivilegedSetTccl(..).
Best regards,
Konstantin Kolinko
>
> Modified:
> tomcat/tc7.0.x/trunk/ (props changed)
> tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/
harSet = new StringBuilder();
> -noCharSet.append(type);
> -noCharSet.append('/');
> -noCharSet.append(subtype);
> -for (Map.Entry entry : parameters.entrySet()) {
> -noCharSet.append(';');
> -// Workaround for Adobe Rea
> +public synchronized void add(ELResolver elResolver) {
> +super.add(elResolver);
if (resolvers.length < size) {
resolvers[size] = elResolver;
} else {
> +ELResolver[] nr = new ELResolver[size + 1];
> +System.arraycopy(resolvers, 0, nr,
2012/11/13 Mark Thomas :
> On 13/11/2012 00:57, Konstantin Kolinko wrote:
>> 2012/11/12 :
>>> Author: markt
>>> Date: Sun Nov 11 23:35:41 2012
>>> New Revision: 1408152
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1408152&view=rev
>&g
the "Out" tagplugin that should
be fixed before tagging
https://issues.apache.org/bugzilla/show_bug.cgi?id=54144#c2
(I certainly do not have time for it for the next ~8 hours.)
Best regards,
Konstantin Kolinko
-
To unsubsc
>
> Thoughts on back-porting this to 7.0.x?
>
+1
The compiler in Eclipse 3.7.2 was crashing for me when compiling
Tomcat 8. I switched over to 4.2.1 a week ago and the problem
disappeared. Someone else with Java 7 could be experiencing a
similar issue, so
he latest released version of
commons-daemon is 1.0.10. Until 1.0.11 is released there is no way to
bundle it with Tomcat.
http://commons.apache.org/daemon/
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...
rgapachetomcat-043/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_33/
>
> The proposed 7.0.33 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.33 Stab
2012/11/20 Rainer Jung :
> On 08.11.2012 23:25, Konstantin Kolinko wrote:
>> 2012/11/8 Rainer Jung :
>
>> Several notes:
>>
>>> A final version would include a reference to tomcat.apache.org
>
> Yes, noted.
>
>> 1. I think it needs to als
beanutils*.jar" contains sub string ".jar"
or separator "," is missing expected:<35> but was:<13>
at
org.apache.tomcat.util.scan.TestJarScanner.testJarsToSkipFormat(TestJarScanner.java:45
rojects will be smaller.
2. I think it would be better to have
"tomcat-websocket-impl.jar" or simply "tomcat-websocket.jar" instead
of "websocket-impl.jar"
In Maven you will name it "tomcat-.jar" anyway.
There will be less conflicts from including such a name
2012/11/21 Rainer Jung :
>
> Integrate comments.apache.org with TC 7 docs on tomcat.apache.org:
>
> [x] +1, go ahead
> [ ] 0, I don't care
> [ ] -1, Don't integrate, because ...
>
Best regards,
Konstantin Kolinko
-
.naming property
> * to the JNDI properties file
> * Setting an environment variable named Context.URL_PKG_PREFIXES with
> * its value including the org.apache.catalina.util.naming package name.
The above line has the same typo.
Best regards,
Konstantin Kolinko
NG: testPerformance() test rerun completed in 4243 ms
[junit] Test org.apache.tomcat.util.http.mapper.TestMapper FAILED
Performance test for Mapper x BIO. 4243 ms > 4s.
Nothing to worry about.
Re-running this test with NIO
e.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/WsSci.java?view=markup
> + *
> * @since Servlet 3.0
> */
> public interface ServletContainerInitializer {
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
kHashMap may modify itself on get(), as it processes the reference
queue of items removed by GC.
Either a plain old lock / synchronization is needed, or some other solution
(e.g. org.apache.tomcat.util.collections.ManagedConcurrentWeakHashMap )
Best regards,
Konstantin Kolinko
---
steners to the web application via annotations so I
think "true" will be more appropriate here
(and SCI processing happens regardless of the value).
> + org.apache.tomcat.websocket
> +
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
start = template.indexOf('{', pos);
> +}
> +
> +// No more matches, append current position to end
> + if (pos < template.length()) {
> +pattern.append('(');
> +pattern.append(template.substring(pos));
> +
n.lastAccessedTime and
thisAccessedTime by some fixed amount (6) instead of waiting for
that time to pass.
b) Maybe call ManagerBase.setProcessExpiresFrequency(1) instead of the
default value (6) and reduce MANAGER_SCAN_DELAY_SECS from 60 to 10.
Best regards,
Konstantin Kolinko
---
gt;
> Best guess right now is that I'll be tagging 7.0.34 tomorrow.
>
OK.
1. I think we need to switch over to the recently released Daemon 1.0.11.
2. There are a number of issues filed for jdbc-pool. It is not a
stopper, but it might be worth looki
t; suffix=".txt"
If I just enable this feature, I would get a file named
"localhost_access_log..txt" with two dots.
A remedy is to explicitly define the fileDateFormat attribute and move
the dot from prefix attribute into fileDateFormat one.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2012/12/3 Rainer Jung :
> On 03.12.2012 12:09, Konstantin Kolinko wrote:
>> 2012/11/29 :
>>> Author: rjung
>>> Date: Thu Nov 29 08:33:47 2012
>>> New Revision: 1415081
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1415081&view=rev
>>
2012/12/3 Brian Burch :
> On 03/12/12 16:22, Brian Burch wrote:
>>
>> On 03/12/12 11:44, Brian Burch wrote:
>>>
>>> On 02/12/12 22:00, Konstantin Kolinko wrote:
>>
>>
>>>>
>>>> According to Buildbot logs, testBasicLoginSessionT
Of(value);
> +} else if (type.equals(short.class) || type.equals(Short.class)) {
> +return Short.valueOf(value);
> +} else {
> +// TODO
> +throw new IllegalArgumentException();
> +}
> }
> }
"if
2012/12/4 Mark Thomas :
> On 04/12/2012 15:57, Konstantin Kolinko wrote:
>> 2012/12/3 :
>>> Author: markt
>>> Date: Sun Dec 2 21:01:52 2012
>>> New Revision: 1416258
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1416258&view=re
401 - 500 of 2494 matches
Mail list logo
