2012/9/9 <ma...@apache.org>: > Author: markt > Date: Sat Sep 8 21:11:46 2012 > New Revision: 1382367 > > URL: http://svn.apache.org/viewvc?rev=1382367&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52777 > Implement optional automatic removal of old applications where parallel > deployment has been used.
Regarding checkUndeploy(): 1. I think it should check whether the current app version is up and running. Consider the following: you deploy a new version of webapp, but it fails to start If nobody uses the old version, it will be immediately undeployed, and you end up with no running version of the app. A similar problem is when the new version needs some time to start (more than delay between autodeploy runs). You should not undeploy the old one until the new is up and running. 2. I suspect that if the old version is stopped, it should not be auto-undeployed as well. I do not have a good explanation for this though. Something like 'if it was stopped manually, auto-undeploy should not bother with it'. Maybe I am wrong. There are situations where auto-undeploying such stale versions might be good. 3. There should be a check for isServiced(). 4. Some synchronization is needed. E.g. checkResources() is a synchronized method. I think chekUndeploy should be synchronized as well. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
