Re: svn commit: r1677884 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ webapps/docs/config/

2015-05-05 Thread Konstantin Kolinko
cumentation (config/http.html), there exists configuration attribute "truststoreProvider". It is odd that the call uses keystore Provider option instead of "truststoreProvider" as the second argument to getTrustManagers(). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1677840 - in /tomcat/trunk: java/org/apache/tomcat/util/net/SocketProperties.java webapps/docs/config/http.xml

2015-05-05 Thread Konstantin Kolinko
ava/org/apache/tomcat/util/net/SocketProperties.java > tomcat/trunk/webapps/docs/config/http.xml Searching for "socketWrapperCache", it is also mentioned in config/ajp.xml Best regards, Konstantin Kolinko > Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java > URL:

Re: svn commit: r1677971 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java webapps/docs/changelog.xml

2015-05-06 Thread Konstantin Kolinko
eProvider() directly then there is no such fallback logic. 2. The patch is not applicable to Tomcat 6 as is, as its endpoint classes do not have "getTruststoreProvider()" method. Searching for "truststoreProvider" I see that documentation mentions such option in config/http.xml, and

Re: Tomcat Grid write up

2015-05-07 Thread Konstantin Kolinko
e write up. > Your attachment was removed by mailing list server. The users' list rules apply here as well, http://tomcat.apache.org/lists.html#tomcat-users -> 7. *.txt text/plain attachments may pass through the server, but zip/doc/image/binary are certainly dropped. B

Re: svn commit: r1678169 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SSLHostConfig.java jsse/JSSESocketFactory.java

2015-05-07 Thread Konstantin Kolinko
in the end I don't think there's much difference between >> getPathAbsolute and toAbsolute(getPath). > > I think I am done with the config changes although I'd give it a while > to see what bugs get reported. > > I need to add SSLHostConfig to JMX. That is ne

Re: [VOTE] Release Apache Tomcat 7.0.62

2015-05-08 Thread Konstantin Kolinko
age about failed attempt to load a *BeanInfo class that does not actually exist. [1] http://markmail.org/message/fmtljuelrfxwbkld (VOTE 7.0.61 thread) [2] http://markmail.org/message/rdu7uiqkw3qh6yme (VOTE 7.0.57 thread) [3] https://bz.apache.org/bugzilla/show_bug.cg

Re: [VOTE] Release Apache Tomcat 6.0.44

2015-05-08 Thread Konstantin Kolinko
ng with SecurityManager enabled, BIO connector, Java versions 5u20, 6u45, 8u45 32-bit on Windows 7 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Back-porting the new HttpHeaderSecurityFilter

2015-05-12 Thread Konstantin Kolinko
lve ambiguity in understanding the text. 7) I do not see any mention of this filter in docs/security-howto.html 8) All those X-something headers are non-standard. It is good to use them, but they may change in a future specification. In general

Re: svn commit: r1678945 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

2015-05-12 Thread Konstantin Kolinko
w, s/* o/* to/ at start of the next line. . > + * o be configured with network.http.spdy.enforce-tls-profile=false in order for > + * FireFox to be able to connect. > * > */ > public class Http2UpgradeHandler implements InternalHttpUpgradeHandler { > Best regards, Ko

Re: [VOTE] Release Apache Tomcat 8.0.23

2015-05-21 Thread Konstantin Kolinko
CAT_8_0_23/ > > The proposed 8.0.23 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.0.23 Tests - OK (all connectors) Java 7u80 32-bit on Windows 7. Smoke testing OK. Best regards, Konstantin Kolinko --

Re: svn commit: r1641363 - in /tomcat/trunk: ./ conf/ java/org/apache/catalina/tribes/transport/nio/ java/org/apache/jasper/ java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ java/org

2014-11-25 Thread Konstantin Kolinko
} else { > -// Default to 1.7 > +// Default to 1.8 > settings.put(CompilerOptions.OPTION_TargetPlatform, > -CompilerOptions.VERSION_1_7); > +CompilerOptions.VERSION_1_8); > settings.put(CompilerOptions.OPTION_Co

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Konstantin Kolinko
} > +return true; > +} > + > +public static Key getInstance(Object o) { > +if (o instanceof String) { o is never null inside this if() block. > +return new Key((String) o); > +} > +return nu

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Konstantin Kolinko
2014-11-28 21:29 GMT+03:00 Mark Thomas : > On 28/11/2014 17:47, Konstantin Kolinko wrote: > > Thanks for the review. I think I've addressed everything. > public int hashCode() { final int prime = 31; int result = 1; result

Re: svn commit: r1642360 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java WsWebSocketContainer.java server/UpgradeUtil.java server

2014-11-28 Thread Konstantin Kolinko
2014-11-28 23:33 GMT+03:00 : > Author: remm > Date: Fri Nov 28 20:33:20 2014 > New Revision: 1642360 > > URL: http://svn.apache.org/r1642360 > Log: > - Use the extensions specified by the configuration (and ignore if there are > no associated transformations). > - Add an origin header on the clie

Re: svn commit: r1642595 - in /tomcat/trunk: java/org/apache/catalina/valves/RequestFilterValve.java test/org/apache/catalina/valves/TestRequestFilterValve.java webapps/docs/config/valve.xml

2014-11-30 Thread Konstantin Kolinko
http port to check whether the app > works but public access will still be restricted to the AJP port. 3) Expose the new properties via JMX = ? > Modified: > tomcat/trunk/java/org/apache/catalina/valves/RequestFilterValve.java > tomcat/trunk/test/org/apache/catalina/valves/Te

Re: Behavior and default config for JULI AsyncFileHandler

2014-12-01 Thread Konstantin Kolinko
Thus recent entries are guaranteed to appear in the log after some delay. If I enable buffering in FileHandler, there is no time guarantee when the entries will appear in the file. A flush is performed only when buffer overflows or when the handler is closed. A similar but smaller issue is with rotation of log files. Rotation is performed only when a log event arrives. If there are no log events coming, the old log file is kept open. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-02 Thread Konstantin Kolinko
ave a very large cost. Thus, I'm not very motivated to bring it to the EG, >> but you can do it since the issue is simple to describe. > > My opinion is that the default value currently being provided is just > plain wrong. The origin is meant to be "the script origin g

Re: Recreate missing TC commit emails

2014-12-06 Thread Konstantin Kolinko
d the subject will be > > [BACKUP] svn commit: > > to make them distinguishable from the automated ones. > > I'll send the 12 mails out in a few minutes. Looks good. Thank you. Best regards, Konstantin Kolinko - To

Re: svn commit: r1643323 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/security/ java/org/apache/el/parser/ java/org/apache/jasper/ java/org/apache/jasper/compiler/

2014-12-06 Thread Konstantin Kolinko
s where line separator is used repeatedly in the same method and they can benefit from such local variable, e.g. /java/org/apache/jasper/compiler/DefaultErrorHandler.java Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1643323 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/security/ java/org/apache/el/parser/ java/org/apache/jasper/ java/org/apache/jasper/compiler/

2014-12-06 Thread Konstantin Kolinko
2014-12-06 19:37 GMT+03:00 Mark Thomas : > On 06/12/2014 16:07, Konstantin Kolinko wrote: >> 2014-12-05 18:18 GMT+03:00 : >>> Author: markt >>> Date: Fri Dec 5 15:18:46 2014 >>> New Revision: 1643323 >>> >>> URL: http://svn.apach

Re: svn commit: r1614165 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/ManagerServlet.java webapps/docs/changelog.xml

2014-12-06 Thread Konstantin Kolinko
irations. If there is a session that is idle for 40 minutes then it will be counted in the last bucket: else if (time >= maxCount) timeout[maxCount-1]++; The label for its counter shall be ">=29", not "29 - <30". Example to reproduce this issue: Configure examples webapp with the following in its web.xml 2 and the following in its META-INF/context.xml: Actually it would be better to use a separate counter for such overly idle sessions, to be able to distinct them from those that have time between 29 and 30. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1614165 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/ManagerServlet.java webapps/docs/changelog.xml

2014-12-06 Thread Konstantin Kolinko
2014-12-07 7:45 GMT+03:00 Konstantin Kolinko : > 2014-07-29 0:42 GMT+04:00 : >> Author: markt >> Date: Mon Jul 28 20:42:46 2014 >> New Revision: 1614165 >> >> URL: http://svn.apache.org/r1614165 >> Log: >> Correct the label in the list of sessions by

Re: svn commit: r1643912 - in /tomcat/trunk: build.properties.default build.xml res/patches/ res/patches/commons-logging-log4j2.patch

2014-12-08 Thread Konstantin Kolinko
rs to Maven need to be updated. Best regards, Konstantin Kolinko > Probably a candidate for upstream (commons logging). Interesting. > Added: > tomcat/trunk/res/patches/ > tomcat/trunk/res/patches/commons-logging-log4j2.patch (with props) > Modified: > tom

Re: svn commit: r1643912 - in /tomcat/trunk: build.properties.default build.xml res/patches/ res/patches/commons-logging-log4j2.patch

2014-12-08 Thread Konstantin Kolinko
though. Thus far I prefer to use our JULI (and plan to work on extending it if it ever does not meet my needs). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1644737 - /tomcat/trunk/webapps/docs/config/systemprops.xml

2014-12-11 Thread Konstantin Kolinko
If I wrap a space character with the following span: the line is wrapped and the space is not copied when I copy the text. (Tested with Firefox 34, IE 11). It feels like a trick, though. Best regards, Konstantin Kolinko 2014-12-12 1:06 GMT+03:00 Christopher Schultz : > All, > >

Re: svn commit: r1645444 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-12-14 Thread Konstantin Kolinko
2014-12-14 15:00 GMT+03:00 : > Author: markt > Date: Sun Dec 14 12:00:28 2014 > New Revision: 1645444 > > URL: http://svn.apache.org/r1645444 > Log: > StandardContext doesn't implement authenticator so remove pointless test. I think you are wrong here, though I do not know of a use case. Maybe it

Re: svn commit: r1645444 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-12-14 Thread Konstantin Kolinko
2014-12-14 18:33 GMT+03:00 Mark Thomas : > On 14/12/2014 15:25, Konstantin Kolinko wrote: >> 2014-12-14 15:00 GMT+03:00 : >>> Author: markt >>> Date: Sun Dec 14 12:00:28 2014 >>> New Revision: 1645444 >>> >>> URL: http://svn.apache.org/r

Re: svn commit: r1645466 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardServer.java java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java test/org/apache/catalin

2014-12-14 Thread Konstantin Kolinko
server. What is a use case for changing domain name of StoreConfig MBean? Multiple embedded Tomcat servers in the same JVM? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1646359 - /tomcat/trunk/java/org/apache/coyote/Response.java

2014-12-17 Thread Konstantin Kolinko
this (technically it has not broken anything yet to be a veto, but it looks as a wrong change to me). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1647051 - in /tomcat/trunk/java/org/apache: catalina/connector/ catalina/manager/ catalina/manager/host/ catalina/servlets/ catalina/users/ catalina/util/ catalina/valves/ tomcat/util

2014-12-22 Thread Konstantin Kolinko
ot;coyoteResponse.sendRedirect.note", > -RequestUtil.filter(absolute))); > + HttpMessages.filter(absolute))); > flushBuffer(); > } > } catch (IllegalArgumentException e) { > (...) Best regards,

Re: svn commit: r1647044 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/juli/ClassLoaderLogManager.java webapps/docs/changelog.xml

2014-12-22 Thread Konstantin Kolinko
ing zero length log files. ]]] As such, I expect that those configurations will start logging this error message. I think that that step shall be replaced with creating a zero-length logging.properties file. (I thought that our docs were already saying so, but the actual text is different). Best r

Re: svn commit: r1647356 - /tomcat/jk/trunk/conf/workers.properties.minimal

2014-12-22 Thread Konstantin Kolinko
riworkermap.properties native\iis\installer\isapi-redirector-win32-msi.ism tools\jkrelease.sh Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1648306 - in /tomcat/tc8.0.x/trunk: ./ build.properties.default webapps/docs/changelog.xml

2014-12-29 Thread Konstantin Kolinko
n it may be possible to use java.7.home property to run it with Java 7. Currently I see no need to backport this change to Tomcat 7. > \tc7.0.x\trunk\build.xml:509: java.lang.UnsupportedClassVersionError: > com/puppycrawl/tools/checkstyle/CheckStyleTask : Unsupported major.minor > version 51

Re: [mod_jk] Modify how common/config.h gets built

2015-01-06 Thread Konstantin Kolinko
just commit changes to common/config.h > because it's auto-generated. > > Can anyone shed some light on where I can modify what gets dumped into > common/config.h? I see some stuff in config.status, but that in turn > gets generated by configure. > > Any suggestions? Best

Re: Release of Apache Taglibs

2015-01-08 Thread Konstantin Kolinko
n issue in Bugzilla)? What do we do with Maven artifacts? Abandon one of them? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [CANCELLED][VOTE] Release Apache Tomcat 8.0.16

2015-01-08 Thread Konstantin Kolinko
b3nsqtxkaxn Now the source cause of the issue seems to be found. (I have not evaluated the BZ issue yet). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-12 Thread Konstantin Kolinko
72 on Windows 7. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1653367 - /tomcat/trunk/webapps/docs/changelog.xml

2015-01-21 Thread Konstantin Kolinko
cher) > +57431: Enable usage of custom class for context creation > +when using embedded tomcat. (fschumacher) > > > Hi! The usual practice is that until the first release from trunk its changelog file lists only changes that have not been backported to st

Re: Coverity Scan

2015-01-22 Thread Konstantin Kolinko
that URL is actually used for analysis, one would have to change it. (+1 for the change if it is needed). 2) Looking at "Upload a Project Build" form, it expects a tarball created by "Coverity Scan Self-Build tool". I have never tried to create one.

Re: svn commit: r1654064 - in /tomcat/tc7.0.x/trunk: java/org/apache/naming/resources/DirContextURLConnection.java webapps/docs/changelog.xml

2015-01-23 Thread Konstantin Kolinko
> I didn't see anything also, until I enabled checkstyle locally by adding > "execute.validate=true" to my build.properties. > I can make the failure go away by adding SafeCharSet to the allowed classes: > > diff --git a/res/checkstyle/org-import-control.xml > b/res/check

Re: svn commit: r1654487 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2015-01-24 Thread Konstantin Kolinko
2015-01-24 13:00 GMT+03:00 : > Author: markt > Date: Sat Jan 24 10:00:32 2015 > New Revision: 1654487 > > URL: http://svn.apache.org/r1654487 > Log: > Prep for next tag > > Modified: > tomcat/tc8.0.x/trunk/build.properties.default > tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default >

Re: [VOTE] Release Apache Tomcat 8.0.18

2015-01-26 Thread Konstantin Kolinko
r for bug 57476 OK. Smoke testing OK. Using JDK 7u72 32-bit on Windows 7. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1654852 - in /tomcat/trunk/java/org/apache: catalina/servlets/CGIServlet.java catalina/servlets/DefaultServlet.java tomcat/util/net/jsse/JSSESocketFactory.java tomcat/util/net/jsse/re

2015-01-26 Thread Konstantin Kolinko
2015-01-26 21:05 GMT+03:00 : > Author: fschumacher > Date: Mon Jan 26 18:05:06 2015 > New Revision: 1654852 > > URL: http://svn.apache.org/r1654852 > Log: > Log failure to close a resource instead of ignoring it silently. > > Modified: > tomcat/trunk/java/org/apache/catalina/servlets/CGIServle

Re: regression in 8.0.18?

2015-01-27 Thread Konstantin Kolinko
nerating the code, but what about implicit imports (java.lang.*, javax.servlet.* etc.) - are they affected or not? 2015-01-26 22:46 GMT+03:00 Mark Thomas : > > That code hasn't changed 8.0.17 -> 8.0.18 (I don't think) but it did > change in a previous version. > Violletta

Re: regression in 8.0.18?

2015-01-27 Thread Konstantin Kolinko
2015-01-27 15:18 GMT+03:00 Konstantin Kolinko : > 2015-01-26 21:17 GMT+03:00 Romain Manni-Bucau : >> Hi guys, >> >> since I upgraded to 8.0.18 I get: >> >> SEVERE: Servlet.service() for servlet [jsp] in context with path >> [/test] threw exc

Re: [VOTE] Release Apache Taglibs 1.2.2

2015-01-27 Thread Konstantin Kolinko
p file on dist.a.o with the one from Maven. Any objections or concerns here? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1654487 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2015-01-28 Thread Konstantin Kolinko
uot; afterwards. It is possible to use both dates, but I think it looks ugly, maybe except the "not released" use case, rtext="tagged 2015-01-28, not released", rtext="tagged 2015-01-28, released 2015-02-05", rtext="tagged 2015-01-28, beta 2015-02-05&

Re: svn commit: r1655357 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2015-01-28 Thread Konstantin Kolinko
2015-01-28 18:03 GMT+03:00 : > Author: violetagg > Date: Wed Jan 28 15:03:33 2015 > New Revision: 1655357 > > URL: http://svn.apache.org/r1655357 > Log: > Update changelog > > Modified: > tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml > > Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.

Re: svn commit: r1655357 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2015-01-28 Thread Konstantin Kolinko
2015-01-28 22:43 GMT+03:00 Violeta Georgieva : > Hi, > > 2015-01-28 20:52 GMT+02:00 Konstantin Kolinko : >> >> 2015-01-28 18:03 GMT+03:00 : >> > Author: violetagg >> > Date: Wed Jan 28 15:03:33 2015 >> > New Revision: 1655357 >> > >&

Re: svn commit: r1655982 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/naming/factory/BeanFactory.java webapps/docs/changelog.xml webapps/docs/jndi-resources-howto.xml

2015-01-30 Thread Konstantin Kolinko
not available"); ]]] 1) We can look for a java.beans.PropertyEditor (PropertyEditorManager.findEditor()) 2) We can look for setter(String) method, like your new code does. Your code allows to use any arbitrary method as a setter. I think that if a custom name is needed, one can just rename the XM

Re: [VOTE] Release Apache Taglibs 1.2.2

2015-02-02 Thread Konstantin Kolinko
2015-01-27 19:08 GMT+03:00 Jeremy Boynes : > >> On Jan 27, 2015, at 7:59 AM, Konstantin Kolinko >> wrote: >> >> 2015-01-26 20:17 GMT+03:00 Jeremy Boynes : >>> The proposed Apache Taglibs 1.2.2 release is now available for voting. >>> >>> It c

Re: [VOTE] Release Apache Tomcat 7.0.59

2015-02-02 Thread Konstantin Kolinko
rver=[Apache-Coyote/1.1]} There is no Connection: close header. This failure is odd and needs a review, but as the test passes with Java 7 I do not consider this as a stopper. Best regards, Konstantin Kolinko - To unsubscribe,

Re: [VOTE] Release Apache Tomcat 7.0.59

2015-02-02 Thread Konstantin Kolinko
2015-02-02 15:05 GMT+03:00 Konstantin Kolinko : > 2015-01-28 22:35 GMT+03:00 Violeta Georgieva : >> The proposed Apache Tomcat 7.0.59 release is now available for voting. >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.59/ &

Re: [wiki] Can't log into the wiki

2015-02-03 Thread Konstantin Kolinko
.a.o/tomcat and wiki.a.o/foobar are different wikis with different sets of users. You may try to re-register. IIRC if you have already registered you may ask the wiki to mail you the password. Best regards, Konstantin Kolinko ---

Re: svn commit: r1657125 - /tomcat/trunk/test/org/apache/coyote/http11/TestInternalOutputBuffer.java

2015-02-04 Thread Konstantin Kolinko
d after a timeout, before they start running this test. (No recent test results for this test exist at buildbot) Thus I do not see what the error is. Older runs are OK, http://ci.apache.org/projects/tomcat/tomcat9/logs/1656590/TEST-org.apache.coyote.http11.TestInternalOutputBuffer.NIO

Re: svn commit: r1657565 - /tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

2015-02-05 Thread Konstantin Kolinko
rformance tests and relax timing tests. +1. There are slow machines that just cannot run those tests sensibly. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1657580 - in /tomcat/trunk: build.xml test/org/apache/catalina/valves/TesterAccessLogValve.java

2015-02-05 Thread Konstantin Kolinko
t; > private final List entries = new ArrayList<>(); 2. Mention the new "test.relaxTiming" build property in BUILDING.txt -> "(7.3) Other configuration options" 3. System.out.println() added in http://svn.apache.or

Re: [VOTE] Release Apache Taglibs 1.2.2

2015-02-05 Thread Konstantin Kolinko
2015-02-02 14:05 GMT+03:00 Konstantin Kolinko : > 2015-01-27 19:08 GMT+03:00 Jeremy Boynes : >> >>> On Jan 27, 2015, at 7:59 AM, Konstantin Kolinko >>> wrote: > > Here comes my vote: > >> The proposed 1.2.2 release is: >> [ ] Broken - do not relea

Re: svn commit: r1657653 - in /tomcat/taglibs/standard/trunk: impl/src/test/java/org/apache/taglibs/standard/tag/common/xml/ForEachTagTest.java pom.xml

2015-02-05 Thread Konstantin Kolinko
> 20s to run", so I was prepared to wait, but an hour is more than I expected from that comment. Maybe reducing the size of a sample document ("newBenchmarkDocument(20)") will help. This is not my priority for now. I just run it as I wanted to verify whether my code change mattered. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1657910 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractInputBuffer.java webapps/docs/changelog.xml

2015-02-06 Thread Konstantin Kolinko
other errors 2) http://ci.apache.org/projects/tomcat/tomcat8/logs/1657908/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.BIO.txt - many failures (NIO, NIO2 -OK) 3) TestAsyncContextImpl, TestMapperPerformance - timing failure, as usual. Tomcat 7 buildbot Broken. It cannot delete old

Re: [RESULT] [VOTE] Release Apache Taglibs 1.2.2

2015-02-08 Thread Konstantin Kolinko
2015-02-08 22:29 GMT+03:00 Jeremy Boynes : > On Feb 5, 2015, at 10:01 AM, Konstantin Kolinko > wrote: >> >> 2015-02-02 14:05 GMT+03:00 Konstantin Kolinko : >>> 2015-01-27 19:08 GMT+03:00 Jeremy Boynes : >>>> >>>>> On Jan 27, 2015, at 7:5

Re: svn commit: r1658557 - /tomcat/native/trunk/native/src/sslinfo.c

2015-02-09 Thread Konstantin Kolinko
2015-02-09 22:52 GMT+03:00 : > Author: rjung > Date: Mon Feb 9 19:52:36 2015 > New Revision: 1658557 > > URL: http://svn.apache.org/r1658557 > Log: > Replace access to OpenSSL session internals > by accessor function. Internals are no longer > available for OpenSSL master. > > Not compiled or tes

Re: [GUMP@vmgump]: Project tomcat-native-make (in module tomcat-native) failed

2015-02-09 Thread Konstantin Kolinko
tion 'ssl_socket_recv': src/sslnetwork.c:413:36: error: dereferencing pointer to incomplete type if (s == 0 && (con->ssl->shutdown & SSL_RECEIVED_SHUTDOWN)) { ^ src/sslnetwork.c: In function 'Java_org_apache_tomcat_jni_

Re: svn commit: r1658754 - in /tomcat/taglibs/standard/trunk: ./ impl/src/main/java/org/apache/taglibs/standard/util/ impl/src/test/java/org/apache/taglibs/standard/util/

2015-02-10 Thread Konstantin Kolinko
i < url.length(); i++) { > +char ch = url.charAt(i); > +if (ch == ':') { > +String result = scheme.toString(); > +if (!"jar".equals(result)) { > +return result; > +

Re: svn commit: r1658799 - /tomcat/trunk/bin/catalina-tasks.xml

2015-02-10 Thread Konstantin Kolinko
2015-02-10 23:32 GMT+03:00 : > Author: markt > Date: Tue Feb 10 20:32:45 2015 > New Revision: 1658799 > > URL: http://svn.apache.org/r1658799 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57558 > Add missing JARs > JARs in alpha order > > Modified: > tomcat/trunk/bin/catalina

Re: svn commit: r1658804 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContext.java test/org/apache/catalina/core/TestStandardContext.java

2015-02-10 Thread Konstantin Kolinko
ion iae) { > // ServletContext.getRealPath() does not allow this to be > thrown > } Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: async and thread constraint

2015-02-10 Thread Konstantin Kolinko
for that too. Commits to follow shortly. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1658351 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/el/parser/ java/org/apache/jasper/compiler/ test/org/apache/el/ test/webapp-3.0/bug45nnn/ webapps/docs/

2015-02-10 Thread Konstantin Kolinko
TestParser FAILED Testsuite: org.apache.jasper.compiler.TestParser Tests run: 16, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 15.18 sec Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-native-make (in module tomcat-native) failed

2015-02-10 Thread Konstantin Kolinko
2015-02-10 3:45 GMT+03:00 Konstantin Kolinko : > 2015-02-09 22:52 GMT+03:00 Rainer Jung : >> Am 09.02.2015 um 20:31 schrieb Rainer Jung: >> >> >>>>> src/sslinfo.c: In function >>>>> 'Java_org_apache_tomcat_jni_SSLSocket_getInfoB'

Re: [VOTE] Release Apache Taglibs 1.2.3

2015-02-11 Thread Konstantin Kolinko
Stable Tested examples app (Tomcat 6 + Java 5) Tested my apps running on Java 8 and Java 6. I use c:,fmt:,fn: parts of the library. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apac

Re: svn commit: r1659043 - in /tomcat/trunk: java/org/apache/catalina/filters/CorsFilter.java test/org/apache/catalina/filters/TestCorsFilter.java

2015-02-11 Thread Konstantin Kolinko
2015-02-11 22:18 GMT+03:00 : > Author: markt > Date: Wed Feb 11 19:18:46 2015 > New Revision: 1659043 > > URL: http://svn.apache.org/r1659043 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57534 > CORS Filter should only look at media type component of content type > > Modified: >

Re: svn commit: r1659296 - /tomcat/tc6.0.x/trunk/STATUS.txt

2015-02-12 Thread Konstantin Kolinko
kt/patches/2015-02-06-maxSwallowSize-tc6-v2.patch There is no such file at p.a.o. BTW, today is 2015-02-12. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tagging 8.0.x

2015-02-13 Thread Konstantin Kolinko
ch update for 8.0 needs a formal release (of the library) first. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.19

2015-02-15 Thread Konstantin Kolinko
che.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_19/ > > The proposed 8.0.19 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 8.0.19 > The Maven staging repository (orgapachetomcat-1035) does not exist. The only available orgapachetomcat-*

Re: [GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-02-15 Thread Konstantin Kolinko
M org.apache.coyote.AbstractProtocol stop INFO: Stopping ProtocolHandler ["http-apr-127.0.0.1-auto-3-49827"] фев 15, 2015 6:48:45 PM org.apache.coyote.AbstractProtocol destroy INFO: Destroying ProtocolHandler ["http-apr-1

Re: [VOTE] Release Apache Tomcat 8.0.20

2015-02-16 Thread Konstantin Kolinko
that version as well, so it is not a regression. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1660266 - in /tomcat/tc8.0.x/trunk: java/org/apache/catalina/tribes/tipis/ReplicatedMap.java webapps/docs/changelog.xml

2015-02-17 Thread Konstantin Kolinko
2015-02-17 5:20 GMT+03:00 : > Author: kfujino > Date: Tue Feb 17 02:20:11 2015 > New Revision: 1660266 > > URL: http://svn.apache.org/r1660266 > Log: > Make sure that add to the backup node of the map entry when map member has > been added to ReplicatedMap. It is hard to read the above phrase. I

Re: Question about taglibs. Issue 37466

2015-02-17 Thread Konstantin Kolinko
ars ago. You need to provide an example that reproduces your issue. Wrapping a request with overwritten getMethod() should not break parsing of POST parameters. The parameters parsing is done by tomcat internals and operates on the orig

Re: [VOTE] Release Apache Tomcat 8.0.20

2015-02-18 Thread Konstantin Kolinko
2015-02-17 16:49 GMT+03:00 Mark Thomas : > On 16/02/2015 14:09, Konstantin Kolinko wrote: >> 2015-02-15 21:46 GMT+03:00 Mark Thomas : >>> The proposed Apache Tomcat 8.0.20 release is now available for voting. >>> >>> >>> The proposed 8.0.2

Re: [VOTE] Release Apache Tomcat 8.0.20

2015-02-18 Thread Konstantin Kolinko
2015-02-18 15:56 GMT+03:00 Konstantin Kolinko : > 2015-02-17 16:49 GMT+03:00 Mark Thomas : >> On 16/02/2015 14:09, Konstantin Kolinko wrote: >>> 2015-02-15 21:46 GMT+03:00 Mark Thomas : >>>> The proposed Apache Tomcat 8.0.20 release is now available for voting. >

Re: [VOTE] Release Apache Tomcat 8.0.20

2015-02-18 Thread Konstantin Kolinko
2015-02-17 16:49 GMT+03:00 Mark Thomas : > On 16/02/2015 14:09, Konstantin Kolinko wrote: >> 2015-02-15 21:46 GMT+03:00 Mark Thomas : >>> The proposed Apache Tomcat 8.0.20 release is now available for voting. >>> >>> >>> The proposed 8.0.2

Re: [Tomcat 8] [Listener Web] [RequestDispatcher]

2015-02-20 Thread Konstantin Kolinko
current NPE. If you want the NPE to be changed, it would better to prepare some source code that demonstrates the issue and open an issue in Bugzilla, but at this point I think it is a cosmetic issue and fixing it wouldn't solve your problem. [1] http://docs.oracle.com/javaee/7/api/javax/ser

Re: [VOTE][RESULT] Release Apache Taglibs 1.2.3

2015-02-20 Thread Konstantin Kolinko
gt; I updated dist.a.o. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Two serious issues have been introduced in Tomcat 7 and Tomcat 8...

2015-02-23 Thread Konstantin Kolinko
of prefix matching in [1]. It says "uripath - a String specifying the context path of another web application in the container." b) It says "The given path must be begin with /", but context path of the default context is an empty string (per ServletContext.getContextPath()). Th

Re: svn commit: r1661670 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java

2015-02-24 Thread Konstantin Kolinko
2015-02-23 16:45 GMT+03:00 : > Author: markt > Date: Mon Feb 23 13:45:46 2015 > New Revision: 1661670 > > URL: http://svn.apache.org/r1661670 > Log: (empty) No log message here. This is a revert of r1661642, discussed in "Re: r1661642" thread. > Modified: > tomcat/trunk/java/org/apache/coyo

Re: [VOTE][RESULT] Release Apache Tomcat 8.0.20

2015-02-24 Thread Konstantin Kolinko
es now and announce in ~24 hours once the mirrors catch up. > 8.0.20 is at the mirrors, but there was no announcement and no update to tomcat.a.o site. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomca

Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Konstantin Kolinko
nothing showing elsewhere. A very small > number of other TEST-*.txt files exist in the logs/ directory. > > Any suggestions? Is it a virtual machine? Are other tests mentioned in the console output of Ant? Can it be that "hard drive" is full, so no more logs could be writt

Re: [VOTE] Release Apache Tomcat 8.5.86

2023-02-22 Thread Konstantin Kolinko
proposed 8.5.86 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.5.86 (stable) Smoke tests OK with Java 7u80, Tomcat Native enabled, on Windows 10. Best regards, Konstantin Kolinko

Re: [VOTE] Release Apache Tomcat 9.0.72

2023-02-23 Thread Konstantin Kolinko
68470320295 > > The proposed 9.0.72 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 9.0.72 Smoke tests OK with Java 8u362, Tomcat Native enabled, Unit tests OK with Java 11.0.18, all connectors, on Windows 10. Best regards, Konstantin Kolinko ---

Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-23 Thread Konstantin Kolinko
887970d7203 > > The proposed 10.1.6 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 10.1.6 Smoke tests OK with Java 11.0.18. Unit tests OK, all connectors (NIO, NIO2), with or without Tomcat Native, with Java 11.0.18. on Windows 10. Best regards, Konstanti

Re: [ANN] Apache Tomcat 9.0.72 available

2023-02-27 Thread Konstantin Kolinko
tml > > Since it seems there are two identified regressions in 9.0.72, I plan > to swap 9.0.71 back in on the website (and dlcdn) while things get > fixed and we produce 9.0.73. > > Comments ? If you are about https://bz.apache.org/bugzilla/show_bug.cgi?id=66488 9.0.71 is affecte

Re: [VOTE] Release Apache Tomcat 9.0.73

2023-02-28 Thread Konstantin Kolinko
The proposed 9.0.73 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 9.0.73 Smoke tests OK with Java 8u362. Unit tests OK with Java 11.0.18, all connectors (APR, NIO, NIO2) on Windows 10. Best regards, Konstantin Kolinko ---

Re: [VOTE] Release Apache Tomcat 8.5.87

2023-02-28 Thread Konstantin Kolinko
2936eace5c46e8860b644b3c > > The proposed 8.5.87 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 8.5.86 (stable) > [x] Stable - go ahead and release as 8.5.87 (stable) Smoke tests OK with Java 7u80 (32-bit) Unit te

Re: [VOTE] Release Apache Tomcat 10.1.7

2023-03-01 Thread Konstantin Kolinko
as 10.1.7 Smoke tests OK with Java 11.0.18. Unit tests OK with Java 11.0.18, all connectors (NIO, NIO2) on Windows 10. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [tomcat] branch main updated: Align with spec

2023-03-06 Thread Konstantin Kolinko
mes with a license. I have not checked recently (with the spec is managed by Eclipse Foundation), but in earlier times (for specs copyrighted by Oracle) it was clear that you were not allowed to copy their text as you wish. You are not the first one to make such changes. There were similar discuss

Re: [tomcat] branch main updated: Align with spec

2023-03-06 Thread Konstantin Kolinko
вт, 7 мар. 2023 г. в 10:14, Han Li : > > > > > On Mar 7, 2023, at 14:39, Konstantin Kolinko wrote: > > > > вт, 7 мар. 2023 г. в 09:17, mailto:li...@apache.org>>: > >> > >> This is an automated email from the ASF dual-hosted git repository. >

Re: tomcat-native v2.0+ breaks unix domain socket support on java16-

2023-03-07 Thread Konstantin Kolinko
IO2. The APR connector has been removed. Is your Tomcat failing to start because it is explicitly configured to use the APR connector (Http11AprProtocol, AjpAprProtocol)? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: d

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
0 for 11.0.x. > >> > >> Thoughts on if/how to back-port this to 10.1.x and friends? > >> > >> Straight to 1000 for all older versions? > >> Straight to 1000 for 10.1.x then wait a few releases for each further > >> backport? > >> Or more

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : > > ср, 15 мар. 2023 г. в 12:07, Mark Thomas : > > > > On 14/03/2023 21:13, Christopher Schultz wrote: > > > Mark, > > > > > > On 3/14/23 13:57, Mark Thomas wrote: > > >> On

Re: Reduce default for maxParameterCount

2023-03-15 Thread Konstantin Kolinko
ср, 15 мар. 2023 г. в 13:29, Konstantin Kolinko : > > ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : > > > > ср, 15 мар. 2023 г. в 12:07, Mark Thomas : > > > > > > On 14/03/2023 21:13, Christopher Schultz wrote: > > > > Mark, > > > >

<    11   12   13   14   15   16   17   18   19   20   >