Re: svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread Konstantin Kolinko
lt value in o.a.juli.FileHandler to disable buffering. I am ok with any of a) and b). Any thoughts? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r898909 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread Konstantin Kolinko
connect upon transmission failure > +  http://svn.apache.org/viewvc?rev=898906&view=rev > +  +1: fhanik > +  -1: > + Just wondering: 1. If any destination fails, you will disconnect the whole sender? 2. Shouldn't disconnect() call

Re: svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread Konstantin Kolinko
2010/1/13 Mark Thomas : > On 13/01/2010 16:24, Konstantin Kolinko wrote: >> There is Mark's patch for that (r898468), but I have doubts >> regarding Runtime.getRuntime().addShutdownHook(new Cleaner()); >> used there. > > Why? It is pretty much identical to the

Re: Removing @VERSION@ filtering from top level text files

2010-01-14 Thread Konstantin Kolinko
intenance for these files. Content of the files is mostly version-specific. E.g. TC 6 requires JRE 5, but TC 7 JRE 6, TC 6 implements Servlets 2.5, TC 7 Servlets 3.0, etc. > * Download a source package from: > http://tomcat.apache.org/downl

Re: svn commit: r899380 - /tomcat/trunk/dist.xml

2010-01-16 Thread Konstantin Kolinko
2010/1/14 : > Author: markt > Date: Thu Jan 14 19:48:41 2010 > New Revision: 899380 > > URL: http://svn.apache.org/viewvc?rev=899380&view=rev > Log: > Skipping installer shouldn't break package-winzip target > > Modified: >    tomcat/trunk/dist.xml > I think that all content of the new "win-prepa

Re: svn commit: r900130 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-17 Thread Konstantin Kolinko
2010/1/17 : > Author: markt > Date: Sun Jan 17 12:43:34 2010 > New Revision: 900130 > > URL: http://svn.apache.org/viewvc?rev=900130&view=rev > Log: > Vote > > Modified: >    tomcat/tc6.0.x/trunk/STATUS.txt > > * Allow compliance with SRV.15.2.22.1 to be controlled separately > from STRICT_SERV

native-doc part of Tomcat site: outdated?

2010-01-18 Thread Konstantin Kolinko
;t maintain changelog-1.1.x.html [2] in the trunk, because it duplicates effort. I'll update the link on the main site. Be sure to use the right link in the announcement. Best regards, Konstantin Kolinko - To uns

Re: native-doc part of Tomcat site: outdated?

2010-01-19 Thread Konstantin Kolinko
2010/1/19 Rainer Jung : > On 19.01.2010 01:59, Konstantin Kolinko wrote: >> >> Is http://tomcat.apache.org/native-doc/  generated from /native/trunk, >> or from /native/branches/1.1.x/  ? >> >> Apparently the site for 1.1.18 was generated from trunk, but the one &g

Re: [VOTE] Release build 6.0.24

2010-01-20 Thread Konstantin Kolinko
ni.Socket.accept I think it is a minor issue, because it only happens on shutdown. I'll file a Bugzilla issue with more details. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release build 6.0.24

2010-01-20 Thread Konstantin Kolinko
2010/1/20 Konstantin Kolinko : > 2010/1/19 jean-frederic clere : >> The candidates binaries are available here: >> http://people.apache.org/~jfclere/tomcat-6/v6.0.24/ >> >> > > Tested > apache-tomcat-6.0.24.exe > apache-tomcat-6.0.24-windows-x86.zip &g

Re: [VOTE][RESULT] Release build 6.0.24

2010-01-21 Thread Konstantin Kolinko
ur work on this. > > Mark > > PS  Don't forget the (relatively) new announce@ list. > Congratulations! Note, that we now have 4 zip binaries: a generic one, and three bundled with Windows binaries for different CPU architectures. Best regards, Konstantin Kolinko --

Re: [ANN] Apache Tomcat Native 1.1.19 released

2010-01-21 Thread Konstantin Kolinko
rchives.apache.org/mod_mbox/tomcat-announce/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE][RESULT] Release build 6.0.24

2010-01-21 Thread Konstantin Kolinko
2010/1/21 Konstantin Kolinko : > 2010/1/21 Mark Thomas : >> On 21/01/2010 04:33, jean-frederic clere wrote: >>> Hi, >>> >>> We have 6 binding Stable votes. >>> I'll proceed with copying the files to >>> dist, updating the web pages and m

Viewing changelog.xml XML files as HTML

2010-01-21 Thread Konstantin Kolinko
this to 6.0 and 5.5 docs. Are there any complaints? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat 5.5.28, jsp-api.jar EL not working

2010-01-22 Thread Konstantin Kolinko
i tried putting jsp-api.jar into the /usr/java/jdk1.5.0_16/jre/lib/ext. Please, do not forget to remove it from there. > But in vain. > false is there into web.xml. What is the problem, can > someone please explain me about this? Do i have to download tomcat again? Do > you t

Re: svn commit: r904152 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-28 Thread Konstantin Kolinko
t-juli.jar in extras, but that is "other" JULI, used to run Tomcat with Log4J. (62759 bytes jar vs. 25804 bytes jar in 6.0.24). Is this intended? Best regards, Konstantin Kolinko - To unsubscribe, e-ma

Re: EL issues and 6.0.x release

2010-01-29 Thread Konstantin Kolinko
deferredSyntaxAllowedAsLiteral options all along with unescaped expressions until evaluation time? Lastly, when Mark was testing TC7 with JSP 2.2 TCK, he caught several minor EL evaluation issues. Those are fixed in TC7, and I think some of them have to be backported to TC6. Though, I have not reviewed them in detail yet. For reference, here are those revision numbers: 899635 <- I've already proposed this one for backport 899653 899769 899770 899783 899788 899792 899916 899918 899919 899935 899949 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

AprLifecycleListener reflective access to o.a.t.jni.Library (was Re: svn commit: r904865)

2010-01-30 Thread Konstantin Kolinko
I do not mind, as far as it works. I am just curious. I thought that was to be able to separate o.a.t.jni.* into separate jar, and to be able to run AprLifecycleListener even if that jar is not available. Best regards, Konstantin Kolinko ---

Re: svn commit: r905147 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-01-31 Thread Konstantin Kolinko
I saw that you reverted 804734 in TC6 (rev. 905015), so probably only the second one is needed here, (and to add 905015 to TC6 proposal?) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: EL issues and 6.0.x release

2010-02-01 Thread Konstantin Kolinko
2010/1/31 Mark Thomas : > On 30/01/2010 17:41, Mark Thomas wrote: >> On 30/01/2010 07:33, Konstantin Kolinko wrote: >>> Regarding the implementation, AttributeParser.java class. I think >>> that, based on the above, we can fix it to solve bug 48627. Other >>>

Re: svn commit: r905147 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-02-02 Thread Konstantin Kolinko
2010/2/1 Mark Thomas : > On 01/02/2010 02:04, Konstantin Kolinko wrote: >> 2010/2/1  : >>> Author: markt >>> Date: Mon Feb  1 00:08:07 2010 >>> New Revision: 905147 >>> >>> URL: http://svn.apache.org/viewvc?rev=905147&view=rev >>>

Re: svn commit: r905710 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-02-02 Thread Konstantin Kolinko
Also, it would be better to do the same for trunk and 6.0 as well. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r905717 - /tomcat/trunk/java/org/apache/catalina/core/StandardService.java

2010-02-02 Thread Konstantin Kolinko
+            return; >         } > It should be if (started) { if(log.isInfoEnabled()) { log.info(sm.getString("standardService.start.started")); } return; } Best regards, Konstantin Kolinko

Re: svn commit: r905710 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-02-02 Thread Konstantin Kolinko
2010/2/2 Mark Thomas : > On 02/02/2010 17:31, Konstantin Kolinko wrote: >> 2010/2/2  : >>> Author: markt >>> Date: Tue Feb  2 17:10:05 2010 >>> New Revision: 905710 >>> >>> URL: http://svn.apache.org/viewvc?rev=905710&view=rev >>&

Re: svn commit: r905710 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-02-02 Thread Konstantin Kolinko
2010/2/2 Konstantin Kolinko : > 2010/2/2 Mark Thomas : >> On 02/02/2010 17:31, Konstantin Kolinko wrote: >>> 2010/2/2  : >>>> Author: markt >>>> Date: Tue Feb  2 17:10:05 2010 >>>> New Revision: 905710 >>>> >>>>

Re: 6.0.24 service.bat is missing

2010-02-03 Thread Konstantin Kolinko
s.sourceforge.net/ It can be unpacked by certain archivers (e.g. by 7-zip that I am using). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Fwd: Switching incubator.apache.org to svnpubsub?

2010-02-04 Thread Konstantin Kolinko
e expandable repository. > I do not see /repos/dist/ svn.apache.org, dist.apache.org give 404 for that address. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2010-02-06 Thread Konstantin Kolinko
ied. The build procedure for Tomcat 6 remains the same. Thank you for your work on this. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2010-02-06 Thread Konstantin Kolinko
le and I'll get on > with it? > > Probably the contents of output/release ? or just the contents of > output/release/v7.0.0-dev/src/ ? > I think it is output/release Both the binaries and the sources are needed. > What else? > &

Re: svn commit: r907538 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2010-02-08 Thread Konstantin Kolinko
2010/2/8 : > Author: markt > Date: Mon Feb  8 02:00:58 2010 > New Revision: 907538 > > URL: http://svn.apache.org/viewvc?rev=907538&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48668 > Don't look for EL matches (which swallow the EL match string) if EL is not > enabled

Re: Gump failures

2010-02-08 Thread Konstantin Kolinko
ava/tomcat-native-1.1.19 creation was not successful for an unknown reason Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

JDT Compiler download (was: r908009)

2010-02-09 Thread Konstantin Kolinko
pse/downloads/drops/R-3.5.1-200909170800/ecj-3.5.1.jar Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDT Compiler download (was: r908009)

2010-02-09 Thread Konstantin Kolinko
2010/2/9 Mark Thomas : > On 09/02/2010 13:05, Konstantin Kolinko wrote: >> Looking at >> http://archive.eclipse.org/eclipse/downloads/drops/R-3.4.2-200902111700/ >> there exist a download "JDT Core Batch Compiler" >> >> The ecj-3.4.2.jar downloaded fro

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2010-02-10 Thread Konstantin Kolinko
nk", where this change is not implemented yet. The "tomcat-6-trunk" buildbot apparently has the same value of "base.path" as the "tomcat-trunk" one. That is, it reuses libraries downloaded by "tomcat-trunk" on its previous run. Thus it was more rare to see errors coming from it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r908917 - in /tomcat/site/trunk: docs/security-6.html xdocs/security-6.xml

2010-02-11 Thread Konstantin Kolinko
is change now there is no information about what TC release includes the workaround. It requires some experience to derive that from revision numbers. Though everyone can look in the changelog. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r909018 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-11 Thread Konstantin Kolinko
actly where the JspLoader was created. Some search shows that JspCompilationContext.compile() sets JspCompilationContext.jspLoader to null. Maybe that will result in a leak when recompiling updated JSP. Best regards, Konstantin Kolinko -

Re: Minor Error in Documentation

2010-02-12 Thread Konstantin Kolinko
just do the assignment. Quotes are needed. 2) %my.jmx.port% will be ${my.jmx.port} Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r907390 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2010-02-12 Thread Konstantin Kolinko
the tomcat-5.5-doc symlink. It is owned by your private group (markt) right now. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r909673 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

2010-02-12 Thread Konstantin Kolinko
2010/2/13 : > Author: fhanik > Date: Sat Feb 13 00:51:47 2010 > New Revision: 909673 > > URL: http://svn.apache.org/viewvc?rev=909673&view=rev > Log: > fix compilation error > > Modified: >    tomcat/trunk/java/org/apache/catalina/connector/Connector.java > What is this? The new code is equivale

Re: [PROPOSAL] Make Lifecycle mandatory rather than optional

2010-02-15 Thread Konstantin Kolinko
the case in all places - see BZ 48625 and its fix (r752323) Though that might have been an occasional error - I have not searched all places. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa

Redeclaration of variables by tag handler (BZ 48616, 42390)

2010-02-15 Thread Konstantin Kolinko
6.0 and 5.5 variations of the patch will be prepared soon. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r909979 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-15 Thread Konstantin Kolinko
that JspFragment to appear. Once we try to nest a classic tag in it, it fails. In r910395.I added a test that demonstrates that. The alternative patch, https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c20 does work here. Best regards, Konstantin Kolinko ---

Re: svn commit: r910644 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-16 Thread Konstantin Kolinko
nts > +   > http://people.apache.org/~markt/patches/2010-02-16-manifest-improvements.patch > +  +1: markt > +  -1: Looks good, though I have to test it yet. I see that it includes rev.905360 that was already proposed to TC.6. You may revoke that old proposal as th

Re: svn commit: r910644 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-16 Thread Konstantin Kolinko
2010/2/16 Konstantin Kolinko : > 2010/2/16  : >> Author: markt >> Date: Tue Feb 16 18:39:08 2010 >> New Revision: 910644 >> >> URL: http://svn.apache.org/viewvc?rev=910644&view=rev >> Log: >> Proposal >> >> Modified: >>

Re: svn commit: r910644 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-16 Thread Konstantin Kolinko
2010/2/17 Mark Thomas : > On 16/02/2010 21:24, Konstantin Kolinko wrote: >> 2010/2/16 Konstantin Kolinko : >>> 2010/2/16  : >>>> Author: markt >>>> Date: Tue Feb 16 18:39:08 2010 >>>> New Revision: 910644 >>>> >>>>

Re: [VOTE] Release Apache Tomcat Native 1.1.20

2010-02-16 Thread Konstantin Kolinko
ng were saying that the checksums are wrong without that change. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JSTL - TOMCat Version 6

2010-02-21 Thread Konstantin Kolinko
Check what version of Servlet specification your web.xml adheres to. See examples webapp that comes with Tomcat for an example. http://faq.javaranch.com/java/ElOrJstlNotWorkingAsExpected Best regards, Konstantin Kolinko - To un

Re: [VOTE] Release build 6.0.25

2010-02-25 Thread Konstantin Kolinko
also had "6.0.0.0" in their server.number. In 6.0.20 it was "6.0.20.0" as it should be. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r916587 - in /tomcat/site/trunk: docs/download-connectors.html docs/index.html xdocs/download-connectors.xml xdocs/index.xml

2010-02-25 Thread Konstantin Kolinko
2010/2/26 : > Author: mturk > Date: Fri Feb 26 06:47:19 2010 > New Revision: 916587 > > URL: http://svn.apache.org/viewvc?rev=916587&view=rev > Log: > Add Tomcat Connectors 1.2.29 release > > + > + > +The Apache Tomcat Project is proud to announce the release of version 1.2.29 > of > +Apache Tom

[VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Konstantin Kolinko
2010/2/27 : > Author: mturk > Date: Sat Feb 27 10:16:14 2010 > New Revision: 916938 > > URL: http://svn.apache.org/viewvc?rev=916938&view=rev > Log: > Revert withdrawal notice. Seems this requires a vote > If withdrawing needs a vote, here is my +1. Best

Re: [VOTE] Release build 6.0.25

2010-02-27 Thread Konstantin Kolinko
quot;#{") are called regardless of whether pageInfo.isELIgnored() or pageInfo.isDeferredSyntaxAllowedAsLiteral() are true. I consider it a rare case though. I planned to look at BZ 48668 first. In any case, that I won't be able to do that earlier than in 8 hours

Re: [VOTE] Withdraw Tomcat Connectors 1.2.29 (was: svn commit: r916938)

2010-02-27 Thread Konstantin Kolinko
ent can be sent faster than any testing for RC can be done. I do not expect 1.2.30 release earlier than in next 40 hours (let me be wrong). It can save some people a day. Best regards, Konstantin Kolinko - To unsubscribe,

Re: [VOTE] Release build 6.0.25

2010-03-01 Thread Konstantin Kolinko
2010/2/27 Konstantin Kolinko : > 2010/2/24 jean-frederic clere : >> The candidates binaries are available here: >> http://people.apache.org/~jfclere/tomcat-6/v6.0.25/ >> >> According to the release process, the 6.0.25 tag is: >> [x] Broken > > https://iss

Re: svn commit: r917928 - in /tomcat/trunk: java/org/apache/tomcat/jni/SSL.java java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/res/LocalStrings.properties webapps/d

2010-03-02 Thread Konstantin Kolinko
2010/3/2 : > Author: mturk > Date: Tue Mar  2 09:14:44 2010 > New Revision: 917928 > > +    public void seSSLInsecureRenegotiation(boolean SSLInsecureRenegotiation) > { There is a misprint above: s/seSSL/setSSL/ Best regards,

Re: svn commit: r918093 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2010-03-03 Thread Konstantin Kolinko
2010/3/2 : > Author: markt > Date: Tue Mar  2 16:02:25 2010 > New Revision: 918093 > > URL: http://svn.apache.org/viewvc?rev=918093&view=rev > Log: > Better fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48660 > As per Konstantin's comments, ensure a single Vary header is used and take

Re: svn commit: r918792 - /tomcat/trunk/java/org/apache/juli/FileHandler.java

2010-03-04 Thread Konstantin Kolinko
ngs. > It just happens. I am sure that I myself will forget to set those properties sometime. It is good that your computer is up and running. Happy coding! Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-u

Re: svn commit: r919102 - in /tomcat/trunk/java/org/apache/catalina/util: LifecycleBase.java LocalStrings.properties

2010-03-04 Thread Konstantin Kolinko
/LifecycleState.java - do not have svn:eol-style. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat 5.5.x build broken?

2010-03-05 Thread Konstantin Kolinko
r message you were getting we'd > be able to provide more specific advice. Note, that you can use build/build.properties file to redefine the download URLs. Please let us know if some of them are not working. Best regards, Konstantin Kolinko --

Re: svn commit: r919349 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-03-05 Thread Konstantin Kolinko
re write lock is released on an error condition") Mark, on error condition we should release all locks and quit the method (there is only one lock there: write lock). We should not obtain the read lock after an error in that try{} block. Best regards, Konstantin Kolinko

Re: svn commit: r919747 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-03-06 Thread Konstantin Kolinko
There were no changes at all, as it is all English, but the patch replaces all lines of it. Just checked the file - and it does not have svn:eol-style property set. I think that you can fix the property and remove that file from the patch. Best regards, Konstantin Kolinko

Re: svn commit: r919772 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-03-06 Thread Konstantin Kolinko
il/java/org/apache/tomcat/util/net/jsse/JSSE13SocketFactory.java >> +  2) >> +     >> http://people.apache.org/~kkolinko/patches/2010-03-06_tc55_remove_JSSE13Factory.patch >> +  +1: kkolinko >> +  -1: > > Unless I am missing something, you can also remove the whole

Re: svn commit: r919914 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ test/org/apache/jasper/compiler/ test/webapp/

2010-03-07 Thread Konstantin Kolinko
eb.xml >> parse/merge changes for Tomcat 7. I'll get those fixed and see what >> impact that has. > > That has fixed one set of failures but some failures remain and they > look to be related to the isDeferredSyntaxAllowedAsLiter

Re: Tomcat build error

2010-03-07 Thread Konstantin Kolinko
ot;modern" compiler and initialize a wrapper around it, but cannot. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-07 Thread Konstantin Kolinko
f deferred EL syntax is treated as EL or as >> a literal Ah, I see. That is said in the chapter "Backwards Compatibility with JSP 2.0" that precedes the main spec pages (page xxiv in JSP 2.2 Specification). Best regards, Konstantin Kolinko -

Re: svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-07 Thread Konstantin Kolinko
2010/3/7 Konstantin Kolinko : > 2010/3/7 Mark Thomas : >> On 07/03/2010 18:45, ma...@apache.org wrote: >>> Author: markt >>> Date: Sun Mar  7 18:45:50 2010 >>> New Revision: 920055 >>> >>> URL: http://svn.apache.org/viewvc?rev=920055&view=r

Re: svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-08 Thread Konstantin Kolinko
2010/3/8 Mark Thomas : > On 07/03/2010 21:26, Konstantin Kolinko wrote: >> 2010/3/7 Konstantin Kolinko : >>> 2010/3/7 Mark Thomas : >>>> On 07/03/2010 18:45, ma...@apache.org wrote: >>>>> Author: markt >>>>> Date: Sun Mar  7 18

Re: tagging 6.0.26

2010-03-08 Thread Konstantin Kolinko
n Monday... >> >> Though so :) >> >> Konstantin's improved fixes for 48668 need one more vote and then I >> think we'll be good to go. > > hm the 3 patches go very well togother. Won't

[VOTE] C-T-R for any translation fixes

2010-03-08 Thread Konstantin Kolinko
ISO-8859-1, some in Windows-1252, some in UTF-8. There should have been some reason why that happened. That said, I am +1 for C-T-R for any translation fixes. 6. Should we mark C-T-R commits somehow in the commit message? E.g. writing "C-T-R" or "tr

Re: [VOTE] C-T-R for any translation fixes

2010-03-08 Thread Konstantin Kolinko
I propose to relax our RTC policy and use CTR for the types of changes listed below: 2010/3/8 Konstantin Kolinko : > 1. We already have Commit-Then-Review for any documentation, including > JavaDoc and code comments. > Already decided. No need to vote. > 2. I think that we can ha

Re: [VOTE] C-T-R for any translation fixes

2010-03-08 Thread Konstantin Kolinko
2010/3/8 Mladen Turk : > On 03/08/2010 08:00 PM, Konstantin Kolinko wrote: >> Allow C-T-R for changes to svn properties: >> [ ] +1 >> [ ] 0 >> [X] -1 >> > > -1 because it can mean anything and nothing. > Changing line endings, executable flag, mime type

Re: svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-08 Thread Konstantin Kolinko
2010/3/8 Konstantin Kolinko : > 2010/3/8 Mark Thomas : >> On 07/03/2010 21:26, Konstantin Kolinko wrote: >>> >>> Re: r920110: >>> (...) >>> I see no provision in the spec for the above change. >>> >>> The chapter "Backwards Compa

Re: tagging 6.0.26

2010-03-09 Thread Konstantin Kolinko
Do not forget to update both version.minor version.suffix Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r920907 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2010-03-09 Thread Konstantin Kolinko
of the "tag invocation will give the name of the variable." So the attribute value must be known at translation time. Cannot verify that without some testing, though. Best regards, Konstantin Kolinko - To unsubscribe, e-mail

Re: tagging 6.0.26

2010-03-09 Thread Konstantin Kolinko
2010/3/9 Konstantin Kolinko : > Do not forget to update both > version.minor > version.suffix I meant version.build version.suffix Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apach

Re: [VOTE] Release build 6.0.26

2010-03-10 Thread Konstantin Kolinko
2010/3/9 jean-frederic clere : > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.26/ > > According to the release process, the 6.0.26 tag is: > [x] Stable > Best regards,

Re: net start "Apache tomcat" is not working on java build

2010-03-11 Thread Konstantin Kolinko
It must be CALL e:\ant\bin\ant.bat all -logger org.apache.tools.ant.listener.MailLogger (...) Please read http://tomcat.apache.org/lists.html and ask such questions on the users@ list. - To unsubscribe, e-mail: dev-unsubscr...@to

Tomcat 6.0.26 docs on the site - not replicated

2010-03-11 Thread Konstantin Kolinko
about the US mirror. It is the only one that we have now: the EU mirror is out of service for the last four days. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands

Re: svn commit: r922300 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-03-12 Thread Konstantin Kolinko
loadedClass" in findClassInternal(): - The loadedClass field would need to be volatile to avoid broken double-checked locking pattern here, but the change that I am proposing also fixes it. Any comments? [1] http://java.sun.com/docs/books/jls/third_edition/html

Re: Reusing instances

2010-03-12 Thread Konstantin Kolinko
security issues. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r922300 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-03-12 Thread Konstantin Kolinko
2010/3/12 Konstantin Kolinko : > 2010/3/12  : >> Author: kkolinko >> Date: Fri Mar 12 15:41:55 2010 >> New Revision: 922300 >> >> URL: http://svn.apache.org/viewvc?rev=922300&view=rev >> Log: >> proposal >> > > My concern, leading to th

Re: Using JIRA instead STATUS.txt

2010-03-14 Thread Konstantin Kolinko
e. Some other thought: The Subversion project was recently choosing what Bug tracking system they will be using at Apache, when migrating from Tigris. They choose Bugzilla, not JIRA: http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415808 Best regards,

[RESULT] (Was: [VOTE] C-T-R for any translation fixes)

2010-03-16 Thread Konstantin Kolinko
Tim RESULT: Passes I did not count the votes by Henri Gomez (probably +1 to 2.,3.,4.,5.) and by Jean-Frederic Clere (looks like -0 to all), as those were not clear to me. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r924228 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-03-17 Thread Konstantin Kolinko
that my proposal for this issue is already there, since 2010-03-11. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat not able to access folder which is in virtual drive

2010-03-18 Thread Konstantin Kolinko
Your question is off-topic here. Usage questions should be send to the tomcat-users list. Please read: http://tomcat.apache.org/lists.html http://www.catb.org/~esr/faqs/smart-questions.html Do not forget to provide all relevant information. That includes the *text* of any error messages that you

Re: Patch for better support of Unified EL 2.2

2010-03-18 Thread Konstantin Kolinko
2010/3/18 Ruslan Gainutdinov : > Please review this patch for inclusion in trunk. Your attachment is lost. Please create a Bugzilla entry for Tomcat 7 and attach it there, though I cannot comment on whether it will be applied or not. Best regards, Konstantin Koli

Re: svn commit: r926064 - /tomcat/trunk/java/org/apache/catalina/core/StandardContextValve.java

2010-03-23 Thread Konstantin Kolinko
null) > +                int j = (instances.length -1) -i; > +                if (instances[j] == null) >                     continue; (...) There is a more easy way to write the same loop: for (int i = instances.length; (--i) >= 0; ) { Best regards, Konstantin Kolinko --

Re: svn commit: r927037 - in /tomcat/trunk/java/org/apache/catalina: ha/session/DeltaManager.java session/ManagerBase.java

2010-03-25 Thread Konstantin Kolinko
ile > qualifier, and add a synchronised getter. > A synchronized getter is what we surely do not need here. We can go back to the separate read and write locks though. We need volatile so that the current value of 'maxActive' were consistent between threads. Even the write lock may look a bit excessive. But - why not? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r927351 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-03-25 Thread Konstantin Kolinko
JRE 7.0 support is an enhancement and can be considered separately. I will attach my old patch to BZ 48903 for future reference. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r927555 - in /tomcat/trunk/java/org/apache: catalina/connector/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2010-03-25 Thread Konstantin Kolinko
d thread pool. >      */ > The above commit of AbstractEndpoint.java probably was not part of the async work. The above new property is not used anywhere, so it is useless as it is. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat 7 windows installer image

2010-03-26 Thread Konstantin Kolinko
background when I zoom-out the page in the browser. Should check how it looks when actually running the installer, though. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additiona

Re: svn commit: r928798 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ webapps/docs/config/

2010-03-30 Thread Konstantin Kolinko
y be volatile. > Startup is performed by a single thread, and it will set the value of this field. According to the memory model all the threads started after that will see the assigned value. I do not remember any of the "option value" fields in Tomca

Re: [ANN] New Tomcat Committer: Keiichi Fujino (kfujino)

2010-03-31 Thread Konstantin Kolinko
2010/3/31 Filip Hanik - Dev Lists : > On behalf of the Tomcat committers I am pleased to announce that Keiichi > Fujino (kfujino) has been voted in as a new Tomcat committer. > Welcome! Best regards, Konstantin Kolinko ---

Re: GSoC Tomcat SPDY Connectors

2010-04-05 Thread Konstantin Kolinko
2010/4/5 Felix Kurth : > one last thing: is there A website where i can easily browse this > mailinglist? The ones that we know about are mentioned on the following page: http://tomcat.apache.org/lists.html Best regards, Konstantin K

Re: [VOTE] Release build 5.5.29

2010-04-06 Thread Konstantin Kolinko
found" may annoy someone, but it does not impact functionality. The patch is already in STATUS for some time, but needs a third vote. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa

Re: Patch suggestion

2010-04-10 Thread Konstantin Kolinko
cle runs, if it is enabled, but there are also explicit calls from the manager web application that must not be broken. The above is from my mind/memory. I have not researched it for this case. Best regards, Konstantin Kolinko - To u

Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java

2010-04-14 Thread Konstantin Kolinko
uot; and "insecure random" at runtime. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: setRequest method on HttpServletRequestWrapper

2010-04-15 Thread Konstantin Kolinko
y one such well-known library, http://tuckey.org/urlrewrite/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: building tomcat-oacc: missing some classes?

2010-04-15 Thread Konstantin Kolinko
commit message says among other things "- Add manager base class ClusterManagerBase" but none classes were added in that revision. If it will not be fixed shortly, please raise a bug. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: setRequest method on HttpServletRequestWrapper

2010-04-16 Thread Konstantin Kolinko
t; Struts 2.1 uses servlet filters as controllers and we can not get > request dispatcher for filters. Filters can be called for forwarded and included requests, if you map them in certain way (something like INCLUDE). See the Servlet spec for details. SRV.6.2.5 Best regards, Konstantin Kolinko -

Proposal (cleanup): drop "org.apache.tomcat.util.collections" package (MultiMap class) in TC7

2010-04-16 Thread Konstantin Kolinko
just mark it as deprecated. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

<    7   8   9   10   11   12   13   14   15   16   >