2010/3/25 Mark Thomas <ma...@apache.org>: > On 25/03/2010 11:34, kkoli...@apache.org wrote: >> @@ -234,6 +234,12 @@ PATCHES PROPOSED TO BACKPORT: >> and Catalina. Jasper should be independent. >> The patch also needs to use the StringManager for i18n. I'm >> working on an updated patch. >> + kkolinko - Jasper vs. Catalina dependency can be solved by moving the >> + new LockAwareURLClassLoader class to some other package. >> + Can go into o.a.tomcat.util.<something>. that is currently >> + packed into tomcat-coyote.jar in TC 6.0. The only >> + "dependency" on Catalina there is the name of the system >> + property that controls the behaviour. > > How about just sync'ing on this in 6.0.x and 5.5.x and experiementing > new options in Tomcat 7. > > In 7.0.x, the tomcat-api jar is shared between Catalina and Jasper but > for these classloader changes I'm leaning towards just using copy and > paste to keep things simple. >
1. I just noted several hour ago, that there is one more classloader that needs to inherit from LockAwareClassLoader: o.a.catalina.loader.StandardClassLoader So LockAwareClassLoader has to go into bootstrap.jar 2. For 5.5 I definitely would go with just sync(this). There is no point to target JRE 7 features there. 3. For 6.0 I am fine to go with sync(this) now. JRE 7.0 support is an enhancement and can be considered separately. I will attach my old patch to BZ 48903 for future reference. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
