Re: Cookies are broken in 6.0.16?

2008-02-13 Thread Filip Hanik - Dev Lists
the cookie contains invalid characters then -> quote the cookie and set the version to 1 Filip Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] On Sun, 2008-02-10 at 23:29 +, Mark Thomas wrote: Filip Hani

Re: [PROPOSAL] Announce 3.x is no longer supported

2008-02-14 Thread Filip Hanik - Dev Lists
+1 Filip Mark Thomas wrote: All, The last 3.x release was almost 4 years ago. Since then there has been one security patch made available in source form and that was more an application issue than a Tomcat one. There is still the odd support question on the users list but I think it is ti

Re: svn commit: r627911 - in /tomcat/trunk: NOTES-FOR-TOMCAT-6.2.txt NOTES-FOR-TOMCAT-7.txt

2008-02-14 Thread Filip Hanik - Dev Lists
+1. AnnotationProcessor -> InstanceManager replacement (used by Geronimo) this is already in trunk, is that what you meant? Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTEC

Re: [PROPOSAL / POLL] Issue a de-support notice for Tomcat 4

2008-02-14 Thread Filip Hanik - Dev Lists
yes, a the timeframe of 16 months heads up sounds like a good plan. still many instances of 4 running, another way to look at it, is to have no more than 3 versions active at any point, so when TC 7 comes out, TC 4 goes to bed. I think it's too hard for us to try to maintain more releases than t

Re: [VOTE] Release build 4.1.37

2008-02-14 Thread Filip Hanik - Dev Lists
According to the release process, the 4.1.37 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r628117 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-16 Thread Filip Hanik - Dev Lists
[EMAIL PROTECTED] wrote: Author: remm Date: Fri Feb 15 08:49:10 2008 New Revision: 628117 * Allow old style cookie values to work(auto switch to v1) (regression) http://svn.apache.org/viewvc?view=rev&revision=627743 (ServerCookie.java) +1: fhanik, markt + +0: remm (the property nam

Re: 6.0.16 available in maven repository

2008-02-18 Thread Filip Hanik - Dev Lists
I just did it today, it's not an automated process, as we can't publish it until the release has been voted on, and after the release has been voted through, it's just a matter of someone doing it Filip Mohn, Robert wrote: When will the 6.0.16 release be available in the maven repository? I n

Re: svn commit: r628117 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-18 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Sun, 2008-02-17 at 02:40 +, Filip Hanik - Dev Lists wrote: [EMAIL PROTECTED] wrote: Author: remm Date: Fri Feb 15 08:49:10 2008 New Revision: 628117 * Allow old style cookie values to work(auto switch to v1) (regression) http://svn.apache.org

Re: Cookie handling issue (bug?) in Tomcat 5.5.26

2008-02-19 Thread Filip Hanik - Dev Lists
they're not broken, read the servlet spec http://marc.info/?t=12025394451&r=1&w=2 Filip Marcinek, Blazej wrote: Hi, I've just tried running Tomcat 5.5.26 and I've noticed a problem with Cookie handling (though I'm not sure on which side it should be corrected). In our application we us

Re: Cookie handling issue (bug?) in Tomcat 5.5.26

2008-02-19 Thread Filip Hanik - Dev Lists
n, my web app (running on Tomcat) needs to fetch value of this cookie properly to verify user's authentication - which worked fine till now, but on 5.5.26 the returned cookie value is truncated. Can this be worked around somehow? Kind regards, Blazej Marcinek -Original Message-

[PROPOSAL] Add to changelog.xml

2008-02-21 Thread Filip Hanik - Dev Lists
since we have the ability to add bz number to changelog, wouldn't it be nice to be able to add svn rev number and automatically link changes to the actual commit Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: [PROPOSAL] Add to changelog.xml

2008-02-21 Thread Filip Hanik - Dev Lists
jean-frederic clere wrote: Filip Hanik - Dev Lists wrote: since we have the ability to add bz number to changelog, wouldn't it be nice to be able to add svn rev number Sure. and automatically link changes to the actual commit How? 627743 becomes http://svn.apache.org/viewvc?vie

Re: [PROPOSAL] Add to changelog.xml

2008-02-21 Thread Filip Hanik - Dev Lists
jean-frederic clere wrote: Filip Hanik - Dev Lists wrote: jean-frederic clere wrote: Filip Hanik - Dev Lists wrote: since we have the ability to add bz number to changelog, wouldn't it be nice to be able to add svn rev number Sure. and automatically link changes to the actual commit

Re: [PROPOSAL] Add to changelog.xml

2008-02-21 Thread Filip Hanik - Dev Lists
://issues.apache.org/jira/browse/GERONIMO-3417 (click on "all") very nice, but we're still on bugzilla (not that we couldn't switch, but thats not part of this proposal) Filip david jencks - Original Message ---- From: Filip Hanik - Dev Lists <[EMAIL PROTECTED]> To: To

Re: svn commit: r630043 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-22 Thread Filip Hanik - Dev Lists
[EMAIL PROTECTED] wrote: Author: remm @@ -80,6 +82,7 @@ +1: fhanik, markt +0: remm (the property name is inconsistent with what has been used recently, but that convention was never really discussed either) fhanik: the propperty name is the same as everywhere else + I posted a

Re: Serving ICY streams from a servlet

2008-02-25 Thread Filip Hanik - Dev Lists
an HTTP request, requires an HTTP response, regardless of what the headers are set to. proxies and other things that come in the middle would be confused, or even reject the response if something else came in between. I'd be surprised if anyone here would be interested in making that modificatio

Re: Ajp connector giving error with Executor configuration. is this a bug?

2008-02-26 Thread Filip Hanik - Dev Lists
please use the tomcat-user list for these kinds of questions. executor is not a supported attribute for AJP connectors, since it doesn't make sense to have it Filip nitin dubey wrote: Hi, I tried configuring executor in tomcat 6.0.14 for AJP Connector like following: While starting tomca

async close of comet requests

2008-02-26 Thread Filip Hanik - Dev Lists
I've implemented a proper async close http://people.apache.org/~fhanik/patches/comet-async-close.patch for the NIO connector. today, when someone calls CometEvent.close() it finishes out the request, but nothing happens until the connection actually times out, which could be forever. also, any

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch can be found here. http://people.apache.org/~fhanik/tomcat/b2c/ This is what is happening int cnt=conv.read( result

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 12:51 -0700, Filip Hanik - Dev Lists wrote: Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch c

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 12:51 -0700, Filip Hanik - Dev Lists wrote: Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Filip Hanik - Dev Lists wrote: Test Case and 5.5.x patch c

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 16:04 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: unfortunately, the "elegant" solution caused a regression :( http://issues.apache.org/bugzilla/show_bug.cgi?id=44494 I tested this with the inelegant (original propo

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-27 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 17:08 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: This makes me think there's a straight issue in CharChunk (I suppose the problem is that realReadChars gets called with len = 0; if it handled that scenario, things shou

Re: svn commit: r631878 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-02-28 Thread Filip Hanik - Dev Lists
[EMAIL PROTECTED] wrote: Author: billbarker Date: Wed Feb 27 23:44:58 2008 New Revision: 631878 URL: http://svn.apache.org/viewvc?rev=631878&view=rev Log: casting vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tom

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Remy Maucherat wrote: On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: Index: java/org/apache/catalina/connector/InputBuffer.java === ---java/org/apache/catalina/connector/InputBuffer.java(revision 6

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-02-28 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-02-27 at 18:25 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: On Wed, 2008-02-27 at 17:08 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: This makes me think there's a straight issue in CharChu

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Remy Maucherat wrote: On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: Index: java/org/apache/catalina/connector/InputBuffer.java === ---java/org

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Mon, 2008-03-03 at 21:13 +, Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Remy Maucherat wrote: On Thu, 2008-02-28 at 01:36 +0100, Remy Maucherat wrote: Index: java/org/apache/catalina/connector

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Mon, 2008-03-03 at 15:58 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: This problem is a small detail. Much more should be done if you want to do a refactoring: both the mark functionality and readLine need to have direct access to the buffer to

Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2008-03-03 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: On 3/3/08, Remy Maucherat <[EMAIL PROTECTED]> wrote: On Mon, 2008-03-03 at 15:58 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: This problem is a small detail. Much more should be done if you want to do a refactoring

Re: Reorder the http header generated by tomcat

2008-03-06 Thread Filip Hanik - Dev Lists
George Sexton wrote: William A. Rowe, Jr. wrote: Jim Jagielski wrote: Requiring any specific order on HTTP response headers is completely bogus... :) To elaborate on why Jim thinks so (and we all agree)... - it's not spec. You cannot rely on this when authoring a user agent. - proxies c

Re: latest Tomcat and maven

2008-03-09 Thread Filip Hanik - Dev Lists
http://people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/tomcat/ Henri Gomez wrote: While looking at http://tomcat.apache.org/tomcat-6.0-doc/maven-jars.html I notice about that http://tomcat.apache.org/tomcat-6.0-doc/maven-jars.html still contains 6.0.14 jars. Will it be updated to

Re: latest Tomcat and maven

2008-03-09 Thread Filip Hanik - Dev Lists
you shouldn't steal threads ;) Peter Rossbach wrote: Hi, I thing we must remove 6.0.16 and 5.5.26 from site. The 8 K Post Bug is a major issue and it must be fixed. But currently I don't understand the fix alternatives. Peter Am 09.03.2008 um 10:23 schrieb Henri Gomez: While looking at

Re: Adding HTTPOnly support to Tomcat

2008-03-09 Thread Filip Hanik - Dev Lists
haven't forgotten about you, it's still on the todo list. Filip Jim Manico wrote: Gentlemen, I'd like to make a suggestion to add HTTPOnly support to Tomcat 5.5 (for starters). This is a significant security enhancement that will assist in preventing XSS attacks. http://msdn2.microsoft.com/

Re: svn commit: r634863 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-09 Thread Filip Hanik - Dev Lists
actually, IE only supports quoting of the value for v0 cookies. honestly, I wasn't up for the backwards compatible fix, but since it turns out that most folks use v0 cookies with v1 values, this is an evil must. without the below fix, every single JSESSIONID cookie will not work on IE. Filip

Re: Draft support status announcement

2008-03-11 Thread Filip Hanik - Dev Lists
sounds good to me Filip Mark Thomas wrote: All, Please find below a draft of an announcement I intend sending to the users list later this week. Comments? Mark Subject: [ANN] Tomcat support status All, We would like to draw your attention to a new Wiki page that provides detailed infor

Re: svn commit: r634863 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-17 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: actually, IE only supports quoting of the value for v0 cookies. honestly, I wasn't up for the backwards compatible fix, but since it turns out that most folks use v0 cookies with v1 values, this is an evil must. without the below fix,

Re: svn commit: r634863 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-17 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Filip Hanik - Dev Lists wrote: actually, IE only supports quoting of the value for v0 cookies. honestly, I wasn't up for the backwards compatible fix, but since it turns out that most folks use v0 cookies with v1 v

Re: svn commit: r638442 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-18 Thread Filip Hanik - Dev Lists
this wont work either. for the value of the cookie, it must be what it was before. tspecials2. those are the correct characters for the "value" of the cookie, but they are not correct for the "path" the problem is how browsers work (or not work for that matter). for example, browsers will acce

Re: Cookie standards

2008-03-18 Thread Filip Hanik - Dev Lists
tomcat doesn't use that spec, we use http://wp.netscape.com/newsref/std/cookie_spec.html http://www.faqs.org/rfcs/rfc2109.html not sure how many browsers are actually up to 2965 yet Filip William A. Rowe, Jr. wrote: The standard is only 7 1/2 years old; http://www.ietf.org/rfc/rfc2965 Jim Ma

Re: svn commit: r638442 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-18 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: this wont work either. for the value of the cookie, it must be what it was before. tspecials2. those are the correct characters for the "value" of the cookie, but they are not correct for the "path" I'm not convince

Re: svn commit: r638442 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-18 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Filip Hanik - Dev Lists wrote: this wont work either. for the value of the cookie, it must be what it was before. tspecials2. those are the correct characters for the "value" of the cookie, but they are not corre

Re: svn commit: r638854 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-19 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-03-19 at 15:03 +, [EMAIL PROTECTED] wrote: Author: fhanik Date: Wed Mar 19 08:03:50 2008 New Revision: 638854 URL: http://svn.apache.org/viewvc?rev=638854&view=rev Log: change a vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0

Re: svn commit: r638854 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-19 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-03-19 at 15:03 +, [EMAIL PROTECTED] wrote: Author: fhanik Date: Wed Mar 19 08:03:50 2008 New Revision: 638854 URL: http://svn.apache.org/viewvc?rev=638854&view=rev Log: change a vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-19 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote: +1 : remm, markt - -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also saw the bug report, informing about further issues that are still valid + +1 : fhanik - I don't think we should su

renaming jar files

2008-03-20 Thread Filip Hanik - Dev Lists
when the commons-logging jar files got updated, they also got renamed, we missed a few spots, some files in bin and conf still reference the old name, like catalina.policy // These permissions apply to the commons-logging API grant codeBase "file:${catalina.home}/bin/commons-logging-api.jar" {

Re: renaming jar files

2008-03-21 Thread Filip Hanik - Dev Lists
install the package. Costin On 3/20/08, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: when the commons-logging jar files got updated, they also got renamed, we missed a few spots, some files in bin and conf still reference the old name, like catalina.policy // These permi

Re: Cookies are broken in 6.0.16?

2008-03-21 Thread Filip Hanik - Dev Lists
even the 6.0.x needs one more patch in order to be backwards compatible Filip Olivier Jaquemet wrote: One last question Mark... The tc6.6.x trunk has the patch and it works fine, but not yet the tc5.5.x. Is it planned for the next 5.5.x release ? Olivier Jaquemet wrote: Thank you for your a

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-03-19 at 18:17 -0600, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: On Wed, 2008-03-19 at 22:43 +, [EMAIL PROTECTED] wrote: +1 : remm, markt - -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also saw

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Fri, 2008-03-21 at 11:25 -0600, Filip Hanik - Dev Lists wrote: what this filter does, is it relies on the already implemented BufferedReader, no need to reinvent the wheel. The java.io.BufferedReader, already has this logic implemented, and it works, so CoyoteReader

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Fri, 2008-03-21 at 14:29 -0600, Filip Hanik - Dev Lists wrote: I'd prefer to move forward with just the truncation fix so that we can move towards a release. Any other efforts can be postponed at this time. If the mark/reset bug in fact exists, there is an

Re: svn commit: r639046 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-03-21 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Fri, 2008-03-21 at 15:19 -0600, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: regression, the fact that you can't read more than 8k when using ServletRequest.getReader I proposed a patch for that. If it doesn't fix it with the patch I propos

Re: Tomcat Header Injection

2008-03-25 Thread Filip Hanik - Dev Lists
Jim Manico wrote: I'm continuing to do a security review of Tomcat 5.5 for my company. I noticed that linefeeds get ripped out of header values which stops header injection attacks cold. Whoever did this, I commend you. Many other containers do not. You Rock. InternalInputBuffer.java InternalA

Re: tomcat-oacc

2008-03-26 Thread Filip Hanik - Dev Lists
Rainer Jung wrote: Hi Jean-Frederic, jean-frederic clere wrote: Hi, What is the goal of tomcat-oacc exactly. 1 - Replace the actual tc-trunk cluster. No. 2 - Port the tc-5.5.x code and have an alternate cluster. Yes, reason for alternate see below. 3 - Just a try for the fun. That wo

Re: tomcat-oacc

2008-03-26 Thread Filip Hanik - Dev Lists
Rainer Jung wrote: But I do not only have these very abstract concerns. There is room for improvement and I'll happily help as I did in 2004 for the TC 5.0/5.5 cluster. Examples for improvements: - monitoring (the old MBeans are gone and there's no good alternative) ClusterJMXHelper.java

Re: tomcat-oacc

2008-03-26 Thread Filip Hanik - Dev Lists
ugs that arise from the port itself. I do have some comments inline too Rainer Jung wrote: Hi Filip, Filip Hanik - Dev Lists schrieb: Rainer Jung wrote: But I do not only have these very abstract concerns. There is room for improvement and I'll happily help as I did in 2004 f

Re: tomcat-oacc

2008-03-26 Thread Filip Hanik - Dev Lists
Rainer Jung wrote: Hi Filip, Filip Hanik - Dev Lists schrieb: - Java 5 dispatcher: I mostly agree. I got lost in the code. The code I thought was responsible was transport/PooledSender.java which uses a fixed pool of threads without queueing. I overlooked somehow the Executor with queue in

Re: tomcat-oacc

2008-03-27 Thread Filip Hanik - Dev Lists
Rainer Jung wrote: Filip Hanik - Dev Lists schrieb: hi Rainer, so to tell the true tale, isn't the story... - You got customers on 5.5 using session replication Of course, and that helped in making the 5.5 cluster better. - Your customers want to move to Tomcat 6 I do hope so! I th

Re: tomcat-oacc

2008-03-27 Thread Filip Hanik - Dev Lists
But what are we talking about: - "your codebase": its our codebase. If we had to find a single person for this cluster codebase, then it would be your codebase. As everyone can see from yesterdays commit, the codebase is nearly identical from the TC 5.5 codebase. I don't want to have "my" c

Re: tomcat-oacc

2008-03-27 Thread Filip Hanik - Dev Lists
jean-frederic clere wrote: +++ CUT +++ All in all I feel accused by the above formulation. the answer to this all lies in the fact, that I didn't see an email on tomcat-dev about OACC creation, so if I missed it, my apologies, but I cant recall seeing one. That is in sandbox. sandbox is sup

Re: HttpOnly and Kauai

2008-03-31 Thread Filip Hanik - Dev Lists
nice, since we work RTC (Review-Then-Commit) you're gonna have to extend this invitation to everyone who votes for the patch's inclusion :) Filip Jim Manico wrote: Gentlemen, As a blatant bribery attempt - I live and work on the island of Kauai in Hawaii. Whomever commits this *https://is

Re: HttpOnly and Kauai

2008-04-01 Thread Filip Hanik - Dev Lists
we can't do this one https://issues.apache.org/bugzilla/attachment.cgi?id=21741 that's a servlet spec class Filip Jim Manico wrote: Tequila, tents, food and wireless access provided!!! Tomcat coding party at Jim's house! nice, since we work RTC (Review-Then-Commit) you're gonna have to exte

Re: HttpOnly and Kauai

2008-04-01 Thread Filip Hanik - Dev Lists
Guenter Knauf wrote: Hi, we can't do this one https://issues.apache.org/bugzilla/attachment.cgi?id=21741 that's a servlet spec class well, that wasnt clever now! You should first have commited, then made a trip to Kauai with your laptop, and then from there at the Tomcat co

Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-08 Thread Filip Hanik - Dev Lists
just taking a quick look at the patch, this is a memory leak. the buffer will simply grow larger and larger until an OOM happens, if one keeps marking the buffer when I am more awake, I'll help out on this, it's very easy to reproduce http://people.apache.org/~fhanik/upload-mark.jsp Filip [EMA

Re: svn commit: r645722 - /tomcat/trunk/java/org/apache/catalina/connector/InputBuffer.java

2008-04-08 Thread Filip Hanik - Dev Lists
ignore my prev email about the mem leak, I wasn't up to current in trunk, and was running into something else Filip [EMAIL PROTECTED] wrote: Author: markt Date: Mon Apr 7 15:47:54 2008 New Revision: 645722 URL: http://svn.apache.org/viewvc?rev=645722&view=rev Log: All of the issues I was see

Re: svn commit: r648019 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-17 Thread Filip Hanik - Dev Lists
+1, absolutely, I think the remaining patches, are small and easy and we can get them in, wanna set a date for the tag I'll do the same for 5.5 but trail it a couple of days after so we can get the votes in If possible, please review * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=4266

Re: Osgifing Tomcat

2008-04-22 Thread Filip Hanik - Dev Lists
Henri Gomez wrote: Hi to all, Did there is plans, ideas or interest around about OSGI-fing Tomcat ? I've put a note about this a while ago in tomcat/trunk/PROPOSALS.txt my original plan was just to make sure all the MANIFEST.MF for each file would have enough in it so that each JAR can be a

Re: Osgifing Tomcat

2008-04-23 Thread Filip Hanik - Dev Lists
Henri Gomez wrote: 2008/4/23 Florent.BENOIT <[EMAIL PROTECTED]>: Hello, As part of OW2 JOnAS 5.0 OSGi based application server we're interested to have Tomcat packaged as an OSGi bundle. All our modules are bundles and if tomcat is already a bundle we won't have to wrap it into a bundle

Re: Osgifing Tomcat

2008-04-23 Thread Filip Hanik - Dev Lists
Henri Gomez wrote: I'm not sure it's the best idea, my goal is to move it out of sandbox, it already has enough experiments that need completion. and the main goal is to be 'lite' :-). It has a simple Addon mechanism, and I don't mind having an optional addon manager impl using OSGI - but I

Re: Osgifing Tomcat

2008-04-23 Thread Filip Hanik - Dev Lists
like jarjar. Filip Of course no commit just testing on my own eclipse/m2 workspace. 2008/4/23 Filip Hanik - Dev Lists <[EMAIL PROTECTED]>: Henri Gomez wrote: I'm not sure it's the best idea, my goal is to move it out of sandbox, it already has enough experiments that

Re: Osgifing Tomcat

2008-04-23 Thread Filip Hanik - Dev Lists
Henri Gomez wrote: First define 'mavenizing' please :-) Yes If you mean exporting tomcat components in maven repository - fine with me. It's allready done (by hand) ? If you mean building tomcat with maven instead of ant - the opposite, absolutely not fine. it wa

Re: Osgifing Tomcat

2008-04-23 Thread Filip Hanik - Dev Lists
Niall Pemberton wrote: On Wed, Apr 23, 2008 at 6:56 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: Henri Gomez wrote: I'm not sure it's the best idea, my goal is to move it out of sandbox, it already has enough experiments that need completion. and the ma

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-04-29 Thread Filip Hanik - Dev Lists
Henri Gomez wrote: -1 for any change to the build in Tomcat 6.0. Why ? simply because it requires changes, I like to think we work according to "if it aint broke, don't fix it", and since the maven build doesn't give us anything the ANT build already does, then there seems to be litt

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-04-29 Thread Filip Hanik - Dev Lists
Yoav Shapira wrote: Filip, this is a fairly rare case where I disagree with you ;) On Tue, Apr 29, 2008 at 7:18 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: simply because it requires changes, I like to think we work according to It can be done without requiri

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-04-30 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: We already have eclipse files checked in AFAIK - that counts as the second build system. We used to have makefiles too, also in parallel with ant (in 3.0 times). The goal IMO is that people who like to type mvn can do it - without any guarantee that the result will be id

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-04-30 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: On Wed, Apr 30, 2008 at 11:31 AM, Filip Hanik - Dev Lists < [EMAIL PROTECTED]> wrote: Costin Manolache wrote: We already have eclipse files checked in AFAIK - that counts as the second build system. We used to have makefiles too, also in parallel with a

Re: Mavenizing Tomcat : Was: Osgifing Tomcat

2008-04-30 Thread Filip Hanik - Dev Lists
e have fully recovered from the last episode yet to the point where we can just CTR anything and listen to me, I was the one that marked revolutionary :) Filip Costin On Wed, Apr 30, 2008 at 3:55 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: Costin Manolache wrote:

Re: Osgifing Tomcat

2008-05-01 Thread Filip Hanik - Dev Lists
Peter Kriens wrote: I must admit I feel I am walking on eggs ... and I am a bit surprised how few others tune in. there is a reason few others turn in, at this point, you have written, and very well so, about 30 pages of responses. It's just to hard keep up with long essays like that, not t

Re: svn commit: r652743 - /tomcat/trunk/.classpath

2008-05-01 Thread Filip Hanik - Dev Lists
ant -f extras.xml downloads and builds this this filip [EMAIL PROTECTED] wrote: Author: costin Date: Thu May 1 20:18:26 2008 New Revision: 652743 URL: http://svn.apache.org/viewvc?rev=652743&view=rev Log: Match build.xml - exclude webservices, missing deps Not sure why it's checked in - if 'd

Re: svn commit: r656035 - in /tomcat/trunk/java/org/apache/tomcat/util/net/jsse: JSSESocketFactory.java res/LocalStrings.properties

2008-05-13 Thread Filip Hanik - Dev Lists
-1, this code change here -log.error("Exception trying to load keystore " +path,ex); -throw new IOException("Exception trying to load keystore " + - path + ": " + ex.getMessage() ); +String msg = sm.getString("jsse.keystore_loa

Re: svn commit: r656124 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java

2008-05-14 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Peter Rossbach wrote: Hi Mark Java 5 don't support new IOExceptin(String, Throwable) compile: [javac] Compiling 49 source files to /Users/peter/develop/projects/tomcat/tomcat6currenttrunk/output/classes [javac] /Users/peter/develop/projects/tomcat/tomcat6currenttru

Re: svn commit: r656752 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-05-15 Thread Filip Hanik - Dev Lists
no, this is my fault you've updated the link, but left the old votes in there :) Filip Mark Thomas wrote: [EMAIL PROTECTED] wrote: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44968 @@ -151,4 +151,4 @@ http://svn.apache.org/viewvc?rev=656739&view=rev http://svn.apache.org/vie

Re: Potential problem with COMET & sendfile

2008-05-21 Thread Filip Hanik - Dev Lists
I don't see any use case for Comet+sendfile make sense. but if you do it, you should ... set your sendfile stuff call CometEvent.close() . ie, the event shouldn't be cometized when doing sendfile, it makes zero sense since when the file is sent, the HTTP request is over. Filip Alex Barc

Re: Potential problem with COMET & sendfile

2008-05-21 Thread Filip Hanik - Dev Lists
Alex Barclay wrote: Filip Hanik - Dev Lists wrote: I don't see any use case for Comet+sendfile make sense. but if you do it, you should ... set your sendfile stuff call CometEvent.close() . ie, the event shouldn't be cometized when doing sendfile, it makes zero sense since whe

Re: svn commit: r658474 - in /tomcat/tc6.0.x/trunk: java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java webapps/docs/changelog.xml webapps/docs/config/http.xml

2008-05-22 Thread Filip Hanik - Dev Lists
removing (or changing signatures) for non-private methods, shouldn't they be @deprecated for a while? Filip [EMAIL PROTECTED] wrote: Author: markt Date: Tue May 20 15:54:32 2008 New Revision: 658474 URL: http://svn.apache.org/viewvc?rev=658474&view=rev Log: Fix remainder of https://issues.apa

Re: Tomcat 5.5 question

2008-05-29 Thread Filip Hanik - Dev Lists
hi Mike, this question belongs on the user list, I suggest you try there Filip Mike wrote: Hello, I'm trying to set up connection pooling for Tomcat 5.5 but it doesn't work. When I start Tomcat, it shows in the Catalina log this: SEVERE: Exception loading sessions from pe

Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-04 Thread Filip Hanik - Dev Lists
sandbox better place to play around :) ? [EMAIL PROTECTED] wrote: Author: markt Date: Wed Jun 4 15:07:24 2008 New Revision: 663385 URL: http://svn.apache.org/viewvc?rev=663385&view=rev Log: More 1.5 externals Modified: tomcat/current/svn15/tc5.5.x/ (props changed) Propchange: tomcat/cu

Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Filip Hanik - Dev Lists
oh, maybe I missed the email discussion where we talked about adding this to svn if I did, ignore this email Filip Mark Thomas wrote: Filip Hanik - Dev Lists wrote: sandbox better place to play around :) ? I don't see this as playing around. For those of us on this side of the Atl

Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: oh, maybe I missed the email discussion where we talked about adding this to svn There wasn't any discussion but what is there to discuss? I would change the choice of names and the SVN location, for me looking at svn, I have no idea

Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Filip Hanik - Dev Lists
Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Filip Hanik - Dev Lists wrote: oh, maybe I missed the email discussion where we talked about adding this to svn There wasn't any discussion but what is there to discuss? I would change the choice of names and the SVN location, f

Re: svn commit: r663385 - /tomcat/current/svn15/tc5.5.x/

2008-06-09 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Mark Thomas wrote: Filip Hanik - Dev Lists wrote: oh, maybe I missed the email discussion where we talked about adding this to svn There wasn't any discussion but what is there to discuss? I would change the choice of names and th

Re: svn commit: r667604 - /tomcat/trunk/java/org/apache/catalina/session/StandardSession.java

2008-06-13 Thread Filip Hanik - Dev Lists
hi Mark, can you please update the changelog thanks Filip [EMAIL PROTECTED] wrote: Author: markt Date: Fri Jun 13 10:43:51 2008 New Revision: 667604 URL: http://svn.apache.org/viewvc?rev=667604&view=rev Log: Fix bug 45195. NPE when calling getAttribute(null). The spec is unclear but this is a

Re: svn commit: r667604 - /tomcat/trunk/java/org/apache/catalina/session/StandardSession.java

2008-06-13 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: hi Mark, can you please update the changelog For trunk? The changelog for trunk hasn't been been kept up to date since it was created. then we should bring it up to date, and keep it up to date. trunk is no different in terms of chan

Re: svn commit: r668249 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2008-06-17 Thread Filip Hanik - Dev Lists
my initial reaction is a -1 to this one it should be if ( entry != null && entry.isPrimary() ) set.add(new MapEntry(key,entry.getValue())); and not propagate internals of the cluster information out to the caller Filip [EMAIL PROTECTED] wrote: Author: markt Date: Mon Jun 16 10:22:36 2008

Re: DBCP Deadlock

2008-06-25 Thread Filip Hanik - Dev Lists
Tomcat uses 1.2.2 in that version, so I would suggest not using the background validation at this point Filip Metta wrote: I'm running TC 6.0.16 on 64Bit RH Linux 5.1 We're seeing a deadlock in the tomcat-dbcp - looks like it's to do with the abandoned connection checking. I thought 6.0.16 us

more cookie fun

2008-06-25 Thread Filip Hanik - Dev Lists
https://issues.apache.org/bugzilla/show_bug.cgi?id=45272 turns out that IE doesn't like Path="/" but it does like Path=/ so, IE, doesn't really do RFC-2109, I would suggest quoting Path based on tspecials2 minus the "/" thoughts? Filip

Re: more cookie fun

2008-06-26 Thread Filip Hanik - Dev Lists
jean-frederic clere wrote: Filip Hanik - Dev Lists wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=45272 turns out that IE doesn't like Path="/" but it does like Path=/ Do you mean that it also doesn't like Path=/myapp or does it like it? it likes Path=/myapp

Re: DBCP Deadlock

2008-06-26 Thread Filip Hanik - Dev Lists
I have submitted a patch for this to commons https://issues.apache.org/jira/browse/DBCP-270 Filip Metta wrote: I'm running TC 6.0.16 on 64Bit RH Linux 5.1 We're seeing a deadlock in the tomcat-dbcp - looks like it's to do with the abandoned connection checking. I thought 6.0.16 used the commo

Re: InstanceManager javadoc

2008-06-29 Thread Filip Hanik - Dev Lists
here's some history on package etc http://tomcat.markmail.org/search/?q=InstanceManager Filip Costin Manolache wrote: Also, is there any documentation (or anyone who can explain) DefaultInstanceManager.processAnnotations() ? Sorry, I'm a bit confused, lots of calls and structures. I'm intere

Re: svn commit: r673614 - in /tomcat/tc6.0.x/trunk: STATUS.txt build.properties.default build.xml dist.xml webapps/docs/changelog.xml

2008-07-03 Thread Filip Hanik - Dev Lists
I think this one is missing Index: dist.xml === --- dist.xml(revision 673890) +++ dist.xml(working copy) @@ -454,7 +454,7 @@ filtering="true" overwrite="true"/> - + [EMAIL PROTECTED]

<    7   8   9   10   11   12   13   14   15   >