[EMAIL PROTECTED] wrote:
Author: billbarker
Date: Wed Feb 27 23:44:58 2008
New Revision: 631878

URL: http://svn.apache.org/viewvc?rev=631878&view=rev
Log:
casting vote

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=631878&r1=631877&r2=631878&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Feb 27 23:44:58 2008
@@ -124,4 +124,5 @@
   http://svn.apache.org/viewvc?rev=568605&view=rev
+1: fhanik - -1: + -1: billbarker The original patch s*cks bigtime. I agree with remy (on list) that this issue should have + involved a discussion on list on how to fix, rather than just proposing a 5 sec fix.
then why are you not discussing it. adding a comment to the status file like that is pretty sad.

the current fix is broken, and now it's not just UTF8 conversion that's broken, most data read with getReader over 8k will fail. the old fix introduced some edge cases that clearly caused problems in other components than the ones modified. it's obvious the fix broke more than it fixed.

Filip

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to