Remy Maucherat wrote:
On Wed, 2008-03-19 at 15:03 +0000, [EMAIL PROTECTED] wrote:
Author: fhanik
Date: Wed Mar 19 08:03:50 2008
New Revision: 638854
URL: http://svn.apache.org/viewvc?rev=638854&view=rev
Log:
change a vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=638854&r1=638853&r2=638854&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 19 08:03:50 2008
@@ -90,7 +90,8 @@
return cb.getLength();
- +1 : remm, markt, fhanik
+ +1 : remm, markt
+ -1 : fhanik - I tried this patch, and it doesn't work, it hangs. I also saw
the bug report, informing about further issues that are still valid
In the real world, the bug reporter you mention tested your patch, and
proposes an alternative patch which seems reasonable to me.
after looking and thinking about it, I don't think supporting mark/reset
is reasonable. how are you going to do that with mega bytes of data
being streamed. I think our implementation should simply return false on
markSupported.
Then it is very easy to write a Filter that wraps
ServletRequest.getReader in a caching reader that can support mark/reset
in its own buffer
Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
