Hi,
2014-03-13 23:12 GMT+02:00 Konstantin Kolinko :
>
> 2014-03-13 16:28 GMT+04:00 Violeta Georgieva :
> > Hi,
> >
> > In OSGi world the functionality is separated in different bundles and
> > schemes for servlet API is in one bundle and schemes for JSP API in
> > another.
> > With that change we
Hi,
2014-03-13 23:33 GMT+02:00 Mark Thomas :
>
> On 13/03/2014 13:41, Violeta Georgieva wrote:
> > 2014-03-13 15:28 GMT+02:00 Mark Thomas :
>
>
>
> >> What exactly is it that we want to cover? I can think of a number of
> >> requirements.
> >>
> >> 1. Ensure that Tomcat still works (excluding va
2014-03-14 0:43 GMT+02:00 Konstantin Kolinko :
>
> 1. addSelf() is odd, does not match with TC8. Bad merge?
> 2. Both add() and addSelf() should display a warning.
> Maybe move "log.warn()" into locationFor(..) method.
> 3. What is the point of putting null values into the maps.
> 4. Message:
> > d
On 13/03/2014 22:43, Konstantin Kolinko wrote:
> 1. addSelf() is odd, does not match with TC8. Bad merge?
Yes, it was a bad merge. I'll get that fixed.
> 2. Both add() and addSelf() should display a warning.
> Maybe move "log.warn()" into locationFor(..) method.
Good idea. Will do.
> 3. What is
Author: markt
Date: Fri Mar 14 09:37:26 2014
New Revision: 1577463
URL: http://svn.apache.org/r1577463
Log:
Review by kkolinko
Avoid adding nulls to the map
Log a warning for problems in addSelf() as well as add()
Modified:
tomcat/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.j
Author: markt
Date: Fri Mar 14 09:38:14 2014
New Revision: 1577464
URL: http://svn.apache.org/r1577464
Log:
Fix bad merge
Review by kkolinko
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util
Author: markt
Date: Fri Mar 14 09:40:15 2014
New Revision: 1577465
URL: http://svn.apache.org/r1577465
Log:
Review by kkolinko
Avoid adding nulls to the map
Log a warning for problems in addSelf() as well as add()
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/jav
Author: markt
Date: Fri Mar 14 09:43:42 2014
New Revision: 1577468
URL: http://svn.apache.org/r1577468
Log:
Update proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1577468&r1=15
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/1802
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Sourc
https://issues.apache.org/bugzilla/show_bug.cgi?id=56236
Konstantin Kolinko changed:
What|Removed |Added
Resolution|FIXED |INVALID
Severity|bl
Author: kkolinko
Date: Fri Mar 14 11:41:35 2014
New Revision: 1577489
URL: http://svn.apache.org/r1577489
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56236
Add issue number
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL
Author: kkolinko
Date: Fri Mar 14 11:44:47 2014
New Revision: 1577492
URL: http://svn.apache.org/r1577492
Log:
Fix trailing whitespace. Sorry for the noise.
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/
Author: kkolinko
Date: Fri Mar 14 11:45:12 2014
New Revision: 1577493
URL: http://svn.apache.org/r1577493
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56236
Add issue number
Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc7.0.x/trunk/webapps/docs/c
Author: kkolinko
Date: Fri Mar 14 11:46:28 2014
New Revision: 1577495
URL: http://svn.apache.org/r1577495
Log:
Add issue number and vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=
Author: remm
Date: Fri Mar 14 12:09:48 2014
New Revision: 1577501
URL: http://svn.apache.org/r1577501
Log:
Start harmonizing exception types (todo: same thing for completion handlers).
Modified:
tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java
tomcat/trunk/java/org/
The Buildbot has detected a restored build on builder tomcat-7-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/1803
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build So
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5594
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
Author: markt
Date: Fri Mar 14 14:14:29 2014
New Revision: 1577544
URL: http://svn.apache.org/r1577544
Log:
Add a couple more tests based on a report on the users list
(There tests pass, the problem looks to be elsewhere)
Modified:
tomcat/trunk/test/org/apache/jasper/compiler/TestELParser.jav
Author: remm
Date: Fri Mar 14 14:24:09 2014
New Revision: 1577546
URL: http://svn.apache.org/r1577546
Log:
Experiment some more with this test and NIO2 (sorry for the noise).
Modified:
tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java
Modified:
tomcat/trunk/tes
https://issues.apache.org/bugzilla/show_bug.cgi?id=56239
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: kkolinko
Date: Fri Mar 14 14:54:13 2014
New Revision: 1577557
URL: http://svn.apache.org/r1577557
Log:
Better reporting for skipped tests.
With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test
run summary.
Modified:
tomcat/trunk/test/org/apache/catalina/come
Author: remm
Date: Fri Mar 14 15:02:18 2014
New Revision: 1577561
URL: http://svn.apache.org/r1577561
Log:
Improve the FutureWrite logic so that writing starts when creating it, and then
will recurse on get until the content is actually written.
Modified:
tomcat/trunk/java/org/apache/tomcat/
Author: kkolinko
Date: Fri Mar 14 15:02:25 2014
New Revision: 1577562
URL: http://svn.apache.org/r1577562
Log:
Better reporting for skipped tests.
With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test
run summary.
Modified:
tomcat/trunk/test/org/apache/catalina/nonb
https://issues.apache.org/bugzilla/show_bug.cgi?id=56256
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: kkolinko
Date: Fri Mar 14 15:17:27 2014
New Revision: 1577565
URL: http://svn.apache.org/r1577565
Log:
Better reporting for skipped tests.
With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test
run summary.
Modified:
tomcat/trunk/test/org/apache/tomcat/util/n
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5595
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
Author: remm
Date: Fri Mar 14 15:21:26 2014
New Revision: 1577569
URL: http://svn.apache.org/r1577569
Log:
Add missing code to retry if no bytes are written (handshake) like for blocking
IO, and use EOFException instead.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channe
Author: kkolinko
Date: Fri Mar 14 15:43:47 2014
New Revision: 1577581
URL: http://svn.apache.org/r1577581
Log:
Correct typo in the message
Modified:
tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java
tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
tomcat/
Author: kkolinko
Date: Fri Mar 14 15:46:45 2014
New Revision: 1577582
URL: http://svn.apache.org/r1577582
Log:
Merged revisions r1577557 r1577565 r1577581 from tomcat/trunk:
Better reporting for skipped tests.
With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test
run sum
Author: remm
Date: Fri Mar 14 16:11:40 2014
New Revision: 1577598
URL: http://svn.apache.org/r1577598
Log:
Make sure the byte buffer passed as a parameter is used in all read/write
operations (come code is from the NIO1 which forces using the main read/write
buffers).
Modified:
tomcat/trunk
https://issues.apache.org/bugzilla/show_bug.cgi?id=56190
--- Comment #11 from Francois-Xavier Bonnet ---
Thanks. I just tested. Everything works as expected now.
--
You are receiving this mail because:
You are the assignee for the bug.
--
Andreas Christoforides created MTOMCAT-264:
--
Summary: uriEncoding parameter not applied to HTTPS connector
Key: MTOMCAT-264
URL: https://issues.apache.org/jira/browse/MTOMCAT-264
Project: Apac
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/5596
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
[
https://issues.apache.org/jira/browse/MTOMCAT-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Christoforides updated MTOMCAT-264:
---
Description:
The uriEncoding parameter does not work when using HTTPS with t
[
https://issues.apache.org/jira/browse/MTOMCAT-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935400#comment-13935400
]
Andreas Christoforides commented on MTOMCAT-237:
I was mistaken in my cas
Author: kkolinko
Date: Fri Mar 14 19:16:54 2014
New Revision: 1577665
URL: http://svn.apache.org/r1577665
Log:
1. Do not hardcode the path to output directory. It can be controlled via
build.properties.
2. Cleanup after the test.
Modified:
tomcat/trunk/test/org/apache/jasper/TestJspC.java
M
https://issues.apache.org/bugzilla/show_bug.cgi?id=56265
Bug ID: 56265
Summary: Unexpected escaping in the values of dynamic tag
attributes containing EL expressions
Product: Tomcat 7
Version: 7.0.52
Hardware: PC
https://issues.apache.org/bugzilla/show_bug.cgi?id=56265
--- Comment #1 from Konstantin Kolinko ---
Created attachment 31388
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31388&action=edit
test.war
A simple web application that reproduces this issue.
Steps to reproduce on 7.0.52:
1
https://issues.apache.org/bugzilla/show_bug.cgi?id=56265
Konstantin Kolinko changed:
What|Removed |Added
OS||All
--- Comment #2 from Konst
https://issues.apache.org/bugzilla/show_bug.cgi?id=56266
Bug ID: 56266
Summary: Property location incorrect in build instructions
Product: Tomcat 7
Version: 7.0.52
Hardware: PC
Status: NEW
Severity: minor
Priori
https://issues.apache.org/bugzilla/show_bug.cgi?id=56266
Konstantin Kolinko changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|-
Author: kkolinko
Date: Fri Mar 14 21:15:36 2014
New Revision: 1577714
URL: http://svn.apache.org/r1577714
Log:
Properly delete %TEMP%/ser{number}.tmp temporary file that was used to test
serialization of a Principal.
On Windows the test could not delete the file, because FileInputStream has not
Author: kkolinko
Date: Fri Mar 14 21:21:29 2014
New Revision: 1577721
URL: http://svn.apache.org/r1577721
Log:
Merged r1577714 from tomcat/trunk:
Properly delete %TEMP%/ser{number}.tmp temporary file that was used to test
serialization of a Principal.
On Windows the test could not delete the fil
Author: remm
Date: Fri Mar 14 23:13:00 2014
New Revision: 1577757
URL: http://svn.apache.org/r1577757
Log:
Implement the read/write pending contract in the SSL channel (not doing so
would likely still trigger the exception, but would add corruption).
Modified:
tomcat/trunk/java/org/apache/to
https://issues.apache.org/bugzilla/show_bug.cgi?id=56265
--- Comment #3 from Konstantin Kolinko ---
Thus far:
1. It is reproducible with the current trunk
The following line numbers are from debugging the reproducer with current trunk
@1577714.
2. 'setDynamicAttribute(' is written out at
Gener
https://issues.apache.org/bugzilla/show_bug.cgi?id=56265
Konstantin Kolinko changed:
What|Removed |Added
Severity|normal |regression
--
You are receiv
https://issues.apache.org/bugzilla/show_bug.cgi?id=56265
--- Comment #4 from Konstantin Kolinko ---
Created attachment 31390
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31390&action=edit
2014-03-15_56265_tc8_v1.patch
Patch for this issue.
Essentially it limits the effect of r15391
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
T
48 matches
Mail list logo
