Author: kkolinko
Date: Fri Mar 14 15:02:25 2014
New Revision: 1577562
URL: http://svn.apache.org/r1577562
Log:
Better reporting for skipped tests.
With org.junit.Assume the tests are clearly reported as 'skipped' in JUnit test
run summary.
Modified:
tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
Modified:
tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java?rev=1577562&r1=1577561&r2=1577562&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
Fri Mar 14 15:02:25 2014
@@ -41,6 +41,7 @@ import javax.servlet.http.HttpServletReq
import javax.servlet.http.HttpServletResponse;
import org.junit.Assert;
+import org.junit.Assume;
import org.junit.Test;
import org.apache.catalina.core.StandardContext;
@@ -91,11 +92,10 @@ public class TestNonBlockingAPI extends
public void testNonBlockingReadIgnoreIsReady() throws Exception {
// TODO Investigate options to get this test to pass with the HTTP BIO
// connector.
- if (getTomcatInstance().getConnector().getProtocol().equals(
- "org.apache.coyote.http11.Http11Protocol")) {
- throw new IOException(
- "Forced failure as this test requires true non-blocking
IO");
- }
+ Assume.assumeFalse(
+ "Skipping as this test requires true non-blocking IO",
+ getTomcatInstance().getConnector().getProtocol()
+ .equals("org.apache.coyote.http11.Http11Protocol"));
doTestNonBlockingRead(true);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
