On 13/03/2014 22:43, Konstantin Kolinko wrote:
> 1. addSelf() is odd, does not match with TC8. Bad merge?
Yes, it was a bad merge. I'll get that fixed.
> 2. Both add() and addSelf() should display a warning.
> Maybe move "log.warn()" into locationFor(..) method.
Good idea. Will do.
> 3. What is the point of putting null values into the maps.
There isn't a point. I'll get that fixed too.
> 4. Message:
>> digesterFactory.missingSchema=The XML schema [{0}] could not be found. This
>> is likely to break XML validation if enabled.
>
> It is ambiguous to what "if enabled" refers to (what is the subject
> for that verb).
I'll improve the wording.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
