svn commit: r1530172 - /tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 07:19:36 2013 New Revision: 1530172 URL: http://svn.apache.org/r1530172 Log: Remove completed TODOs Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java URL

svn commit: r1530178 - /tomcat/sandbox/storeconfig7/tags/0.0.1.Alpha3/

2013-10-08 Thread remm
Author: remm Date: Tue Oct 8 07:55:25 2013 New Revision: 1530178 URL: http://svn.apache.org/r1530178 Log: New storeconfig tag. Added: tomcat/sandbox/storeconfig7/tags/0.0.1.Alpha3/ - copied from r1530176, tomcat/sandbox/storeconfig7/trunk/

svn commit: r1530177 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java JIoEndpoint.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 07:55:22 2013 New Revision: 1530177 URL: http://svn.apache.org/r1530177 Log: Revert r1529130 and add a comment that explains why the sync is necessary. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomca

svn commit: r1530179 - /tomcat/sandbox/storeconfig6/tags/0.0.1.Alpha3/

2013-10-08 Thread remm
Author: remm Date: Tue Oct 8 07:55:58 2013 New Revision: 1530179 URL: http://svn.apache.org/r1530179 Log: New storeconfig tag. Added: tomcat/sandbox/storeconfig6/tags/0.0.1.Alpha3/ - copied from r1530178, tomcat/sandbox/storeconfig6/trunk/

svn commit: r1530180 - in /tomcat/sandbox: storeconfig6/tags/0.0.1.Alpha3/pom.xml storeconfig7/tags/0.0.1.Alpha3/pom.xml

2013-10-08 Thread remm
Author: remm Date: Tue Oct 8 07:56:57 2013 New Revision: 1530180 URL: http://svn.apache.org/r1530180 Log: Version number. Modified: tomcat/sandbox/storeconfig6/tags/0.0.1.Alpha3/pom.xml tomcat/sandbox/storeconfig7/tags/0.0.1.Alpha3/pom.xml Modified: tomcat/sandbox/storeconfig6/tags/0.0.

svn commit: r1530182 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 08:09:31 2013 New Revision: 1530182 URL: http://svn.apache.org/r1530182 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55633 for NIO. The Comet code that ensured that multiple threads didn't process the same socket when the selector indicated that a soc

svn commit: r1530183 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 08:10:38 2013 New Revision: 1530183 URL: http://svn.apache.org/r1530183 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55633 for APR. If the socket was registered for read and write and only one occurred, the registration for the other event was lost. E

svn commit: r1530184 - in /tomcat/tc7.0.x/trunk: ./ webapps/examples/WEB-INF/classes/websocket/snake/Snake.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 08:11:50 2013 New Revision: 1530184 URL: http://svn.apache.org/r1530184 Log: If the browser crashes or a similar event occurs writing messages will start failing. Rather than ignoring these failures, close the session. Modified: tomcat/tc7.0.x/trunk/ (props c

[Bug 55633] [websocket] Tomcat can't read data from the client after the client temporarily pauses

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55633 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1530213 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/config/context.xml

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 10:16:38 2013 New Revision: 1530213 URL: http://svn.apache.org/r1530213 Log: Fix an intermittent failure with TestWebappClassLoaderExecutorMemoryLeak. If the executor threads did not stop quickly enough, Thread.stop() was used. Sometimes this resulted in the executo

svn commit: r1530216 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/config/context.xml

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 10:34:19 2013 New Revision: 1530216 URL: http://svn.apache.org/r1530216 Log: Fix an intermittent failure with TestWebappClassLoaderExecutorMemoryLeak. If the executor threads did not stop quickly enough, Thread.stop() was used. Sometimes this resulted in the executo

svn commit: r1530217 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 10:36:17 2013 New Revision: 1530217 URL: http://svn.apache.org/r1530217 Log: Extend the test case to cover RequestProcessors Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/mbeans/TestRegistration.java Modified: tomcat/tc7.0.x/trunk/test/org/apache/cat

svn commit: r1530219 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 10:47:35 2013 New Revision: 1530219 URL: http://svn.apache.org/r1530219 Log: Some more false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.org/view

svn commit: r1530269 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 13:28:44 2013 New Revision: 1530269 URL: http://svn.apache.org/r1530269 Log: Ensure sendfile is enabled by default for APR. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoin

CI build issues

2013-10-08 Thread Mark Thomas
The CI builds have been taking 2-3 times longer than they should have. This has been triggering a number of timing related test failures. I took a look on the CI slave and it appears a couple of old builds were sat burning CPU cycles and generally slowing everything down. I have killed those build

RE: svn commit: r1530081 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-08 Thread Konstantin Preißer
Hi Mark, > -Original Message- > From: ma...@apache.org [mailto:ma...@apache.org] > Sent: Monday, October 7, 2013 11:44 PM > To: dev@tomcat.apache.org > Subject: svn commit: r1530081 - > /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java > > Author: markt > Date: Mon Oct 7 21:

[Bug 55639] Add Drawboard Websocket Example

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55639 --- Comment #2 from Mark Thomas --- Trunk (a.k.a. 8.0.x) is Commit-the-Review so go for it. So is 7.0.x for that matter, but I'd recommend against an immediate back-port. Get everything sorted in 8 and then back-port. -- You are receiving

Re: svn commit: r1530081 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-08 Thread Mark Thomas
On 08/10/2013 14:50, Konstantin Preißer wrote: > Hi Mark, > >> -Original Message- >> From: ma...@apache.org [mailto:ma...@apache.org] >> Sent: Monday, October 7, 2013 11:44 PM >> To: dev@tomcat.apache.org >> Subject: svn commit: r1530081 - >> /tomcat/trunk/java/org/apache/tomcat/util/net/A

buildbot success in ASF Buildbot on tomcat-trunk

2013-10-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5066 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1530298 [2/2] - in /tomcat/trunk/webapps/examples: WEB-INF/classes/websocket/drawboard/ WEB-INF/classes/websocket/drawboard/wsmessages/ websocket/

2013-10-08 Thread kpreisser
Modified: tomcat/trunk/webapps/examples/websocket/drawboard.xhtml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/websocket/drawboard.xhtml?rev=1530298&r1=1530297&r2=1530298&view=diff == --- tomcat/trunk/we

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 robc...@knowledgetree.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolu

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 robc...@knowledgetree.com changed: What|Removed |Added CC||robc...@knowledgetree.co

svn commit: r1530325 - in /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard: Client.java DrawboardEndpoint.java Room.java wsmessages/CloseWebsocketMessage.java

2013-10-08 Thread kpreisser
Author: kpreisser Date: Tue Oct 8 16:01:28 2013 New Revision: 1530325 URL: http://svn.apache.org/r1530325 Log: Improve Drawboard Example: - Check if buffered messages exceed a specific size, to avoid a DoS. - Combine buffered string message to reduce TCP overhead when sending them. Added: t

[Bug 55639] Add Drawboard Websocket Example

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55639 Konstantin Preißer changed: What|Removed |Added Component|Examples|Examples Product|T

svn commit: r1530342 - in /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard: DrawboardEndpoint.java Room.java

2013-10-08 Thread kpreisser
Author: kpreisser Date: Tue Oct 8 16:39:40 2013 New Revision: 1530342 URL: http://svn.apache.org/r1530342 Log: - Use "100" as maximum number of players instead of "2" that was for debug purposes only. - If a player couldn't enter the room, close the connection. Modified: tomcat/trunk/webap

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 --- Comment #10 from Christopher Schultz --- Note that I tested this with Tomcat 8 trunk. $ keytool -genkey -alias tomcat -keystore ~/.keystore -keyalg RSA -keysize 4096 Enter keystore password: Re-enter new password: What is your firs

svn commit: r1530348 - /tomcat/trunk/webapps/examples/websocket/drawboard.xhtml

2013-10-08 Thread kpreisser
Author: kpreisser Date: Tue Oct 8 16:53:39 2013 New Revision: 1530348 URL: http://svn.apache.org/r1530348 Log: Fix error in JavaScript code. Modified: tomcat/trunk/webapps/examples/websocket/drawboard.xhtml Modified: tomcat/trunk/webapps/examples/websocket/drawboard.xhtml URL: http://svn.a

[Bug 55639] Add Drawboard Websocket Example

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55639 --- Comment #4 from Christopher Schultz --- Is there any reason to bother sending a PNG image to begin with? Why not just store all the mutations (i.e. draw commands) on the server and send those to the clients when they connect? If you did

[Bug 55639] Add Drawboard Websocket Example

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55639 --- Comment #5 from Konstantin Preißer --- Hi Christopher, (In reply to Christopher Schultz from comment #4) > Is there any reason to bother sending a PNG image to begin with? Why not > just store all the mutations (i.e. draw commands) on

svn commit: r1530354 - /tomcat/trunk/webapps/docs/changelog.xml

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 17:11:02 2013 New Revision: 1530354 URL: http://svn.apache.org/r1530354 Log: Tab police Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xm

svn commit: r1530355 - /tomcat/trunk/webapps/docs/changelog.xml

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 17:12:07 2013 New Revision: 1530355 URL: http://svn.apache.org/r1530355 Log: More tab police Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changel

svn commit: r1530353 - in /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard: Client.java DrawMessage.java DrawboardEndpoint.java Room.java wsmessages/CloseWebsocketMessage.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 17:09:29 2013 New Revision: 1530353 URL: http://svn.apache.org/r1530353 Log: Add missing license header. Remove trailing whitespace. Fix Javadoc errors. Remove some blank lines. Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Client.

setting handler in AbstractEndpont

2013-10-08 Thread Niki Dokovski
Hi, Is there a good reason why AbstractEndpoint in coyote does not have an association with Handler through an abstract getter and setter? All concrete implementations of AbstractEndpoint [AprEndpoint,JIoEndpoint,NioEndpoint] provide a getter and a setter of a AbstractEndpoint.Handler Cheers Niki

Re: setting handler in AbstractEndpont

2013-10-08 Thread Mark Thomas
On 08/10/2013 19:46, Niki Dokovski wrote: > Hi, > Is there a good reason why AbstractEndpoint in coyote does not have an > association with Handler through an abstract getter and setter? All > concrete implementations of AbstractEndpoint > [AprEndpoint,JIoEndpoint,NioEndpoint] provide a getter and

Re: setting handler in AbstractEndpont

2013-10-08 Thread Niki Dokovski
On Tue, Oct 8, 2013 at 9:52 PM, Mark Thomas wrote: > On 08/10/2013 19:46, Niki Dokovski wrote: > > Hi, > > Is there a good reason why AbstractEndpoint in coyote does not have an > > association with Handler through an abstract getter and setter? All > > concrete implementations of AbstractEndpoin

svn commit: r1530399 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/upgrade/NioServletOutputStream.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 19:18:49 2013 New Revision: 1530399 URL: http://svn.apache.org/r1530399 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55638 Fix the corruption of large WebSocket messages when using the NIO connector. Modified: tomcat/tc7.0.x/trunk/ (props change

svn commit: r1530397 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/NioServletOutputStream.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 19:18:04 2013 New Revision: 1530397 URL: http://svn.apache.org/r1530397 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55638 Fix the corruption of large WebSocket messages when using the NIO connector. Modified: tomcat/trunk/java/org/apache/coyote/

svn commit: r1530418 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 20:56:49 2013 New Revision: 1530418 URL: http://svn.apache.org/r1530418 Log: Clear the handler then close the connection so the handler gets to the the exception that caused the problem rather than any exception that may happen during close. Modified: tomcat/

svn commit: r1530421 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 21:03:15 2013 New Revision: 1530421 URL: http://svn.apache.org/r1530421 Log: Fix infinite loop issue triggered by the test case for BZ 55638 Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java Modified: tomcat/trunk/java/org/apache/tomcat/w

[Bug 55638] [websocket] Tomcat corrupts binary websocket messages when using the NIO connector

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55638 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas

svn commit: r1530423 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 21:07:23 2013 New Revision: 1530423 URL: http://svn.apache.org/r1530423 Log: Whoops. Remove the debug code. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java URL: h

svn commit: r1530426 - /tomcat/trunk/webapps/examples/WEB-INF/web.xml

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 21:11:49 2013 New Revision: 1530426 URL: http://svn.apache.org/r1530426 Log: Add .xhtml to the welcome files for the examples webapp Modified: tomcat/trunk/webapps/examples/WEB-INF/web.xml Modified: tomcat/trunk/webapps/examples/WEB-INF/web.xml URL: http://svn

RE: svn commit: r1530081 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-08 Thread Konstantin Preißer
Hi Mark, > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, October 8, 2013 3:57 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1530081 - > /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java > > > None. I've seem the same problem

svn commit: r1530436 - /tomcat/trunk/webapps/examples/WEB-INF/web.xml

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 21:47:15 2013 New Revision: 1530436 URL: http://svn.apache.org/r1530436 Log: Ensure the examples webapp starts when validation is enabled. Modified: tomcat/trunk/webapps/examples/WEB-INF/web.xml Modified: tomcat/trunk/webapps/examples/WEB-INF/web.xml URL: http

svn commit: r1530445 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 22:05:17 2013 New Revision: 1530445 URL: http://svn.apache.org/r1530445 Log: Fix the fix in r1530423 Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java URL: http://s

svn commit: r1530449 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 22:32:33 2013 New Revision: 1530449 URL: http://svn.apache.org/r1530449 Log: Clear the handler then close the connection so the handler gets to the the exception that caused the problem rather than any exception that may happen during close. Modified: tomcat/t

svn commit: r1530448 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 22:31:52 2013 New Revision: 1530448 URL: http://svn.apache.org/r1530448 Log: Move comment to go with code that was moved earlier Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java Modified: tomcat/tc7.0.x/tr

svn commit: r1530451 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java

2013-10-08 Thread markt
Author: markt Date: Tue Oct 8 22:34:19 2013 New Revision: 1530451 URL: http://svn.apache.org/r1530451 Log: Fix infinite loop issue triggered by the test case for BZ 55638 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/WsFrameBase.j

[Bug 55638] [websocket] Tomcat corrupts binary websocket messages when using the NIO connector

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55638 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

RE: svn commit: r1530081 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-08 Thread Konstantin Preißer
Mark, > > -Original Message- > > From: Mark Thomas [mailto:ma...@apache.org] > > Sent: Tuesday, October 8, 2013 3:57 PM > > To: Tomcat Developers List > > Subject: Re: svn commit: r1530081 - > > /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java > > > > > > None. I've seem the

Proposal for a more flexible tomcat embedding api

2013-10-08 Thread Adib Saikali
Hi, I am a long time tomcat user over the past few months I have started to use embedded tomcat, in the process I have discovered a few limitations and I want to make the following proposal to fix these issues. Tomcat Builder Proposal: This proposal outline

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 --- Comment #12 from saurabh --- Created attachment 30912 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30912&action=edit HTTP 0.9 response from the server I tried the identical steps that have been provided and the browser re