Re: svn commit: r995901 - /tomcat/jk/trunk/native/common/portable.h

2010-09-11 Thread William A. Rowe Jr.
On 9/11/2010 12:23 AM, Mladen Turk wrote: > On 09/10/2010 08:06 PM, William A. Rowe Jr. wrote: >> On 9/10/2010 12:48 PM, mt...@apache.org wrote: >>> Author: mturk >>> Date: Fri Sep 10 17:48:15 2010 >>> New Revision: 995901 >>> >>> URL: http://svn.apache.org/viewvc?rev=995901&view=rev >>> Log: >>> O

Re: svn commit: r995901 - /tomcat/jk/trunk/native/common/portable.h

2010-09-11 Thread Mladen Turk
On 09/11/2010 09:54 AM, William A. Rowe Jr. wrote: So, dunno if we need to ship that at the first place. Sounds like not. This might be a good point to drop it and let people confirm that it isn't used? +1 Regards -- ^TM ---

svn commit: r996112 - in /tomcat/trunk/java/org/apache/catalina/startup: EngineRuleSet.java HostRuleSet.java

2010-09-11 Thread markt
Author: markt Date: Sat Sep 11 09:48:32 2010 New Revision: 996112 URL: http://svn.apache.org/viewvc?rev=996112&view=rev Log: Remove unnecessary digester configuration hostConfigClass and engineConfigClass were removed before 6.0.x Modified: tomcat/trunk/java/org/apache/catalina/startup/Engine

svn commit: r996114 - in /tomcat/trunk/java/org/apache/catalina/startup: EngineRuleSet.java HostRuleSet.java

2010-09-11 Thread markt
Author: markt Date: Sat Sep 11 10:17:07 2010 New Revision: 996114 URL: http://svn.apache.org/viewvc?rev=996114&view=rev Log: Revert r996112. At least some of that config is required. Modified: tomcat/trunk/java/org/apache/catalina/startup/EngineRuleSet.java tomcat/trunk/java/org/apache/ca

svn commit: r996117 - /tomcat/trunk/java/org/apache/catalina/startup/LifecycleListenerRule.java

2010-09-11 Thread markt
Author: markt Date: Sat Sep 11 10:44:50 2010 New Revision: 996117 URL: http://svn.apache.org/viewvc?rev=996117&view=rev Log: Fix an issue where elements defined in server.xml did not use the configClass specified by the parent element Modified: tomcat/trunk/java/org/apache/catalina/startup

Re: [VOTE] Release Tomcat 5.5.31 Build

2010-09-11 Thread Jim Jagielski
On Sep 8, 2010, at 10:50 AM, Jim Jagielski wrote: > The builds for Tomcat 5.5.31 are ready for testing and approval. > The candidates binaries are available here: > > http://people.apache.org/~jim/tomcat-5.5/ > > According to the release process, the 5.5.31 build corresponding to the > tag TOM

Re: [VOTE] Release Tomcat 5.5.31 Build

2010-09-11 Thread Rainer Jung
On 08.09.2010 16:50, Jim Jagielski wrote: The builds for Tomcat 5.5.31 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.31 build corresponding to the tag TOMCAT_5_5_31 [1] is:

Re: [VOTE] Release Tomcat 5.5.31 Build

2010-09-11 Thread Mladen Turk
According to the release process, the 5.5.31 build corresponding to the tag TOMCAT_5_5_31 [1] is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additio

Re: [VOTE] Release Tomcat 5.5.31 Build

2010-09-11 Thread Mark Thomas
On 08/09/2010 15:50, Jim Jagielski wrote: > The builds for Tomcat 5.5.31 are ready for testing and approval. > The candidates binaries are available here: > > http://people.apache.org/~jim/tomcat-5.5/ > > According to the release process, the 5.5.31 build corresponding to the > tag TOMCAT_5_5_3

svn commit: r996159 - /tomcat/trunk/webapps/docs/changelog.xml

2010-09-11 Thread markt
Author: markt Date: Sat Sep 11 15:47:01 2010 New Revision: 996159 URL: http://svn.apache.org/viewvc?rev=996159&view=rev Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/we

svn commit: r996160 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-09-11 Thread markt
Author: markt Date: Sat Sep 11 15:53:15 2010 New Revision: 996160 URL: http://svn.apache.org/viewvc?rev=996160&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=996

svn commit: r996163 - in /tomcat/trunk: build.properties.default webapps/docs/changelog.xml

2010-09-11 Thread markt
Author: markt Date: Sat Sep 11 16:32:02 2010 New Revision: 996163 URL: http://svn.apache.org/viewvc?rev=996163&view=rev Log: Update commons pool to 1.5.5 Modified: tomcat/trunk/build.properties.default tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/build.properties.defaul

svn commit: r996164 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-09-11 Thread markt
Author: markt Date: Sat Sep 11 16:33:11 2010 New Revision: 996164 URL: http://svn.apache.org/viewvc?rev=996164&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=996

Re: Can jsp-file be a JspServlet init-param?

2010-09-11 Thread Mark Thomas
On 11/09/2010 07:20, David Jencks wrote: > > On Sep 8, 2010, at 11:48 PM, Mark Thomas wrote: > >> On 09/09/2010 00:54, David Jencks wrote: >>> I've recently rewritten the geronimo-jetty integration to work off the >>> servlet 3 *Registration classes. This works great except for servlets >>> ba

DO NOT REPLY [Bug 49811] [PATCH] Disable UrlRewriting

2010-09-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49811 --- Comment #10 from Mark Thomas 2010-09-11 13:13:15 EDT --- Functionally, the patch looks good to me and I'd propose it for Tomcat if it wasn't for some minor cosmetic issues: - use 4 spaces rather than tabs - setDisableURLRewriting(boolea

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-09-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #91 from Mark Thomas 2010-09-11 13:18:01 EDT --- Please enable validation in your build process and ensure in future that patch you provide build with validation enabled. This one had a number of tabs that needs to be replaced w

DO NOT REPLY [Bug 49811] [PATCH] Disable UrlRewriting

2010-09-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49811 --- Comment #11 from Wesley 2010-09-11 13:27:48 EDT --- (In reply to comment #10) > - use 4 spaces rather than tabs Em do you have a style guide? If theres any code formatters I can use for eclipse that would be great. Then I can just us

DO NOT REPLY [Bug 49811] [PATCH] Disable UrlRewriting

2010-09-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49811 --- Comment #12 from Mark Thomas 2010-09-11 13:39:50 EDT --- (In reply to comment #11) > Em do you have a style guide? If theres any code formatters I can use for > eclipse that would be great. Then I can just use the format shortcut. 'fra

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-09-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #92 from Mark Thomas 2010-09-11 13:51:37 EDT --- The patch is heading in the right direction and I am tempted to commit it. However, I see a bunch of stack traces in the logs when I try to start a Context so I think there is sti

DO NOT REPLY [Bug 49811] [PATCH] Disable UrlRewriting

2010-09-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49811 Wesley changed: What|Removed |Added Attachment #25961|0 |1 is obsolete|

Re: Proposed .dsp and source change to jk for apache 2.0

2010-09-11 Thread Tim Whittington
+1 from me. I've been maintaining my own VS 2003 (and now 2005) solution for a while now with Apache 2.0/2.2 projects. cheers tim On Thu, Sep 9, 2010 at 4:51 AM, William A. Rowe Jr. wrote: > It seems I've been lax in committing anything in recent memory, and had my > commit privileges for the j

svn commit: r996235 - /tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml

2010-09-11 Thread markt
Author: markt Date: Sun Sep 12 01:38:30 2010 New Revision: 996235 URL: http://svn.apache.org/viewvc?rev=996235&view=rev Log: Fix typos. Remove attributes that don't exist. Add a missing attribute. Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml Modified: tomcat/tr

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-09-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #93 from Mark Thomas 2010-09-11 21:44:59 EDT --- I got to the bottom of the problem. The correct parent class loader was not being passed down the object hierarchy. I fixed that and applied your patch. I can now get to the point