https://issues.apache.org/bugzilla/show_bug.cgi?id=49811

--- Comment #10 from Mark Thomas <ma...@apache.org> 2010-09-11 13:13:15 EDT ---
Functionally, the patch looks good to me and I'd propose it for Tomcat if it
wasn't for some minor cosmetic issues:
- use 4 spaces rather than tabs
- setDisableURLRewriting(boolean allow) is confusing.
setDisableURLRewriting(boolean disable) would be better

Fix those and I'll propose it for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to