+1 from me.

I've been maintaining my own VS 2003 (and now 2005) solution for a while now
with Apache 2.0/2.2 projects.

cheers
tim

On Thu, Sep 9, 2010 at 4:51 AM, William A. Rowe Jr. <wr...@rowe-clan.net>wrote:

> It seems I've been lax in committing anything in recent memory, and had my
> commit privileges for the jk module suspended :)  But wanted to pass on
> these
> very small proposals;
>
>  * mod_jk.dsp should have referred to a project 'named' mod_jk, the
> 'project
>   name' should generally match the name of the .dsp file itself.
>
>  * mod_jk.dsp would benefit from having 'mod_jk - Win32 Release httpd 2.2'
>   targets, so that we can build either for httpd 2.0 or 2.2 without making
>   any changes to the library references (libapr.lib vs libapr-1.lib).
>   In any case, having a default to 2.0 seems awfully archaic now :)
>
>  * mod_jk.c conditionally compiled for map_to_storage.  That hook predated
>   the beta and GA of httpd 2.0, so leaving such a test in place is likely
>   confusing to the more casual reviewer.
>
> I'm happy to commit this myself, if the team will entertain restoring my
> commit bit to the connectors tree and folks are happy with the suggestions.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Reply via email to