DO NOT REPLY [Bug 49625] New: Tomcat doesn't send Vary consistently when gzip enabled

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49625 Summary: Tomcat doesn't send Vary consistently when gzip enabled Product: Tomcat 6 Version: 6.0.28 Platform: PC OS/Version: Linux Status: NEW Severi

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-21 Thread Mark Thomas
On 20/07/2010 11:14, Rainer Jung wrote: > On 20.07.2010 08:35, jean-frederic clere wrote: >> On 07/19/2010 07:16 PM, Mark Thomas wrote: >>> On 18/07/2010 23:50, Rainer Jung wrote: On 18.07.2010 02:02, Mark Thomas wrote: > On 18/07/2010 00:57, ma...@apache.org wrote: >> Author: markt >>

svn commit: r966131 - /tomcat/trunk/build.xml

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 08:12:37 2010 New Revision: 966131 URL: http://svn.apache.org/viewvc?rev=966131&view=rev Log: Eclipse sample files need to have correct (platform specific) line endings in src distributions. Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL

svn commit: r966134 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 08:17:34 2010 New Revision: 966134 URL: http://svn.apache.org/viewvc?rev=966134&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=966

Re: [VOTE] Release build 6.0.29

2010-07-21 Thread Keiichi Fujino
2010/7/20 jean-frederic clere : > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.29/ > > According to the release process, the 6.0.29 build corresponding to the > tag TOMCAT_6_0_29 is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable > Tested tar.gz b

svn commit: r966149 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-21 Thread kkolinko
Author: kkolinko Date: Wed Jul 21 09:14:37 2010 New Revision: 966149 URL: http://svn.apache.org/viewvc?rev=966149&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=9661

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-21 Thread Rainer Jung
On 21.07.2010 09:40, Mark Thomas wrote: On 20/07/2010 11:14, Rainer Jung wrote: So: the default we use is 1, but if the timeout were<=0 then I think the condition in the AsyncTimeout runnable would fail. Agreed. That matches with what I was observing. I have no idea if a default timeout o

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-21 Thread Mark Thomas
On 21/07/2010 10:18, Rainer Jung wrote: > On 21.07.2010 09:40, Mark Thomas wrote: >> On 20/07/2010 11:14, Rainer Jung wrote: >>> So: the default we use is 1, but if the timeout were<=0 then I >>> think the condition in the AsyncTimeout runnable would fail. >> >> Agreed. That matches with what I

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-21 Thread Remy Maucherat
On Wed, 2010-07-21 at 11:18 +0200, Rainer Jung wrote: > IMHO for any serious application of async the developer will need to > adjust the timeout. I am responsible for the fact that setting the timeout is separate, as I did not understand how it was meaningful in most cases to have it be anything

Re: [VOTE] Release build 6.0.29

2010-07-21 Thread Mark Thomas
On 19/07/2010 17:33, jean-frederic clere wrote: > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.29/ > > According to the release process, the 6.0.29 build corresponding to the > tag TOMCAT_6_0_29 is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable

svn commit: r966164 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-21 Thread jfclere
Author: jfclere Date: Wed Jul 21 10:13:31 2010 New Revision: 966164 URL: http://svn.apache.org/viewvc?rev=966164&view=rev Log: my vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=9

svn commit: r966177 - in /tomcat/trunk/webapps/docs/config: cluster-manager.xml cluster.xml

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 10:58:56 2010 New Revision: 966177 URL: http://svn.apache.org/viewvc?rev=966177&view=rev Log: Add note about message processing order. Modified: tomcat/trunk/webapps/docs/config/cluster-manager.xml tomcat/trunk/webapps/docs/config/cluster.xml Modified: tomc

svn commit: r966178 - /tomcat/trunk/webapps/docs/config/cluster-manager.xml

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 10:59:31 2010 New Revision: 966178 URL: http://svn.apache.org/viewvc?rev=966178&view=rev Log: Correct explanation. mapSendOptions=6 is synchronous, not asynchronous. Modified: tomcat/trunk/webapps/docs/config/cluster-manager.xml Modified: tomcat/trunk/webapps/d

Re: [VOTE] Release build 6.0.29

2010-07-21 Thread Konstantin Kolinko
2010/7/19 jean-frederic clere : > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.29/ > > According to the release process, the 6.0.29 build corresponding to the > tag TOMCAT_6_0_29 is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable > Best regards, K

svn commit: r966184 - in /tomcat/tc6.0.x/trunk/webapps/docs/config: cluster-manager.xml cluster.xml

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 11:31:18 2010 New Revision: 966184 URL: http://svn.apache.org/viewvc?rev=966184&view=rev Log: Merge cluster doc updates from trunk - correct description for backup default - add note about message ordering with async Modified: tomcat/tc6.0.x/trunk/webapps/docs/c

DO NOT REPLY [Bug 49625] Tomcat doesn't send Vary consistently when gzip enabled

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49625 --- Comment #1 from Ferenc Lutischan 2010-07-21 07:33:47 EDT --- A test url: http://redbot.org/?uri=http://dictzone.com/english-german-dictionary/ -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- Y

win an i phone

2010-07-21 Thread sameer ch
If u want to win an i phone just register_http://www.e-castig.com/index.php?r=81P6m

svn commit: r966292 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 16:09:41 2010 New Revision: 966292 URL: http://svn.apache.org/viewvc?rev=966292&view=rev Log: Return copies of the URL array rather than the original. This facilitated CVE-2010-1622 although the root cause was in the Spring Framework. Returning a copy in this case

svn commit: r966293 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 16:11:20 2010 New Revision: 966293 URL: http://svn.apache.org/viewvc?rev=966293&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=966

svn commit: r966294 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt dist.xml webapps/docs/changelog.xml

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 16:14:18 2010 New Revision: 966294 URL: http://svn.apache.org/viewvc?rev=966294&view=rev Log: Fix line endings for Eclipse files in src distro Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/dist.xml

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #65 from Mark Thomas 2010-07-21 12:19:16 EDT --- (In reply to comment #64) > Currently I am bit stuck on above. Any ideas on this? I'd start by looking at the MBeans for the components that currently have separate MBeans. --

svn commit: r966304 - in /tomcat/trunk: java/org/apache/catalina/filters/ExpiresFilter.java test/org/apache/catalina/filters/TestExpiresFilter.java webapps/docs/changelog.xml webapps/docs/config/filte

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 16:37:58 2010 New Revision: 966304 URL: http://svn.apache.org/viewvc?rev=966304&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49617 Correct the ExpiresFilter documentation after changes to the submitted patch Modified: tomcat/trunk/java/or

DO NOT REPLY [Bug 49617] Fix ExpiresFilter docs (remove remaining ExpiresActive reference)

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49617 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49165] Enhancement - Allow %{TIME_FORMAT}t As Configuration for AccessLogValve

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49165 --- Comment #5 from Mark Thomas 2010-07-21 13:47:59 EDT --- (In reply to comment #4) Thanks for the patch. I have reviewed it and have the following comments: 1. It uses a mix of tabs and spaces for indenting. Only spaces should be used. 2

DO NOT REPLY [Bug 49600] Bad exception thrown by ProxyDirContext.lookup

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49600 --- Comment #1 from Mark Thomas 2010-07-21 14:05:57 EDT --- The gain by using notFoundException is in GC. It prevents exception objects being created for resources that don't exist. I agree it could be static (final too). -- Configure bug

DO NOT REPLY [Bug 49631] New: Custom DatabaseResourceProvider extension cannot get app context JNDI resources

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49631 Summary: Custom DatabaseResourceProvider extension cannot get app context JNDI resources Product: Tomcat 6 Version: 6.0.28 Platform: PC OS/Version: Windows NT

svn commit: r966404 - in /tomcat/trunk: java/org/apache/naming/resources/ webapps/docs/

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 20:30:53 2010 New Revision: 966404 URL: http://svn.apache.org/viewvc?rev=966404&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49600 Return a consistent exception for 'Not Found' resources. Modified: tomcat/trunk/java/org/apache/naming/reso

svn commit: r966405 - /tomcat/trunk/test/org/apache/naming/resources/TestProxyDirContext.java

2010-07-21 Thread markt
Author: markt Date: Wed Jul 21 20:31:30 2010 New Revision: 966405 URL: http://svn.apache.org/viewvc?rev=966405&view=rev Log: Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49600 Based on a patch by Marc Guillemot Added: tomcat/trunk/test/org/apache/naming/resources/TestProxy

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-21 Thread Mark Thomas
On 21/07/2010 10:47, Remy Maucherat wrote: > On Wed, 2010-07-21 at 11:18 +0200, Rainer Jung wrote: >> IMHO for any serious application of async the developer will need to >> adjust the timeout. > > I am responsible for the fact that setting the timeout is separate, as I > did not understand how i

DO NOT REPLY [Bug 49600] Bad exception thrown by ProxyDirContext.lookup

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49600 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

2010-07-21 Thread Remy Maucherat
On Wed, 2010-07-21 at 21:36 +0100, Mark Thomas wrote: > I take it that this means you think there is room for simplification. > I'm still trying to get my head around the Async implementation so if > you have any pointers on how it could be simplified, they would be much > appreciated. Ok, so for

DO NOT REPLY [Bug 49631] Custom DatabaseResourceProvider extension cannot get app context JNDI resources

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49631 --- Comment #1 from Matt 2010-07-21 17:58:25 EDT --- Created an attachment (id=25793) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25793) stack trace This is a stack trace for the request that fails to find the jndi context e

DO NOT REPLY [Bug 49631] Custom DatabaseResourceProvider extension cannot get app context JNDI resources

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49631 --- Comment #2 from Matt 2010-07-21 18:01:15 EDT --- Looking into this a bit more I noticed that when the JNDI lookup fails, its calling my FileDirContext without having gone through the default servlet (see attached stack trace). Looks l

svn commit: r966477 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-21 Thread kfujino
Author: kfujino Date: Thu Jul 22 01:45:20 2010 New Revision: 966477 URL: http://svn.apache.org/viewvc?rev=966477&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=96647

DO NOT REPLY [Bug 49422] hudson does not work on tomcat 7.0.0 rc4

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49422 Kohsuke Kawaguchi changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|IN

DO NOT REPLY [Bug 49422] hudson does not work on tomcat 7.0.0 rc4

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49422 Bill Barker changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 49635] New: org.apache.catalina.connector.RequestFacade has wrong implementation...

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49635 Summary: org.apache.catalina.connector.RequestFacade has wrong implementation... Product: Tomcat 7 Version: 7.0.0 Platform: PC Status: NEW Severity: normal

DO NOT REPLY [Bug 49567] when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 Mark Thomas changed: What|Removed |Added CC||den04...@gmail.com --- Comment #6 fr

DO NOT REPLY [Bug 49635] org.apache.catalina.connector.RequestFacade has wrong implementation...

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49635 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49600] Bad exception thrown by ProxyDirContext.lookup

2010-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49600 --- Comment #3 from Marc Guillemot 2010-07-22 02:50:00 EDT --- Can you explain why GC gain are considered at this special place in detriment of a correct exception? For me if GC gain is an argument, then there are so many other places in