On 21.07.2010 09:40, Mark Thomas wrote:
On 20/07/2010 11:14, Rainer Jung wrote:
So: the default we use is 10000, but if the timeout were<=0 then I
think the condition in the AsyncTimeout runnable would fail.
Agreed. That matches with what I was observing.
I have no idea if a default timeout of 10s is appropriate for Async
requests or not. It seems like a good place to start but I'd be fine
with 60s too. The advantage of a shorter timeout is that when tests
fail, they fail relatively quickly.
IMHO for any serious application of async the developer will need to
adjust the timeout. A very long default is of no real use as a timeout,
so I'd be fine with the 10 seconds we have now. Yes, many use cases will
fire the timeout though they want to wait longer, but at least they get
aware they need to adjust.
Once we've finalized this we need to add the asyncTimeout description to
the connectors config docs (though IMHO when people start to use
different async use cases in parallel, a connector configuration will no
longer be enough and they have to set the timeout via the AsyncContext API).
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
