https://issues.apache.org/bugzilla/show_bug.cgi?id=49165
--- Comment #5 from Mark Thomas <ma...@apache.org> 2010-07-21 13:47:59 EDT --- (In reply to comment #4) Thanks for the patch. I have reviewed it and have the following comments: 1. It uses a mix of tabs and spaces for indenting. Only spaces should be used. 2. Log messages should use the StringManager to provide i18n support. 3. Setting currentDate in the AccessDateStruct serves no purpose 4. Same for currentDateString 5. DateAndTimeElementVolumeTest can probably be added to the existing Benchmarks test. Out of curiosity, if you remove the code that manages the only creating the date once a second entirely and use a date format that does not include millis, what is the performance like? I'm wondering if we can just remove that code entirely. If you can update the patch, I'll take another look. With the issues above fixed it should be ready to apply. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
