(tomcat) 01/01: Merge pull request #842 from jengebr/nonstandard_tags

2025-04-16 Thread jengebr
eng...@users.noreply.github.com> AuthorDate: Wed Apr 16 14:53:40 2025 -0500 Merge pull request #842 from jengebr/nonstandard_tags Adding nonstandard support for c:set and c:remove java/org/apache/jasper/EmbeddedServletOptions.java | 12 ++ java/org/apache/jasper/JspC.java | 19 ++

(tomcat-training) 01/01: Merge pull request #34 from jbampton/fix-spelling

2025-04-01 Thread markt
:22 2025 +0100 Merge pull request #34 from jbampton/fix-spelling misc: fix spelling modules/tls-03.html | 2 +- modules/tomcat-11-jakarta-ee-11.html | 4 ++-- modules/tomcat-11-preview.html | 10 +- res/tls-03/script.txt| 4 ++-- 4

(tomcat-tck) 01/01: Merge pull request #2 from adoroszlai/snapshots-only

2025-03-31 Thread markt
2025 +0100 Merge pull request #2 from adoroszlai/snapshots-only prefer central repo, disable releases for asf-snapshots pom.xml | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) - To unsubscribe, e

[Bug 69610] New: Consider implementing support for upgrade-insecure-requests request header and conditional HSTS

2025-03-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69610 Bug ID: 69610 Summary: Consider implementing support for upgrade-insecure-requests request header and conditional HSTS Product: Tomcat 11 Version: unspecified

[Bug 69604] Catalina connector request does not adhere to RFC 7232 3.3 (If-Modified-Since)

2025-03-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69604 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 69604] New: Catalina connector request does not adhere to RFC 7232 3.3 (If-Modified-Since)

2025-03-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69604 Bug ID: 69604 Summary: Catalina connector request does not adhere to RFC 7232 3.3 (If-Modified-Since) Product: Tomcat 10 Version: 10.1.34 Hardware: All

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-14 Thread via GitHub
dsoumis commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2658927616 Indeed Mark, that's a fair point. I've refactored the order as suggested in: [commit](https://github.com/apache/tomcat/commit/e451872) . -- This is an automated message from the Apache Git

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-14 Thread via GitHub
markt-asf commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2658848926 I echo n828cl's concerns about calling `isSameOrigin()` before `isValidOrigin()`. I can't see an obvious issue but swapping the order of those two checks is going to be a lot faster than d

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
koust6u commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657908424 @n828cl Which part do you find harder to follow? If you could clarify, it would help me understand better. I also believe that calling `isSameOrigin()` before `isValidOrigin()`

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
dsoumis commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657902498 The revised code, though less nested, adheres to the CORS flow as specified. In my opinion, this structure offers a more maintainable and understandable implementation. Also the ordering

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
n828cl commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657751803 If this were to be merged, the CORS flowchart should be updated accordingly. See ![](https://tomcat.apache.org/tomcat-11.0-doc/images/cors-flowchart.png) -- This is an automated mes

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
n828cl commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657748693 I'm not sure that the revised code properly implements the spec. (Unfortunately, the current spec is much harder to follow than the previous iteration.) Also, calling IsSameOrigin() before is

(tomcat) branch 9.0.x updated: Clean up check CORS request type method (#826)

2025-02-13 Thread dsoumis
This is an automated email from the ASF dual-hosted git repository. dsoumis pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3d967dddad Clean up check CORS request type

(tomcat) branch 11.0.x updated: Clean up check CORS request type method (#826)

2025-02-13 Thread dsoumis
This is an automated email from the ASF dual-hosted git repository. dsoumis pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 73d5ee6afd Clean up check CORS request type

(tomcat) branch 10.1.x updated: Clean up check CORS request type method (#826)

2025-02-13 Thread dsoumis
This is an automated email from the ASF dual-hosted git repository. dsoumis pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new ad2f570cde Clean up check CORS request type

(tomcat) branch main updated: Clean up check CORS request type method (#826)

2025-02-13 Thread dsoumis
This is an automated email from the ASF dual-hosted git repository. dsoumis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a4ccdba4bf Clean up check CORS request type method

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
dsoumis merged PR #826: URL: https://github.com/apache/tomcat/pull/826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-12 Thread via GitHub
koust6u opened a new pull request, #826: URL: https://github.com/apache/tomcat/pull/826 This PR refactors the checkRequestType method in the CORS filter to simplify and improve the readability of the request type determination logic. The main changes are: + Early Returns: The code

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2025-02-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #12 from Chen Jp --- Would to know how apache httpd server deal cleanup ops. // I'm not a C fan. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2025-02-10 Thread bugzilla
and DBCP provides a range of options to enabled applications to select the strategy that works best for them. This proposal might protect against some Tomcat bugs in some circumstances but at the price of a performance penalty for every single request. I might be convinced that such a trade-off was

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2025-02-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #10 from Chen Jp --- see https://github.com/apache/tomcat/pull/822 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-m

[Bug 69504] CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2025-02-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 --- Comment #4 from Chen Jp --- see PR 821. https://github.com/apache/tomcat/pull/821 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscri

[Bug 69504] CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2025-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 --- Comment #3 from Mark Thomas --- If you want to propose a refactoring then please provide a patch for review. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2025-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #9 from Mark Thomas --- It will also have a negative impact on performance. The more I think about this, the more I am leaning towards WONTFIX. -- You are receiving this mail because: You are the assignee for the bug. ---

(tomcat) 01/02: Add ParameterLimitValve to enforce request parameter limits for specific URLs (#753)

2025-01-30 Thread dsoumis
ParameterLimitValve to enforce request parameter limits for specific URLs (#753) Introduce ParameterLimitValve to enforce request parameter limits - Added `ParameterLimitValve`, a new valve that allows enforcing limits on the number of parameters in HTTP requests. - Supports

Re: [PR] Add ParameterLimitValve to enforce request parameter limits for specific URLs [tomcat]

2025-01-29 Thread via GitHub
dsoumis merged PR #753: URL: https://github.com/apache/tomcat/pull/753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: [PR] Add ParameterLimitValve to enforce request parameter limits for specific URLs [tomcat]

2025-01-23 Thread via GitHub
x.Pattern; + +import jakarta.servlet.ServletException; + +import org.apache.catalina.connector.Request; +import org.apache.catalina.connector.Response; + + +/** + * This is a concrete implementation of {@link ValveBase} that enforces a limit on the number of HTTP request parameters. + * The features of

Re: Request dispatcher decoding and normalization

2025-01-22 Thread Rémy Maucherat
On Wed, Jan 22, 2025 at 3:11 PM Mark Thomas wrote: > > As a result of a user request, I am looking at Tomcat's handling of %2f > (encoded '/') and %5c (encoded '\'). > > I have already added a new attribute (encodedReverseSolidusHandling) to > the Conne

Request dispatcher decoding and normalization

2025-01-22 Thread Mark Thomas
As a result of a user request, I am looking at Tomcat's handling of %2f (encoded '/') and %5c (encoded '\'). I have already added a new attribute (encodedReverseSolidusHandling) to the Connector to align options for %5c handling with options for %2f handling.

Re: [PR] fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size [tomcat]

2025-01-12 Thread via GitHub
s that ensure that the request body length is restricted by LimitRequestBody. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size [tomcat]

2025-01-12 Thread via GitHub
rmaucher commented on PR #806: URL: https://github.com/apache/tomcat/pull/806#issuecomment-2586420543 As per the response in the BZ, we're not going to address this (esp not using an unrelated configuration setting). -- This is an automated message from the Apache Git Service. To respond

Re: [PR] fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size [tomcat]

2025-01-12 Thread via GitHub
rmaucher closed pull request #806: fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size URL: https://github.com/apache/tomcat/pull/806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size [tomcat]

2025-01-12 Thread via GitHub
Chenjp opened a new pull request, #806: URL: https://github.com/apache/tomcat/pull/806 maxSwallowSize is semantically equivalent to max file size of upload file size. Send 413 when length of Content-Range request exceeds maxSwallowSize. -- This is an automated message from the Apache Git

(tomcat) branch main updated: Drop code trying to detect a request body for LOCK and PROPFIND

2025-01-10 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6863bc912b Drop code trying to detect a request body

(tomcat) branch 11.0.x updated: Drop code trying to detect a request body for LOCK and PROPFIND

2025-01-10 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 3fc44630f7 Drop code trying to detect a request

(tomcat) branch 9.0.x updated: Drop code trying to detect a request body for LOCK and PROPFIND

2025-01-10 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new bf1b3b7d76 Drop code trying to detect a request

(tomcat) branch 10.1.x updated: Drop code trying to detect a request body for LOCK and PROPFIND

2025-01-10 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 7d14ee71e0 Drop code trying to detect a request

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #8 from Chen Jp --- It is similar to DBCP alive checking in testOnBorrow() / testOnReturn(). Provides an extra opportunity, ensure that request/response are fresh and clean when taken (borrow) from / returned to a pool or serving

[Bug 69504] CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2024-12-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 --- Comment #2 from Chen Jp --- propose extract recycling ops on external request/response from CoyoteAdapter#log. e.g. supposed implementation of CoyoteAdapter#checkRecycled: 1. access logging; 2. explicitly make sure req/resp were recycled

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #7 from Mark Thomas --- (In reply to Chen Jp from comment #6) > related cve: CVE-2024-21733 Sort of but not really. The root cause of that CVE was an error path that bypassed resetting the buffer. It is just as likely that the zero

[Bug 69504] CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2024-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas ---

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #6 from Chen Jp --- related cve: CVE-2024-21733 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr..

[Bug 69504] New: CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2024-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 Bug ID: 69504 Summary: CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside. Product: Tomcat 10 Version: 10.1.34

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-12 Thread bugzilla
ing the JVM. > Next request/response cycle will not able to obtains context of previous > service round. ByteBuffer.limit(0) already does this. -- You are receiving this mail because: You are the assignee for the bug. - To un

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #4 from Chen Jp --- For those reusable resources, when the current request processing is completed or abnormally interrupted, if possible, intermediate data (which were serving for current service lifecycle) purging in the resource

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-06 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2522898421 Got it. If possible, send me those examples to study the scenario. thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #3 from Christopher Schultz --- Setting the length of the buffer to 0 should be enough (e.g. limit(0)). If there are data-leakage bugs in ByteBuffer, they should be fixed. Writing zeros to the buffer may or may not happen, dependin

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
rmaucher commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516870493 Konstantin has provided examples of requests out there with these kind of ranges. Rejecting them provides no value to Tomcat, so the change was reverted. -- This is an automated message f

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516821173 > Yes. This change has been reverted. It is not RFC 9110 compliant. It is not rfc required, remove this detector if reasonable cases endorse. Rfc uses term MAY, not MUST: A server

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-04 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2516715364 Look at the history of the code. You'll need to go back a long way. There is definitely an argument for deprecating this option and removing it in Tomcat 12. -- This is an automated mess

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
markt-asf commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516693987 Yes. This change has been reverted. It is not RFC 9110 compliant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516674415 @markt-asf any issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #2 from Mark Thomas --- Even with those caveats, I'm not sure I'd be in favour of this. I'm leaning towards "won't fix". -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy Mauchera

(tomcat) branch 9.0.x updated: Revert "Reject Range-Request if those ranges are not strictly in ascending order"

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b3b3f57ffc Revert "Reject Range-Request if

(tomcat) branch 10.1.x updated: Revert "Reject Range-Request if those ranges are not strictly in ascending order (#791)"

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 1edf8e7c54 Revert "Reject Range-Request if

(tomcat) branch 11.0.x updated: Revert "Reject Range-Request if those ranges are not strictly in ascending order (#791)"

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 0f13daffbf Revert "Reject Range-Request if

(tomcat) 01/02: Revert "Reject Range-Request if those ranges are not strictly in ascending order (#791)"

2024-12-03 Thread markt
eject Range-Request if those ranges are not strictly in ascending order (#791)" This reverts commit 19efe70c8732f78803b9cff9be0a63c8f6202a8a. --- .../apache/catalina/servlets/DefaultServlet.java | 22 +++--- .../servlets/TestDefaultServletRangeRequests.java | 3 --

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
Chenjp commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2516346283 > No. If server enable Range-Requests feature and the target resource also support it, I think no good reason for the absence of ```Accept-Ranges: bytes``` response header. -- This

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
Chenjp commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2516095894 Since the ***Range Requests*** feature is optional, may a reason stand there. This feature affects the "Accept-Range" header of responses, and server behavior for requests (with "Range“, "I

[Bug 69486] New: Destroy data in memory completely after the request-response service is finished

2024-12-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 Bug ID: 69486 Summary: Destroy data in memory completely after the request-response service is finished Product: Tomcat 10 Version: 10.1.33 Hardware: PC

Re: Multi-Range requests (was: (tomcat) branch main updated: Reject Range-Request if those ranges are not strictly in ascending order (#791))

2024-12-03 Thread Rémy Maucherat
repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/main by this push: > > new 19efe70c87 Reject Range-Request if those ranges are not strictly > > in ascending order (#791) > > 19efe70c87 is described below > > > > com

Multi-Range requests (was: (tomcat) branch main updated: Reject Range-Request if those ranges are not strictly in ascending order (#791))

2024-12-03 Thread Konstantin Kolinko
by this push: > new 19efe70c87 Reject Range-Request if those ranges are not strictly in > ascending order (#791) > 19efe70c87 is described below > > commit 19efe70c8732f78803b9cff9be0a63c8f6202a8a > Author: Chenjp > AuthorDate: Tue Dec 3 23:44:32 2024 +0800 > > Rejec

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2515112985 If they really want to do that - and I can't think of a valid reason they would - they can write a Filter (or Valve) to remove the Range header. -- This is an automated message from the

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
Chenjp commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2515107111 If app developer decide to disable ***Range Requests*** feature, how to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2515073630 No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
Chenjp commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2515063984 > Note: It is not required for a server to send `Accept-Ranges` for it to process a request with `Range`. Does value of ```useAcceptRanges``` determine the server enable / disa

(tomcat) branch 9.0.x updated: Reject Range-Request if those ranges are not strictly in ascending order (#791)

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ef730de75f Reject Range-Request if those ranges

(tomcat) branch 10.1.x updated: Reject Range-Request if those ranges are not strictly in ascending order (#791)

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 51a498285d Reject Range-Request if those ranges

(tomcat) branch 11.0.x updated: Reject Range-Request if those ranges are not strictly in ascending order (#791)

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 71cc25669d Reject Range-Request if those ranges

(tomcat) branch main updated: Reject Range-Request if those ranges are not strictly in ascending order (#791)

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 19efe70c87 Reject Range-Request if those ranges are

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-03 Thread via GitHub
markt-asf merged PR #791: URL: https://github.com/apache/tomcat/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

(tomcat) branch 11.0.x updated: fix incomplete chunked request body in testcase (#792)

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 591b439b13 fix incomplete chunked request body

Re: [PR] fix incomplete chunked request body in testcase [tomcat]

2024-12-03 Thread via GitHub
markt-asf merged PR #792: URL: https://github.com/apache/tomcat/pull/792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

(tomcat) branch main updated: fix incomplete chunked request body in testcase (#792)

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 08cbff9e97 fix incomplete chunked request body in

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2514678141 Note: It is not required for a server to send `Accept-Ranges` for it to process a request with `Range`. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2514634738 Needs some small changes but I'll do that after merging but before back-porting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-03 Thread via GitHub
markt-asf merged PR #790: URL: https://github.com/apache/tomcat/pull/790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

(tomcat) 01/02: Fix return and code links when request URI has a pathInfo

2024-12-02 Thread markt
and code links when request URI has a pathInfo --- webapps/docs/changelog.xml | 4 .../WEB-INF/classes/RequestInfoExample.java| 25 +++--- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs

(tomcat) 01/02: Fix return and code links when request URI has a pathInfo

2024-12-02 Thread markt
and code links when request URI has a pathInfo --- webapps/docs/changelog.xml | 4 .../WEB-INF/classes/RequestInfoExample.java| 25 +++--- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs

(tomcat) 01/02: Fix return and code links when request URI has a pathInfo

2024-12-02 Thread markt
code links when request URI has a pathInfo --- .../WEB-INF/classes/RequestInfoExample.java| 25 +++--- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/webapps/examples/WEB-INF/classes/RequestInfoExample.java b/webapps/examples/WEB-INF/classes

(tomcat) 01/02: Fix return and code links when request URI has a pathInfo

2024-12-02 Thread markt
and code links when request URI has a pathInfo --- webapps/docs/changelog.xml | 4 .../WEB-INF/classes/RequestInfoExample.java| 25 +++--- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs

[PR] fix incomplete chunked request body in testcase [tomcat]

2024-12-02 Thread via GitHub
Chenjp opened a new pull request, #792: URL: https://github.com/apache/tomcat/pull/792 add CRLF after the last-chunk to build a valid chunked request body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-11-29 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2508272217 simpler and elegant logic to detect both overlap and ASC order in same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-11-29 Thread via GitHub
Chenjp opened a new pull request, #791: URL: https://github.com/apache/tomcat/pull/791 Request that ranges are not strictly in ascending order, indicates either a broken client or a deliberate denial-of-service attack. -- This is an automated message from the Apache Git Service. To

[PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-11-29 Thread via GitHub
Chenjp opened a new pull request, #790: URL: https://github.com/apache/tomcat/pull/790 - Bug: incorrect partial content response to HEAD request with-Range-header ***Tomcat*** - 206: ``` C:\Users\chenjp>curl http://localhost:55263/index.html -i -H "Range: bytes=

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-27 Thread via GitHub
markt-asf closed pull request #782: send 416 error to overlapping ranges request URL: https://github.com/apache/tomcat/pull/782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2504291618 Tx. Applied a variation manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-25 Thread via GitHub
Chenjp commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1857791659 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd()

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-25 Thread via GitHub
Chenjp commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1857791659 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd()

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-22 Thread via GitHub
Chenjp commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2495275038 > I'd like to see similar protection for `Content-Range` when used with partial `PUT`. @markt-asf done with PR #778 -- This is an automated message from the Apache Git Service. To r

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-22 Thread via GitHub
Chenjp commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2495274861 > I'd like to see similar protection for `Content-Range` when used with partial `PUT`. @markt-asf done with PR #778 -- This is an automated message from the Apache Git Service. To r

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-22 Thread via GitHub
markt-asf commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1854564015 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd

[Bug 69444] jakarta.servlet.error.message request attribute should be empty string instead of null

2024-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69444 --- Comment #7 from Paolo B. --- Thanks! I've reported this to Mojarra project -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-19 Thread via GitHub
gmshake commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2485163715 Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] send 416 error to overlapping ranges request [tomcat]

2024-11-18 Thread via GitHub
Chenjp opened a new pull request, #782: URL: https://github.com/apache/tomcat/pull/782 request ranges validation - overlap detection added. * invalid ranges - overlapping: ``` D:\git\github.com>curl http://localhost:55464/index.html -i -H "Range: bytes=10-40,35-50"

[Bug 69444] jakarta.servlet.error.message request attribute should be empty string instead of null

2024-11-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69444 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[SECURITY] CVE-2024-52317 Apache Tomcat - Request and/or response mix-up

2024-11-18 Thread Mark Thomas
Note: Correction to 10.1.x affected versions CVE-2024-52317 Apache Tomcat - Request and/or response mix-up Severity: Important Vendor: The Apache Software Foundation Versions Affected: Apache Tomcat 11.0.0-M23 to 11.0.0-M26 Apache Tomcat 10.1.27 to 10.1.30 Apache Tomcat 9.0.92 to 9.0.95

[SECURITY] CVE-2024-52317 Apache Tomcat - Request and/or response mix-up

2024-11-18 Thread Mark Thomas
CVE-2024-52317 Apache Tomcat - Request and/or response mix-up Severity: Important Vendor: The Apache Software Foundation Versions Affected: Apache Tomcat 11.0.0-M23 to 11.0.0-M26 Apache Tomcat 10.1.7 to 10.1.30 Apache Tomcat 9.0.92 to 9.0.95 Description: Incorrect recycling of the request and

[Bug 69444] jakarta.servlet.error.message request attribute should be empty string instead of null

2024-11-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69444 --- Comment #5 from Mark Thomas --- >From the setAttribute() Javadoc: "If the object passed in is null, the effect is the same as calling {@link #removeAttribute}." I think we are going to need to set it explicitly to the empty String. -- Y

  1   2   3   4   5   6   7   8   9   10   >