(tomcat) branch 11.0.x updated: Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null

2025-06-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new bfdd3af5c9 Optimize Request#getCharsetHolder

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-12 Thread via GitHub
ChristopherSchultz merged PR #867: URL: https://github.com/apache/tomcat/pull/867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat

(tomcat) branch main updated: Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null

2025-06-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a652b71630 Optimize Request#getCharsetHolder to

Re: [PR] recycle RequestInfo when Request is reused in pool [tomcat]

2025-06-12 Thread via GitHub
markt-asf commented on PR #868: URL: https://github.com/apache/tomcat/pull/868#issuecomment-2967321515 HTTP/2 is handled differently because of the multiplexing. We probably do need a `recycle()` method on `RequestInfo`. It looks like it should be called around line 440 (current 9.0.x code)

Re: [PR] recycle RequestInfo when Request is reused in pool [tomcat]

2025-06-12 Thread via GitHub
rmaucher commented on PR #868: URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966635424 Definitely this PR is wrong. RequestInfo is not the stats for an individual request, so it should not be reset. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] recycle RequestInfo when Request is reused in pool [tomcat]

2025-06-12 Thread via GitHub
rmaucher closed pull request #868: recycle RequestInfo when Request is reused in pool URL: https://github.com/apache/tomcat/pull/868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] recycle RequestInfo when Request is reused in pool [tomcat]

2025-06-12 Thread via GitHub
qingdaoheze commented on PR #868: URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966572313 Sorry. I don't understand what you mean. My issue is that the metrics in org.apache.coyote.RequestGroupInfo#removeRequestProcessor is not counted correctly when org.apache.coyote.http2.

Re: [PR] recycle RequestInfo when Request is reused in pool [tomcat]

2025-06-12 Thread via GitHub
rmaucher commented on PR #868: URL: https://github.com/apache/tomcat/pull/868#issuecomment-2966521488 Are you trying to fix a problem you noticed, or is this PR based on code analysis ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[PR] recycle RequestInfo when Request is reused in pool [tomcat]

2025-06-11 Thread via GitHub
qingdaoheze opened a new pull request, #868: URL: https://github.com/apache/tomcat/pull/868 The request statistics will be wrong when Request object is reused in the object pool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
morning-gu commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964764619 > What does your flame graph look like after this change? After optimization, the consumption of `Request#getCharsetHolder` is only present during the first parsing. Subsequen

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
morning-gu commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964740795 > Looks reasonable to me. Needs a change log entry. Thank you for the feedback. I have added a changelog entry to webapps/docs/changelog.xml for this change. -- This is an automa

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
markt-asf commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2963154081 Looks reasonable to me. Needs a change log entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
rmaucher commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962991943 I think it is likely ok. I did not like it since it is backwards from the original intent of the refactoring. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
morning-gu commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962535411 > What does your flame graph look like after this change? Sorry, I don't have a flame graph right now. I can capture one tomorrow. -- This is an automated message from the Apache

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
ChristopherSchultz commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962444324 What does your flame graph look like after this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
ChristopherSchultz commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962441562 This analysis looks correct to me, and the solution is staightforward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
morning-gu commented on code in PR #867: URL: https://github.com/apache/tomcat/pull/867#discussion_r2139963921 ## java/org/apache/coyote/Request.java: ## @@ -389,14 +389,18 @@ public void setLocalPort(int port) { // encoding/type

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
ChristopherSchultz commented on code in PR #867: URL: https://github.com/apache/tomcat/pull/867#discussion_r2139938437 ## java/org/apache/coyote/Request.java: ## @@ -389,14 +389,18 @@ public void setLocalPort(int port) { // encoding/type ---

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
ChristopherSchultz commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962314501 @morning-gu Please don't ping specific members of this team to ask for a review. Everyone is aware that this PR is here, and it will be reviewed when these volunteers have time to

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
morning-gu commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962026185 @rmaucher Please review and approve the workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
morning-gu commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961553998 reopen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-11 Thread via GitHub
morning-gu commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961546330 > Why would the charset name be null ? Because it is not included in the request headers, as shown below: ‌Content-Type=application/x-www-form-urlencoded -- This is

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-10 Thread via GitHub
rmaucher commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961464959 Why would the charset name be null ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-10 Thread via GitHub
rmaucher closed pull request #867: Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null URL: https://github.com/apache/tomcat/pull/867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-10 Thread via GitHub
StudentGu commented on PR #867: URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961118047 @markt-asf @michael-o Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Optimize Request#getCharsetHolder to avoid repeated parsing when charset is null [tomcat]

2025-06-10 Thread via GitHub
StudentGu opened a new pull request, #867: URL: https://github.com/apache/tomcat/pull/867 In org.apache.coyote.Request#getCharsetHolder, when charsetHolder.getName() returns null, parsing is performed repeatedly, resulting in unnecessary performance overhead. The following optimizations

[Bug 69702] Sometime return 404 for normal request when using HTTP2

2025-06-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69702 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Bug 69702] Sometime return 404 for normal request when using HTTP2

2025-06-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69702 --- Comment #2 from Thomas --- I found the root cause. Async task and new request used the same request, which caused the request preparation to fail. So, if request pooling is enabled, please use async task with caution. -- You are

(tomcat) branch main updated: Fix saved request serialization issue in FORM

2025-06-05 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 9cfb4797f5 Fix saved request serialization issue in

(tomcat) branch 9.0.x updated: Fix saved request serialization issue in FORM

2025-06-05 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 36b0ec4a15 Fix saved request serialization issue in

(tomcat) branch 10.1.x updated: Fix saved request serialization issue in FORM

2025-06-05 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 94b1b1fdd6 Fix saved request serialization issue

(tomcat) 01/02: Fix saved request serialization issue in FORM

2025-06-05 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e7326307a0fc2c4611fe04d94f3045bed822fc0b Author: remm AuthorDate: Thu Jun 5 10:38:38 2025 +0200 Fix saved request

[Bug 69702] Sometime return 404 for normal request when using HTTP2

2025-06-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69702 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Mark Thomas

[Bug 69702] New: Sometime return 404 for normal request when using HTTP2

2025-06-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69702 Bug ID: 69702 Summary: Sometime return 404 for normal request when using HTTP2 Product: Tomcat 9 Version: 9.0.100 Hardware: All OS: Linux

(tomcat) branch 9.0.x updated: Add ParameterLimitValve: enforce request parameter limit per URL (#753)

2025-05-28 Thread markt
request parameter limit per URL (#753) 8954758204 is described below commit 89547582045de4a88edb8a723040c55c74623f69 Author: Dimitrios Soumis AuthorDate: Wed Jan 29 16:45:53 2025 +0200 Add ParameterLimitValve: enforce request parameter limit per URL (#753) Introduce ParameterLimitValve to

(tomcat) branch 10.1.x updated: Add ParameterLimitValve: enforce request parameter limit per URL (#753)

2025-05-28 Thread markt
request parameter limit per URL (#753) 3f39af98f9 is described below commit 3f39af98f9a4f2034b64a2c5ee62b434cefbd220 Author: Dimitrios Soumis AuthorDate: Wed Jan 29 16:45:53 2025 +0200 Add ParameterLimitValve: enforce request parameter limit per URL (#753) Introduce ParameterLimitValve

(tomcat) branch 11.0.x updated: Fix BZ 69690 - getParameter is OK for multipart request and no config

2025-05-21 Thread markt
multipart request and no config d36bd03ed7 is described below commit d36bd03ed717885eaeb23465a46eff0bcc98ecd9 Author: Mark Thomas AuthorDate: Wed May 21 15:23:21 2025 +0100 Fix BZ 69690 - getParameter is OK for multipart request and no config It is only if getPart() or getParts

(tomcat) branch main updated: Fix BZ 69690 - getParameter is OK for multipart request and no config

2025-05-21 Thread markt
multipart request and no config d42dd73a2e is described below commit d42dd73a2eeae52c1e7107316bc279f3f3f8ff8e Author: Mark Thomas AuthorDate: Wed May 21 15:23:21 2025 +0100 Fix BZ 69690 - getParameter is OK for multipart request and no config It is only if getPart() or getParts() is

(tomcat) 01/01: Merge pull request #808 from Chenjp/webdav_specialpath_tc

2025-05-05 Thread remm
2025 +0200 Merge pull request #808 from Chenjp/webdav_specialpath_tc webdav testcase for special path .../catalina/servlets/TestWebdavServlet.java | 87 -- 1 file changed, 64 insertions(+), 23 deletions

(tomcat) branch 10.1.x updated: BZ 68876 sequence diagrams for request processing and authentication

2025-05-01 Thread markt
request processing and authentication 9598b455c5 is described below commit 9598b455c5338c340be292bb9f1e7a3a3b5830bf Author: Mark Thomas AuthorDate: Tue Apr 29 20:18:32 2025 +0100 BZ 68876 sequence diagrams for request processing and authentication https://bz.apache.org/bugzilla

(tomcat) branch 11.0.x updated: BZ 68876 sequence diagrams for request processing and authentication

2025-05-01 Thread markt
request processing and authentication 617eafaa12 is described below commit 617eafaa120b37c2a5418dc573376bdd5fbd187a Author: Mark Thomas AuthorDate: Tue Apr 29 20:18:32 2025 +0100 BZ 68876 sequence diagrams for request processing and authentication https://bz.apache.org/bugzilla

(tomcat) 04/08: Remove the legacy request process diagram

2025-05-01 Thread markt
legacy request process diagram The new diagrams replace this, provide more detail and are more accurate. --- webapps/docs/architecture/requestProcess.xml | 4 .../architecture/requestProcess/request-process.png| Bin 109471 -> 0 bytes 2 files changed, 4 deleti

(tomcat) 01/08: Start to re-do the sequence diagrams for request processing

2025-05-01 Thread markt
-do the sequence diagrams for request processing NIOEndpoint to Processor --- webapps/docs/architecture/requestProcess.xml | 51 +-- .../architecture/requestProcess/1_nio.plantuml | 93 + webapps/docs/architecture/requestProcess/1_nio.png | Bin 0

(tomcat) 01/01: Merge pull request #842 from jengebr/nonstandard_tags

2025-04-16 Thread jengebr
eng...@users.noreply.github.com> AuthorDate: Wed Apr 16 14:53:40 2025 -0500 Merge pull request #842 from jengebr/nonstandard_tags Adding nonstandard support for c:set and c:remove java/org/apache/jasper/EmbeddedServletOptions.java | 12 ++ java/org/apache/jasper/JspC.java | 19 ++

(tomcat-training) 01/01: Merge pull request #34 from jbampton/fix-spelling

2025-04-01 Thread markt
:22 2025 +0100 Merge pull request #34 from jbampton/fix-spelling misc: fix spelling modules/tls-03.html | 2 +- modules/tomcat-11-jakarta-ee-11.html | 4 ++-- modules/tomcat-11-preview.html | 10 +- res/tls-03/script.txt| 4 ++-- 4

(tomcat-tck) 01/01: Merge pull request #2 from adoroszlai/snapshots-only

2025-03-31 Thread markt
2025 +0100 Merge pull request #2 from adoroszlai/snapshots-only prefer central repo, disable releases for asf-snapshots pom.xml | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) - To unsubscribe, e

[Bug 69610] New: Consider implementing support for upgrade-insecure-requests request header and conditional HSTS

2025-03-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69610 Bug ID: 69610 Summary: Consider implementing support for upgrade-insecure-requests request header and conditional HSTS Product: Tomcat 11 Version: unspecified

[Bug 69604] Catalina connector request does not adhere to RFC 7232 3.3 (If-Modified-Since)

2025-03-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69604 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 69604] New: Catalina connector request does not adhere to RFC 7232 3.3 (If-Modified-Since)

2025-03-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69604 Bug ID: 69604 Summary: Catalina connector request does not adhere to RFC 7232 3.3 (If-Modified-Since) Product: Tomcat 10 Version: 10.1.34 Hardware: All

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-14 Thread via GitHub
dsoumis commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2658927616 Indeed Mark, that's a fair point. I've refactored the order as suggested in: [commit](https://github.com/apache/tomcat/commit/e451872) . -- This is an automated message from the Apache Git

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-14 Thread via GitHub
markt-asf commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2658848926 I echo n828cl's concerns about calling `isSameOrigin()` before `isValidOrigin()`. I can't see an obvious issue but swapping the order of those two checks is going to be a lot faster than d

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
koust6u commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657908424 @n828cl Which part do you find harder to follow? If you could clarify, it would help me understand better. I also believe that calling `isSameOrigin()` before `isValidOrigin()`

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
dsoumis commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657902498 The revised code, though less nested, adheres to the CORS flow as specified. In my opinion, this structure offers a more maintainable and understandable implementation. Also the ordering

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
n828cl commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657751803 If this were to be merged, the CORS flowchart should be updated accordingly. See ![](https://tomcat.apache.org/tomcat-11.0-doc/images/cors-flowchart.png) -- This is an automated mes

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
n828cl commented on PR #826: URL: https://github.com/apache/tomcat/pull/826#issuecomment-2657748693 I'm not sure that the revised code properly implements the spec. (Unfortunately, the current spec is much harder to follow than the previous iteration.) Also, calling IsSameOrigin() before is

(tomcat) branch 9.0.x updated: Clean up check CORS request type method (#826)

2025-02-13 Thread dsoumis
This is an automated email from the ASF dual-hosted git repository. dsoumis pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3d967dddad Clean up check CORS request type

(tomcat) branch 11.0.x updated: Clean up check CORS request type method (#826)

2025-02-13 Thread dsoumis
This is an automated email from the ASF dual-hosted git repository. dsoumis pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 73d5ee6afd Clean up check CORS request type

(tomcat) branch 10.1.x updated: Clean up check CORS request type method (#826)

2025-02-13 Thread dsoumis
This is an automated email from the ASF dual-hosted git repository. dsoumis pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new ad2f570cde Clean up check CORS request type

(tomcat) branch main updated: Clean up check CORS request type method (#826)

2025-02-13 Thread dsoumis
This is an automated email from the ASF dual-hosted git repository. dsoumis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a4ccdba4bf Clean up check CORS request type method

Re: [PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-13 Thread via GitHub
dsoumis merged PR #826: URL: https://github.com/apache/tomcat/pull/826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

[PR] Refactor CORS Request Type Checking Logic for Simplicity and Clarity [tomcat]

2025-02-12 Thread via GitHub
koust6u opened a new pull request, #826: URL: https://github.com/apache/tomcat/pull/826 This PR refactors the checkRequestType method in the CORS filter to simplify and improve the readability of the request type determination logic. The main changes are: + Early Returns: The code

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2025-02-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #12 from Chen Jp --- Would to know how apache httpd server deal cleanup ops. // I'm not a C fan. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2025-02-10 Thread bugzilla
and DBCP provides a range of options to enabled applications to select the strategy that works best for them. This proposal might protect against some Tomcat bugs in some circumstances but at the price of a performance penalty for every single request. I might be convinced that such a trade-off was

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2025-02-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #10 from Chen Jp --- see https://github.com/apache/tomcat/pull/822 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-m

[Bug 69504] CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2025-02-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 --- Comment #4 from Chen Jp --- see PR 821. https://github.com/apache/tomcat/pull/821 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscri

[Bug 69504] CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2025-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 --- Comment #3 from Mark Thomas --- If you want to propose a refactoring then please provide a patch for review. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2025-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #9 from Mark Thomas --- It will also have a negative impact on performance. The more I think about this, the more I am leaning towards WONTFIX. -- You are receiving this mail because: You are the assignee for the bug. ---

(tomcat) 01/02: Add ParameterLimitValve to enforce request parameter limits for specific URLs (#753)

2025-01-30 Thread dsoumis
ParameterLimitValve to enforce request parameter limits for specific URLs (#753) Introduce ParameterLimitValve to enforce request parameter limits - Added `ParameterLimitValve`, a new valve that allows enforcing limits on the number of parameters in HTTP requests. - Supports

Re: [PR] Add ParameterLimitValve to enforce request parameter limits for specific URLs [tomcat]

2025-01-29 Thread via GitHub
dsoumis merged PR #753: URL: https://github.com/apache/tomcat/pull/753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: [PR] Add ParameterLimitValve to enforce request parameter limits for specific URLs [tomcat]

2025-01-23 Thread via GitHub
x.Pattern; + +import jakarta.servlet.ServletException; + +import org.apache.catalina.connector.Request; +import org.apache.catalina.connector.Response; + + +/** + * This is a concrete implementation of {@link ValveBase} that enforces a limit on the number of HTTP request parameters. + * The features of

Re: Request dispatcher decoding and normalization

2025-01-22 Thread Rémy Maucherat
On Wed, Jan 22, 2025 at 3:11 PM Mark Thomas wrote: > > As a result of a user request, I am looking at Tomcat's handling of %2f > (encoded '/') and %5c (encoded '\'). > > I have already added a new attribute (encodedReverseSolidusHandling) to > the Conne

Request dispatcher decoding and normalization

2025-01-22 Thread Mark Thomas
As a result of a user request, I am looking at Tomcat's handling of %2f (encoded '/') and %5c (encoded '\'). I have already added a new attribute (encodedReverseSolidusHandling) to the Connector to align options for %5c handling with options for %2f handling.

Re: [PR] fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size [tomcat]

2025-01-12 Thread via GitHub
s that ensure that the request body length is restricted by LimitRequestBody. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size [tomcat]

2025-01-12 Thread via GitHub
rmaucher commented on PR #806: URL: https://github.com/apache/tomcat/pull/806#issuecomment-2586420543 As per the response in the BZ, we're not going to address this (esp not using an unrelated configuration setting). -- This is an automated message from the Apache Git Service. To respond

Re: [PR] fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size [tomcat]

2025-01-12 Thread via GitHub
rmaucher closed pull request #806: fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size URL: https://github.com/apache/tomcat/pull/806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] fix BZ 69446 - Propagate maxSwallowSize to enforce partial PUT request target file size [tomcat]

2025-01-12 Thread via GitHub
Chenjp opened a new pull request, #806: URL: https://github.com/apache/tomcat/pull/806 maxSwallowSize is semantically equivalent to max file size of upload file size. Send 413 when length of Content-Range request exceeds maxSwallowSize. -- This is an automated message from the Apache Git

(tomcat) branch main updated: Drop code trying to detect a request body for LOCK and PROPFIND

2025-01-10 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6863bc912b Drop code trying to detect a request body

(tomcat) branch 11.0.x updated: Drop code trying to detect a request body for LOCK and PROPFIND

2025-01-10 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 3fc44630f7 Drop code trying to detect a request

(tomcat) branch 9.0.x updated: Drop code trying to detect a request body for LOCK and PROPFIND

2025-01-10 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new bf1b3b7d76 Drop code trying to detect a request

(tomcat) branch 10.1.x updated: Drop code trying to detect a request body for LOCK and PROPFIND

2025-01-10 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 7d14ee71e0 Drop code trying to detect a request

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #8 from Chen Jp --- It is similar to DBCP alive checking in testOnBorrow() / testOnReturn(). Provides an extra opportunity, ensure that request/response are fresh and clean when taken (borrow) from / returned to a pool or serving

[Bug 69504] CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2024-12-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 --- Comment #2 from Chen Jp --- propose extract recycling ops on external request/response from CoyoteAdapter#log. e.g. supposed implementation of CoyoteAdapter#checkRecycled: 1. access logging; 2. explicitly make sure req/resp were recycled

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #7 from Mark Thomas --- (In reply to Chen Jp from comment #6) > related cve: CVE-2024-21733 Sort of but not really. The root cause of that CVE was an error path that bypassed resetting the buffer. It is just as likely that the zero

[Bug 69504] CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2024-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas ---

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #6 from Chen Jp --- related cve: CVE-2024-21733 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr..

[Bug 69504] New: CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside.

2024-12-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69504 Bug ID: 69504 Summary: CoyoteAdapter recycle request/response objects in "log()" method even if they are came from outside. Product: Tomcat 10 Version: 10.1.34

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-12 Thread bugzilla
ing the JVM. > Next request/response cycle will not able to obtains context of previous > service round. ByteBuffer.limit(0) already does this. -- You are receiving this mail because: You are the assignee for the bug. - To un

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #4 from Chen Jp --- For those reusable resources, when the current request processing is completed or abnormally interrupted, if possible, intermediate data (which were serving for current service lifecycle) purging in the resource

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-06 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2522898421 Got it. If possible, send me those examples to study the scenario. thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #3 from Christopher Schultz --- Setting the length of the buffer to 0 should be enough (e.g. limit(0)). If there are data-leakage bugs in ByteBuffer, they should be fixed. Writing zeros to the buffer may or may not happen, dependin

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
rmaucher commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516870493 Konstantin has provided examples of requests out there with these kind of ranges. Rejecting them provides no value to Tomcat, so the change was reverted. -- This is an automated message f

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516821173 > Yes. This change has been reverted. It is not RFC 9110 compliant. It is not rfc required, remove this detector if reasonable cases endorse. Rfc uses term MAY, not MUST: A server

Re: [PR] fix incorrect partial content response to HEAD request with-Range-header, or from Not-accept-range server [tomcat]

2024-12-04 Thread via GitHub
markt-asf commented on PR #790: URL: https://github.com/apache/tomcat/pull/790#issuecomment-2516715364 Look at the history of the code. You'll need to go back a long way. There is definitely an argument for deprecating this option and removing it in Tomcat 12. -- This is an automated mess

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
markt-asf commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516693987 Yes. This change has been reverted. It is not RFC 9110 compliant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Reject Range-Request if those ranges are not strictly in ascending order [tomcat]

2024-12-04 Thread via GitHub
Chenjp commented on PR #791: URL: https://github.com/apache/tomcat/pull/791#issuecomment-2516674415 @markt-asf any issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-04 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 --- Comment #2 from Mark Thomas --- Even with those caveats, I'm not sure I'd be in favour of this. I'm leaning towards "won't fix". -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69486] Destroy data in memory completely after the request-response service is finished

2024-12-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69486 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy Mauchera

(tomcat) branch 9.0.x updated: Revert "Reject Range-Request if those ranges are not strictly in ascending order"

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b3b3f57ffc Revert "Reject Range-Request if

(tomcat) branch 10.1.x updated: Revert "Reject Range-Request if those ranges are not strictly in ascending order (#791)"

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 1edf8e7c54 Revert "Reject Range-Request if

(tomcat) branch 11.0.x updated: Revert "Reject Range-Request if those ranges are not strictly in ascending order (#791)"

2024-12-03 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 0f13daffbf Revert "Reject Range-Request if

  1   2   3   4   5   6   7   8   9   10   >