Hi,
2017-04-28 9:54 GMT+03:00 Violeta Georgieva :
>
> Hi,
>
>> ...
>> ...
>
> The fixes for all comments are available in the PR.
> If there are no other comments I'm going to commit this functionality to
Tomcat 9.
The fix is in Tomcat 9 for a month now and there are no issues so far.
I'm plannin
2017-04-27 23:33 GMT+03:00 Mark Thomas :
>
> On 27/04/17 21:22, Violeta Georgieva wrote:
> > Hi,
> >
> > 2017-04-26 17:43 GMT+03:00 Mark Thomas :
> >>
> >> On 25/04/17 11:47, Violeta Georgieva wrote:
> >>
> >>
> >>
> >>> Thanks for the review.
> >>> Changes for all comments are applied to the PR.
Hi,
2017-04-26 17:43 GMT+03:00 Mark Thomas :
>
> On 25/04/17 11:47, Violeta Georgieva wrote:
>
>
>
> > Thanks for the review.
> > Changes for all comments are applied to the PR.
> > Can you take a look?
>
> Sure. A few more comments but nothing serious. Unless the fixes for any
> of these require
On 27/04/17 21:22, Violeta Georgieva wrote:
> Hi,
>
> 2017-04-26 17:43 GMT+03:00 Mark Thomas :
>>
>> On 25/04/17 11:47, Violeta Georgieva wrote:
>>
>>
>>
>>> Thanks for the review.
>>> Changes for all comments are applied to the PR.
>>> Can you take a look?
>>
>> Sure. A few more comments but not
Hi,
2017-04-26 17:43 GMT+03:00 Mark Thomas :
>
> On 25/04/17 11:47, Violeta Georgieva wrote:
>
>
>
> > Thanks for the review.
> > Changes for all comments are applied to the PR.
> > Can you take a look?
>
> Sure. A few more comments but nothing serious. Unless the fixes for any
> of these require
On 25/04/17 11:47, Violeta Georgieva wrote:
> Thanks for the review.
> Changes for all comments are applied to the PR.
> Can you take a look?
Sure. A few more comments but nothing serious. Unless the fixes for any
of these require large changes to the patch I'd be +1 on applying the
patch with
2017-04-21 15:38 GMT+03:00 Mark Thomas :
>
> On 19/04/17 11:43, Violeta Georgieva wrote:
> > Hi,
> >
> > 2017-03-29 23:59 GMT+03:00 Mark Thomas :
>
>
>
> >> I think the problem is that "reading in progress" and suspended are
> >> treated separately when it is the combination of the two that
repres
On 19/04/17 11:43, Violeta Georgieva wrote:
> Hi,
>
> 2017-03-29 23:59 GMT+03:00 Mark Thomas :
>> I think the problem is that "reading in progress" and suspended are
>> treated separately when it is the combination of the two that represents
>> the current state.
>>
>> If it were me, I'd probab
Hi,
2017-03-29 23:59 GMT+03:00 Mark Thomas :
>
> On 29/03/17 08:02, Violeta Georgieva wrote:
> >> 2017-02-27 16:50 GMT+02:00 Mark Thomas :
>
>
>
> >>> Overall, I like the approach and would support apply a patch along
these
> >>> lines once the timing issues are resolved.
> >
> > Any feedback abo
On 29/03/17 08:02, Violeta Georgieva wrote:
>> 2017-02-27 16:50 GMT+02:00 Mark Thomas :
>>> Overall, I like the approach and would support apply a patch along these
>>> lines once the timing issues are resolved.
>
> Any feedback about the new changes?
First of all, kudos for implementing what
Hi,
2017-03-20 16:41 GMT+02:00 Violeta Georgieva :
>
> Hi,
>
> 2017-02-27 16:50 GMT+02:00 Mark Thomas :
> >
> > On 27/02/17 11:55, Violeta Georgieva wrote:
> >
> >
> >
> > >> A new patch is available based on the provided comments.
> > >> Can you please review it.
> > >
> > > Any feedback for the
2017-03-20 15:41 GMT+01:00 Violeta Georgieva :
> Hi,
>
> 2017-02-27 16:50 GMT+02:00 Mark Thomas :
> >
> > On 27/02/17 11:55, Violeta Georgieva wrote:
> >
> >
> >
> > >> A new patch is available based on the provided comments.
> > >> Can you please review it.
> > >
> > > Any feedback for the lates
Hi,
2017-02-27 16:50 GMT+02:00 Mark Thomas :
>
> On 27/02/17 11:55, Violeta Georgieva wrote:
>
>
>
> >> A new patch is available based on the provided comments.
> >> Can you please review it.
> >
> > Any feedback for the latest changes
>
> Sorry for the delay.
>
> On a minor/style point, I'd pref
On 27/02/17 11:55, Violeta Georgieva wrote:
>> A new patch is available based on the provided comments.
>> Can you please review it.
>
> Any feedback for the latest changes
Sorry for the delay.
On a minor/style point, I'd prefer SUSPENDED rather than READ_SUSPENDED
since the socket won't be e
Hi,
2017-02-14 23:43 GMT+02:00 Violeta Georgieva :
>
> Hi,
>
>
> 2017-02-10 11:07 GMT+02:00 Mark Thomas :
> >
> > On 09/02/17 22:08, Violeta Georgieva wrote:
> >>
> >> 2017-02-08 11:25 GMT+02:00 Violeta Georgieva :
> >>>
> >>> 2017-02-08 1:51 GMT+02:00 Mark Thomas :
> >
> >
> >
> >
> I guess
Violeta,
On 2/15/17 1:14 PM, Violeta Georgieva wrote:
> 2017-02-15 19:46 GMT+02:00 Christopher Schultz > I think we need to come to an agreement about what it's okay to change
>> in a non-backward-compatible way in terms of internal APIs. It's become
>> clear lately that API breakages really affec
On 15/02/17 17:46, Christopher Schultz wrote:
Violeta,
On 2/14/17 4:43 PM, Violeta Georgieva wrote:
Hi,
2017-02-10 11:07 GMT+02:00 Mark Thomas :
On 09/02/17 22:08, Violeta Georgieva wrote:
2017-02-08 11:25 GMT+02:00 Violeta Georgieva :
2017-02-08 1:51 GMT+02:00 Mark Thomas :
I gues
Hi Chris,
2017-02-15 19:46 GMT+02:00 Christopher Schultz :
>
> Violeta,
>
> On 2/14/17 4:43 PM, Violeta Georgieva wrote:
> > Hi,
> >
> > 2017-02-10 11:07 GMT+02:00 Mark Thomas :
> >>
> >> On 09/02/17 22:08, Violeta Georgieva wrote:
> >>>
> >>> 2017-02-08 11:25 GMT+02:00 Violeta Georgieva :
>
Violeta,
On 2/14/17 4:43 PM, Violeta Georgieva wrote:
> Hi,
>
> 2017-02-10 11:07 GMT+02:00 Mark Thomas :
>>
>> On 09/02/17 22:08, Violeta Georgieva wrote:
>>>
>>> 2017-02-08 11:25 GMT+02:00 Violeta Georgieva :
2017-02-08 1:51 GMT+02:00 Mark Thomas :
>>
>>
>>
>>
> I guess that makes
Hi,
2017-02-10 11:07 GMT+02:00 Mark Thomas :
>
> On 09/02/17 22:08, Violeta Georgieva wrote:
>>
>> 2017-02-08 11:25 GMT+02:00 Violeta Georgieva :
>>>
>>> 2017-02-08 1:51 GMT+02:00 Mark Thomas :
>
>
>
>
I guess that makes me reluctantly in favour of it in principle but I'd
>>
>> very much pre
On 09/02/17 22:08, Violeta Georgieva wrote:
2017-02-08 11:25 GMT+02:00 Violeta Georgieva :
2017-02-08 1:51 GMT+02:00 Mark Thomas :
I guess that makes me reluctantly in favour of it in principle but I'd
very much prefer to review a patch proposal minus the reformatting.
There is a new p
Hi,
2017-02-08 11:25 GMT+02:00 Violeta Georgieva :
>
>
>
> 2017-02-08 1:51 GMT+02:00 Mark Thomas :
>>
>> On 06/02/17 19:55, Violeta Georgieva wrote:
>>>
>>> Hi,
>>>
>>> Currently JSR356 provides possibility to add message handlers in order
to
>>> receive web socket
>>> messages but there is no way
2017-02-08 1:51 GMT+02:00 Mark Thomas :
> On 06/02/17 19:55, Violeta Georgieva wrote:
>
>> Hi,
>>
>> Currently JSR356 provides possibility to add message handlers in order to
>> receive web socket
>> messages but there is no way to instruct the web socket implementation to
>> suspend for a while
>
2017-02-08 0:51 GMT+01:00 Mark Thomas :
> On 06/02/17 19:55, Violeta Georgieva wrote:
>
>> Hi,
>>
>> Currently JSR356 provides possibility to add message handlers in order to
>> receive web socket
>> messages but there is no way to instruct the web socket implementation to
>> suspend for a while
>
On 06/02/17 19:55, Violeta Georgieva wrote:
Hi,
Currently JSR356 provides possibility to add message handlers in order to
receive web socket
messages but there is no way to instruct the web socket implementation to
suspend for a while
the incoming messages (backpressure) so that the application
Hi,
2017-02-07 11:54 GMT+02:00 Rémy Maucherat :
>
> 2017-02-06 20:55 GMT+01:00 Violeta Georgieva :
>
> > Hi,
> >
> > Currently JSR356 provides possibility to add message handlers in order
to
> > receive web socket
> > messages but there is no way to instruct the web socket implementation
to
> > su
2017-02-06 20:55 GMT+01:00 Violeta Georgieva :
> Hi,
>
> Currently JSR356 provides possibility to add message handlers in order to
> receive web socket
> messages but there is no way to instruct the web socket implementation to
> suspend for a while
> the incoming messages (backpressure) so that t
Hi,
2017-02-07 9:55 GMT+02:00 Martin Grigorov :
>
> Hi Violeta,
>
> On Mon, Feb 6, 2017 at 8:55 PM, Violeta Georgieva
> wrote:
>
> > Hi,
> >
> > Currently JSR356 provides possibility to add message handlers in order
to
> > receive web socket
> > messages but there is no way to instruct the web so
Hi Violeta,
On Mon, Feb 6, 2017 at 8:55 PM, Violeta Georgieva
wrote:
> Hi,
>
> Currently JSR356 provides possibility to add message handlers in order to
> receive web socket
> messages but there is no way to instruct the web socket implementation to
> suspend for a while
> the incoming messages
Hi,
Currently JSR356 provides possibility to add message handlers in order to
receive web socket
messages but there is no way to instruct the web socket implementation to
suspend for a while
the incoming messages (backpressure) so that the application is able to
process the already delivered messa
30 matches
Mail list logo
