Violeta, On 2/15/17 1:14 PM, Violeta Georgieva wrote: > 2017-02-15 19:46 GMT+02:00 Christopher Schultz <ch...@christopherschultz.net >> I think we need to come to an agreement about what it's okay to change >> in a non-backward-compatible way in terms of internal APIs. It's become >> clear lately that API breakages really affect users, and we shouldn't >> take that lightly. >> >> 8.5.x is already "stable" and users are actively being encouraged to >> move from 8.0 to it. I think that qualifies it as being something we >> should be very careful about changing. >> >> I'm not trying to say that APIs can never change; I just want to do it >> in a way that is minimally-breaking to downstream users. > > The change introduces a new API. Existing APIs are not modified at all and > the change is fully backwards compatible. > All Junit tests are passing and the results of the Web Socket Autobahn > tests are the same as before the change. > Do you have some concrete concerns or proposals regarding the > implementation? > I can test some concrete scenarios if you have some in mind.
I apologize if I raised the warning flag unnecessarily. I admit that I hadn't read-through the patches very carefully, and I'm not at all familiar with the byte-pushing code deep within Tomcat. Introducing new APIs should not be a problem at all. Thanks for the clarification. Apologies for the noise. -chris
signature.asc
Description: OpenPGP digital signature
