Hi, 2017-02-08 11:25 GMT+02:00 Violeta Georgieva <violet...@apache.org>: > > > > 2017-02-08 1:51 GMT+02:00 Mark Thomas <ma...@apache.org>: >> >> On 06/02/17 19:55, Violeta Georgieva wrote: >>> >>> Hi, >>> >>> Currently JSR356 provides possibility to add message handlers in order to >>> receive web socket >>> messages but there is no way to instruct the web socket implementation to >>> suspend for a while >>> the incoming messages (backpressure) so that the application is able to >>> process the already delivered messages. >>> The other web containers (Jetty, Undertow) supports such functionality so I >>> would like to introduce it in Tomcat. >>> Here [1] I prepared one possible implementation. >>> >>> What do you think about this feature and the proposed implementation? >> >> >> I suggest you go ahead and commit (and back-port) the formatting updates. They all look good and getting those out of the way will make the diff easier to read. > > > Formatting changes were committed. > >> >> >> I'm currently undecided on this. >> >> I understand the requirement but rather than have proprietary methods added to various WebSocket implementations, I would have preferred to see a reactive wrapper provided for Java WebSocket that would have used Server->Client WebSocket messages to communicate back pressure to the client. >> >> However, that doesn't work if the aim is to feed 'uncontrolled' WebSocket clients into a reactive server side framework. Blocking is going to be only option to apply back-pressure and better to do that just on the client rather than on the client and the server - which means this feature is required in some form. >> >> I guess that makes me reluctantly in favour of it in principle but I'd very much prefer to review a patch proposal minus the reformatting. >> > > There is a new patch > - no formatting noise > - Martin's comments included
There is a new patch: - With a fix for the Martin's comment (StringManager) - I switched from AtomicBoolean to AtomicIntegerFieldUpdater in order to minimize the memory usage Regards, Violeta > >> >> Mark >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >
