On 13/10/2017 16:02, Kapil Kumar wrote:
> Hello everyone,
>
> Hope you find this well.
>
> My name is Kapil Kumar and I joined the mailing list today.
>
> I work as an Oracle DBA professionally and I really appreciate the efforts
> of the apache community.
>
> Mark helped me getting subscribed
Jean-Frederic,
2017-01-09 14:23 GMT+02:00 Josh Soref :
>
>
https://github.com/jsoref/tomcat/commit/7c6bc40ac289ee7e7c9655c69a529f18afb5b92f
Can you take a look at this change? It's about a spelling mistake in your
email address in the KEYS file.
Thanks a lot,
Violeta
>
>
> ---
I can drop that, but please note that the spelling is listed as corrected in
the MIT key server. I really wonder how tomcat managed to corrupt it.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional comma
2017-01-09 14:23 GMT+02:00 Josh Soref :
>
>
https://github.com/jsoref/tomcat/commit/7c6bc40ac289ee7e7c9655c69a529f18afb5b92f
Let's not touch the KEYS file
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>
https://github.com/jsoref/tomcat/commit/7c6bc40ac289ee7e7c9655c69a529f18afb5b92f
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
2017-01-09 11:23 GMT+02:00 Josh Soref :
>
> I can certainly squash. The reason I personally retain splits by
misspelled word is that it's easier to rebase / resolve conflicts when I
can see what word was misspelled.
>
> Typically large projects prefer to have my changes split into a couple of
patc
2017-01-09 10:51 GMT+02:00 Josh Soref :
>
> Hi,
> I have a series of spelling fixes for Apache Tomcat [1].
>
I reviewed these changes. Please see the comments.
When you are ready squash the commits and make PR. I'll commit the changes.
> If someone could suggest a preferred way to receive them, I
Josh,
2017-01-09 11:38 GMT+02:00 Mark Thomas :
>
> On 09/01/2017 09:35, Violeta Georgieva wrote:
> > Mark,
> >
> > 2017-01-09 11:11 GMT+02:00 Mark Thomas :
> >>
> >> On 09/01/2017 08:51, Josh Soref wrote:
> >>> Hi,
> >>> I have a series of spelling fixes for Apache Tomcat [1].
> >>>
> >>> If someo
On 09/01/2017 09:35, Violeta Georgieva wrote:
> Mark,
>
> 2017-01-09 11:11 GMT+02:00 Mark Thomas :
>>
>> On 09/01/2017 08:51, Josh Soref wrote:
>>> Hi,
>>> I have a series of spelling fixes for Apache Tomcat [1].
>>>
>>> If someone could suggest a preferred way to receive them, I'm happy to
>>> sp
Mark,
2017-01-09 11:11 GMT+02:00 Mark Thomas :
>
> On 09/01/2017 08:51, Josh Soref wrote:
> > Hi,
> > I have a series of spelling fixes for Apache Tomcat [1].
> >
> > If someone could suggest a preferred way to receive them, I'm happy to
> > split them up.
>
> Pull request or patch file attached t
I can certainly squash. The reason I personally retain splits by misspelled
word is that it's easier to rebase / resolve conflicts when I can see what
word was misspelled.
Typically large projects prefer to have my changes split into a couple of
patches/PRs instead of as a single commit.
As a
Hi Josh,
2017-01-09 11:11 GMT+02:00 Mark Thomas :
>
> On 09/01/2017 08:51, Josh Soref wrote:
> > Hi,
> > I have a series of spelling fixes for Apache Tomcat [1].
> >
> > If someone could suggest a preferred way to receive them, I'm happy to
> > split them up.
>
> Pull request or patch file attache
On 09/01/2017 08:51, Josh Soref wrote:
> Hi,
> I have a series of spelling fixes for Apache Tomcat [1].
>
> If someone could suggest a preferred way to receive them, I'm happy to
> split them up.
Pull request or patch file attached to a new Bugzilla issue is fine.
Mark
>
> Some changes are mo
Hi,
2017-01-09 10:51 GMT+02:00 Josh Soref :
>
> Hi,
> I have a series of spelling fixes for Apache Tomcat [1].
>
> If someone could suggest a preferred way to receive them, I'm happy to
> split them up.
>
> Some changes are more interesting than others (the change to KEYS is
> interesting).
>
> [1
14 matches
Mail list logo