2017-01-09 11:23 GMT+02:00 Josh Soref <jso...@gmail.com>: > > I can certainly squash. The reason I personally retain splits by misspelled word is that it's easier to rebase / resolve conflicts when I can see what word was misspelled. > > Typically large projects prefer to have my changes split into a couple of patches/PRs instead of as a single commit. >
Yes that's true. I also prefer separate patches. But in this case this is just a spelling correction and I think we can use a single commit. > As a quick review, you can do diff -r trunk -r spelling or similar to see the world. > > [1] https://github.com/xbmc/xbmc/pull/11346 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
