Josh, 2017-01-09 11:38 GMT+02:00 Mark Thomas <ma...@apache.org>: > > On 09/01/2017 09:35, Violeta Georgieva wrote: > > Mark, > > > > 2017-01-09 11:11 GMT+02:00 Mark Thomas <ma...@apache.org>: > >> > >> On 09/01/2017 08:51, Josh Soref wrote: > >>> Hi, > >>> I have a series of spelling fixes for Apache Tomcat [1]. > >>> > >>> If someone could suggest a preferred way to receive them, I'm happy to > >>> split them up. > >> > >> Pull request or patch file attached to a new Bugzilla issue is fine. > > > > Some of the fixes are in DBCP2 code [1] > > Should we fix our copy of DBCP2? I think it's better this to be changed > > directly in DBCP2 code. > > I agree. DBCP2 fixes should be applied to Commons and then we'll pick > them up when up next update.
Please review this document https://github.com/apache/tomcat/blob/trunk/MERGE.txt We reuse code from other Apache projects Violeta > Mark > > > > > [1] > > https://github.com/jsoref/tomcat/commit/6c686154f8a780733bc14546056ef588c34d20b9 > > > >> Mark > >> > >> > >>> > >>> Some changes are more interesting than others (the change to KEYS is > >>> interesting). > >>> > >>> [1] https://github.com/jsoref/tomcat/commits/spelling > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > >>> For additional commands, e-mail: dev-h...@tomcat.apache.org > >>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > >> For additional commands, e-mail: dev-h...@tomcat.apache.org > >> > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
