Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: That's unfortunate. So regular is better? What are they doing with Grizzly? no, its me :) I need to come up with a non cpu sucking wait algorithm for the wait. once that is fixed, the performance should be close to identical For some rea

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: That's unfortunate. So regular is better? What are they doing with Grizzly? no, its me :) I need to come up with a non cpu sucking wait algorithm for the wait. once that is fixed, the performance should be close to identical For some reason, the performance we

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Jess Holle wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualifie

Re: NIO Connector, please review

2006-06-22 Thread Jess Holle
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualified classname here.

Re: NIO Connector, please review

2006-06-22 Thread Costin Manolache
On 6/22/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Filip Hanik - Dev Lists wrote: > Ok, I have a non SSL enabled Java NIO connector created and checked in. > It works in the exact way as APR, meaning it blocks on read and write, > So its no true NIO, but close enough to handle comet style tra

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualified classname here. I am able to diff to s

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualified classname here. I am able to diff to see what got fixed, and it's triv

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualified classname here. I am able to diff to see what got fixed, and it's trivial: all requests were

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I did, just check http://marc.theaimsgroup.com/?l=tomcat-dev&m=115064982127403&w=2 In terms of negativity, not sure where your head is at, but there is none here. This was quite a subtle mention. The plan is

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I did, just check http://marc.theaimsgroup.com/?l=tomcat-dev&m=115064982127403&w=2 In terms of negativity, not sure where your head is at, but there is none here. This was quite a subtle mention. The plan is that the socket will not get de

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: I did, just check http://marc.theaimsgroup.com/?l=tomcat-dev&m=115064982127403&w=2 In terms of negativity, not sure where your head is at, but there is none here. This was quite a subtle mention. The plan is that the socket will not get destroyed and deallocated

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: you gotta look at the glass as half full, not half empty :), it also doesn't crash the VM when the client aborts the connection on a comet request ;) I know of no crash problems. I think there's a very negative development atmosphere in th

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: you gotta look at the glass as half full, not half empty :), it also doesn't crash the VM when the client aborts the connection on a comet request ;) I know of no crash problems. I think there's a very negative development atmosphere in the components you become

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Ok, I have a non SSL enabled Java NIO connector created and checked in. It works in the exact way as APR, meaning it blocks on read and write, So its no true NIO, but close enough to handle comet style traffic, and to increase the connection

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Ok, I have a non SSL enabled Java NIO connector created and checked in. It works in the exact way as APR, meaning it blocks on read and write, So its no true NIO, but close enough to handle comet style traffic, and to increase the connection count without increasin

Re: NIO Connector, please review

2006-06-21 Thread Filip Hanik - Dev Lists
Ok, I have a non SSL enabled Java NIO connector created and checked in. It works in the exact way as APR, meaning it blocks on read and write, So its no true NIO, but close enough to handle comet style traffic, and to increase the connection count without increasing thread count. Filip [EMAIL

RE: NIO Connector, please review

2006-06-19 Thread devlists
let me fill in the other blanks, the connector will be modified so that it knows when it has enough data to proceed, ala, chunked encoding etc. that is still work to be done. but I wanted let you know how it conceptually could look similar to the APR connector, and how much of the code could be sh

RE: NIO Connector, please review

2006-06-19 Thread devlists
So it uses NIO to increase concurrency, ie, have more connections open than threads, same way as APR, but writing to the stream is not done non blocking, it still follows the request/response/1-thread model still lot of work to do Filip >> >> >>> -Original Message- >>> From: Filip Hanik

RE: NIO Connector, please review

2006-06-19 Thread devlists
> > >> -Original Message- >> From: Filip Hanik - Dev Lists [mailto:[EMAIL PROTECTED] >> Sent: Monday, June 19, 2006 6:31 AM >> To: Tomcat Developers List >> Subject: NIO Connector, please review >> >> gents, >> I've worked on an NIO connector, since the NIO and APR model >> can be/are >> ve

Re: NIO Connector, please review

2006-06-19 Thread Mladen Turk
Costin Manolache wrote: On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: I agree - it's good to have a single codebase ! But I strongly disagree that we should have one big bloated release that includes everything in the codebase. Look, all that I'm saying is that the code that is inside /

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > > Of course - all stuff must compile at least - but I don't think it's a > reasonable > requirement to have all modules or other things that are not part of tomcat > tested in order to do a release. > But in that case

Re: NIO Connector, please review

2006-06-19 Thread devlists
I would love to backport it to Tc5.5 and that way also have Comet support in tc5.5.x Filip > +1 - I'm also working on a nio connector ( it is in sandbox ), but the > goals > are quite different, > I want to have it simpler and smaller than the apr model. I think > old-style > connector > should

Re: NIO Connector, please review

2006-06-19 Thread Mladen Turk
Costin Manolache wrote: Of course - all stuff must compile at least - but I don't think it's a reasonable requirement to have all modules or other things that are not part of tomcat tested in order to do a release. But in that case, they could not be the part of the Tomcat code. If you think

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > > I don't see the benefit of having things like cluster support in the tomcat > release - > if someone does want a cluster, they can easily download an additional > jar - > setting > up a cluster involves a lot of work,

Re: NIO Connector, please review

2006-06-19 Thread Mladen Turk
Costin Manolache wrote: I don't see the benefit of having things like cluster support in the tomcat release - if someone does want a cluster, they can easily download an additional jar - setting up a cluster involves a lot of work, we won't make it much simpler by bundling the jar with tomcat.

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > > By modules/ I mean mostly release units - so maybe a build.xml to create > build and package the module, some readme, manifest, etc. Tomcat normal > release wouldn't include the module, but it can be released indepe

Re: NIO Connector, please review

2006-06-19 Thread Mladen Turk
Costin Manolache wrote: By modules/ I mean mostly release units - so maybe a build.xml to create build and package the module, some readme, manifest, etc. Tomcat normal release wouldn't include the module, but it can be released independently, maybe for multiple versions of tomcat. Look, if

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > Maybe create a modules/ under tomcat6 - with the definition 'stuff that can > be > released independently, and may support older versions of tomcat as well' > Or just 'can be released independently'. > Hmm, I'm not ver

RE: NIO Connector, please review

2006-06-19 Thread Bill Barker
> -Original Message- > From: Filip Hanik - Dev Lists [mailto:[EMAIL PROTECTED] > Sent: Monday, June 19, 2006 6:31 AM > To: Tomcat Developers List > Subject: NIO Connector, please review > > gents, > I've worked on an NIO connector, since the NIO and APR model > can be/are > very simi

Re: NIO Connector, please review

2006-06-19 Thread Mladen Turk
Costin Manolache wrote: Maybe create a modules/ under tomcat6 - with the definition 'stuff that can be released independently, and may support older versions of tomcat as well' Or just 'can be released independently'. Hmm, I'm not very much in favor of that. If the 'module' is mature enough it

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > > What about finally creating tomcat-modules or tomcat-addons ( or any other > name ), > for stuff that is (more or less) tomcat version independent, or at least > works for > multiple recent versions, and can be releas

Re: NIO Connector, please review

2006-06-19 Thread Mladen Turk
Costin Manolache wrote: What about finally creating tomcat-modules or tomcat-addons ( or any other name ), for stuff that is (more or less) tomcat version independent, or at least works for multiple recent versions, and can be released independently ? This way the cluster stuff would have a bet

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
On 6/19/06, Mladen Turk <[EMAIL PROTECTED]> wrote: Costin Manolache wrote: > are quite different, > I want to have it simpler and smaller than the apr model. I think old-style > connector > should be deprecated, since JDK1.5 is now required there is no point in > having it. > Sorry for stealing

Re: NIO Connector, please review

2006-06-19 Thread Mladen Turk
Costin Manolache wrote: are quite different, I want to have it simpler and smaller than the apr model. I think old-style connector should be deprecated, since JDK1.5 is now required there is no point in having it. Sorry for stealing the thread ;) What about old jk2 connectors found again in t

Re: NIO Connector, please review

2006-06-19 Thread Costin Manolache
+1 - I'm also working on a nio connector ( it is in sandbox ), but the goals are quite different, I want to have it simpler and smaller than the apr model. I think old-style connector should be deprecated, since JDK1.5 is now required there is no point in having it. ( I assume this is intended fo