> > >> -----Original Message----- >> From: Filip Hanik - Dev Lists [mailto:[EMAIL PROTECTED] >> Sent: Monday, June 19, 2006 6:31 AM >> To: Tomcat Developers List >> Subject: NIO Connector, please review >> >> gents, >> I've worked on an NIO connector, since the NIO and APR model >> can be/are >> very similar, this is a fairly straightforward port. >> I'd like for you to review and then continue this as work, as >> this would >> allow me to have Comet support without the need for native libraries. >> After review, please suggest where I can continue the work, trunk or >> sandbox? >> >> If the attachments don't make it, here is a link >> http://www.halosg.com/connectors.zip >> >> This is not worked completed, but working, I wanna see if I can make >> optimizations, and of course, SSL support > > I don't see how this could possibly work. You are using non-blocking > sockets, but you consider it to be an error if readSocket returns false > (when all it actually means is that the data hasn't arrived yet :). > > The APR Connector doesn't have this problem since it uses blocking sockets > (for much this reason).
there is a discrepency, I need to fix the fill() method, for the other methods, false means, return the socket to the poller, free the thread and come back when you have more data. ala non blocking mode so there is some massaging to do, but they are not that different. And on writing, it does busy loop until it flushed it all out to the os buffer. Filip > >> >> thanks >> Filip >> >> -- >> >> >> Filip Hanik >> > > > > This message is intended only for the use of the person(s) listed above as > the intended recipient(s), and may contain information that is PRIVILEGED > and CONFIDENTIAL. If you are not an intended recipient, you may not read, > copy, or distribute this message or any attachment. If you received this > communication in error, please notify us immediately by e-mail and then > delete all copies of this message and any attachments. > > In addition you should be aware that ordinary (unencrypted) e-mail sent > through the Internet is not secure. Do not send confidential or sensitive > information, such as social security numbers, account numbers, personal > identification numbers and passwords, to us via ordinary (unencrypted) > e-mail. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
