Re: Tomcat 6 source organisation part 2

2006-03-07 Thread Florian Fray
Hi Remy! Ok, so I'll (try to) create the structure (not the one in this mail), but how is it done in SVN ? Is it all simply folders without anything special ? A simple bunch of "svn mkdir" commands will do its job. There's nothing special about it. Regards Florian ---

Re: Tomcat 6 source organisation part 2

2006-03-07 Thread Remy Maucherat
Remy Maucherat wrote: Hi, Given the comments, I propose using a single repository with the following structure (based on our root "tomcat" repository): - tc6.0.x/trunk: - src/share: all the relevant sources go there - webapps: all our current webapps, including the examples webapps (note:

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Filip Hanik - Dev Lists
are all the conf files, startup scripts etc in one place? res? I was thinking that we still have a src directory, and subdirectories under that. trunk/src/java trunk/src/native trunk/webapps etc Keith Wannamaker wrote: Yes, this will do nicely. Keith Costin Manolache wrote: We still need

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Keith Wannamaker
Yes, this will do nicely. Keith Costin Manolache wrote: We still need separate dirs for native code and java I think. What about: tc6(.0.x ?)/trunk/java tc6/trunk/native tc6/trunk/webapps tc6/trunk/res - To unsubscribe, e

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Keith Wannamaker
We should keep the java sources separate from the native sources by one more level under src/, aka the share directory (or something- I always thought it referenced "share"d across platforms as simply opposed to specific "native" code). Keith Remy Maucherat wrote: Yoav Shapira wrote: I've b

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Mario Ivankovits
Hi!Costin Manolache schrieb: > The extra src/ is useless in our code organization. > Sure, but it didn't cost anything and it makes clear where to look if one searches the sources. Its simply one nice little place for all the great code. But ok, its my personal preference :-) --- Mario -

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Costin Manolache
On 3/1/06, Mario Ivankovits <[EMAIL PROTECTED]> wrote: > Hi! > >> tc6(.0.x ?)/trunk/java > >> tc6/trunk/native > >> tc6/trunk/webapps > >> tc6/trunk/res > Isn't it widely used to have: > > src/java > src/tests > src/native Widely used doesn't mean it's good in all cases :-) For most simple native

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Mario Ivankovits
Hi! >> tc6(.0.x ?)/trunk/java >> tc6/trunk/native >> tc6/trunk/webapps >> tc6/trunk/res Isn't it widely used to have: src/java src/tests src/native Ciao, Mario - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Yoav Shapira
Hola, > "share" has a long history - I think JDK is organized this way, with > separate dirs for windows, linux, etc. Maybe the JDK was organized that way in the past, but doesn't seem to be that way any more. Anyways, I don't think it has a purpose currently. If something we're not aware of co

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Remy Maucherat
Costin Manolache wrote: We still need separate dirs for native code and java I think. What about: tc6(.0.x ?)/trunk/java tc6/trunk/native tc6/trunk/webapps tc6/trunk/res There's a native folder too, and most likely there should be a test folder too. and the docs webapp at top level, as Yo

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Costin Manolache
We still need separate dirs for native code and java I think. What about: tc6(.0.x ?)/trunk/java tc6/trunk/native tc6/trunk/webapps tc6/trunk/res and the docs webapp at top level, as Yoav suggested. "share" has a long history - I think JDK is organized this way, with separate dirs for windows,

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Ian Darwin
So let's make it: - tc6.0.x/trunk: - src: all the relevant sources go there - webapps: all our current webapps, including the examples webapps - resources: misc resources, such as configuration files (server.xml), readmes, etc +1

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Remy Maucherat
Yoav Shapira wrote: So let's make it: - tc6.0.x/trunk: - src: all the relevant sources go there - webapps: all our current webapps, including the examples webapps - resources: misc resources, such as configuration files (server.xml), readmes, etc OK. One other thing: can we put docs u

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Yoav Shapira
> So let's make it: > - tc6.0.x/trunk: >- src: all the relevant sources go there >- webapps: all our current webapps, including the examples webapps >- resources: misc resources, such as configuration files > (server.xml), readmes, etc OK. One other thing: can we put docs under trunk

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Remy Maucherat
Yoav Shapira wrote: I've been meaning to ask this for years now: what's the purpose of the "share" directory under src? We share all our source by definition, so it just seems like an extra layer... I have no idea what "share" means either ;) So let's make it: - tc6.0.x/trunk: - src: all th

Re: Tomcat 6 source organisation part 2

2006-03-01 Thread Yoav Shapira
I've been meaning to ask this for years now: what's the purpose of the "share" directory under src? We share all our source by definition, so it just seems like an extra layer... Yoav On 3/1/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: > Hi, > > Given the comments, I propose using a single repo

Re: Tomcat 6 source organisation

2006-02-28 Thread Yoav Shapira
> At this point, I don't think there's a big need to decide on these > components. From what I understand, the general opinion is to have a > "src" folder containing all the source, with a target that builds > everything, and then have subtargets for packaging individual components. Yeah. Yoav -

Re: Tomcat 6 source organisation

2006-02-28 Thread Remy Maucherat
Mark Thomas wrote: Remy Maucherat wrote: Hi, I think it is time to decide how the source repository is going to be organized, with the questions being: - how many source folders do we need (Costin wanted one, while others like Jacob seem to want "modules") ? - do we continue to use Ant ? - etc

Re: Tomcat 6 source organisation

2006-02-28 Thread Filip Hanik - Dev Lists
good idea, I will refactor that. Filip Remy Maucherat wrote: Costin Manolache wrote: Of course, this is a case where you need a separate module. IMHO it is a bad sign when you have to do this - maybe you could use a different package name instead of same class names, or refactor a bit so you

Re: Tomcat 6 source organisation

2006-02-28 Thread Remy Maucherat
Costin Manolache wrote: Of course, this is a case where you need a separate module. IMHO it is a bad sign when you have to do this - maybe you could use a different package name instead of same class names, or refactor a bit so you don't depend on the class name. But if for any reason you have t

Re: Tomcat 6 source organisation

2006-02-28 Thread Costin Manolache
Of course, this is a case where you need a separate module. IMHO it is a bad sign when you have to do this - maybe you could use a different package name instead of same class names, or refactor a bit so you don't depend on the class name. But if for any reason you have to use the same classname,

Re: Tomcat 6 source organisation

2006-02-28 Thread Filip Hanik - Dev Lists
I would prefer to keep the module source tree separate. For example, the "ha" module (cluster2) uses the same classes as the "cluster", but they are being enhanced for performance and modularity. merging all this into one tree would be a pain in the neck. Filip Costin Manolache wrote: On 2/2

Re: Tomcat 6 source organisation

2006-02-28 Thread Costin Manolache
On 2/28/06, Mark Thomas <[EMAIL PROTECTED]> wrote: > Remy Maucherat wrote: > > Hi, > > > > I think it is time to decide how the source repository is going to be > > organized, with the questions being: > > - how many source folders do we need (Costin wanted one, while others > > like Jacob seem to

Re: Tomcat 6 source organisation

2006-02-28 Thread Mark Thomas
Remy Maucherat wrote: > Hi, > > I think it is time to decide how the source repository is going to be > organized, with the questions being: > - how many source folders do we need (Costin wanted one, while others > like Jacob seem to want "modules") ? > - do we continue to use Ant ? > - etc I am

Re: Tomcat 6 source organisation

2006-02-28 Thread Filip Hanik - Dev Lists
s! I also thing we don't use maven2. +1 to use ant Peter Am 28.02.2006 um 19:49 schrieb Bill Barker: -Original Message- From: Costin Manolache [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 28, 2006 10:24 AM To: Tomcat Developers List Subject: Re: Tomcat 6 source organisat

Re: Tomcat 6 source organisation

2006-02-28 Thread Peter Rossbach
Yes! I also thing we don't use maven2. +1 to use ant Peter Am 28.02.2006 um 19:49 schrieb Bill Barker: -Original Message- From: Costin Manolache [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 28, 2006 10:24 AM To: Tomcat Developers List Subject: Re: Tomcat 6 s

RE: Tomcat 6 source organisation

2006-02-28 Thread Bill Barker
> -Original Message- > From: Costin Manolache [mailto:[EMAIL PROTECTED] > Sent: Tuesday, February 28, 2006 10:24 AM > To: Tomcat Developers List > Subject: Re: Tomcat 6 source organisation > > On 2/28/06, Peter Rossbach <[EMAIL PROTECTED]> wrote: > &

Re: Tomcat 6 source organisation

2006-02-28 Thread Costin Manolache
On 2/28/06, Peter Rossbach <[EMAIL PROTECTED]> wrote: > We can have maven2 dependency management without use maven2 complete. > > see. http://maven.apache.org/ant-tasks.html I have no problem with using maven or similar tasks for downloading the deps, if they can provide the same functionality wit

Re: Tomcat 6 source organisation

2006-02-28 Thread Peter Rossbach
We can have maven2 dependency management without use maven2 complete. see. http://maven.apache.org/ant-tasks.html I thing maven is good for standard prepare/compile/test, but is heavy to use with spezial things like the current tomcat release build. I have heard that some "go back to ant" di

Re: Tomcat 6 source organisation

2006-02-28 Thread Costin Manolache
On 2/28/06, Keith Wannamaker <[EMAIL PROTECTED]> wrote: > +1 for consolidating into a single module/src folder. > > maven has matured since I last looked. It seems the biggest advantages > for us would be dependency management and a common build layout. I > don't have a feel for how much work it

Re: Tomcat 6 source organisation

2006-02-28 Thread Remy Maucherat
Yoav Shapira wrote: Overall, I'm +1 on Ant (-0.5 on Maven), and +0 to a single source tree and other consolidations / clarifications / improvements that'll make it easier to work with Tomcat's source... Ok, this sounds good to me. Yoav Shapira Senior Architect Nimalex LLC 1 Mifflin Place, Sui

Re: Tomcat 6 source organisation

2006-02-28 Thread Mladen Turk
Remy Maucherat wrote: Costin Manolache wrote: Having a single source tree would also greatly simplify the ant file, Obviously, the build script would be far far simpler. Personally, I am also in favor of a single source tree, since it's simply much easier to work with. I hope this will

Re: Tomcat 6 source organisation

2006-02-28 Thread Yoav Shapira
Overall, I'm +1 on Ant (-0.5 on Maven), and +0 to a single source tree and other consolidations / clarifications / improvements that'll make it easier to work with Tomcat's source... Yoav On 2/28/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > > Why would you want to cha

Re: Tomcat 6 source organisation

2006-02-28 Thread Remy Maucherat
Costin Manolache wrote: Why would you want to change ant ??? I don't, I am asking questions. Re. source folders versus modules - we can have both of them, it's not exclusive. Single source tree makes it easy to navigate, more IDE-friendly, etc. The build file can compile as many modules as ne

Re: Tomcat 6 source organisation

2006-02-28 Thread Ian Darwin
Costin Manolache wrote: Re. source folders versus modules - we can have both of them, it's not exclusive. Single source tree makes it easy to navigate, more IDE-friendly, etc. The build file can compile as many modules as needed - either by compiling a subset of the tree, or by compiling the enti

Re: Tomcat 6 source organisation

2006-02-28 Thread Keith Wannamaker
+1 for consolidating into a single module/src folder. maven has matured since I last looked. It seems the biggest advantages for us would be dependency management and a common build layout. I don't have a feel for how much work it would take to convert, but it doesn't seem like we would loos

Re: Tomcat 6 source organisation

2006-02-28 Thread Costin Manolache
Why would you want to change ant ??? Re. source folders versus modules - we can have both of them, it's not exclusive. Single source tree makes it easy to navigate, more IDE-friendly, etc. The build file can compile as many modules as needed - either by compiling a subset of the tree, or by compil

Re: Tomcat 6 source organisation

2006-02-28 Thread Remy Maucherat
Yoav Shapira wrote: Hola, Ant as opposed to Maven, or to something else? I like Ant... Yes, I meant it as Ant vs Maven 2, indeed. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTE

Re: Tomcat 6 source organisation

2006-02-28 Thread Yoav Shapira
Hola, Ant as opposed to Maven, or to something else? I like Ant... Yoav On 2/28/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: > Hi, > > I think it is time to decide how the source repository is going to be > organized, with the questions being: > - how many source folders do we need (Costin want