Hmm, makes me think about two comments:
1. Looks like a custom formatter not matching inline syntax of abstract
logging valve so maybe extract the parser/element factory in a class
reusable by multiple implementations.
2. Your pre and post are specific to json but dont enable native json since
nul
On Thu, Jan 21, 2021 at 03:28:12PM +0100, Romain Manni-Bucau wrote:
> Hi
Hi,
> Why cant it be added as element earlier at pattern parsing time? Would
> avoid to have two particular cases and keep current pattern/impl.
> A %java or so sounds more natural no?
Mhh, maybe I just share my idea of th
Hi
Why cant it be added as element earlier at pattern parsing time? Would
avoid to have two particular cases and keep current pattern/impl.
A %java or so sounds more natural no?
Le jeu. 21 janv. 2021 à 13:59, Thomas Meyer a écrit :
> a sub class can extend before and after the addElement loop
> -Original Message-
> From: Huxing Zhang [mailto:huxing@alibaba-inc.com]
> Sent: Friday, September 23, 2016 12:58 PM
> To: Tomcat Developers List ; gavin
>
> Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
>
> Hi Gavin,
>
>
tc8.5.x trunk
> -Original Message-
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Sent: Friday, September 23, 2016 3:25 AM
> To: Tomcat Developers List
> Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
>
> Gavin,
&g
> -Original Message-
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Sent: Friday, September 23, 2016 3:25 AM
> To: Tomcat Developers List
> Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
>
> Gavin,
>
> On 9/22
Gavin,
On 9/22/16 1:03 AM, Gavin McDonald wrote:
> Please find attached 3 patches for tweaks to the rat-excludes file in trunk
> and the 8.0 and 8.5 branches.
>
> RAT tests are currently producing invalid xml reports due to files that
> should be excluded
> (and therefore xml parser cant convert
Am 27.05.2016 um 23:42 schrieb gradstud:
Good afternoon,
Your emails back and forth are all going through our graduate admissions email,
can you please find another place for your Bugzilla, Apache, Tomcat business.
You should find instructions to unsubscribe yourself from this
mailinglist at th
Good afternoon,
Your emails back and forth are all going through our graduate admissions email,
can you please find another place for your Bugzilla, Apache, Tomcat business.
Thank you
From: Sadik Kalia [mailto:kalia.sa...@gmail.com]
Sent: Friday, May 27, 2016 3:36 PM
To: dev@tomcat.apache.org
S
On 13/03/2016 19:56, Patrick Beckmann wrote:
> Hello,
>
> As an occasional user of Tomcat I was missing HTTP Public Key Pinning
> header support¹. So I have added it to the existing
> "HttpHeaderSecurityFilter" class and would like to share it with you in
> case you are interested. Please see the
On 16/03/2015 14:50, Raghavendran N wrote:
>> diff --git a/java/org/apache/tomcat
/websocket/server/WsServerContainer.java
>> b/java/org/apache/tomcat/websocket/server/WsServerContainer.java
>> index d2c824c..a663e8e 100644
>> --- a/java/org/apache/tomcat/websocket/server/WsServerContainer.java
>>
On 16/03/2015 14:50, Raghavendran N wrote:
> diff --git a/java/org/apache/tomcat/websocket/server/WsServerContainer.java
> b/java/org/apache/tomcat/websocket/server/WsServerContainer.java
> index d2c824c..a663e8e 100644
> --- a/java/org/apache/tomcat/websocket/server/WsServerContainer.java
> +++ b/
Hi Chris,
thank you for your answer. Will do. :-)
kind regards,
Björn
On May 24, 2013, at 23:10 , Christopher Schultz
wrote:
> Björn,
>
> On 5/24/13 4:08 PM, Björn Raupach wrote:
>> out of pure curiosity I was browsing the source of jdbc-pool and
>> ended up looking through FairBlockingQueue
Björn,
On 5/24/13 4:08 PM, Björn Raupach wrote:
> out of pure curiosity I was browsing the source of jdbc-pool and
> ended up looking through FairBlockingQueue. FairBlockingQueue
> utilises a global ReentrantLock for mutual exclusion. Common practice
> is to always follow a call to lock with a try
Greg Turnquist wrote:
>Attached is a patch file where I went through looking for usage of
>concrete
>class MemberImpl, and when possible, replaced it with the interface
>Member.
>I added a few (maybe three) methods to the Member interface definition
>to
>support those changes. I ran the entire te
I created Bug 53800 and attached the patch file. Is that all that is necessary
to get this patch considered?
On Aug 29, 2012, at 8:43 PM, Konstantin Kolinko wrote:
> 2012/8/30 Kevin Wooten :
>> New to contributing to Tomcat so and not sure of the protocol for patches.
>> Details follow…
>>
2012/8/30 Kevin Wooten :
> New to contributing to Tomcat so and not sure of the protocol for patches.
> Details follow…
>
> I ran into an issue using starting Tomcat (7.0.29) from inside Eclipse with
> the "Serve modules without publishing" option enabled for a project that uses
> CDI (Weld 1.1
I see now you don't seem to be able to attach patch files on this mailing list.
The patch is so small… here it is…
Index: java/org/apache/naming/resources/FileDirContext.java
===
--- java/org/apache/naming/resources/FileDirContext.ja
2011/11/3 Konstantin Kolinko :
> Hi!
>
> The patch:
> http://people.apache.org/~kkolinko/patches/2011-11-03_tc8_fastShutdown.patch
>
> It saves 1 second for each Tomcat shutdown during tests,
> by skipping a sleep in AbstractEndpoint.pause().
>
> I think it is worth doing, but maybe there are other
File a bug, attach the patch to the bug etc...
p
On 5 October 2011 11:33, Francis Galiegue wrote:
> Found by FindBugs. startService() and stopService() both return boolean, so it
> is likely that the '&' is a typo and '&&' was meant.
> ---
> .../tribes/membership/McastServiceImpl.java |
On 08/11/2010 18:05, Remy Maucherat wrote:
> On Mon, 2010-11-08 at 18:26 +0100, Rainer Jung wrote:
>> On 08.11.2010 18:05, Remy Maucherat wrote:
>>> I'll up that to -1, with another concern I've just thought about: if
>>> using a session id path which includes more than one webapp, the version
>>>
On Mon, 2010-11-08 at 18:26 +0100, Rainer Jung wrote:
> On 08.11.2010 18:05, Remy Maucherat wrote:
> > I'll up that to -1, with another concern I've just thought about: if
> > using a session id path which includes more than one webapp, the version
> > numbers will have problems matching between th
On 08/11/2010 17:26, Rainer Jung wrote:
> On 08.11.2010 18:05, Remy Maucherat wrote:
>> I'll up that to -1, with another concern I've just thought about: if
>> using a session id path which includes more than one webapp, the version
>> numbers will have problems matching between the two webapps.
>
On 08.11.2010 18:05, Remy Maucherat wrote:
I'll up that to -1, with another concern I've just thought about: if
using a session id path which includes more than one webapp, the version
numbers will have problems matching between the two webapps.
You mean situations like portals / emptysessionpa
On Mon, 2010-11-08 at 15:46 +, Mark Thomas wrote:
> I did consider that approach but rejected it for a couple of reasons:
> - Mapper needs to be manager aware - it isn't currently
Add a one method interface to be able to perform a session lookup.
> - Performance
Likely, having to do String m
On 08/11/2010 15:40, Remy Maucherat wrote:
> On Mon, 2010-11-08 at 14:31 +, Mark Thomas wrote:
>> We might be able to avoid that be limiting the version to just integers.
>> I think that is reasonable but would like to hear some feedback from others.
>>
>> That does raise the issue of whether t
On Mon, 2010-11-08 at 14:31 +, Mark Thomas wrote:
> We might be able to avoid that be limiting the version to just integers.
> I think that is reasonable but would like to hear some feedback from others.
>
> That does raise the issue of whether to convert the provided version to
> a (zero padd
On 08/11/2010 15:09, Rainer Jung wrote:
> Furthermore we could as a convenience convert all dots to underscores and
Or s/dots/non-alphanumerics/
p
0x62590808.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature
On 08.11.2010 15:27, Mark Thomas wrote:
Yep - that looks like a left-over from when I was playing with int
rather than String for version. I'm still in two minds about that bit.
There are places internally where using String makes it easier but
limiting it to int would allow us to avoid a bunch o
On 06/11/2010 13:00, Rainer Jung wrote:
> On 06.11.2010 12:57, Tim Funk wrote:
>> When running mod_jk with sticky session, but not using tomcat clustering
>> ... Will adding a new version append the version number to the end of
>> the session cookie AFTER the engineId (used by mod_jk for determinin
On 06/11/2010 11:57, Tim Funk wrote:
> This might cause a problem of using == instead of equals() for strcmp
>
> if (version == (request.getContext().getWebappVersion())) {
> mapRequired = false;
> }
Yep - that looks like a left-over from when I was playing with int
rather than String for ver
On 06.11.2010 14:00, Rainer Jung wrote:
On 06.11.2010 12:57, Tim Funk wrote:
When running mod_jk with sticky session, but not using tomcat clustering
... Will adding a new version append the version number to the end of
the session cookie AFTER the engineId (used by mod_jk for determining
where
On 06.11.2010 12:57, Tim Funk wrote:
When running mod_jk with sticky session, but not using tomcat clustering
... Will adding a new version append the version number to the end of
the session cookie AFTER the engineId (used by mod_jk for determining
where to route the request)
Tried it and the
This might cause a problem of using == instead of equals() for strcmp
if (version == (request.getContext().getWebappVersion())) {
mapRequired = false;
}
When running mod_jk with sticky session, but not using tomcat clustering
... Will adding a new version append the version number to the e
On 12 April 2010 11:25, Pid * wrote:
> On 11 April 2010 14:56, Pid * wrote:
>
>>
>> On 11 April 2010 00:17, Konstantin Kolinko wrote:
>>
>>> 2010/4/10 Pid :
>>> > In lieu of of a Bugzilla enhancement (and hoping that I have the right
>>> end
>>> > of the stick).
>>> >
>>>
>>> If I guess your int
On 11 April 2010 14:56, Pid * wrote:
>
> On 11 April 2010 00:17, Konstantin Kolinko wrote:
>
>> 2010/4/10 Pid :
>> > In lieu of of a Bugzilla enhancement (and hoping that I have the right
>> end
>> > of the stick).
>> >
>>
>> If I guess your intention correctly,
>> you want to prevent deployment
On 11 April 2010 00:17, Konstantin Kolinko wrote:
> 2010/4/10 Pid :
> > In lieu of of a Bugzilla enhancement (and hoping that I have the right
> end
> > of the stick).
> >
>
> If I guess your intention correctly,
> you want to prevent deployment of a war file that is still open for
> writing?
>
2010/4/10 Pid :
> In lieu of of a Bugzilla enhancement (and hoping that I have the right end
> of the stick).
>
If I guess your intention correctly,
you want to prevent deployment of a war file that is still open for writing?
If that is the case, then asking for modification time probably will
no
Created bug 48941.
I would like it to be integrated into Tomcat 6, if possible.
Proposed changes are light, IMHO.
With kindest personal regards,
Ruslan Gainutdinov
On Thu, Mar 18, 2010 at 4:18 PM, Konstantin Kolinko
wrote:
> 2010/3/18 Ruslan Gainutdinov :
>> Please review this patch for inclusi
2010/3/18 Ruslan Gainutdinov :
> Please review this patch for inclusion in trunk.
Your attachment is lost.
Please create a Bugzilla entry for Tomcat 7 and attach it there,
though I cannot comment on whether it will be applied or not.
Best regards,
Konstantin Kolinko
Brane F. Gračnar wrote:
> Hello :)
>
> This patch adds support for X-Forwarded-For (or any other) http request
> header
> holding ip address of real client so that request.getRemoteAddr() return
> correct address if tomcat is running behind apache or any other reverse http
> proxy.
Note you c
On 11/12/2009 16:36, Brane F. Gračnar wrote:
> Hello :)
>
> This patch adds support for X-Forwarded-For (or any other) http request
> header
> holding ip address of real client so that request.getRemoteAddr() return
> correct address if tomcat is running behind apache or any other reverse http
On 07.04.2009 00:46, Brane F. Gračnar wrote:
> On Monday 06 April 2009 18:19:26 Mark Thomas wrote:
>> It would also be a good idea to
>> include an update to the documentation in your patch.
>
> I know that this is a stupid question, but i don't have any idea which files
> to update :)
http://m
On Monday 06 April 2009 18:19:26 Mark Thomas wrote:
> Please create a bugzilla entry for this and attach the patch there so it
> doesn't get lost.
Done.
> To keep this consistent with httpOnly, this should be configured at the
> Context level rather than the manager.
Ok, this makes sense. I'll t
Brane F. Grac(nar wrote:
> Hello :)
>
> We needed subdomain session cookie support for our java webapp; currently
> there is no way to configure cookie domain attribute in tomcat <= 6.0.18.
>
> This patch adds this functionality. Cookie domain can be specified as Manager
> property (default nul
Giannini Alessandro wrote:
> This patch is useful when you want handle keystore password from external
> class.
> To do this, I added two additional parameters (in Connector tag of
> server.xml) to call external method and get Password String.
>
> - Parameter keystorePassHandler (in form some.
Michael:
It sounds like a good change. I have not tried the patch (BTW: I
believe that FarmWarDeployer is now considered
unsupported/deprecated), but the theory here sounds right. I think it
makes sense to consolidate the implementations of the code that
removes the files, if they are basically
Can someone in the know comment on this? Is it intended behavior for tomcat
to follow symlinks when deleting the exploded directory during undeploy? Or
should I file a bug and attached this patch to it?
Michael Bailey
On Thu, Jul 3, 2008 at 11:27 AM, Michael Bailey <[EMAIL PROTECTED]>
wrote:
> P
Patch pasted in case the attachement didn't make throught the list:
Index: java/org/apache/tomcat/util/FileUtils.java
===
--- java/org/apache/tomcat/util/FileUtils.java (revision 0)
+++ java/org/apache/tomcat/util/FileUtils.java (re
This patch has been committed as bug 44645.
-- Seth
Mark Thomas wrote:
Seth Leger wrote:
Hi devs,
I've added support to the JNDIRealm so that a custom
javax.net.SocketFactory can be specified for the JNDI connection.
This is necessary so that you can perform customized SSL negotiation
on
Mark Thomas wrote:
Patches posted directly to the dev list can get overlooked if someone
doesn't act on them straight away. To protect against this, please
create a bugzilla entry and attach your patch there.
Cheers,
Mark
Will do, thanks for the tip.
-- Seth
--
Seth Leger wrote:
Hi devs,
I've added support to the JNDIRealm so that a custom
javax.net.SocketFactory can be specified for the JNDI connection. This
is necessary so that you can perform customized SSL negotiation on the
connection. For instance, it allows you to connect to an SSL server wit
Hi Remy,
True, but today it exists a lot of applications/Service that want
control the connection.
At my Comet example I have also miss this simple feature.
I feel that the patch looks good.
Peter
Am 25.01.2008 um 13:14 schrieb Remy Maucherat:
On Thu, 2008-01-24 at 17:11 -0500, John Wehl
On Thu, 2008-01-24 at 17:11 -0500, John Wehle wrote:
> Currently if a servlet uses:
>
> res.setHeader("Connection", "close");
>
> tomcat just sets the header and sends the reponse to the client. It
> then waits for the client to close the connection. In some cases (i.e.
> buggy client) the cl
Eiji Takahashi wrote:
Dear developers.
I made the mod_jk patch to support ipv6 between mod_jk and Tomcat.
The detection of getaddrinfo() and implementation of jk_resolve()
referred to APR.
This patch was tested in the following environments (Do not compile in
other OS's).
1.RHEL4/5 with Apache
David Blevins wrote:
On Sep 14, 2007, at 10:34 AM, Filip Hanik - Dev Lists wrote:
- adding methods or altering the signature of the javax. APIs is
clearly illegal
yes, that would not be spec compliant, that's essentially what spec
compliant means, that we pass the signature test (which we hav
On Sep 14, 2007, at 10:34 AM, Filip Hanik - Dev Lists wrote:
- adding methods or altering the signature of the javax. APIs is
clearly illegal
yes, that would not be spec compliant, that's essentially what spec
compliant means, that we pass the signature test (which we haven't
done for a co
Remy Maucherat wrote:
Filip Hanik - Dev Lists wrote:
Yoav Shapira wrote:
Hey,
On 9/13/07, Andrew J Snodgrass <[EMAIL PROTECTED]> wrote:
The attached patch adds support for the direct use of enums in the
attributes of tags.
Cool idea. Is it in Bugzilla?
I agree, think it is very
Filip Hanik - Dev Lists wrote:
Yoav Shapira wrote:
Hey,
On 9/13/07, Andrew J Snodgrass <[EMAIL PROTECTED]> wrote:
The attached patch adds support for the direct use of enums in the
attributes of tags.
Cool idea. Is it in Bugzilla?
I agree, think it is very useful. Would you mind
Yoav Shapira wrote:
Hey,
On 9/13/07, Andrew J Snodgrass <[EMAIL PROTECTED]> wrote:
The attached patch adds support for the direct use of enums in the
attributes of tags.
Cool idea. Is it in Bugzilla?
I agree, think it is very useful. Would you mind opening a bugzilla,
http://issu
Yoav Shapira wrote:
Hey,
On 9/13/07, Andrew J Snodgrass <[EMAIL PROTECTED]> wrote:
The attached patch adds support for the direct use of enums in the
attributes of tags.
Cool idea. Is it in Bugzilla?
I agree it seems like a good idea, but if it is not in the
specification, then there's no
Hey,
On 9/13/07, Andrew J Snodgrass <[EMAIL PROTECTED]> wrote:
> The attached patch adds support for the direct use of enums in the
> attributes of tags.
Cool idea. Is it in Bugzilla?
Yoav
-
To unsubscribe, e-mail: [EMAIL PROT
Remy Maucherat wrote:
> I am not certain they're that redundant. I would leave them in just to
I'm not quite sure I understand why, so please could you elaborate.
* Since setString() is invoked after setChars(), a toString() on (which
is pretty much the only method invoked on mappingData.reques
>> Attached is a simple patch (for TC 6.0's trunk) that removes a couple
>> of lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper
>
> I am not certain they're that redundant. I would leave them in just to
> be safe given that the cost of these calls is very low.
They are not red
Arvind Srinivasan wrote:
Attached is a simple patch (for TC 6.0's trunk) that removes a couple of
lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper
I am not certain they're that redundant. I would leave them in just to
be safe given that the cost of these calls is very low.
Then why was proxyPort and proxyName not done in a Valve or Filter? I
assumed that I should be following the same route that other, similar
requirements followed.
With regards to a Filter, what if I have 30 webapps, and each one needs
the correct request.getRemoteAddr? Could one map a filter globa
Filip Hanik - Dev Lists wrote:
This is a question for the user list, it might be better for you to take
the inquiries there, and you shouldn't need to hack tomcat for something
like this.
Simply create a filter, that wraps your HttpServletRequest in a
HttpServletRequestWrapper,
worst case you
This is a question for the user list, it might be better for you to take
the inquiries there, and you shouldn't need to hack tomcat for something
like this.
Simply create a filter, that wraps your HttpServletRequest in a
HttpServletRequestWrapper,
worst case you could create Valve that does it
yep, I'll get this one in
Haroon Rafique wrote:
On Apr 6 at 9:54am, HR=>Haroon Rafique <[EMAIL PROTECTED]> wrote:
HR> On Mar 22 at 3:04pm, FHDL=>Filip Hanik - Dev Lists <[EMAIL PROTECTED]>
wrote:
HR>
HR> FH> patch looks good to me, +1,
HR> FH> if no objections arise, then I can submit, we'l
On Apr 6 at 9:54am, HR=>Haroon Rafique <[EMAIL PROTECTED]> wrote:
HR> On Mar 22 at 3:04pm, FHDL=>Filip Hanik - Dev Lists <[EMAIL PROTECTED]>
wrote:
HR>
HR> FH> patch looks good to me, +1,
HR> FH> if no objections arise, then I can submit, we'll wait until end of week.
HR> FH> Filip
HR> FH>
HR>
Yoav Shapira wrote:
> Darryl,
> Thanks for reporting this. I saw it
> (http://issues.apache.org/bugzilla/show_bug.cgi?id=37819) before the
> release but forgot to fix it, so it will go into 5.5.17. Thanks,
>
> Yoav
>
> On 3/13/06, Darryl L. Miles <[EMAIL PROTECTED]> wrote:
>
>>Dear Developers,
Darryl,
Thanks for reporting this. I saw it
(http://issues.apache.org/bugzilla/show_bug.cgi?id=37819) before the
release but forgot to fix it, so it will go into 5.5.17. Thanks,
Yoav
On 3/13/06, Darryl L. Miles <[EMAIL PROTECTED]> wrote:
>
> Dear Developers,
>
> When following the build instruc
Tim Funk wrote:
I see the point of the native dir.
Right, anything but bin is OK.
lib/native/{platform}/
I see the point of the native dir. Once my sysadmin sees this (whose not much
of a java guy) - he'd be confused in seeing a bin dir with jar, bat, sh, and
so files in it. Maybe itstime to reorg the the bin package dir. Possibly
something along the lines of:
bin/ <-- All the sh and bat files
li
Mladen Turk wrote:
Hi,
Any objections for committing this patch?
It sets LD_LIBRARY_PATH to include CATALINA_HOME/native
if CATALINA_HOME/native/libtcnative-1.so is present.
Why not using the "bin" folder ?
Rémy
-
To unsubsc
Bill Barker wrote:
I agree that the patch is simply masking the real problem. With the current
mod_jk code what Tomcat sees is:
Cookie: myCookie=1234
Cookie: $Version=1
Huh, looking at the source I see the problem.
we are using:
'if (memcmp(p, "OOKIE", 5)'
so both cookie and cookie2 a
> -Original Message-
> From: Mladen Turk [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, December 07, 2005 10:09 AM
> To: Tomcat Developers List
> Subject: Re: [PATCH] Cookie, Cookie2 Header fix for mod_jk
>
> Andre Gebers wrote:
> > Hi,
> >
> > n
Andre Gebers wrote:
Hi,
newer versions of opera send the Cookie2-header along with the
Cookie-header which looks somewhat like this:
Right, but the patch would not work.
It would be a security hole, because the http rfc
diferentiates cookie from cookie2.
Right now the Cookie2 header is pas
Patrick,
Thanks for your contribution. However, the mailing list doesn't like
attachments. Please can you open a Bugzilla item for this and attach your patch
to that?
Thanks,
Mark
_
From: May, Patrick [mailto:[EMAIL PROTECTED]
Sent: Wednesday, October 12, 2005 7:55 PM
To: 'tomcat-
79 matches
Mail list logo
