Hi
Why cant it be added as element earlier at pattern parsing time? Would
avoid to have two particular cases and keep current pattern/impl.
A %java or so sounds more natural no?
Le jeu. 21 janv. 2021 à 13:59, Thomas Meyer <tho...@m3y3r.de> a écrit :
> a sub class can extend before and after the addElement loop to
> establish a context via thread-dependend CharArrayWriter object.
> ---
> java/org/apache/catalina/valves/AbstractAccessLogValve.java | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/java/org/apache/catalina/valves/AbstractAccessLogValve.java
> b/java/org/apache/catalina/valves/AbstractAccessLogValve.java
> index e23f49d3a5..5e774c2320 100644
> --- a/java/org/apache/catalina/valves/AbstractAccessLogValve.java
> +++ b/java/org/apache/catalina/valves/AbstractAccessLogValve.java
> @@ -685,9 +685,11 @@ public abstract class AbstractAccessLogValve extends
> ValveBase implements Access
> result = new CharArrayWriter(128);
> }
>
> + preLogAddElement(result);
> for (int i = 0; i < logElements.length; i++) {
> logElements[i].addElement(result, date, request, response,
> time);
> }
> + postLogAddElement(result);
>
> log(result);
>
> @@ -699,6 +701,9 @@ public abstract class AbstractAccessLogValve extends
> ValveBase implements Access
>
> // -------------------------------------------------------- Protected
> Methods
>
> + protected void preLogAddElement(CharArrayWriter result) {}
> + protected void postLogAddElement(CharArrayWriter result) {}
> +
> /**
> * Log the specified message.
> *
> --
> 2.20.1
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
