Re: Feedback for Bayeux contribution

2008-07-22 Thread Peter Rossbach
Hi Filip and Guy, great news +1 to commit the bayeux stuff. It was a big step to show the usage of async programming style. Peter Am 17.07.2008 um 03:47 schrieb Filip Hanik - Dev Lists: I'd like some feedback on the contribution, before I call for a vote for inclusion thanks Filip [E

Re: Feedback for Bayeux contribution

2008-07-17 Thread Costin Manolache
Thanks, my +1 on committing it to tomcat, seems like a good start and a good example on how to use the async stuff. Costin On Thu, Jul 17, 2008 at 7:50 AM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > >> On Thu, Jul 17, 2008 at 7:00 AM, Filip Hanik - Dev Lists <

Re: Feedback for Bayeux contribution

2008-07-17 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: On Thu, Jul 17, 2008 at 7:00 AM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: Remy Maucherat wrote: On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote: On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:

Re: Feedback for Bayeux contribution

2008-07-17 Thread Costin Manolache
On Thu, Jul 17, 2008 at 7:00 AM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > Remy Maucherat wrote: > >> On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote: >> >> >>> On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists >>> <[EMAIL PROTECTED]> wrote: >>> >>> I'd like some feedb

Re: Feedback for Bayeux contribution

2008-07-17 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote: On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: I'd like some feedback on the contribution, before I call for a vote for inclusion thanks Filip [EMAIL PROTECTED] wrote:

Re: Feedback for Bayeux contribution

2008-07-17 Thread Filip Hanik - Dev Lists
Costin Manolache wrote: BTW - any docs associated with this ? For example, what's the relation with JMS and other products/APIs ? Briefly looking at the code - it would be nice to include javadocs at least on the public APIs, org.apache.cometd.bayeux is javadoc:ed, that's the public API, noth

Re: Feedback for Bayeux contribution

2008-07-17 Thread Remy Maucherat
On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote: > On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists > <[EMAIL PROTECTED]> wrote: > > I'd like some feedback on the contribution, before I call for a vote for > > inclusion > > > > thanks > > Filip > > > > [EMAIL PROTECTED] wrote: > >> >

Re: Feedback for Bayeux contribution

2008-07-17 Thread Yoav Shapira
On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > I'd like some feedback on the contribution, before I call for a vote for > inclusion > > thanks > Filip > > [EMAIL PROTECTED] wrote: >> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413 I'm happy to wel

Re: Feedback for Bayeux contribution

2008-07-16 Thread Costin Manolache
BTW - any docs associated with this ? For example, what's the relation with JMS and other products/APIs ? Briefly looking at the code - it would be nice to include javadocs at least on the public APIs, and some indication of which are the public / frozen APIs and which are just impl methods that sh

Re: Feedback for Bayeux contribution

2008-07-16 Thread Costin Manolache
I think this is a nice contribution ( haven't reviewed the code in detail yet ), but seems like a separate enough feature to be distributed as a separate/optional package. I can't think of any good reason to include it in the base tomcat distro ( except that a lot of other stuff is there and should

Feedback for Bayeux contribution

2008-07-16 Thread Filip Hanik - Dev Lists
I'd like some feedback on the contribution, before I call for a vote for inclusion thanks Filip [EMAIL PROTECTED] wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=45413 Summary: Contribution of Bayeux implementation for Tomcat Product: Tomcat 6 Versio