Thanks, my +1 on committing it to tomcat, seems like a good start and a good example on how to use the async stuff.
Costin On Thu, Jul 17, 2008 at 7:50 AM, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > >> On Thu, Jul 17, 2008 at 7:00 AM, Filip Hanik - Dev Lists < >> [EMAIL PROTECTED]> >> wrote: >> >> >> >>> Remy Maucherat wrote: >>> >>> >>> >>>> On Thu, 2008-07-17 at 07:39 -0400, Yoav Shapira wrote: >>>> >>>> >>>> >>>> >>>>> On Wed, Jul 16, 2008 at 9:47 PM, Filip Hanik - Dev Lists >>>>> <[EMAIL PROTECTED]> wrote: >>>>> >>>>> >>>>> >>>>> >>>>>> I'd like some feedback on the contribution, before I call for a vote >>>>>> for >>>>>> inclusion >>>>>> >>>>>> thanks >>>>>> Filip >>>>>> >>>>>> [EMAIL PROTECTED] wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413 >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> I'm happy to welcome this contribution. It's refreshingly cool. >>>>>> >>>>>> >>>>> >>>>> >>>> OTOH, I haven't heard anything about bayeux lately. Is it actually >>>> picking up enough adoption to be included with Tomcat ? >>>> >>>> >>>> >>>> >>> I'd follow Costin's advice, have it be a separate component, if it does >>> become popular, it can be considered for inclusion then >>> >>> >>> >> >> Great, thank you. >> >> I assume the first step is to check in the code in tomcat ( based on the >> bug >> layout - looks like separate dir, which is probably better in this case ). >> After that it'll follow the normal process for a release - and I hope >> you'll >> add more to README at least before release. >> >> > of course, as well as documentation. but one has to start somewhere. > >> Few more questions: >> I would guess that only part of it is specific to tomcat ( connector >> interface ) - do you plan to have it support other servlet engines as well >> ( >> wouldn't be a bad idea if you want adoption for your API - or bayeux ) ? >> >> > this can of course be implemented as a regular servlet, but would be less > resource efficient. > doing it through comet, allows it to use the async io features. > But I think it would be good to implement the service() method of > BayeuxServlet, and then it would be portable > >> What kind of config is needed - and if any, is it in server.xml or can it >> be >> done via web.xml in apps that use it ? >> >> > web.xml only > >> What kind of monitoring do you have/plan - didn't see any JMX. I guess >> it'll >> affect the number of open connections. >> >> > number of open connections should be monitored at the tomcat level, but > JMX should be on the road map in terms of what clients are connected, what > channels they are subscribed to etc > > Filip > >> >> Costin >> >> >> >> >> >>> Filip >>> >>> >>> Rémy >>> >>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>> For additional commands, e-mail: [EMAIL PROTECTED] >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>> For additional commands, e-mail: [EMAIL PROTECTED] >>> >>> >>> >>> ------------------------------------------------------------------------ >>> >>> No virus found in this incoming message. >>> Checked by AVG. Version: 7.5.526 / Virus Database: 270.5.0/1556 - Release >>> Date: 7/16/2008 4:56 PM >>> >>> >> > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
