BTW - any docs associated with this ? For example, what's the relation with JMS and other products/APIs ? Briefly looking at the code - it would be nice to include javadocs at least on the public APIs, and some indication of which are the public / frozen APIs and which are just impl methods that shouln't be used by apps. A small automated test would be extra nice ( if you really want feedback ) :-)
Costin On Wed, Jul 16, 2008 at 10:45 PM, Costin Manolache <[EMAIL PROTECTED]> wrote: > I think this is a nice contribution ( haven't reviewed the code in detail > yet ), but seems like a separate enough feature > to be distributed as a separate/optional package. > I can't think of any good reason to include it in the base tomcat distro ( > except that a lot of other stuff is there and > shouldn't ) - it is not required in order to implement http or servlet > specs, seems useful for a relatively narrow > user base, etc. > > Costin > > > On Wed, Jul 16, 2008 at 6:47 PM, Filip Hanik - Dev Lists < > [EMAIL PROTECTED]> wrote: > >> I'd like some feedback on the contribution, before I call for a vote for >> inclusion >> >> thanks >> Filip >> >> [EMAIL PROTECTED] wrote: >> >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=45413 >>> >>> Summary: Contribution of Bayeux implementation for Tomcat >>> Product: Tomcat 6 >>> Version: 6.0.16 >>> Platform: All >>> URL: http://svn.hanik.com/svn/repos/tomcat-bayeux >>> OS/Version: All >>> Status: NEW >>> Severity: enhancement >>> Priority: P2 >>> Component: Catalina >>> AssignedTo: [EMAIL PROTECTED] >>> ReportedBy: [EMAIL PROTECTED] >>> >>> >>> Created an attachment (id=22267) >>> --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22267) >>> Contribution of code >>> >>> The following bugzilla issue is a contribution of a codebase from Filip >>> Hanik(asf:fhanik) and Guy Molinari(individual) >>> Both have ICLAs on file with the ASF. >>> >>> Description: >>> The contribution is two fold >>> >>> 1. The core implementation >>> Core implementation of the Bayeux protocol using Comet and HTTP >>> External dependencies: json.jar from json.org - Apache License 2.0 >>> packages: - org.apache.cometd.bayeux APIs for web application >>> developers >>> derived from a proposed but incomplete API by Dojo Foundation >>> - org.apache.tomcat.bayeux >>> implementation of API classes >>> >>> 2. The sample applications >>> External dependencies: Dojo Toolkit, license: >>> http://trac.dojotoolkit.org/browser/dojo/trunk/LICENSE#L13 >>> >>> COPYRIGHT and LICENSE files included. >>> >>> The contribution is a full environment, to be able to download and build >>> distributions. We don't expect everything to be merged in, instead we >>> expect >>> that the source code be integrated into tomcat/trunk and we can then >>> modify the >>> existing build scripts to fit into the Tomcat build/distribution scheme >>> >>> >>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> >
