Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Mark Thomas wrote: ... Before I read you latest e-mail, I was intending to tidy up the patch attached to bug 49268 and look at applying it to trunk. Right now that looks like rewarding behaviour I have no wish to encourage so I'll be spending my time on other things instead. I'll circle back to t

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Mark Thomas
On 12/07/2010 11:28, Marc Guillemot wrote: > Mark Thomas wrote: >> Taking a confrontational approach isn't going to win you any friends and >> isn't going to help you achieve the changes you want. > > I know, but it is a desperate step. I have tried following approaches: > - provide patches ready

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Konstantin Kolinko
2010/7/12 Marc Guillemot : > >> 2. There is NO consensus on @Version format. >> (...) > > if there is no consensus, then all commits concerning this should never have > occurred ;-) The consensus is that $Date$ is broken and must not be used. Nothing else. > > Why a 80 characters limit? Is this a

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Mark Thomas wrote: On 12/07/2010 09:39, Marc Guillemot wrote: I find interesting how some (Mark, you) seem to fight against introducing checkstyle and precisely defining what should be the rules although you make exactly this kind of changes. Then you completely mis-understand my position. r

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Mark Thomas
On 12/07/2010 09:39, Marc Guillemot wrote: > I find interesting how some (Mark, you) seem to fight against > introducing checkstyle and precisely defining what should be the rules > although you make exactly this kind of changes. Then you completely mis-understand my position. My default preferen

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-12 Thread Marc Guillemot
Hi Konstantin, 1. What is TabSpacePolicy? It is not listed at: http://checkstyle.sourceforge.net/availablechecks.html There is FileTabCharacter though. http://checkstyle.sourceforge.net/config_whitespace.html#FileTabCharacter of course this is the FileTabCharacter check. Interesting to see wh

Re: [VOTE] Add Checkstyle ruleset and make code cleanups!

2010-07-10 Thread Konstantin Kolinko
Adjusted the thread subject. Was: Vote: Add Checkstyle roleset and make code cleanups! 2010/7/8 Peter Roßbach : > Hi, > > after the discussion about code style > (http://tomcat.markmail.org/thread/2c7lkzmpcuxqpgjj), I think that we must > vote for this fix: > > https://issues.apache.org/bugzilla/