https://bz.apache.org/bugzilla/show_bug.cgi?id=56397
Mark Thomas changed:
What|Removed |Added
Resolution|--- |LATER
Status|NEW
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #48 from Mark Thomas ---
Patch applied.
Sorry it took a while. I dropped this part of the source tree from my checkout
because svn up was so slow. I now have a dedicated checkout for this.
--
You are receiving this mail becau
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #47 from Pierre Viret ---
Can you please check my last patch and commit it if it's ok?
--
You are receiving this mail because:
You are the assignee for the bug.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32151|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #45 from Mark Thomas ---
Patch applied. Many thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32120|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #43 from Mark Thomas ---
Nice.
This passes a simple smoke test (WebSocket snake game).
One thing to think about when you get back is how to translate the version
number filtering to Maven.
--
You are receiving this mail beca
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32113|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #41 from Mark Thomas ---
Great. The instance starts for me too.
I suspect the issue with JSPs is that Jasper is not getting initialized.
If you look in trunk/res/META-INF you'll see various files that need to be
packaged with
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32108|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #39 from Mark Thomas ---
That fixed it.
It looks like (from a quick glance at the stack traces) the problem is that the
mbean-descriptor.xml files are not being included in the JARs. They need to
appear in the same package as t
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #38 from Pierre Viret ---
Something went wrong with the patch: I had renamed the dir:
apache-tomcat/src/main/resoucres/
To :
apache-tomcat/src/main/resources
but maybe the "svn mv" was not contained in the patch?? Can you pleas
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #37 from Mark Thomas ---
Patch applied. I still don't see the scripts or the conf directory being
created.
--
You are receiving this mail because:
You are the assignee for the bug.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32101|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #35 from Mark Thomas ---
No need to think too much about git at the moment. There doesn't seem to be
much interest in moving right now.
Patche are all applied and the build completes.
I don't see the startup scripts or the con
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32088|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #33 from Mark Thomas ---
Looks like tomcat-webapps/docs/pom.xml is missing
--
You are receiving this mail because:
You are the assignee for the bug.
-
To uns
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #32 from Mark Thomas ---
I have applied your patch. I had to apply some bits manually so apologies if
any bits got lost.
I'm done a simple test on my dev machine. svn up on the Maven layout takes ~2
minutes. svn up on /trunk ta
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Mark Thomas changed:
What|Removed |Added
Attachment #32088|0 |1
is patch|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32077|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #30 from Mark Thomas ---
Something to think about.
Tomcat might be moving to git. svn externals will no longer be available. How
would you solve this then?
--
You are receiving this mail because:
You are the assignee for the
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #29 from Pierre Viret ---
Thank you for your feedback. Here my answers:
1. Why has the license header been removed from pom.xml?
2. Every pom.xml file should have a license header.
--> I've just forgotten to copy it, I will fix
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #28 from Mark Thomas ---
A few questions/comments on the proposed patch
1. Why has the license header been removed from pom.xml?
2. Every pom.xml file should have a license header.
3. Why has the element been removed from a
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32072|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #26 from Pierre Viret ---
OK I understand and can accept your point. I will try to implement it using so
few externals as possible and upload a corresponding patch.
--
You are receiving this mail because:
You are the assignee
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #25 from Mark Thomas ---
No, your patch hasn't been applied.
I won't be applying it as I don't believe externals alone are a viable
solution. It is too slow to do svn up.
--
You are receiving this mail because:
You are the as
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #24 from Pierre Viret ---
I'm getting troubles with the svn:externals and the fact that my changes were
never committed: I always got some svn errors like "Path xyz has no committed
revision".
Did you try to commit my patch? As
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #23 from Pierre Viret ---
I have seen that the update takes some time but it is difficult for me to say
if this is really an issue or not, as the external definitions are not
committed yet.
On one hand the update is slower, on
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #22 from Mark Thomas ---
Comment on attachment 32072
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32072
Patch for tomcat-maven-layout created with "svn diff -x -u"
I do not believe that your current approach is vi
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
Attachment #32016|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #20 from Pierre Viret ---
Created attachment 32044
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32044&action=edit
patch to be applied in tomcat_maven_layout created with "svn diff"
I have created the necessary sou
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #19 from Mark Thomas ---
(In reply to Pierre Viret from comment #18)
> Would it be possible for me to commit to the sandbox/trunk-maven-layout
> repository?
Not until the dev community decides to offer you committership ;)
> I
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #18 from Pierre Viret ---
Would it be possible for me to commit to the sandbox/trunk-maven-layout
repository? I don't know how I can try & test the svn externals without being
able to commit to the repository. This is due to the
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #17 from Pierre Viret ---
The use of filters for the maven-compiler-plugin in the pom is not optimal: in
the IDE you see all the classes under the component, even if they are excluded
through filters in pom. I don't think that w
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #16 from Pierre Viret ---
I've just figured out where you have performed the changes
(tomcat/sandbox/trunk-maven-layout/) so I will be able to check this out on
Friday.
Regarding the tests: I have not tried to integrate the tes
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #15 from Pierre Viret ---
Here my answers to the first comment:
Working with the source:
1. How do you propose to update the version number after a release? Updating
every POM by hand is not viable.
--> I use the maven-version
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #14 from Mark Thomas ---
For the record a narrow as possible single external combined with
include/exclude filters in the POM looks like a good solution. I'll update the
existing modules that use multiple externals to use this a
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #13 from Mark Thomas ---
Mmm. Because of what needs to be filtered, the use of externals is going to get
painful for some modules. I'm wondering if there is a better solution.
The modules aspect of this is good. Is it possible
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #12 from Mark Thomas ---
I am making progress. The structure is in svn, the sources for JULI are hooked
up via externals and the tomcat-juli-8.0.13-SNAPSHOT.jar that is created looks
reasonable (I haven't tested it).
If we want
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #11 from Pierre Viret ---
Sorry about the circular dependency I forgot to mention that tomcat-coyote
needs tomcat-util to compile, so tomcat-util may not depend on the
tomcat-coyote.
--
You are receiving this mail because:
You
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #10 from Pierre Viret ---
Thank you very much for your feedback.
1) About the circular dependency: the pattern for the tomcat-coyote component
selects the file "org/apache/tomcat/util/net/Constants.java".
This class is referenc
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #9 from Mark Thomas ---
Thanks for this. I still want to try and create the svn externals as that means
the Maven build would be based directly on svn and folks would be able to
commit / propose patches / merge updates much more
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #8 from Pierre Viret ---
I have implemented an EXPERIMENTAL set of maven projects for the tomcat
components.
The main idea is that the sources are simply copied from the central repository
to an existing maven projects' tree. Ev
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #7 from Pierre Viret ---
Created attachment 32017
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32017&action=edit
README for setting up maven for tomcat
This file contains a small how-to explaining the steps needed
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #6 from Pierre Viret ---
Created attachment 32016
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32016&action=edit
tar containing the maven pom.xml files and the directories
See README-MAVEN.txt file for usage
--
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
Pierre Viret changed:
What|Removed |Added
CC||pierre.vi...@gmail.com
--
You are
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #5 from Pierre Viret ---
I have already migrated several projects from ant to maven and I like this kind
of challenge. I'm ready to help here.
So my fist question is: do you need some help?
If the answer is positive: can you ple
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #4 from Tim Whittington ---
> and the Ant build script is indeed meh (the Maven fans have a point there).
Also Ant as a project appears to be in some difficulty - 1.8 and 1.9 (until I
patched it, and I'm still suspicious of som
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #3 from Remy Maucherat ---
Ok, let me know when the basics are in.
Although I did put in place the single source tree, which worked fine, and it's
great if it has been useful for a (long) while. OTOH people keep whining about
M
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #2 from Mark Thomas ---
This is one of the things discussed at the Tomcat Summit this week.
My proposal was to start a multi-module maven project in the sandbox using svn
externals to pull in the relevant bits of Tomcat source
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #1 from Remy Maucherat ---
I don't see how this is doable or useful since the point of maven is to accept
its source code structure and componentization. IMO it is either Tomcat
switches cleanly to Maven (or another similar one)
51 matches
Mail list logo
