https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #29 from Pierre Viret <pierre.vi...@gmail.com> --- Thank you for your feedback. Here my answers: 1. Why has the license header been removed from pom.xml? 2. Every pom.xml file should have a license header. --> I've just forgotten to copy it, I will fix this 3. Why has the <url> element been removed from a number of pom files? --> as it is defined in the master project I think this was not necessary to define it redundantly in the sub-projects: it is automatically inherited. But if I execute "mvm help:effective-pom" in a sub-project it seems that the url from parent get automatically extended with the sub-project id (i.e. "<url>http://tomcat.apache.org/tomcat-catalina</url>" for tomcat-catalina sub-project). I will check this and insert the url again. 4. Indentation is inconsistent. 2 spaces or 4 spaces (never tabs). Pick one and use it consistently. --> I will fix this 5. Why has <scope>test<scope/> been removed from the junit dependencies? --> the scope test is defined per default in the master project DependencyManagement section for junit, so it is automatically inherited: <dependency> <groupId>junit</groupId> <artifactId>junit</artifactId> <version>4.11</version> <scope>test</scope> </dependency> I will fix the problems and upload a new patch tomorrow. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
