[CONF] Apache Tomcat > Servlet TCK 5.0

Title: Message Title There's 1 new comment on this page   Servlet TCK 5.0 Remy Maucherat https://github.com/eclipse-ee4j/jakartaee-tck/pull/338/files

Re: Serving gz files in DefaultServlet (Re: r1531115, BZ 54095)

On Sun, 2013-10-13 at 16:03 +0100, Mark Thomas wrote: > I disagree since: > - this is only in 8.0.x and we haven't had a stable release yet. > - the user has to create the gzip'd version which is unlikely to exist > be default before this feature does anything I also think it should be disabled by

Re: [WS] To flush or not to flush

On Tue, 2013-09-24 at 06:34 -0700, Mark Thomas wrote: > Non-blocking IO with non-upgraded streams still uses the standard > buffering mechanisms. > > I agree some clarification is required. When section 5.1 discusses > buffering, it does so in the context of the ServletResponse object so it > isn'

[WS] To flush or not to flush

Hi Mark, Unless I missed something, Websockets 1.0 on Servlet 3.1 upgrade doesn't do much flushing, so that the IS/OS used in upgrade must effectively just write immediately the data (and ensure it is really sent over the wire). I find that a bit weird, since during the design of Servlets 3.1, th

Re: SCI discovery ordering

On Fri, 2013-09-20 at 08:38 +0100, Mark Thomas wrote: > a) The container defined SCIs need to be loaded first. Any other > solution places an unnecessary burden on application developers. It is > reasonable for application developers to expect that if a container > advertises support for WebSocket,

Re: svn commit: r1518214 - /tomcat/trunk/java/org/apache/jasper/el/ELContextImpl.java

On Wed, 2013-08-28 at 14:14 +, ma...@apache.org wrote: > Author: markt > Date: Wed Aug 28 14:14:09 2013 > New Revision: 1518214 > > URL: http://svn.apache.org/r1518214 > Log: > Add new resolvers to default resolver (bug spotted by remm) > DefaultResolver = new CompositeELResolver

Re: svn commit: r1504148 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/el/ java/org/apache/jasper/runtime/ test/javax/el/ test/org/apache/el/ test/org/apache/el/parser/ t

On Wed, 2013-07-17 at 14:14 +, ma...@apache.org wrote: > Author: markt > Date: Wed Jul 17 14:14:28 2013 > New Revision: 1504148 > > URL: http://svn.apache.org/r1504148 > Log: > Add the two new resolver types (stream and static) to Jasper in the correct > order and modify JasperELResolver so t

Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

On Thu, 2013-08-01 at 22:53 +0200, Mark Thomas wrote: > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-048/ > The svn tag is: > http://svn.apache.org/repo

Re: Timeline for beginning EL 3.0 implementation?

On Tue, 2013-06-11 at 21:36 +0100, Mark Thomas wrote: > Once all that is done I was thinking about some form of alpha release > before starting work on the EL stuff. I tested the EL 3 RI with Jasper, and (as expected) it is still as pluggable as it used to, and it works well. The amount of new s

Re: Automatic deployment changes

On Tue, 2013-05-07 at 13:54 +0100, Mark Thomas wrote: > What has made changes in this area difficult in the past is a) a lack of > a clear definition as to what the expected behaviour is and b) a lack of > test cases to validate that behaviour. a) is very true ... Anyway, I think it's very good to

Re: [VOTE] Release build 6.0.37

On Mon, 2013-04-29 at 12:17 +0200, jean-frederic clere wrote: > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.37/ > > According to the release process, the 6.0.37 build corresponding to the > tag TOMCAT_6_0_37 is: > [ ] Broken > [ ] Alpha > [ ] Beta

Re: Servlet 3.1 tests

On Wed, 2013-04-10 at 21:41 -0400, Mark Thomas wrote: > On 10/04/2013 09:43, Remy Maucherat wrote: > > Hi, > > > > Are there any good Servlet 3.1 tests around ? (besides the websockets > > impl) > > Not yet. We have Filip's initial implementation and a few a

Servlet 3.1 tests

Hi, Are there any good Servlet 3.1 tests around ? (besides the websockets impl) I doubt the Servlet TCK will have that sort of stuff, Servlet 3.0 wasn't very good for that beyond testing of a few specific aspects. Rémy - To u

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

On Wed, 2013-03-20 at 20:46 +, ma...@apache.org wrote: > Author: markt > Date: Wed Mar 20 20:46:04 2013 > New Revision: 1459043 > > URL: http://svn.apache.org/r1459043 > Log: > Add new methods > > Modified: > tomcat/trunk/test/org/apache/catalina/core/TesterContext.java Sorry about that

Re: Strange APR/native behaviour

On Wed, 2013-03-13 at 20:52 +, Mark Thomas wrote: > > I mean check for Socket.setsbb somewhere after the socket is > > returned from poller. Either the new buffer has been set or > > the buffer address is different because of Socket.sendbb's offset param > > (in this case it would be -11530560

Re: Strange APR/native behaviour

On Tue, 2013-03-12 at 13:25 +, Mark Thomas wrote: > Thanks for the pointers. I tried a few of them (the less invasive ones) > with no luck. I'm putting together a test case that demonstrates the > problem. That should make it very simple to determine if the root cause > lies in APR or my code.

Re: Strange APR/native behaviour

On Tue, 2013-03-12 at 00:25 +, Mark Thomas wrote: > I have been tracking down a problem with the Autobahn test suite and > APR/native connector when using SSL (all is fine with non-SSL). > > In the test Autobahn sends a 16MB frame to the server which the server > echos back to the client. > >

Re: URIs, %nn decoding and error handling

On Fri, 2013-03-01 at 20:36 +, Mark Thomas wrote: > I expect to have a similar discussion about request bodies once URIs are > resolved where I have essentially the same view - a decoding error > should lead to a request failure. > > Thoughts? It may not be useful. UTF-8 is THE most used en

Re: Checkstyle errors in storeconfig in trunk

On Sat, 2013-02-09 at 05:19 +0400, Konstantin Kolinko wrote: > 2013/2/8 Konstantin Kolinko : > > Hi! > > > > FYI, there are a lot of checkstyle errors in o.a.c.storeconfig package, > > > > a) tabs in server-registry.xml > > b) a lot of trailing whitespace > > Fixed. Thanks ! > Further notices: >

Re: svn commit: r1443891 - /tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry.xml

On Fri, 2013-02-08 at 21:19 +0400, Konstantin Kolinko wrote: > 2013/2/8 : > > Author: kfujino > > Date: Fri Feb 8 08:50:24 2013 > > New Revision: 1443891 > > > > URL: http://svn.apache.org/r1443891 > > Log: > > Improve ContextSF description. > > Remove unused attributes engineName and saveConfig.

Re: svn commit: r1443872 - /tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java

On Fri, 2013-02-08 at 08:24 +, kfuj...@apache.org wrote: > Author: kfujino > Date: Fri Feb 8 08:24:36 2013 > New Revision: 1443872 > > URL: http://svn.apache.org/r1443872 > Log: > Don't use a hard-coded domain name. Actually, I'm not sure this is a good plan. This was most certainly hardcode

Re: [Proposal] Resurrecting storeconfig

On Tue, 2013-02-05 at 19:27 +0900, Keiichi Fujino wrote: > Hi. > > I do not understand about StoreConfig well, but I have a question. > > As long as I read the code (r1442161), I think that storeconfig() seem > to trigger a redeployment of Web applications. > For example, new context.xml will be

Re: [Proposal] Resurrecting storeconfig

On Fri, 2012-12-14 at 17:26 +, Mark Thomas wrote: > > One issue I'm wondering about is the build system. After all that time, > > I've starting using Maven instead of Ant (unbelievable, I know ...), and > > while I am fine continuing using existing Ant build systems, I find > > adding ones to n

Re: [VOTE] Release Apache Tomcat Native 1.1.26

On Mon, 2013-01-28 at 12:33 +0100, Rainer Jung wrote: > On 25.01.2013 17:01, jean-frederic clere wrote: > > Version 1.1.26 is bug fixing release. > > The proposed release artefacts can be found at [1], > > and the build was done using tag [2]. > > > > The VOTE will remain open for at least 48 hour

Re: NIO in char IO

On Wed, 2013-01-23 at 18:55 +, Mark Thomas wrote: > On 23/01/2013 16:44, Remy Maucherat wrote: > > Hi, > > > > I have ported a refactoring of character encoding (and decoding) to > > trunk, using NIO rather than the creative hacks that are used. It makes > > t

NIO in char IO

Hi, I have ported a refactoring of character encoding (and decoding) to trunk, using NIO rather than the creative hacks that are used. It makes the IO nice and symmetrical, but I haven't specifically tested any performance (I couldn't stand the old style, so it had to go regardless of the conseque

Re: svn commit: r1436814 - /tomcat/trunk/webapps/docs/rewrite.xml

On Tue, 2013-01-22 at 09:19 +, ma...@apache.org wrote: > Author: markt > Date: Tue Jan 22 09:19:26 2013 > New Revision: 1436814 > > URL: http://svn.apache.org/viewvc?rev=1436814&view=rev > Log: > Add license > tabs -> spaces > remove trailing whitespace Thanks for all the beautifying. Rémy

Re: Rewrite functionality for 8

On Mon, 2013-01-21 at 15:52 +0100, Henri Gomez wrote: > mod_rewrite is definitvly HTTPd Swiss Knife and having it in Tomcat is > definitivly a good news. > > This valve is for Tomcat 8 and higher or could it be used with Tomcat 7 ? It will probably not build as is but as with almost everything, i

Re: svn commit: r1433976 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpAprProtocol.java coyote/http11/Http11AprProtocol.java tomcat/util/net/AprEndpoint.java tomcat/util/net/res/LocalStrings.prope

On Wed, 2013-01-16 at 15:14 +, ma...@apache.org wrote: > This is untested (I don't have an OSX build of the native lib handy right > now). I'll test later today. I'm not sure native on OS X is 100% stable, for whatever reason (due to apparent concurrency issues with the poller once read + wri

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

On Wed, 2013-01-16 at 12:08 +, Mark Thomas wrote: > > It is not really a bug: only the newer Windows (Vista+) have efficient > > polling. With previous versions, small pollsets have to be used because > > (apparently) it can only poll over 64 sockets at a time. If the size is > > over 1000, the

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

On Wed, 2013-01-16 at 11:43 +, Mark Thomas wrote: > > Using multiple pollsets is only needed on some platforms (Windows ...), > > and it is possible it is not supposed to be mandatory now (Windows > > should be able to handle large pollsets now). So if you accept to drop > > support for running

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

On Wed, 2013-01-16 at 09:35 +, Mark Thomas wrote: > That would be really nice. What I'd need is this: > > int removeFromPollset(long socket) > > where the return value is either -ve for an error code or +ve for the > current flags. > > Looking at the code, by the time I have finished the oth

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

On Wed, 2013-01-16 at 07:50 +0100, Mladen Turk wrote: > On 01/15/2013 02:29 PM, Mark Thomas wrote: > > Hi, > > > > 3. Currently, we have no record of which Poller a socket is registered > > with. This makes 2) more expensive as we have to iterate through the > > Pollers to find the socket. Tracking

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

On Tue, 2013-01-15 at 19:26 +, Mark Thomas wrote: > >I had to solve each of these issues in the web container of JBoss. > >Although this is not going to be quite 100% compatible with Tomcat, it > >is very similar. > > > >I recommend looking at the branch that is in AS 7 trunk: > >http://anonsvn

Re: APR, WebSocket and Servlet 3.1 NIO refactoring

On Tue, 2013-01-15 at 13:29 +, Mark Thomas wrote: > Hi, > > I think I am going to need to refactor the APR Poller code. Before I get > to far down that road I wanted to get a sanity check from those that > understand the APR/native connector better than I do. > > The main problem: > - I need

Re: Rewrite functionality for 8

On Fri, 2013-01-11 at 18:34 +0100, Rainer Jung wrote: > I only had a look at the code and didn't play with it yet. I'm > positively impressed how complete w.r.t. mod_rewrite compatibility it > looks and personally I think it is nice and useful. Thanks ! > One question that came to my mind and whi

Re: Rewrite functionality for 8

On Wed, 2013-01-09 at 13:16 -0500, Christopher Schultz wrote: > I haven't looked at the code but my first reaction was "why not use > url-rewrite?" When you say that it can re-start request processing, you > mean that you can essentially perform internal rewrites/forwards/etc. > without having to u

Rewrite functionality for 8

Hi, I ported a valve providing mod_rewrite functionality (most of it) for Tomcat "8", and committed it in the sandbox. This could be easily placed in the main repository, where it would provide an additional item in the "new features" department for this major release. I have a documentation page

Re: [Proposal] Resurrecting storeconfig

On Fri, 2012-12-14 at 17:26 +, Mark Thomas wrote: > > The proposal would be to move "storeconfig7/trunk" from the sandbox to > > "modules/storeconfig" in the Tomcat 7 branch [a port to trunk, aka > > Tomcat "8", would be coming shortly, since I believe its container API > > would now start to b

[Proposal] Resurrecting storeconfig

Hi, I would be willing to start maintaining again storeconfig, along with Jean-Frédéric. So after a hiatus, we would be able to bring back this functionality which allows tweaking the configuration (through JMX in particular) and then saving it to server.xml and context.xml files to make changes s

Re: [VOTE] Release build 6.0.36

On Tue, 2012-10-16 at 10:52 +0200, jean-frederic clere wrote: > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.36/ > > According to the release process, the 6.0.36 build corresponding to the > tag TOMCAT_6_0_36 is: > [ ] Broken > [ ] Alpha > [ ] Beta

Re: Resources - Custom URL scheme for unified access

On Tue, 2012-10-09 at 22:19 +0100, Mark Thomas wrote: > If we do go this route I'd like to change the scheme from "jndi://" to > "tomcat://". This is for several reasons: > - I believe there was a complaint that "jndi://" clashed with another > component. > - It makes clear the old and the new ar

Re: Resources - Is DirContext the right basis for the API?

On Thu, 2012-09-27 at 07:34 -0700, Costin Manolache wrote: > One use for a resource API is if it provides different backends - like > Hadoop filesystem abstraction > does. Than you could serve from hdfs/db/etc, and someone could use the same > api in deploy tools > or general programs. > One of th

Re: Recent performance tweaks in trunk

On Sun, 2012-09-23 at 12:35 +0100, Mark Thomas wrote: > ab -c 4 -k -n 100 http://localhost:8080/test-1k.txt The concurrency of the test is very low, there will be only 4 threads used with that test, which means decent sync performance. Although with NIO the executor count can remain lower tha

Re: non blocking API

On Thu, 2012-06-28 at 16:59 -0600, Filip Hanik (mailing lists) wrote: > I posted some feedback to the expert group: > > http://java.net/projects/servlet-spec/lists/users/archive/2012-06/message/15 You can find all the discussions about the API in the archive, which hopefully explain nearly all of

Re: SPDY support

On Thu, 2012-02-02 at 12:28 +, Pid wrote: > > Of course, I'm even less sure about websockets since it's kind of a mess. > > I'd say it was the other way round. WebSockets finalised before Xmas, > and there's lots of interest from various communities to judge from the BZ. Websocrap is a bad t

Re: SPDY support

On Wed, 2012-02-01 at 13:54 -0800, Costin Manolache wrote: > Hi, > > Some initial patch for SPDY - using the NPN SSL extension, as required by > chrome/firefox. > > I used github so it's easy to add comments or test: > > https://github.com/costinm/tomcat/commit/e97def3314216c083cc4b68ad9731e5a94

Re: svn commit: r1140463 - in /tomcat/trunk/java/org/apache/catalina: connector/Request.java ssi/SSIServletExternalResolver.java util/Base64.java

On Tue, 2011-06-28 at 07:22 +, ma...@apache.org wrote: > Author: markt > Date: Tue Jun 28 07:22:28 2011 > New Revision: 1140463 > > URL: http://svn.apache.org/viewvc?rev=1140463&view=rev > Log: > Fix the remaining instances of new String(byte[] b, String enc) that can be > fixed It is possib

Re: svn commit: r1132367 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProcessor.java webapps/docs/changelog.xml

On Mon, 2011-06-06 at 19:15 +0100, Mark Thomas wrote: > Doh. Got it. We do need to modify the length to handle range requests, > but not like that. What's the issue exactly ? When actually sending data, "pos" is set to "start" and the length is used as the usual "end - pos". Rémy -

Re: svn commit: r1132367 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProcessor.java webapps/docs/changelog.xml

On Sun, 2011-06-05 at 10:21 +, ma...@apache.org wrote: > Author: markt > Date: Sun Jun 5 10:21:25 2011 > New Revision: 1132367 > > URL: http://svn.apache.org/viewvc?rev=1132367&view=rev > Log: > Correctly handle range requests when using sendfile and the APR/native HTTP > connector. > -

Re: svn commit: r1094069 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

On Sat, 2011-04-16 at 22:25 +, ma...@apache.org wrote: > Author: markt > Date: Sat Apr 16 22:25:28 2011 > New Revision: 1094069 > > URL: http://svn.apache.org/viewvc?rev=1094069&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51042 > Don't trigger session creation list

Re: [VOTE] Release build 6.0.32

On Wed, 2011-02-02 at 20:37 +0100, jean-frederic clere wrote: > The candidates binaries are available here: > http://people.apache.org/~jfclere/tomcat-6/v6.0.32/ > > According to the release process, the 6.0.32 build corresponding to the > tag TOMCAT_6_0_32 is: > [ ] Broken > [ ] Alpha > [ ] Beta

Re: svn commit: r1061442 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

On Thu, 2011-01-20 at 18:34 +, ma...@apache.org wrote: > Author: markt > Date: Thu Jan 20 18:34:18 2011 > New Revision: 1061442 > > URL: http://svn.apache.org/viewvc?rev=1061442&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50620 > Exceptions calling session.endAcces

Re: [PROPOSAL] Remove o.a.catlina.InstanceListener

On Fri, 2011-01-07 at 15:18 +0300, Konstantin Kolinko wrote: > We indeed do not have our own classes that implement InstanceListener, > but if you search for o.a.c.InstanceEvent, it is used in a plenty of places > (to implement this feature actually). > > So it is not just throwing away classes, i

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

On Thu, 2010-11-25 at 16:33 +, Mark Thomas wrote: > I wouldn't call it bad. It doesn't do any harm (apart from adding a very > small amount of overhead), and it would help if the random source > selected ended up not being that random. > > I thought the trade-off of protection against bad choi

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

On Thu, 2010-11-18 at 19:59 +, ma...@apache.org wrote: > Author: markt > Date: Thu Nov 18 19:59:11 2010 > New Revision: 1036595 > > URL: http://svn.apache.org/viewvc?rev=1036595&view=rev > Log: > Fix expiration statistics broken by r1036281 > Add session creation and expiration rate statistics

Re: svn commit: r1036150 - /tomcat/trunk/webapps/docs/changelog.xml

On Wed, 2010-11-17 at 18:06 +, ma...@apache.org wrote: > Author: markt > Date: Wed Nov 17 18:06:20 2010 > New Revision: 1036150 > > URL: http://svn.apache.org/viewvc?rev=1036150&view=rev > Log: > Add recent performance improvements to changelog Ok. So we have two queues that can essentially

Re: svn commit: r1035699 - in /tomcat/trunk: java/org/apache/catalina/session/ManagerBase.java test/org/apache/catalina/session/Benchmarks.java

On Tue, 2010-11-16 at 17:13 +, ma...@apache.org wrote: > URL: http://svn.apache.org/viewvc?rev=1035699&view=rev > Log: > Session manager performance > Narrow sync - few % improvement > - * 1 thread - 2,422ms > - * 2 threads - 5,047ms > - * 4 threads - 13,188ms > - * 16 thr

Re: [PATCH] Parallel deployment

On Mon, 2010-11-08 at 18:26 +0100, Rainer Jung wrote: > On 08.11.2010 18:05, Remy Maucherat wrote: > > I'll up that to -1, with another concern I've just thought about: if > > using a session id path which includes more than one webapp, the version > > numbers will

Re: [PATCH] Parallel deployment

On Mon, 2010-11-08 at 15:46 +, Mark Thomas wrote: > I did consider that approach but rejected it for a couple of reasons: > - Mapper needs to be manager aware - it isn't currently Add a one method interface to be able to perform a session lookup. > - Performance Likely, having to do String m

Re: [PATCH] Parallel deployment

On Mon, 2010-11-08 at 14:31 +, Mark Thomas wrote: > We might be able to avoid that be limiting the version to just integers. > I think that is reasonable but would like to hear some feedback from others. > > That does raise the issue of whether to convert the provided version to > a (zero padd

Re: [VOTE] Release Apache Tomcat 7.0.4

On Sun, 2010-10-17 at 22:38 +0100, Mark Thomas wrote: > Yes, this is stupid but it is what the spec requires. I have to disagree, there was agreement in the expert group that wildcard mappings and welcome files cannot be mixed at the moment, unless for specific proprietary hacks, or if a static fi

Re: Creating tomcat VFS

On Fri, 2010-10-15 at 08:43 -0700, Costin Manolache wrote: > But I hope you agree you were right, at least in the long term :-) Who cares about the long term, nobody uses 10 years old code. Oh, wait ;) Rémy - To unsubscribe, e

Re: Creating tomcat VFS

On Fri, 2010-10-15 at 07:57 -0700, Costin Manolache wrote: > I remember many years back I was arguing in favor of DirContext - pro > arguments were > "it's a standard", bundled in JDK, probably more target implementations will > be available, etc. > I think Remy was arguing that it's too complex an

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

On Thu, 2010-10-14 at 21:44 +1300, Tim Whittington wrote: > I can have a look at this. > Is there a preferred way of making this configurable? > Given the caches are static, it's either going to be system property, > or changing to using an instance cache retained somewhere appropriate > (at the mo

Re: Bug 49914 - "Filter on url-pattern of "/" is not invoked"

On Tue, 2010-09-21 at 10:15 +0200, Wesley Acheson wrote: > So to get this straight Rémy you think it should be a WONT FIX too? For the actual resolution, you have to talk with Mark. Rémy - To unsubscribe, e-mail: dev-unsubscr.

Re: Bug 49914 - "Filter on url-pattern of "/" is not invoked"

On Mon, 2010-09-20 at 16:31 -0700, Mark Thomas wrote: > I agree the spec isn't crystal clear. > > I took the use of the word "partial" to refer to requests and URIs in > the welcome file to mean that the "complete" request was the result of > adding the welcome file. With that in mind, it seems na

Re: Bug 49914 - "Filter on url-pattern of "/" is not invoked"

On Tue, 2010-09-14 at 12:26 +0100, Mark Thomas wrote: > You need to be able to quote the section of the spec that demonstrates > it is wrong. Having quickly scanned the 2.5 and 3.0 specs I think you > are going to find that there is no clear definition of whether filters > are processed before or a

Re: svn commit: r988537 - in /tomcat/native/trunk/native: build/tcnative.m4 src/jnilib.c

On Tue, 2010-08-24 at 16:56 +0200, jean-frederic clere wrote: > Well the accept is done in a different thread anyway. Additionally with > defer accept we won't see any changes accept latency. Indeed, no change. But Windows is different enough that it would need significantly different code to be c

Re: svn commit: r988537 - in /tomcat/native/trunk/native: build/tcnative.m4 src/jnilib.c

On Tue, 2010-08-24 at 16:30 +0200, Mladen Turk wrote: > Work in progress ... > Will be used in new Poll.interrupt API so we can remove all > that clumsy pollTime/maintainTime logic for adding new sockets > to the pollset. > It should lower the accept latency, remove the need for > socket add queue

Re: svn commit: r988409 - /tomcat/native/trunk/native/build/tcnative.m4

On Tue, 2010-08-24 at 10:23 +0200, Mladen Turk wrote: > This is for trunk (tcnative 1.2.x) > Branch 1.1.x will have apr-1.3.x dependency with those > functions backported after found stable. > Pool pre cleanup is easily backportable and is > already part of RHEL-5 apr-1.2.7, so I added extra > chec

Re: svn commit: r988409 - /tomcat/native/trunk/native/build/tcnative.m4

On Tue, 2010-08-24 at 07:02 +, mt...@apache.org wrote: > Author: mturk > Date: Tue Aug 24 07:02:44 2010 > New Revision: 988409 > > URL: http://svn.apache.org/viewvc?rev=988409&view=rev > Log: > Make 1.4.x mandatory at build time as well This requirement is not possible, even F13 is still at 1

Re: svn commit: r981061 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

On Sat, 2010-07-31 at 15:05 +0100, Mark Thomas wrote: > This appears to fix the crashes on my Mac. Need to test on Windows as > well since that is where I first saw the issue. > > I confess to not understanding why this works, just that it appears to > do the job. Assuming it really does someth

Re: svn commit: r964219 [1/2] - in /tomcat/trunk: java/org/apache/catalina/filters/ test/org/apache/catalina/filters/ webapps/docs/ webapps/docs/config/

On Wed, 2010-07-14 at 22:11 +, ma...@apache.org wrote: > Author: markt > Date: Wed Jul 14 22:11:30 2010 > New Revision: 964219 > > URL: http://svn.apache.org/viewvc?rev=964219&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998 > Add the ExpiresFilter, a port of mod_

Re: svn commit: r966882 - in /tomcat/trunk: build.properties.default build.xml checkstyle.xml webapps/docs/changelog.xml

On Fri, 2010-07-23 at 19:33 -0700, Bill Barker wrote: > I'm -1 (vote, not veto) on having validate be a dependency for compile. I'm pretty sure Costin will never ever be able to contribute a single line of code with that check in place :P Rémy -

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

On Wed, 2010-07-21 at 21:36 +0100, Mark Thomas wrote: > I take it that this means you think there is room for simplification. > I'm still trying to get my head around the Async implementation so if > you have any pointers on how it could be simplified, they would be much > appreciated. Ok, so for

Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/

On Wed, 2010-07-21 at 11:18 +0200, Rainer Jung wrote: > IMHO for any serious application of async the developer will need to > adjust the timeout. I am responsible for the fact that setting the timeout is separate, as I did not understand how it was meaningful in most cases to have it be anything

Re: Vote: Add Checkstyle roleset and make code cleanups!

On Thu, 2010-07-08 at 18:02 +0200, Peter Roßbach wrote: > Hi, > > after the discussion about code style > (http://tomcat.markmail.org/thread/2c7lkzmpcuxqpgjj > ), I think that we must vote for this fix: > > https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 > It includes a starting point

Re: Chunked encoding should be used also when not using keepalive

On Thu, 2010-04-01 at 11:28 +0100, Mark Thomas wrote: > On 01/04/2010 11:02, Óscar Frías Barranco wrote: > > What do you think ? > > Seems reasonable but I'd like to hear from some of the other committers > before making any changes. > > If the change is made, it needs to be made for all connecto

Re: svn commit: r925232 - in /tomcat/trunk: java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/examples/jsp/async/

On Mon, 2010-03-22 at 11:05 -0600, Filip Hanik - Dev Lists wrote: > 2. Since it calls dispatch() before it calls request.setAttribute, it > ends up in a loop For 1), unless the Servlet does startAsync again in the dispatch, it is complete, even if the servlet does not call complete. For 2), this

Re: svn commit: r921464 - in /tomcat/trunk/java/org/apache/jasper: JspCompilationContext.java servlet/JspServletWrapper.java

On Wed, 2010-03-10 at 17:35 +, ma...@apache.org wrote: > Author: markt > Date: Wed Mar 10 17:35:43 2010 > New Revision: 921464 > > URL: http://svn.apache.org/viewvc?rev=921464&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48795 > If compilation fails, always try to r

Re: svn commit: r917931 - /tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

On Tue, 2010-03-02 at 09:19 +, mt...@apache.org wrote: > Author: mturk > Date: Tue Mar 2 09:19:45 2010 > New Revision: 917931 > > URL: http://svn.apache.org/viewvc?rev=917931&view=rev > Log: > With unsafe reneg, minimum required is 1.2.21 caused by API change As long as you don't set the new

Re: EL issues and 6.0.x release

On Fri, 2010-01-08 at 11:36 +, Mark Thomas wrote: > I have some rough code that implements this scheme. I am in the process > of integrating it into Jasper for trunk. I can see this taking little > while to iron out the wrinkles before I'll be ready t propose a > back-port for 6.0.x. I don't th

Re: svn commit: r893001 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

On Mon, 2009-12-21 at 21:51 +, kkoli...@apache.org wrote: > Author: kkolinko > Date: Mon Dec 21 21:51:29 2009 > New Revision: 893001 > > URL: http://svn.apache.org/viewvc?rev=893001&view=rev > Log: > Fix second part of Comment 8 in > https://issues.apache.org/bugzilla/show_bug.cgi?id=47413#c8

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

On Wed, 2009-11-18 at 16:18 +0100, jean-frederic clere wrote: > [X] Stable - no major issues, no regressions > [ ] Beta - at least one significant issue -- tell us what it is > [ ] Alpha - multiple significant issues -- tell us what they are Rémy -

Re: Cookie issues

On Thu, 2009-11-12 at 16:03 -0500, Mark Thomas wrote: > I've done some more digging and I think I have found what was causing this. > I'll > have a fix for trunk shortly and (after some testing) I'll re-propose. No, what I meant is that, if you want to go the strict route and use '/' as a separat

Re: Cookie issues

On Wed, 2009-11-11 at 16:45 -0500, Mark Thomas wrote: > I really do loath cookies right now. I've pulled the proposed patches for > 5.5.x > and 6.0.x until I (or someone else) can take a look at this. I do too. v0 cookies is 15 years old stuff that Netscape hacked out of thin air without thinking

Cookie issues

Hi, I think cookies are still broken, and this is getting more and more complex. The apparent issue is that the parser applies v1 parsing rules when parsing v0 cookies (which are generated using a much more lenient character exclusion), resulting in cookies that cannot be parsed back. A simple ex

Re: svn commit: r832039 - in /tomcat/trunk/java/org/apache/naming: HandlerRef.java ResourceRef.java ServiceRef.java StringManager.java resources/DirContextURLStreamHandler.java

On Mon, 2009-11-02 at 18:46 +, ma...@apache.org wrote: > Author: markt > Date: Mon Nov 2 18:46:21 2009 > New Revision: 832039 > > URL: http://svn.apache.org/viewvc?rev=832039&view=rev > Log: > StringBuffer -> StringBuilder for o.a.naming So I did not test or anything, but is SBuilder faster

Re: svn commit: r831536 - in /tomcat/trunk: java/org/apache/tomcat/util/http/ test/org/apache/tomcat/util/http/ webapps/docs/config/

On Sat, 2009-10-31 at 12:59 +, ma...@apache.org wrote: > Author: markt > Date: Sat Oct 31 12:59:51 2009 > New Revision: 831536 > > URL: http://svn.apache.org/viewvc?rev=831536&view=rev > Log: > Add an explicit configuration option for cookie version switching and update > test cases and docs

Re: [VOTE] Releasing Apache Tomcat Native 1.1.17

On Tue, 2009-10-20 at 21:55 +0200, jean-frederic clere wrote: > [X] Stable - no major issues, no regressions > [ ] Beta - at least one significant issue -- tell us what it is > [ ] Alpha - multiple significant issues -- tell us what they are Rémy -

Re: svn commit: r828212 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

On Wed, 2009-10-21 at 20:57 +, ma...@apache.org wrote: > Author: markt > Date: Wed Oct 21 20:57:14 2009 > New Revision: 828212 > > URL: http://svn.apache.org/viewvc?rev=828212&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47987 > Limit size of not found resources cac

Re: JSR 315 - status ?

On Tue, 2009-09-01 at 13:40 +0200, Matthias Wessendorf wrote: > Is there no Tomcat developer an active member on the JSR ? You do understand this is confidential information, right ? Follow the JCP progress and announcements. Rémy ---

[ANN] Apache Tomcat 6.0.20 released

The Apache Tomcat team announces the immediate availability of Apache Tomcat 6.0.20 stable. This release includes many bugfixes over Apache Tomcat 6.0.18. Apache Tomcat 6.0 includes new features over Apache Tomcat 5.5, including support for the new Servlet 2.5 and JSP 2.1 specifications, a refacto

Re: [VOTE] Release build 6.0.20

On Tue, 2009-06-02 at 13:22 -0400, Martin Dubuc wrote: > What is going to happen to the 6.0.20 load? Will it be officially released? > If it will, when and will it be identical to the load found at: > http://people.apache.org/~remm/tomcat-6/v6.0.20/

Re: [VOTE] Release build 6.0.20

On Thu, 2009-05-14 at 01:33 +0200, Remy Maucherat wrote: > The candidates binaries are available here: > http://people.apache.org/~remm/tomcat-6/v6.0.20/ > > According to the release process, the 6.0.20 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [ ] Stable Ok, so with

Re: [VOTE] Release build 6.0.20

On Sun, 2009-05-24 at 17:02 +0400, Konstantin Kolinko wrote: > I do not see any issues with the release, except the one > of the tgz sources archive. > > Regarding the tgz archive of the sources I propose the following: > The build was created on an Unix machine, so the files in the zip > archive

[VOTE] Release build 6.0.20

The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.20/ According to the release process, the 6.0.20 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Rémy - To unsubscribe, e-mail: dev-unsu

Re: svn commit: r772142 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

On Wed, 2009-05-06 at 10:49 +, ma...@apache.org wrote: > // Acquire global JNDI resources if available > -Server server = ServerFactory.getServer(); > +Server server = > + > ((Engine)context.getParent().getParent()).getService().getServer(); Ouch, not prett

Re: Tomcat Native: APR Http Endpoint handler behavior under Windows

On Wed, 2009-04-29 at 08:50 +1000, mcto...@gmail.com wrote: > A few followups on this. It's only now that I have realised that the > the tomcat apr handler in JBoss is subtly different from the one in > Tomcatie that whole piece of tomcat has been forked into JBossWeb, > and they're startin

  1   2   3   4   5   6   7   8   9   10   >