On Fri, 2013-03-01 at 20:36 +0000, Mark Thomas wrote: > I expect to have a similar discussion about request bodies once URIs are > resolved where I have essentially the same view - a decoding error > should lead to a request failure. > > Thoughts?
It may not be useful. UTF-8 is THE most used encoding. If the decoder is still full of bugs, it means the other encoders/decoders have even more bugs. So the only reasonable statement is that you would like to have "perfect" UTF-8 decoding, and so you would use your own decoder in B2CConverter, just for that encoding. Ok. About endOfInput, I wouldn't use it. The only place where it is somewhat useful is the URI conversion, which can check the underflow flag and throw an exception. Especially if you also want to have "perfect" body decoding, you'll have to use that flag and throw your exception since it won't be able to use endOfInput. I don't bother with either personally, but it's the reason for the existence of the flag. The main purpose of the new B2C and C2B code is to have better handling of non blocking (not required in Servlet 3.1, in the end; at least for now), and that's about it. Since they also look better, save memory and are symmetrical, I thought it would be a good idea to add them. I didn't expect to cause so much trouble, ;) Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
