Re: Bug #57505 - Integration tests for JspC

2015-10-07 Thread Jeremy Boynes
On Sep 21, 2015, at 11:23 AM, Dinesh Joshi wrote: > > Hi all, > > I'm looking to contribute to Tomcat development. I am planning to take a > crack at this bug - https://bz.apache.org/bugzilla/show_bug.cgi?id=57505 > Anybody working on it? Can someone give me some pointers on how I should > pr

Re: [Tomcat Wiki] Update of "Development/NestedFilesystem" by jboynes

2015-04-05 Thread Jeremy Boynes
> On Apr 5, 2015, at 2:25 PM, Apache Wiki wrote: > > Dear Wiki user, > > You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for > change notification. > > The "Development/NestedFilesystem" page has been changed by jboynes: > https://wiki.apache.org/tomcat/Development/Nested

Re: [VOTE] Release Apache Tomcat 8.0.21

2015-03-24 Thread Jeremy Boynes
> The proposed 8.0.21 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.0.21 Used to test Standard Taglib on OS X, Java 1.8 and to test examples. — Jeremy - To unsubscribe, e-mail: dev-unsubscr..

Re: svn commit: r1668021 - /tomcat/site/trunk/docs/taglibs/CHANGES.txt

2015-03-20 Thread Jeremy Boynes
Sorry about that, bad svn config. Shouldn’t happen again. Thanks for fixing. > On Mar 20, 2015, at 7:04 AM, kkoli...@apache.org wrote: > > Author: kkolinko > Date: Fri Mar 20 14:04:50 2015 > New Revision: 1668021 > > URL: http://svn.apache.org/r1668021 > Log: > svn:eol-style = native > > Modifi

[ANN] Apache Standard Taglib 1.2.5 released

2015-03-19 Thread Jeremy Boynes
The Apache Tomcat team announces the immediate availability of Apache Standard Taglib 1.2.5. Apache Standard Taglib is an open source software implementation of the JSP Standard Tag Library (JSTL) technology. This release supports JSTL version 1.2 and includes minor bug-fixes to the previous 1

Re: WAR FileSystem for fast nested JAR access?

2015-03-18 Thread Jeremy Boynes
On Mar 17, 2015, at 9:01 AM, Christopher Schultz wrote: > > Jeremy, > > On 3/17/15 2:39 AM, Jeremy Boynes wrote: >> On Mar 7, 2015, at 10:13 AM, Jeremy Boynes wrote: >>> >>> On Mar 6, 2015, at 7:43 AM, Mark Thomas wrote: >>>> Interesting. The

Re: Taglibs sub-site

2015-03-17 Thread Jeremy Boynes
> On Feb 27, 2015, at 7:57 AM, Jeremy Boynes wrote: > > On Feb 27, 2015, at 3:38 AM, kkoli...@apache.org wrote: >> >> Author: kkolinko >> Date: Fri Feb 27 11:38:13 2015 >> New Revision: 1662662 >> >> URL: http://svn.apache.org/r1662662 >

[RESULT] [VOTE] Release Apache Standard Taglib 1.2.5

2015-03-17 Thread Jeremy Boynes
On Mar 10, 2015, at 9:22 AM, Jeremy Boynes wrote: > > The proposed Apache Standard Taglib 1.2.5 release is now available for voting. > > This release contains two minor bug fixes: > 57673 AccessControlException accessing > org.apache.taglibs.standard.xml.accessExternalEntit

Re: WAR FileSystem for fast nested JAR access?

2015-03-16 Thread Jeremy Boynes
On Mar 7, 2015, at 10:13 AM, Jeremy Boynes wrote: > > On Mar 6, 2015, at 7:43 AM, Mark Thomas wrote: >> Interesting. The deciding factor for me will be performance. Keep in >> mind that we might not need all the API. As long as there is enough to >> implement WebResourc

Re: [VOTE] Release Apache Standard Taglib 1.2.5

2015-03-12 Thread Jeremy Boynes
On Mar 10, 2015, at 9:22 AM, Jeremy Boynes wrote: > > The proposed 1.2.5 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 1.2.5 Stable TCK passed on Mac OS X 10.10.2, Java 7 “1.7.0_75” and Tomcat 7.0.57 with -security set. Run with $ C

[VOTE] Release Apache Standard Taglib 1.2.5

2015-03-10 Thread Jeremy Boynes
The proposed Apache Standard Taglib 1.2.5 release is now available for voting. This release contains two minor bug fixes: 57673 AccessControlException accessing org.apache.taglibs.standard.xml.accessExternalEntity 37466 Reverted changes that overrode HTTP method when importing local resources. I

Re: WAR FileSystem for fast nested JAR access?

2015-03-08 Thread Jeremy Boynes
On Mar 8, 2015, at 9:53 AM, Mark Thomas wrote: > > On 07/03/2015 18:13, Jeremy Boynes wrote: >> I interpret that to mean that there is pretty constant time taken to >> inflate 15MB of data - the 300ms to scan the archive and the ~350ms >> to scan each of the jars within

Re: WAR FileSystem for fast nested JAR access?

2015-03-08 Thread Jeremy Boynes
On Mar 8, 2015, at 5:28 AM, Christopher Schultz wrote: > > Jeremy, > > On 3/7/15 1:13 PM, Jeremy Boynes wrote: >> On Mar 6, 2015, at 7:43 AM, Mark Thomas wrote: >>> Interesting. The deciding factor for me will be performance. Keep >>> in mind that we mi

Re: WAR FileSystem for fast nested JAR access?

2015-03-07 Thread Jeremy Boynes
On Mar 6, 2015, at 7:43 AM, Mark Thomas wrote: > Interesting. The deciding factor for me will be performance. Keep in > mind that we might not need all the API. As long as there is enough to > implement WebResourceSet and WebResource, we probably have all we need. I ran a micro-benchmark using th

Re: Time for 7.0.60

2015-03-07 Thread Jeremy Boynes
On Mar 6, 2015, at 9:19 AM, Konstantin Kolinko wrote: > > 2015-03-05 22:39 GMT+03:00 Violeta Georgieva : >> Hi, >> >> I plan to start preparing 7.0.60 for voting. >> >> If you want to add something to this release please reply here. >> > > Testing the examples app with Security Manager enable

Re: WAR FileSystem for fast nested JAR access?

2015-03-06 Thread Jeremy Boynes
On Mar 4, 2015, at 9:09 AM, Jeremy Boynes wrote: > > My suggestion for using an NIO2 FileSystem is because its API provides for > nesting and for random access to the entries in the filesystem. Something > like: > > Path war = FileSystems.getDefault().getPath(“real/path/

Re: [VOTE][RESULT] Release Apache Taglibs 1.2.3

2015-03-06 Thread Jeremy Boynes
On Mar 6, 2015, at 1:06 AM, Mark Thomas wrote: > > On 20/02/2015 16:01, Konstantin Kolinko wrote: >> 2015-02-20 18:39 GMT+03:00 Jeremy Boynes : >>> The following vote were cast: >>> >>> Binding: >>> +1: jboynes, kkolinko, kfujino >>> >

Re: WAR FileSystem for fast nested JAR access?

2015-03-04 Thread Jeremy Boynes
On Mar 4, 2015, at 3:49 AM, Konstantin Kolinko wrote: > > 2015-03-04 8:20 GMT+03:00 Jeremy Boynes : >> In https://bz.apache.org/bugzilla/show_bug.cgi?id=57251, Mark Thomas wrote: >> >>> The fix for bug 57472 might shave a few seconds of the deployment time but >

WAR FileSystem for fast nested JAR access?

2015-03-03 Thread Jeremy Boynes
In https://bz.apache.org/bugzilla/show_bug.cgi?id=57251, Mark Thomas wrote: > The fix for bug 57472 might shave a few seconds of the deployment time but > it doesn't appear to make a significant difference. > > The fundamental problem when running from a packed WAR is that to access any > resource

Taglibs/JSP future work, was: Time for Taglibs to be sent to the archive?

2015-03-02 Thread Jeremy Boynes
On Mar 2, 2015, at 5:21 AM, Konstantin Kolinko wrote: > > 2015-03-01 1:04 GMT+03:00 Jeremy Boynes : ... >> - Put Standard 1.2.x in maintenance mode for bug fixes only >> - Start a tree/branch for new work without the limitations of the >> now-ancient 1.2 spec >> -

Using functional interfaces for tags and JSP

2015-03-02 Thread Jeremy Boynes
After the recent thread around taglibs future, I wanted to explore the possibility of using Java8’s functional interfaces to implement tags. http://svn.apache.org/r1663366 is a straw man I used. To explain the approach here, I started with the thought that the SimpleTag model in JSP2.0 was a ki

Re: Time for Taglibs to be sent to the archive?

2015-02-28 Thread Jeremy Boynes
Resurrecting this old thread[1] as the topic came up related to the site changes. First message included for context below. TL;DR: Konstantin and I had interest in new work on Standard, Henri has helped with logistics. No-one had any interest in RDC. A concern at the time was lack of progress t

Re: svn commit: r1662913 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestStandardContextAliases.java

2015-02-28 Thread Jeremy Boynes
On Feb 28, 2015, at 1:18 AM, r...@apache.org wrote: > > Author: remm > Date: Sat Feb 28 09:18:57 2015 > New Revision: 1662913 > > URL: http://svn.apache.org/r1662913 > Log: > Fix JSTL related test (already in skip list). Sorry about that, I didn’t think about running the tests for a change affec

Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

2015-02-27 Thread Jeremy Boynes
On Feb 27, 2015, at 6:43 PM, Jeremy Boynes wrote: > > On Feb 27, 2015, at 11:19 AM, Konstantin Kolinko > wrote: >> >> 2015-02-27 19:26 GMT+03:00 : >>> Author: jboynes >>> Date: Fri Feb 27 16:26:21 2015 >>> New Revision: 1662736 >

Re: svn commit: r1662736 - in /tomcat/trunk/webapps/examples/WEB-INF/lib: jstl.jar standard.jar taglibs-standard-impl-1.2.3.jar taglibs-standard-spec-1.2.3.jar

2015-02-27 Thread Jeremy Boynes
On Feb 27, 2015, at 11:19 AM, Konstantin Kolinko wrote: > > 2015-02-27 19:26 GMT+03:00 : >> Author: jboynes >> Date: Fri Feb 27 16:26:21 2015 >> New Revision: 1662736 >> >> URL: http://svn.apache.org/r1662736 >> Log: >> Replace old taglibs library with Apache Standard Taglib 1.2.3 >> >> Added:

Taglibs sub-site

2015-02-27 Thread Jeremy Boynes
On Feb 27, 2015, at 3:38 AM, kkoli...@apache.org wrote: > > Author: kkolinko > Date: Fri Feb 27 11:38:13 2015 > New Revision: 1662662 > > URL: http://svn.apache.org/r1662662 > Log: > Announcement for Standard Taglib 1.2.3. > > I do not like the CVE link (goes to announce@a.o mail archive) and CH

[SECURITY] CVE-2015-0254 XXE and RCE via XSL extension in JSTL XML tags

2015-02-26 Thread Jeremy Boynes
CVE-2015-0254 XXE and RCE via XSL extension in JSTL XML tags Severity: Important Vendor: The Apache Software Foundation Versions Affected: Standard Taglibs 1.2.1 The unsupported 1.0.x and 1.1.x versions may also be affected. Description: When an application uses or tags to process untrusted

[ANN} Apache Standard Taglib 1.2.3 released

2015-02-26 Thread Jeremy Boynes
The Apache Tomcat team announces the immediate availability of Apache Standard Taglib 1.2.3. Apache Standard Taglib is an open source software implementation of the JSP Standard Tag Library (JSTL) technology. This release supports JSTL version 1.2 and includes bug-fixes and improvements on the

Re: TestPojoEndpointBase failing on trunk

2015-02-22 Thread Jeremy Boynes
On Feb 22, 2015, at 10:57 AM, Mark Thomas wrote: > > On 19/02/2015 18:27, Mark Thomas wrote: >> On 19/02/2015 15:17, Jeremy Boynes wrote: >>> Mark >>> >>> I am seing regular failures in TestPojoEndpointBase in trunk where >>> the socket is not

Re: [VOTE][RESULT] Release Apache Taglibs 1.2.3

2015-02-20 Thread Jeremy Boynes
The following vote were cast: Binding: +1: jboynes, kkolinko, kfujino The vote therefore passes. I will release the staging repository. Could a PMC member please update dist.a.o. I will announce after that. Thanks Jeremy signature.asc Description: Message signed with OpenPGP using GPGMail

TestPojoEndpointBase failing on trunk

2015-02-19 Thread Jeremy Boynes
Mark I am seing regular failures in TestPojoEndpointBase in trunk where the socket is not being closed (see attached log). I’ve not dug in yet but this has started since r1660358 and may be related to recent NIO changes (maybe r1660582?). Cheers Jeremy Testsuite: org.apache.tomcat.websocket.p

Re: Question about taglibs. Issue 37466

2015-02-18 Thread Jeremy Boynes
> On Feb 18, 2015, at 3:10 AM, Stephan van Loendersloot (LIST) > wrote: > > Hi Konstantin, Jeremy, > > Yes I can provide a simple example shortly... > > Apologies for breaking the first rule of questioning: provide all details > about operating system, container, libraries, etc. > > Would i

Re: Question about taglibs. Issue 37466

2015-02-18 Thread Jeremy Boynes
On Feb 17, 2015, at 8:23 AM, Jeremy Boynes wrote: > > On Feb 17, 2015, at 4:34 AM, Konstantin Kolinko > wrote: >> >> 2015-02-14 20:04 GMT+03:00 Stephan van Loendersloot (LIST) >> : >>> Hi everyone, >>> >>> I have a question about this iss

Re: Question about taglibs. Issue 37466

2015-02-17 Thread Jeremy Boynes
On Feb 17, 2015, at 4:34 AM, Konstantin Kolinko wrote: > > 2015-02-14 20:04 GMT+03:00 Stephan van Loendersloot (LIST) > : >> Hi everyone, >> >> I have a question about this issue: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=37466 >> >> I tried to switch to the latest Tomcat TagLibs implem

Re: [VOTE] Release Apache Taglibs 1.2.3

2015-02-17 Thread Jeremy Boynes
Ping? > On Feb 13, 2015, at 7:46 AM, Jeremy Boynes wrote: > > Please could we have a third set of eyes on this release. > > Thanks > Jeremy > >> On Feb 10, 2015, at 8:40 PM, Jeremy Boynes wrote: >> >> The proposed Apache Taglibs 1.2.3 release is now

Re: [VOTE] Release Apache Taglibs 1.2.3

2015-02-13 Thread Jeremy Boynes
Please could we have a third set of eyes on this release. Thanks Jeremy > On Feb 10, 2015, at 8:40 PM, Jeremy Boynes wrote: > > The proposed Apache Taglibs 1.2.3 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomc

Re: [VOTE] Release Apache Taglibs 1.2.3

2015-02-11 Thread Jeremy Boynes
> On Feb 10, 2015, at 8:40 PM, Jeremy Boynes wrote: > > The proposed Apache Taglibs 1.2.3 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/taglibs/taglibs-standard-1.2.3/ > > The Maven

[VOTE] Release Apache Taglibs 1.2.3

2015-02-10 Thread Jeremy Boynes
The proposed Apache Taglibs 1.2.3 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/taglibs/taglibs-standard-1.2.3/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1034/ The SVN tag is: ht

[RESULT] [VOTE] Release Apache Taglibs 1.2.2

2015-02-08 Thread Jeremy Boynes
On Feb 5, 2015, at 10:01 AM, Konstantin Kolinko wrote: > > 2015-02-02 14:05 GMT+03:00 Konstantin Kolinko : >> 2015-01-27 19:08 GMT+03:00 Jeremy Boynes : >>> >>>> On Jan 27, 2015, at 7:59 AM, Konstantin Kolinko >>>> wrote: >> >>

Re: svn commit: r1657653 - in /tomcat/taglibs/standard/trunk: impl/src/test/java/org/apache/taglibs/standard/tag/common/xml/ForEachTagTest.java pom.xml

2015-02-05 Thread Jeremy Boynes
> On Feb 5, 2015, at 3:32 PM, Konstantin Kolinko wrote: > > 2015-02-05 21:12 GMT+03:00 : >> Author: kkolinko >> Date: Thu Feb 5 18:12:31 2015 >> New Revision: 1657653 >> >> URL: http://svn.apache.org/r1657653 >> Log: >> Fix compilation failure in a test class when using JDK 1.5. >> The XPathF

Re: [VOTE] Release Apache Taglibs 1.2.2

2015-02-05 Thread Jeremy Boynes
Ping ? > On Feb 2, 2015, at 8:29 PM, Jeremy Boynes wrote: > >> >> On Feb 2, 2015, at 3:05 AM, Konstantin Kolinko >> wrote: >> >> 2015-01-27 19:08 GMT+03:00 Jeremy Boynes : >>> >>>> On Jan 27, 2015, at 7:59 AM, Konstantin Kolinko

Re: [VOTE] Release Apache Taglibs 1.2.2

2015-02-02 Thread Jeremy Boynes
> On Feb 2, 2015, at 3:05 AM, Konstantin Kolinko wrote: > > 2015-01-27 19:08 GMT+03:00 Jeremy Boynes : >> >>> On Jan 27, 2015, at 7:59 AM, Konstantin Kolinko >>> wrote: >>> >>> 2015-01-26 20:17 GMT+03:00 Jeremy Boynes : >>>>

Re: [VOTE] Release Apache Tomcat 7.0.58

2015-01-27 Thread Jeremy Boynes
On Jan 26, 2015, at 6:54 AM, Violeta Georgieva wrote: > > The proposed Apache Tomcat 7.0.58 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.58/ > The Maven staging repo is: > https://repository.apache.org/content/rep

Re: [VOTE] Release Apache Taglibs 1.2.2

2015-01-27 Thread Jeremy Boynes
> On Jan 27, 2015, at 7:59 AM, Konstantin Kolinko > wrote: > > 2015-01-26 20:17 GMT+03:00 Jeremy Boynes : >> The proposed Apache Taglibs 1.2.2 release is now available for voting. >> >> It can be obtained from: >> >> https://dist.apache.org/repo

Re: [VOTE] Release Apache Taglibs 1.2.2

2015-01-26 Thread Jeremy Boynes
On Jan 26, 2015, at 9:17 AM, Jeremy Boynes wrote: > > The proposed 1.2.2 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 1.2.2 Stable JSTL TCK passed in the following environment: Mac OSX 10.10.1 Java 1.7.0_75 Apache Tomcat 7.0.57 Apache Xalan 2.7

[VOTE] Release Apache Taglibs 1.2.2

2015-01-26 Thread Jeremy Boynes
The proposed Apache Taglibs 1.2.2 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/taglibs/taglibs-standard-1.2.2/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1032/ The SVN tag is:

Re: Release of Apache Taglibs

2015-01-26 Thread Jeremy Boynes
On Jan 8, 2015, at 9:26 PM, Jeremy Boynes wrote: > > On Jan 8, 2015, at 1:42 PM, Konstantin Kolinko wrote: >> >> 2015-01-08 9:42 GMT+03:00 Jeremy Boynes : >>> I made a couple of minor improvements to Apache Taglibs last year related >>> to XML parsing and t

Re: Release of Apache Taglibs

2015-01-08 Thread Jeremy Boynes
On Jan 8, 2015, at 1:42 PM, Konstantin Kolinko wrote: > > 2015-01-08 9:42 GMT+03:00 Jeremy Boynes : >> I made a couple of minor improvements to Apache Taglibs last year related to >> XML parsing and to how we load libraries (it now uses the TCCL which means >> the ja

Release of Apache Taglibs

2015-01-07 Thread Jeremy Boynes
I made a couple of minor improvements to Apache Taglibs last year related to XML parsing and to how we load libraries (it now uses the TCCL which means the jars can be shared between webapps as well as be included in a webapp as before). I would like to perform a minor release (1.2.2) to include

Re: TldScanner + Config, was: Jasper Improvements

2014-02-27 Thread Jeremy Boynes
On Feb 27, 2014, at 4:09 AM, Konstantin Kolinko wrote: > 2014-02-27 10:17 GMT+04:00 Jeremy Boynes : >> >> I was thinking of supporting compile-on-start as a option where the >> initializer would scan the war for JSP(x) files and initiate the compilation >> during

TldScanner + Config, was: Jasper Improvements

2014-02-26 Thread Jeremy Boynes
On Feb 26, 2014, at 4:55 PM, Greg Wilkins wrote: > Just in case it was missed, here is the pull request I generated: > > https://github.com/apache/tomcat/pull/4 > > Happy to talk about individual changes either in the comments there or here. Related to the TldScanner changes, I’m assuming you

Re: Git

2014-02-24 Thread Jeremy Boynes
Setting aside Maven and Gradle, did we reach any consensus on Git? On Jan 26, 2014, at 5:34 PM, Costin Manolache wrote: > Gradle is becoming the standard build tool for android. > I didn't like it at first - I don't really see the point of groovy - but > it's still better than 'programming' > in

Re: Jasper Improvements

2014-02-24 Thread Jeremy Boynes
On Feb 23, 2014, at 5:55 PM, Greg Wilkins wrote: > On Jun 26, 2013, at 05:44:23 GMT Jeremy Boynes wrote: > >> I have been thinking about improvements to Jasper as well around better >> support for Servlet >> 3.0 concepts. One area would be decoupling it from Tomcat, bo

Re: Using HttpParser for Cookie header?

2014-01-26 Thread Jeremy Boynes
On Jan 20, 2014, at 1:57 PM, Mark Thomas wrote: > Signed PGP part > On 20/01/2014 21:38, Jeremy Boynes wrote: > > I started to look at using HttpParser for the Cookie header but > > there are some differences in the way it works compared to the > > existing parser in

Re: Git

2014-01-26 Thread Jeremy Boynes
On Jan 21, 2014, at 1:58 AM, Mark Thomas wrote: > I've been using Git more and more for Tomcat development and was > wondering what folks thought about moving Tomcat to git. This isn't a > formal proposal or a vote, I'm just trying to gather some views. > > On the plus side: > - it is much easie

Using HttpParser for Cookie header?

2014-01-20 Thread Jeremy Boynes
I started to look at using HttpParser for the Cookie header but there are some differences in the way it works compared to the existing parser in Cookies that I wanted to check direction before getting too far in. The area I’m concerned about is the need to copy the bytes in order to parse the

Re: svn commit: r1559707 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/resources/LocalStrings.properties test/org/apache/el/TestELInJsp.java test/webapp/bug5

2014-01-20 Thread Jeremy Boynes
On Jan 20, 2014, at 6:22 AM, ma...@apache.org wrote: > Author: markt > Date: Mon Jan 20 14:22:49 2014 > New Revision: 1559707 > > URL: http://svn.apache.org/r1559707 > Log: > Additional fix for bug 56029. Now whitespace is not skipped, make sure it is > trimmed before the function name is used.

[ANN] Apache Standard Taglib 1.2.1 released

2014-01-19 Thread Jeremy Boynes
The Apache Tomcat team announces the immediate availability of Apache Standard Taglib 1.2.1. Apache Standard Taglib is an open source software implementation of the JSP Standard Tag Library (JSTL) technology. This release supports JSTL version 1.2 along with numerous bug-fixes and improvements

Re: [Taglibs] Site updated; ready for announce.

2014-01-19 Thread Jeremy Boynes
On Jan 18, 2014, at 8:12 PM, Henri Yandell wrote: > I've updated the site to point to the 1.2.1 release. It's a bit of a kludge > right now. Once RDC heads in the direction of the Attic, I'd like to move > the site fully into the tomcat-site directory, avoiding any of the > generated Maven noise.

Re: Test failure for TestGroupChannelMemberArrival

2014-01-18 Thread Jeremy Boynes
On Jan 18, 2014, at 1:23 AM, Mark Thomas wrote: > Signed PGP part > On 18/01/2014 02:20, Jeremy Boynes wrote: > > I have started seeing a test failure on one of the tribes tests on > > trunk (see log below). OSX 10.9.1 with 1.7.0_51 or 1.7.0_45 > > r1559303 > > >

Re: svn commit: r1559397 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java test/org/apache/jasper/compiler/TestELParser.java

2014-01-18 Thread Jeremy Boynes
On Jan 18, 2014, at 11:33 AM, ma...@apache.org wrote: > Author: markt > Date: Sat Jan 18 19:33:19 2014 > New Revision: 1559397 > > URL: http://svn.apache.org/r1559397 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56029 a regression in > the fix for https://issues.apache.org/bug

Re: Status of cookies proposals

2014-01-18 Thread Jeremy Boynes
On Jan 18, 2014, at 2:50 AM, Mark Thomas wrote: > Signed PGP part > On 18/01/2014 04:34, Jeremy Boynes wrote: > > On Jan 15, 2014, at 2:38 AM, Mark Thomas wrote: > > > >> Does any one have anything else to add to > >> http://wiki.apache.org/tomcat/Cooki

Re: Status of cookies proposals

2014-01-17 Thread Jeremy Boynes
On Jan 15, 2014, at 2:38 AM, Mark Thomas wrote: > Does any one have anything else to add to > http://wiki.apache.org/tomcat/Cookies ? It feels like we should be > looking to make some decisions on where to go with this. > > My $0.02 to start this discussion is that we should adopt the all of the

Test failure for TestGroupChannelMemberArrival

2014-01-17 Thread Jeremy Boynes
I have started seeing a test failure on one of the tribes tests on trunk (see log below). OSX 10.9.1 with 1.7.0_51 or 1.7.0_45 r1559303 Is anyone else seeing similar, or could you provide me with clues on where to start digging? Thanks Jeremy - Testsuite: org.apache.catalina.tribes.gr

Re: allowed cookie names

2014-01-15 Thread Jeremy Boynes
On Jan 15, 2014, at 10:37 AM, Mark Thomas wrote: > On 15/01/2014 16:58, Jeremy Boynes wrote: > > 2) How to handle cookies whose name might be valid RF6265 but won’t > > be allowed by Cookie’s constructor e.g. «Expires», «$Foo» or the «» > > name from above. If an applicati

Re: name only cookies

2014-01-15 Thread Jeremy Boynes
On Jan 15, 2014, at 10:37 AM, Mark Thomas wrote: > On 15/01/2014 16:58, Jeremy Boynes wrote: > > > 1) Clearer distinction between name-only and value-only cookies. > > Existing code treats a name-value pair of «X» as being name-only > > but the browsers treat that

Re: Status of cookies proposals

2014-01-15 Thread Jeremy Boynes
On Jan 15, 2014, at 2:38 AM, Mark Thomas wrote: > Does any one have anything else to add to > http://wiki.apache.org/tomcat/Cookies ? It feels like we should be > looking to make some decisions on where to go with this. There are two things on my mind I’ve not had a chance to write up yet: 1) C

Re: [Taglibs] Extended?

2014-01-14 Thread Jeremy Boynes
On Jan 13, 2014, at 9:51 PM, Henri Yandell wrote: > Any thoughts Jeremy on our containing tags outside of the Standard > implementation? > > I was pondering folding the Extended one (which contains two very tiny > tags) into the Standard taglib, or if you don't see any likelihood for > adding ne

Re: Taglib Site Update

2014-01-13 Thread Jeremy Boynes
On Jan 12, 2014, at 10:56 PM, Henri Yandell wrote: >> >> >> On Jan 11, 2014, at 10:58 PM, Henri Yandell wrote: >>> Remaining tasks: * Create a page to show source location. * Create a .cgi page for download mirrors *I hope that's gotten easier* * Change urls to point

Re: Taglib Site Update

2014-01-12 Thread Jeremy Boynes
On Jan 11, 2014, at 10:58 PM, Henri Yandell wrote: > Thanks. Wish I'd looked here before digging myself. I assumed it was > something weird I did when moving over from Jakarta and spent far too much > time digging into the old code there :) > > --- > > I've gone ahead and put that file back in,

Re: 8-bit text in cookie values

2014-01-03 Thread Jeremy Boynes
-page.html#cookie On Jan 1, 2014, at 10:18 AM, Jeremy Boynes wrote: > On Jan 1, 2014, at 8:59 AM, Mark Thomas wrote: > >> Signed PGP part >> On 26/12/2013 19:23, Jeremy Boynes wrote: >>> On Dec 26, 2013, at 2:47 AM, Mark Thomas wrote: >>> >>> Foc

Re: Permissions to create release directory for taglibs?

2014-01-03 Thread Jeremy Boynes
On Jan 2, 2014, at 2:55 PM, Olivier Lamy wrote: > Just did that: > > mb-olamy:sirona olamy$ svn mkdir > https://dist.apache.org/repos/dist/release/tomcat/taglibs > > > Committed revision 4030. > > mb-olamy:sirona olamy$ svn mv > https://dist.apache.org/repos/dist/dev/tomcat/taglibs/taglibs-st

Permissions to create release directory for taglibs?

2014-01-02 Thread Jeremy Boynes
On Dec 29, 2013, at 3:10 PM, Mark Thomas wrote: > > > I’ve uploaded a copy of the source release here: > > https://dist.apache.org/repos/dist/dev/tomcat/taglibs/taglibs-standard-1.2.1/ > > > > Is that what you had in mind? Do I just svn mv that to “release” > > when done? > > Yes and yes. I am

[VOTE][RESULT] Release Apache Standard Taglib 1.2.1

2014-01-02 Thread Jeremy Boynes
binding +1: rjung, olamy, markt non-binding +1: jboynes, hyandell No other votes have been cast so I am calling this as passed. I will publish the release artifacts though the Maven and diet repositories and then update the website before sending a general announcement. I would like to thank ev

Re: [Tomcat Wiki] Update of "Cookies" by markt

2014-01-01 Thread Jeremy Boynes
On Dec 31, 2013, at 12:46 PM, Mark Thomas wrote: > Signed PGP part > On 31/12/2013 20:29, Mark Thomas wrote: > > On 31/12/2013 17:03, Jeremy Boynes wrote: > >> On Dec 31, 2013, at 3:55 AM, Mark Thomas > >> wrote: > > > >>> On 31/12/2013

Re: 8-bit text in cookie values

2014-01-01 Thread Jeremy Boynes
On Jan 1, 2014, at 8:59 AM, Mark Thomas wrote: > Signed PGP part > On 26/12/2013 19:23, Jeremy Boynes wrote: > > On Dec 26, 2013, at 2:47 AM, Mark Thomas wrote: > > > > Focusing on the 8-bit issue address by the patch, leaving the other > > RFC6265

Re: Support RFC6265 cookie processing

2014-01-01 Thread Jeremy Boynes
X=test; > Y===test The long name contains every cookie-octet value except equals; note these are valid per Netscape. Safari is missing the cookie from the “=X” and “Z” lines, the others treat it as a cookie with an empty name. IOW, if just “=X” is set, then the Cookie header would contain

Re: [Tomcat Wiki] Update of "Cookies" by markt

2013-12-31 Thread Jeremy Boynes
On Dec 31, 2013, at 3:55 AM, Mark Thomas wrote: > On 31/12/2013 11:39, Apache Wiki wrote: >> Dear Wiki user, >> >> You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for >> change notification. >> >> The "Cookies" page has been changed by markt: >> https://wiki.apache.org/tom

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-12-30 Thread Jeremy Boynes
wrote: > Signed PGP part > On 29/12/2013 15:50, Jeremy Boynes wrote: > > On Dec 29, 2013, at 6:04 AM, Mark Thomas wrote: > > > >> On 14/11/2013 02:58, Jeremy Boynes wrote: > >>> I'd like to release Apache Standard Taglib 1.2.1. This is an > >>>

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-12-29 Thread Jeremy Boynes
On Dec 29, 2013, at 6:04 AM, Mark Thomas wrote: > On 14/11/2013 02:58, Jeremy Boynes wrote: >> I'd like to release Apache Standard Taglib 1.2.1. This is an update >> to the withdrawn 1.2.0, built with JDK 1.7.0_45 to address JavaDoc >> issues and incorporating fee

Re: Support RFC6265 cookie processing

2013-12-27 Thread Jeremy Boynes
rs Jeremy On Dec 24, 2013, at 2:24 AM, Mark Thomas wrote: > Signed PGP part > On 24/12/2013 01:21, Jeremy Boynes wrote: > > In comments on issue #55917, there was suggestion for refactoring > > cookie support along the lines described in RFC6265. > > No, that isn't w

Re: 8-bit text in cookie values

2013-12-26 Thread Jeremy Boynes
On Dec 26, 2013, at 2:47 AM, Mark Thomas wrote: Focusing on the 8-bit issue address by the patch, leaving the other RFC6265 thread for broader discussion ... >> The change only allows these characters in values if version == 0 >> where Netscape’s rather than RFC2109’s syntax applies (per the >>

8-bit text in cookie values, was: svn commit: r1553187

2013-12-24 Thread Jeremy Boynes
On Dec 24, 2013, at 2:29 AM, Mark Thomas wrote: > On 23/12/2013 19:15, jboy...@apache.org wrote: >> Author: jboynes >> Date: Mon Dec 23 19:15:35 2013 >> New Revision: 1553187 >> >> URL: http://svn.apache.org/r1553187 >> Log: >> fix #55917 by allowing 8-bit ISO-8859-1 characters in V0 cookie valu

Support RFC6265 cookie processing

2013-12-23 Thread Jeremy Boynes
In comments on issue #55917, there was suggestion for refactoring cookie support along the lines described in RFC6265. Reading this RFC, it appears to be more of an effort to standardize the actual behaviour seen on the Internet for different browser and server implementations. The observation i

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-12-01 Thread Jeremy Boynes
On Dec 1, 2013, at 3:00 PM, Olivier Lamy wrote: > Build the source release: ok > Rat check give those files > > CHANGES.txt > > DEPENDENCIES > > README_bin.txt > > README_src.txt > > > standard-test/src/test/resources/org/apache/taglibs/standard/tag/el/core/TestOutTag.txt > > Not a bi

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-11-30 Thread Jeremy Boynes
On Nov 19, 2013, at 9:10 PM, Jeremy Boynes wrote: > On Nov 16, 2013, at 8:29 AM, Jeremy Boynes wrote: > >> On Nov 13, 2013, at 6:58 PM, Jeremy Boynes wrote: >> >> Nudge - please could a couple of PMC members vote on this release (there are >> no PMC votes at th

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-11-30 Thread Jeremy Boynes
On Nov 20, 2013, at 12:35 AM, Konstantin Kolinko wrote: > 2013/11/14 Jeremy Boynes : >> I'd like to release Apache Standard Taglib 1.2.1. This is an update to the >> withdrawn 1.2.0, built with JDK 1.7.0_45 to address JavaDoc issues and >> incorporating fee

Re: svn commit: r1544165 - XML validation

2013-11-25 Thread Jeremy Boynes
On Nov 21, 2013, at 7:16 PM, Jeremy Boynes wrote: > On Nov 21, 2013, at 4:59 AM, ma...@apache.org wrote: > >> Author: markt >> Date: Thu Nov 21 12:59:36 2013 >> New Revision: 1544165 >> >> URL: http://svn.apache.org/r1544165 >> Log: >> Extend the

Re: XML parsing config clean-up

2013-11-22 Thread Jeremy Boynes
On Nov 22, 2013, at 8:24 AM, Mark Thomas wrote: > Signed PGP part > On 22/11/2013 16:18, Jeremy Boynes wrote: > > On Nov 22, 2013, at 5:40 AM, Mark Thomas wrote: > > > >> On 22/11/2013 13:04, Konstantin Kolinko wrote: > >>> 2013/11/22 Mark Thomas :

Re: XML parsing config clean-up

2013-11-22 Thread Jeremy Boynes
On Nov 22, 2013, at 5:40 AM, Mark Thomas wrote: > On 22/11/2013 13:04, Konstantin Kolinko wrote: >> 2013/11/22 Mark Thomas : ... > >> It does not mention anything else. >> >> There might be 3rd-party tag libraries that do not validate. I think >> it is good to have a separate option. > > OK. T

Re: svn commit: r1544165 - XML validation

2013-11-22 Thread Jeremy Boynes
On Nov 22, 2013, at 1:28 AM, Mark Thomas wrote: Still catching up on the changes but this jumped out: > > > Looks like JasperInitializer now reads to read an attribute not an > > init-param. In trunk, I'd been trying to decouple Jasper from > > Catalina so having the latter set a jasper-specifi

Re: svn commit: r1544165 - XML validation

2013-11-21 Thread Jeremy Boynes
On Nov 21, 2013, at 4:59 AM, ma...@apache.org wrote: > Author: markt > Date: Thu Nov 21 12:59:36 2013 > New Revision: 1544165 > > URL: http://svn.apache.org/r1544165 > Log: > Extend the reach of the Context attribute xmlValidation to cover XML parsing > by Jasper the JSP engine. > Fix a TODO and

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-11-19 Thread Jeremy Boynes
On Nov 16, 2013, at 8:29 AM, Jeremy Boynes wrote: > On Nov 13, 2013, at 6:58 PM, Jeremy Boynes wrote: > > Nudge - please could a couple of PMC members vote on this release (there are > no PMC votes at the moment). Another gentle nudge - we currently have one binding +1 from rj

Coding styles...

2013-11-17 Thread Jeremy Boynes
On Nov 17, 2013, at 2:33 PM, Konstantin Kolinko wrote: > 2013/11/18 Mark Thomas : ... >> >> The coding standard used in Tomcat is that all boxing and unboxing must >> be explicit. The second parameter in the addDependant() method is a Long >> so the long must be explicitly converted. >> > > +1

Re: svn commit: r1542339 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/config/realm.xml

2013-11-17 Thread Jeremy Boynes
On Nov 17, 2013, at 2:09 PM, Mark Thomas wrote: > On 15/11/2013 20:09, Konstantin Kolinko wrote: >> Wrong spelling of the property name. >> s/spengo/spnego/ > > Grr. I keep doing that. No idea why. I believe it has a reality distortion field. At least, I always have to remind myself it's not "

Re: svn commit: r1542836 - /tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java

2013-11-17 Thread Jeremy Boynes
On Nov 17, 2013, at 1:42 PM, ma...@apache.org wrote: > Author: markt > Date: Sun Nov 17 21:42:26 2013 > New Revision: 1542836 > > URL: http://svn.apache.org/r1542836 > Log: > Revert part of r1542565 which added rather than removed an IDE warning > > Modified: >tomcat/trunk/java/org/apache/ja

MBeanDeregistration test failure

2013-11-16 Thread Jeremy Boynes
On Nov 15, 2013, at 11:29 PM, Mark Thomas wrote: > > On a related note, when I ran the unit tests last night I saw a couple of > intermittent failures that I'd like to try and get to the bottom of before > tagging the next RC. Is one of those org.apache.catalina.mbeans.TestRegistration? It has

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-11-16 Thread Jeremy Boynes
On Nov 16, 2013, at 10:33 AM, Rainer Jung wrote: > > Build warnings: > > 6 times: > > WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property > 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not > recognized.' > Warning: org.apache.xerces.parsers.SAXParser: Feature > 'http://j

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-11-16 Thread Jeremy Boynes
On Nov 13, 2013, at 6:58 PM, Jeremy Boynes wrote: > I'd like to release Apache Standard Taglib 1.2.1. This is an update to the > withdrawn 1.2.0, built with JDK 1.7.0_45 to address JavaDoc issues and > incorporating feedback on the documentation. > > Maven Staging

Re: [VOTE] Release Apache Standard Taglib 1.2.1

2013-11-13 Thread Jeremy Boynes
On Nov 13, 2013, at 6:58 PM, Jeremy Boynes wrote: > > The proposed 1.2.1 release is: > [ ] Broken - do not release > [X] OK - release as 1.2.1 Confirmed source distribution builds. Confirmed JSTL TCK passes on Mac OSX 10.8.5, Java 1.6.0_65, Apache Tomcat 7.0.47 Thanks Jeremy s

  1   2   3   >