On Nov 17, 2013, at 2:33 PM, Konstantin Kolinko <knst.koli...@gmail.com> wrote:

> 2013/11/18 Mark Thomas <ma...@apache.org>:
...
>> 
>> The coding standard used in Tomcat is that all boxing and unboxing must
>> be explicit. The second parameter in the addDependant() method is a Long
>> so the long must be explicitly converted.
>> 
> 
> +1
> 
> By the way,
> the settings for Eclipse IDE are documented here:
> 
> http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt?view=markup

Not all of us use Eclipse and relying on the IDE's defaults is ambiguous. I 
added an export from IDE for the settings I'm using but don't know what else is 
needed.

For things that aren't checked in the build, can we please document them 
somewhere.
Thanks
Jeremy

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

Reply via email to