On Nov 22, 2013, at 1:28 AM, Mark Thomas <ma...@apache.org> wrote:

Still catching up on the changes but this jumped out:
> 
> > Looks like JasperInitializer now reads to read an attribute not an
> >  init-param. In trunk, I'd been trying to decouple Jasper from
> > Catalina so having the latter set a jasper-specific attribute
> > reverts that - in TC7 this is controlled for each JspServlet using
> > a "validating" init-param (i.e. it does not inherit from the
> > Context).
> 
> There are multiple aspects to this.
> 
> Jasper needs to be usable in other containers so it can't depend on
> Catalina. Both attributes and init-params allow this.
> 
> There are some things - like XML validation - that apply to both
> Catalina and Jasper and users shouldn't have to configure this in
> multiple places. attributes vs. init-params are really just the
> mechanism used to pass config from Catalina to Jasper in this case. I
> think it is easier to do this with attributes than init-params.

The issue with magic attributes though is that that container needs to set 
them, whereas init-params can be set in a descriptor supplied with the 
application. I think attributes are easier as well but think there's benefit in 
the other container case of having Jasper's configuration be standalone not 
need container support.

Ideally this configuration would be exposed to an SCI in way defined by the 
spec (e.g. a javax. attribute or method on ServletContext).

Thanks
Jeremy

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

Reply via email to