koust6u opened a new pull request, #828:
URL: https://github.com/apache/tomcat/pull/828
+ Added unit tests for various asyncPostProcess state transitions.
+ Replaced dependencies with fake objects for isolated testing.
--
This is an automated message from the Apache Git Service.
To resp
koust6u commented on PR #827:
URL: https://github.com/apache/tomcat/pull/827#issuecomment-2661166088
Thank you for the thorough review and detailed feedback. I now understand
your concerns regarding the logging helper and the importance of explicitly
showing when logging occurs. Your point
Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/37/builds/1274
Blamelist: Dimitris Soumis , Mark Thomas
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch 9.0.x] e9384a81edec9aa5ce1d7a6a2d16198ad1b83736
Ste
https://bz.apache.org/bugzilla/show_bug.cgi?id=69584
--- Comment #7 from Chuck Caldarale ---
I strongly agree with Konstantin - the "stop" process must not be using the
same logging configuration as the Tomcat server.
Note that when the old 8.0.36 version of tomcat-juli.jar is substituted for th
koust6u closed pull request #827: Refactor CSRF Filter: Simplify Logic, Improve
Logging, and Enhance Code Readability
URL: https://github.com/apache/tomcat/pull/827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
https://bz.apache.org/bugzilla/show_bug.cgi?id=69584
Konstantin Kolinko changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVED
dsoumis commented on PR #827:
URL: https://github.com/apache/tomcat/pull/827#issuecomment-2661100096
1) I am not in favor of the helper class. Conditions like if
(log.isDebugEnabled()) and if (log.isTraceEnabled()) are widely used in the
code and I believe it makes it more transparent when
This is an automated email from the ASF dual-hosted git repository.
dsoumis pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new e9384a81ed Fix BZ 69584 - Include missing "$CATAL
This is an automated email from the ASF dual-hosted git repository.
dsoumis pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new a83979963a Fix BZ 69584 - Include missing "$CAT
This is an automated email from the ASF dual-hosted git repository.
dsoumis pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 2d50aa64ea Fix BZ 69584 - Include missing "$CAT
This is an automated email from the ASF dual-hosted git repository.
dsoumis pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 79e4d27450 Fix BZ 69584 - Include missing "$CATALIN
https://bz.apache.org/bugzilla/show_bug.cgi?id=69584
--- Comment #5 from K ---
(In reply to Chuck Caldarale from comment #3)
> Mixing jars from different Tomcat versions (nearly 8 years apart!) is not
> supported. I'm rather surprised that Tomcat starts at all.
I am not actually mixing jars from
https://bz.apache.org/bugzilla/show_bug.cgi?id=69584
K changed:
What|Removed |Added
Resolution|INVALID |FIXED
--- Comment #4 from K ---
tomcat-juli imple
https://bz.apache.org/bugzilla/show_bug.cgi?id=69584
Chuck Caldarale changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=69584
--- Comment #2 from K ---
1) Using the default system properties applied by catalina.sh for tomcat-juli.
CATALINA_LOGGING_CONFIG="-Djava.util.logging.config.file=$CATALINA_BASE/conf/logging.properties"
2) Only notable change is that I am usi
15 matches
Mail list logo
