Re: [PR] fix typo [tomcat]

2024-11-27 Thread via GitHub
ebourg commented on code in PR #789: URL: https://github.com/apache/tomcat/pull/789#discussion_r1861630238 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1487,7 +1487,7 @@ protected Ranges parseRange(HttpServletRequest request, HttpServletResponse resp

[PR] fix typo [tomcat]

2024-11-27 Thread via GitHub
Chenjp opened a new pull request, #789: URL: https://github.com/apache/tomcat/pull/789 minor typo fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[PR] minor update on .gitignore [tomcat]

2024-11-27 Thread via GitHub
Chenjp opened a new pull request, #788: URL: https://github.com/apache/tomcat/pull/788 ignore ds_store and ant test related outputs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Buildbot success in on tomcat-9.0.x

2024-11-27 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/1191 Blamelist: Chenjp , Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 9.0.x] a3982f33978d5c3e07668858b1e0f813578dda75 Steps: wo

Buildbot failure in on tomcat-10.1.x

2024-11-27 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/1523 Blamelist: Chenjp , Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 10.1.x] 36a9e430d6836d5f1e5b4efcd61

Buildbot failure in on tomcat-9.0.x

2024-11-27 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/1190 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x] 0c7bee5615b187b3b7358e110d7b7ab5f542d

(tomcat) branch 9.0.x updated (0c7bee5615 -> a3982f3397)

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 0c7bee5615 The default servlet now rejects HTTP overlapping range requests new 2a881a2ee9 Partial put - enhance co

(tomcat) 01/02: Partial put - enhance content range verification (#778)

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2a881a2ee9e54e75443e15676e03b8bca41f22a4 Author: Chenjp AuthorDate: Thu Nov 28 01:36:53 2024 +0800 Partial put - enha

(tomcat) 02/02: Remove TODOs and add comment on Ranges vs Range

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a3982f33978d5c3e07668858b1e0f813578dda75 Author: Mark Thomas AuthorDate: Wed Nov 27 18:09:06 2024 + Remove TODOs

(tomcat) branch 10.1.x updated: Correct change log

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 36a9e430d6 Correct change log 36a9e430d6 is descr

(tomcat) branch 11.0.x updated: Correct change log

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new eaad381cb5 Correct change log eaad381cb5 is descr

(tomcat) branch main updated: Correct change log

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new b529adb4b0 Correct change log b529adb4b0 is described

(tomcat) branch 10.1.x updated: Partial put - enhance content range verification (#778)

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 8f98152d57 Partial put - enhance content range ve

(tomcat) branch 11.0.x updated: Partial put - enhance content range verification (#778)

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 1317b8471d Partial put - enhance content range ve

(tomcat) branch main updated: Clean-up and add change log entry

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f4e35c555a Clean-up and add change log entry f4e35c55

(tomcat) branch main updated: Partial put - enhance content range verification (#778)

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new eb22c751de Partial put - enhance content range verifi

Re: [PR] Partial put - enhance content range verification [tomcat]

2024-11-27 Thread via GitHub
markt-asf merged PR #778: URL: https://github.com/apache/tomcat/pull/778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2504405168 You should test the latest version (although I suspect you'll see the same results). Use of proxies rather than wrappers was a design decision for jdbc-pool so it could handle chang

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

2024-11-27 Thread via GitHub
robertonr commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2504365369 Hello, I think this change introduced an important performance penalty comparing my tests using 10.1.26 vs 10.1.27 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-27 Thread via GitHub
markt-asf closed pull request #782: send 416 error to overlapping ranges request URL: https://github.com/apache/tomcat/pull/782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2504291618 Tx. Applied a variation manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

(tomcat) branch 9.0.x updated: The default servlet now rejects HTTP overlapping range requests

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0c7bee5615 The default servlet now rejects HTTP ove

(tomcat) branch 10.1.x updated: The default servlet now rejects HTTP overlapping range requests

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new ed8b88e988 The default servlet now rejects HTTP o

(tomcat) branch 11.0.x updated: The default servlet now rejects HTTP overlapping range requests

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new c7a64b91d2 The default servlet now rejects HTTP o

(tomcat) branch main updated: The default servlet now rejects HTTP overlapping range requests

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 6b76febd89 The default servlet now rejects HTTP overl

[Bug 69479] The HTTP2 header data is confused in H2C, resulting in parsing failure

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail

[Bug 69479] The HTTP2 header data is confused in H2C, resulting in parsing failure

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 --- Comment #1 from Mark Thomas --- 9.0.65 is over two years old. Please provide the simplest possible test case that recreates this issue with the current 9.0.x release (9.0.97 as I write this). Without the ability to recreate the issue, this

[Bug 69479] The HTTP2 header data is confused in H2C, resulting in parsing failure

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 Thomas changed: What|Removed |Added CC||qingdaoh...@163.com -- You are receiving thi

[Bug 69479] New: The HTTP2 header data is confused in H2C, resulting in parsing failure

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 Bug ID: 69479 Summary: The HTTP2 header data is confused in H2C, resulting in parsing failure Product: Tomcat 9 Version: 9.0.65 Hardware: All OS: Linux

[Bug 69478] Cookie setSecure and setHttpOnly ignore argument

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69478 --- Comment #3 from Mark Thomas --- I've applied those regression tests to all current branches. Tx. -- You are receiving this mail because: You are the assignee for the bug. ---

(tomcat) branch 11.0.x updated: Add regression tests for BZ 69478.

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new aaf5c58644 Add regression tests for BZ 69478. aaf

[Bug 69478] Cookie setSecure and setHttpOnly ignore argument

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69478 --- Comment #2 from Thomas --- Cheers! Just sent a pr with some regression tests too, but you were faster :D -- You are receiving this mail because: You are the assignee for the bug. ---

Re: [PR] Fix unsetting of httpOnly and secure flag [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #787: URL: https://github.com/apache/tomcat/pull/787#issuecomment-2503730093 Sorry. Looks like our work on this overlapped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix unsetting of httpOnly and secure flag [tomcat]

2024-11-27 Thread via GitHub
markt-asf closed pull request #787: Fix unsetting of httpOnly and secure flag URL: https://github.com/apache/tomcat/pull/787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[Bug 69478] Cookie setSecure and setHttpOnly ignore argument

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69478 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

(tomcat) branch main updated: Fix BZ 69478 setHttpOnly() and setSecure() ignored passed parameter

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c324245fb6 Fix BZ 69478 setHttpOnly() and setSecure()

Re: [PR] BZ 69477: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation [tomcat]

2024-11-27 Thread via GitHub
jorgediaz-lr commented on PR #786: URL: https://github.com/apache/tomcat/pull/786#issuecomment-2503706162 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[Bug 69477] Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69477 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[PR] Fix unsetting of httpOnly and secure flag [tomcat]

2024-11-27 Thread via GitHub
kriths opened a new pull request, #787: URL: https://github.com/apache/tomcat/pull/787 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(tomcat) branch main updated: Update change log

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 0941ce32ca Update change log 0941ce32ca is described

(tomcat) branch main updated: BZ 69477: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation (#786)

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 46e623e885 BZ 69477: Wrong 'allowedInternalProxies' p

Re: [PR] BZ 69477: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation [tomcat]

2024-11-27 Thread via GitHub
markt-asf merged PR #786: URL: https://github.com/apache/tomcat/pull/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

Re: [PR] RateLimitFilter - enhance exposeHeaders to support "ietf rate limit h… [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #775: URL: https://github.com/apache/tomcat/pull/775#issuecomment-2503658944 Thanks for the PR. I have applied a modified version to 12.0.x, 11.0.x, 10.1.x and 9.0.x. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] RateLimitFilter - enhance exposeHeaders to support "ietf rate limit h… [tomcat]

2024-11-27 Thread via GitHub
markt-asf closed pull request #775: RateLimitFilter - enhance exposeHeaders to support "ietf rate limit h… URL: https://github.com/apache/tomcat/pull/775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[Bug 69478] New: Cookie setSecure and setHttpOnly ignore argument

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69478 Bug ID: 69478 Summary: Cookie setSecure and setHttpOnly ignore argument Product: Tomcat 11 Version: 11.0.1 Hardware: PC OS: Linux Status: NEW Severity:

[Bug 69476] receives unexpected 500 error when upload incomplete content less than content-length header announced

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69476 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 69477] Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69477 Jorge Díaz changed: What|Removed |Added OS||All --- Comment #1 from Jorge Díaz --- I

[PR] BZ 69477: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation [tomcat]

2024-11-27 Thread via GitHub
jorgediaz-lr opened a new pull request, #786: URL: https://github.com/apache/tomcat/pull/786 https://bz.apache.org/bugzilla/show_bug.cgi?id=69477 I have detected that the 'allowedInternalProxies' param name in the Remote IP Filter documentation here https://tomcat.apache.org/tomcat-1

[Bug 69477] New: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation

2024-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69477 Bug ID: 69477 Summary: Wrong 'allowedInternalProxies' param name in the Remote IP Filter documentation Product: Tomcat 11 Version: unspecified Hardware: PC St

(tomcat) branch 9.0.x updated: Avoid IDE warning

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6804b77978 Avoid IDE warning 6804b77978 is describe

(tomcat) branch 10.1.x updated: Avoid IDE warning

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 15127efad5 Avoid IDE warning 15127efad5 is descri

(tomcat) branch 11.0.x updated: Avoid IDE warning

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 5fe0c2367e Avoid IDE warning 5fe0c2367e is descri

(tomcat) branch main updated: Avoid IDE warning

2024-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 7f755a95f9 Avoid IDE warning 7f755a95f9 is described

(tomcat) branch 9.0.x updated: 69476: Catch possible ISE when reporting PUT failure

2024-11-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 456c8c5c0a 69476: Catch possible ISE when reporting

(tomcat) branch 10.1.x updated: 69476: Catch possible ISE when reporting PUT failure

2024-11-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new e7907646bd 69476: Catch possible ISE when reportin

(tomcat) branch 11.0.x updated: 69476: Catch possible ISE when reporting PUT failure

2024-11-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new b742e65d63 69476: Catch possible ISE when reportin

(tomcat) branch main updated: 69476: Catch possible ISE when reporting PUT failure

2024-11-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new bce0062a0c 69476: Catch possible ISE when reporting PU