https://bz.apache.org/bugzilla/show_bug.cgi?id=69477
Bug ID: 69477
Summary: Wrong 'allowedInternalProxies' param name in the
Remote IP Filter documentation
Product: Tomcat 11
Version: unspecified
Hardware: PC
Status: NEW
Severity: minor
Priority: P2
Component: Documentation
Assignee: dev@tomcat.apache.org
Reporter: jorge.d...@liferay.com
Target Milestone: -------
I have detected that the 'allowedInternalProxies' param name in the Remote IP
Filter documentation here
https://tomcat.apache.org/tomcat-11.0-doc/config/filter.html#Remote_IP_Filter
is incorrect.
It says:
<init-param>
<param-name>allowedInternalProxies</param-name>
<param-value>192\.168\.0\.10|192\.168\.0\.11</param-value>
</init-param>
But it should be just 'internalProxies':
<init-param>
<param-name>internalProxies</param-name>
<param-value>192\.168\.0\.10|192\.168\.0\.11</param-value>
</init-param>
If you check the tomcat source code, it is reading that 'internalProxies'
parameter:
-
https://github.com/apache/tomcat/blob/7f755a95f974f7d70d43ad85dc213359e33ee5f8/java/org/apache/catalina/filters/RemoteIpFilter.java#L647
It seems the initial version of this Filter was using allowedInternalProxies
but it was changed to internalProxies, see this old commit:
https://github.com/apache/tomcat/commit/535b9a14314296ef787381f8834e5b4404b502cb#diff-00aecb88d52b0caba7b2752719324be9c60121ecf40dedf48998d94178555daaL583
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
